From nobody Tue Feb 10 04:14:44 2026 Received: from mail-43103.protonmail.ch (mail-43103.protonmail.ch [185.70.43.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D9541E8826 for ; Fri, 16 Jan 2026 17:47:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.103 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768585663; cv=none; b=A9Lm/Dt41zAl7BGB0+Ro9w1keEsObMg9apsHKsslGQM3gESh3o/QmBXW3+jaha8+VwpKLYpO0NnWlDSHDK9qVtr+QbBKzdBZlqZrpOvfdsFHtzyXa3ZiNrq67M+Q1INLvoh3ooPJrDd0sgBpnv+dr2UFDIsRUBUuErHVGLPM12U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768585663; c=relaxed/simple; bh=xaVeVlG8elUKVLqoYIm7im8VyuUKXRUXcYYvb03zIjs=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=F5axevqlhFR3A1axOCtUiJlkZs+d1NILmdA/FXwc8VEKMuB3n3VrGYOJciGkcDYbuQSJH56fQuuOBV8mwP8HL03C78Bocxt+I/EVBpQBTmoXC5Y0RDonIO3D883CHjFBMHwWqkg9GcQZq1+Ow7S7pYg4GH0gp++/zoRwnHi2hPc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=xSnfhUrJ; arc=none smtp.client-ip=185.70.43.103 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="xSnfhUrJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768585660; x=1768844860; bh=xaVeVlG8elUKVLqoYIm7im8VyuUKXRUXcYYvb03zIjs=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=xSnfhUrJ+eSSaOTP/qxmx2TM/0YetCNvgD13WBl0CTElYUjx/Gc8aaLCPfsaVWZJg M/FMbhu8X9LlT6IWJi1cvo0Nq63RQG2gcEOlnA9P5ODtpvbopV2Z6/Gy5BCUpT3sG3 p7q0m57FJLUCcgxSeQTENVox8h2e7d0/SZg4M9qFM+GQhUoIgDolCS6Zg7/qRrR7Or PHqxkJmaeUpqLn/nc/ZAytlZ2eH696q93QL5Pgr8yQoXm5OpRhZL71zKocUSQtMGo0 56TAegSMZWn9wrDGsyRi0i3vCXVVQZRZ5y5Zb7b8EwZs9JsgJvRmUZav9I2evAEDGG sMWlLzaK33k7A== Date: Fri, 16 Jan 2026 17:47:35 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v3 02/27] gpib: agilent_82357a: Fix the *allocate_private retval check Message-ID: <20260116174647.317256-3-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260116174647.317256-1-dominik.karol.piatkowski@protonmail.com> References: <20260116174647.317256-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: 43b11936d2c56e144c76b61dbf27d6118f18b699 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change if (retval < 0) return retval; into if (retval) return retval; as it is more fitting in this case. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v3: - Change `(retval < 0)` to `(retval)` drivers/gpib/agilent_82357a/agilent_82357a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpib/agilent_82357a/agilent_82357a.c b/drivers/gpib/ag= ilent_82357a/agilent_82357a.c index 77c8e549b208..26d2830c3fa3 100644 --- a/drivers/gpib/agilent_82357a/agilent_82357a.c +++ b/drivers/gpib/agilent_82357a/agilent_82357a.c @@ -1316,7 +1316,7 @@ static int agilent_82357a_attach(struct gpib_board *b= oard, const struct gpib_boa return -ERESTARTSYS; =20 retval =3D agilent_82357a_allocate_private(board); - if (retval < 0) { + if (retval) { mutex_unlock(&agilent_82357a_hotplug_lock); return retval; } --=20 2.43.0