From nobody Tue Feb 10 05:09:43 2026 Received: from mail-43102.protonmail.ch (mail-43102.protonmail.ch [185.70.43.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 578E53A0B26 for ; Fri, 16 Jan 2026 17:49:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.102 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768585771; cv=none; b=JHJLQQ/e4pP074EFTBb7CmsDOfrmTkaL3IW6OJuaAxa+WYeQYuZmJQlFKzoLvMRX9P+/nAt/fTKYJ/kBVwDaXqzRIovPpuqFZyHniIaTsAiUPCsvNJnX54YNVzWdfRq57exKSuBIp369at5kw7ho6aBqoxO3oaNDF73LI465j0g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768585771; c=relaxed/simple; bh=j6RP10aloAVlCIOawbo2ATdIBxK5whTdrJAY/heMjPw=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G378L2ykFSijp8gZhhPBhVO1FPofDRuTQp6dfpQwXyA2pLzyi9a9Fizcu3T6AiNpJ8E8J5TH+P+3E4zKUwIHHlpBYPQZlDeAGRI40iqfa9e8J2NQ2UszdsCkfIJa4u9gFY/q7KILDSf3xNaQPi0Sn0BDArTqDPjKBEExLjk44Z8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=bdFfusuc; arc=none smtp.client-ip=185.70.43.102 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="bdFfusuc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768585768; x=1768844968; bh=j6RP10aloAVlCIOawbo2ATdIBxK5whTdrJAY/heMjPw=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=bdFfusucjkvX71v/bmUWSko4mlOW16tGnUd6kCaLR9r8RBeMiF2IyoX8yUK6EysDG UmTIJKmdka64LPgOZivzOXJZs111KbpZgUVo6BZKNFafic8vqEf+zmKL4Rf0Jas4Zm 7mroC0d1Z4cDQv7mgfTiV03hMoSY0fjQvBB6/6zLFkciLtFYJDnMnz/j5Wk+2TnGcl K+JowwFMwLPj8zE8d8PYdCVGgCNYO7X4tybIbKCQ4yJ4UCvjokxUQCSWuWHAYyNgBW WXtTJxWiwGXN2rkEQ8fe8F5JPSSYWm+oNGAtdXXJC9vXGvn6H4YXpgx7N4o0/wptfK iK9B1xY/rKHKw== Date: Fri, 16 Jan 2026 17:49:23 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v3 27/27] gpib: tnt4882: Unify *allocate_private usage Message-ID: <20260116174647.317256-28-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260116174647.317256-1-dominik.karol.piatkowski@protonmail.com> References: <20260116174647.317256-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: 404bed9774834a691578384b3f0baf5e9f505343 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the return value of tnt4882_allocate_private in calling code as early return value in case of error. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v3: - Split commit into smaller pieces - Improve changelog - Change `(retval < 0)` to `(retval)` drivers/gpib/tnt4882/tnt4882_gpib.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/gpib/tnt4882/tnt4882_gpib.c b/drivers/gpib/tnt4882/tnt= 4882_gpib.c index 7b9cfb6c07ad..6d241509419e 100644 --- a/drivers/gpib/tnt4882/tnt4882_gpib.c +++ b/drivers/gpib/tnt4882/tnt4882_gpib.c @@ -915,8 +915,9 @@ static int ni_pci_attach(struct gpib_board *board, cons= t struct gpib_board_confi =20 board->status =3D 0; =20 - if (tnt4882_allocate_private(board)) - return -ENOMEM; + retval =3D tnt4882_allocate_private(board); + if (retval) + return retval; tnt_priv =3D board->private_data; nec_priv =3D &tnt_priv->nec7210_priv; nec_priv->type =3D TNT4882; @@ -1038,8 +1039,9 @@ static int ni_isa_attach_common(struct gpib_board *bo= ard, const struct gpib_boar =20 board->status =3D 0; =20 - if (tnt4882_allocate_private(board)) - return -ENOMEM; + retval =3D tnt4882_allocate_private(board); + if (retval) + return retval; tnt_priv =3D board->private_data; nec_priv =3D &tnt_priv->nec7210_priv; nec_priv->type =3D chipset; @@ -1724,8 +1726,9 @@ static int ni_pcmcia_attach(struct gpib_board *board,= const struct gpib_board_co =20 board->status =3D 0; =20 - if (tnt4882_allocate_private(board)) - return -ENOMEM; + retval =3D tnt4882_allocate_private(board); + if (retval) + return retval; =20 tnt_priv =3D board->private_data; nec_priv =3D &tnt_priv->nec7210_priv; --=20 2.43.0