From nobody Tue Feb 10 01:31:04 2026 Received: from mail-106119.protonmail.ch (mail-106119.protonmail.ch [79.135.106.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50E433939BA for ; Fri, 16 Jan 2026 17:49:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.119 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768585753; cv=none; b=gFp5U6VR+mFR0trcwVsr1XZ3lT7PeJh+qlfKiRNZyYmhwDpOI21gRmTUI/fRFmGGrxvwApDMWkcIqY+kIcKQmdjO9napPsEfNdtJirdwoxEjAWHnOWffVj+HPABMtJ6T4OexM+9i1dZbVt8EE5PVmjlzbebDLKkt0Sj2GpCoszk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768585753; c=relaxed/simple; bh=Ap2bjjk16av1iWsMKsToRo2d/LBUtEtItff+vlJCv0M=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=u9ni2BddHi68AjI+AYuuLnKtfSeyOMJCTEKKveqJFMBoHs15LP51Wd2jR/tkGFYT5hxAm4y+LyIcr4T6nYRLSTSDaWXGr4cYTlj3R3JuLlNi6ZwtpFAbeelSv/gRvHFufmXQgfcW0kmZE+uMy0P3kDcB7+SBgrxBBLuv59kgAgI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=zUHBIAmS; arc=none smtp.client-ip=79.135.106.119 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="zUHBIAmS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768585750; x=1768844950; bh=k/V973eRNDo4ic7VIUnoJqufnran47yP5Dms0rKNVqs=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=zUHBIAmSIa+qdy8iO0rrHYbze1Pgn86QGyAK9gEsMLS5qQkaXQPgJjbOp6Ur7J10+ hy80jnQoPK516snsJqZQzi8Ac+VSsCOQdM9FhOkwFowUm/XoQRuSWsWlP4Q5Vh1KWj xptu/XHtTXDvOTYdN/rCm+bHB2EzcAaesfXkPHdn+NkaozCXEu0Y4IDgCMZVnZ3eqZ Ng1qfObb4GnkBf4s1/geUqJYtcv3EqOcDly87teRiu1Y/jI8IHHAnjmpwVKN0v2jb1 5JdjdKpRnPNSPR1W+01q0Rt2PUPIUfPzDeJy6U1y9Jzx3yrteJgX2EzE8WIBvIj1WJ CGifUQq12dHoA== Date: Fri, 16 Jan 2026 17:48:59 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v3 21/27] gpib: ni_usb: Fix the *allocate_private retval check Message-ID: <20260116174647.317256-22-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260116174647.317256-1-dominik.karol.piatkowski@protonmail.com> References: <20260116174647.317256-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: 142730e58f6541adeed0b3e43bc9409601977553 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change if (retval < 0) return retval; into if (retval) return retval; as it is more fitting in this case. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v3: - Change `(retval < 0)` to `(retval)` drivers/gpib/ni_usb/ni_usb_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpib/ni_usb/ni_usb_gpib.c b/drivers/gpib/ni_usb/ni_usb= _gpib.c index 1fc3ccdebff1..2b7aca9e5a33 100644 --- a/drivers/gpib/ni_usb/ni_usb_gpib.c +++ b/drivers/gpib/ni_usb/ni_usb_gpib.c @@ -2232,7 +2232,7 @@ static int ni_usb_attach(struct gpib_board *board, co= nst struct gpib_board_confi =20 mutex_lock(&ni_usb_hotplug_lock); retval =3D ni_usb_allocate_private(board); - if (retval < 0) { + if (retval) { mutex_unlock(&ni_usb_hotplug_lock); return retval; } --=20 2.43.0