From nobody Tue Feb 10 08:27:06 2026 Received: from mail-24418.protonmail.ch (mail-24418.protonmail.ch [109.224.244.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62BD7225760 for ; Fri, 16 Jan 2026 17:48:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768585705; cv=none; b=WqIC01H5SSeWCIoAax54ULAXnT14H4tZ2ZoUvEBGuVQGviCo1EStuPekcKnwHVHzP/FGBgE/Doil0SoMdN4BScVFmNNCNCr2H7lOK+IkJZxeARj7eFmGS08I3FPaieobmItrQlDEm39mSLhGR7/AOZSmDCXDNpBPKBdZ1/UaL1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768585705; c=relaxed/simple; bh=MKhmINpRTA9aZQOrQiMiOk+tq1EAXnkZmQdRAMmPZPs=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PN13flVpKETOxtb5GYaNblFahMURwesM9/9avL/VuAN8ocbZBWQrEajQ4EoeZ3NHaUskDoPqNaHbXoT+vVZh2SePPdnwJQZhLBrVk3EEYuWMskG78g8gFFQkPFWVNwCE0MEeEh+aAr9BvHPkazuDunGfcPIeiT0dbmn80mA8+c8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=dzH9zzM1; arc=none smtp.client-ip=109.224.244.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="dzH9zzM1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768585699; x=1768844899; bh=Fu5/iW6gJuvnTFUm8/4xFfk/P31gmW38TN/smtBJAjM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=dzH9zzM1kErb6pNxEcEKgycwUDf4xHotDQzlCG4RbVRDWyLhiWKxvhTf+YtmFfvad FXjX95mEyiq69qJy/RoXYse1gNXStqOD/HBGEY0UoafgUX2lwkKSosC2twFMgAMGey MheN0ZwgApvgnGc5aDKXmfs7vWNdsj8qaqlISSSE/HcmnaMbCS54L1jEzFVmUJP8BH GSMnduW6e3c9wHI3bdFYyOs/2px3MGlozSGiZKe3x3mMngtDoKmqbv0wO9kFZ25+iU psrSph08WipmIjf6iAH+LEVA1RYDnNBRnnztuf8s1/3OAfIEtfW0YT8bnXzJM+A0vH pMS1ZL/0zD3OQ== Date: Fri, 16 Jan 2026 17:48:14 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v3 11/27] gpib: fmh_gpib: Fix the *allocate_private retval check Message-ID: <20260116174647.317256-12-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260116174647.317256-1-dominik.karol.piatkowski@protonmail.com> References: <20260116174647.317256-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: 3505467b71e750863e637b5c98a31d5c07cdf794 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change if (retval < 0) return retval; into if (retval) return retval; as it is more fitting in this case. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v3: - Change `(retval < 0)` to `(retval)` drivers/gpib/fmh_gpib/fmh_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpib/fmh_gpib/fmh_gpib.c b/drivers/gpib/fmh_gpib/fmh_g= pib.c index b8d955f124bd..d82ec06b3085 100644 --- a/drivers/gpib/fmh_gpib/fmh_gpib.c +++ b/drivers/gpib/fmh_gpib/fmh_gpib.c @@ -1285,7 +1285,7 @@ static int fmh_gpib_generic_attach(struct gpib_board = *board) board->status =3D 0; =20 retval =3D fmh_gpib_allocate_private(board); - if (retval < 0) + if (retval) return retval; e_priv =3D board->private_data; nec_priv =3D &e_priv->nec7210_priv; --=20 2.43.0