From nobody Tue Feb 10 06:25:16 2026 Received: from mail-106118.protonmail.ch (mail-106118.protonmail.ch [79.135.106.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CCEA3939AE for ; Fri, 16 Jan 2026 17:48:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.118 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768585692; cv=none; b=GQ46AJichdr+oW/2Y+Zz31e3vOT8b5qwd2n1FRvmu/iYTaPDwHGx3Fx7Gz/UB8Swwp34Q9MGHAN4V6D8zrOggcWP6moks2vKVzI+7D90dqU5+xJNj3Lwzaf3QFFZK7FQ6Ef9fYNIiUUFKP1o47MFUT8dK7TgnQsMqxXAfD/eG0A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768585692; c=relaxed/simple; bh=2EGOszBi6X8AbyBqQlwZ/lrWzZlRAipTjwFt51sF+/0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eTKvRZAgaRgsT/U46ajyOpcau0c3DwwHQY2ZJgq5h7NoCpkxLF4mnjF5tpna3equAKsrpkR6M8EFgWW9KDwf4Eo24w/eOdTlfVA3ZjLp1YuEdFq8a6QcQGHEEyA1au9PUSttptaY2AaRfBCkz446p7xVImzxCPMIcpfBsnfsDPA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=xpRguP60; arc=none smtp.client-ip=79.135.106.118 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="xpRguP60" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768585689; x=1768844889; bh=+e9RLpRKUnmb4kxo7yDeFk74HqX7AEO7PKDeFc6lA2E=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=xpRguP60Xo9w+AVVZ6yPz1fyRydWm4j3gWycX+SVrQNjGwHjTP7jh37x2Y9oPrx8S hCQzIISTLeT/rbS4ueAHgd9eQSL7+/BiWTX7KJLgKq7YwkIpca9gRhYwW9H2uUFGZp VUM5H8Mqo01U2VukqA1h7TQtYRCDdIuDiXsdOB21hIGnqQg/52kog8yL8pQkuGg1K+ aNuiYrM3/006lUjks+r6YRNQMnmVEW4yCIeaQEwyFrZF9K2euriQ3SE4A55r3WM9tq 3L0Nq/83Zmcr7ZeZm4fYnFSIuX+NJtU+C7oyJPm8nrEaCdNd06T2VzyyVbYN0QgE8T yw9yXxqpVNQGQ== Date: Fri, 16 Jan 2026 17:48:05 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v3 09/27] gpib: eastwood: Fix the *allocate_private retval check Message-ID: <20260116174647.317256-10-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260116174647.317256-1-dominik.karol.piatkowski@protonmail.com> References: <20260116174647.317256-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: 4ca2a673d175793287c827407820d8f551928a23 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change if (retval < 0) return retval; into if (retval) return retval; as it is more fitting in this case. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v3: - Change `(retval < 0)` to `(retval)` drivers/gpib/eastwood/fluke_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpib/eastwood/fluke_gpib.c b/drivers/gpib/eastwood/flu= ke_gpib.c index 8e315b0e35a2..56153b8a1cb2 100644 --- a/drivers/gpib/eastwood/fluke_gpib.c +++ b/drivers/gpib/eastwood/fluke_gpib.c @@ -886,7 +886,7 @@ static int fluke_generic_attach(struct gpib_board *boar= d) board->status =3D 0; =20 retval =3D fluke_allocate_private(board); - if (retval < 0) + if (retval) return retval; e_priv =3D board->private_data; nec_priv =3D &e_priv->nec7210_priv; --=20 2.43.0