From nobody Sat Feb 7 13:41:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 540B83090C6 for ; Fri, 16 Jan 2026 17:10:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768583406; cv=none; b=E7pMQVdlk7Qa5XVeEZAjehoJ6FqY8ULApRtwqFEel1r+Um7Kg3vAbEIo0fJWBT+PT64SXek2GSDrzxVrMp0jX6jfRTbQHR/cRH4xREK2ISRW3wJiRIlEu/b2tcwLgG/hODTpzNyIidMEsuvCWB2dE4eUSGTKSWoCdVHvUpPelK4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768583406; c=relaxed/simple; bh=Y4aPySI7Cf1PcpXJRvplfe20oNkaJz12vUq/u5rjNWs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ilEZGySLkMd5k7mO/3inNci2Hp3cIGWoFXVyukr7wl5RtJNMRp9iy6IO6FBxnYhExc5sBe4N/ow605dScYHmFpVqNYgg/AAbJqgVPv3OrxtV2xDsSDp5ZgLiYOGw2MuCx2ARm4a0FfV/dxbfJx1FMoJItNSb06cAbAKv7bljKPE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LqewXl62; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LqewXl62" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B64E2C116C6; Fri, 16 Jan 2026 17:10:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768583405; bh=Y4aPySI7Cf1PcpXJRvplfe20oNkaJz12vUq/u5rjNWs=; h=From:To:Cc:Subject:Date:From; b=LqewXl62aU98V9RtQZgI8K9YUsWMPM9P8h75TsD1/IPIPLltOKlQAhjD7MdsbXQyk aSCS4fVpoOv9MHOtQPjgcJebe/By30BT6SabCIUIz1z7lVLWGd56cU4BRxpnQOufxR 5F+UGUfIdiuOozIK44Bg5wTbiJYbCW6ZNkRwv2VeWxdXBUGDe/sZklGtfw+A8xH+/U WzX+4Fd8DClhiKhg4pLh+Zxb3kSX0E2p0GFioWJf9SAoS1Q+mCmcDHUZNlY5uQ71mp XvJmmp7/QY1Jg7Gzs/Hn7YPoIwQ/ROWezcWGaiRcBbDKvZY54HVzof2ERIhoeSeTrK s+WHSPwkA5/1Q== From: srini@kernel.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Srinivas Kandagatla Subject: [PATCH] slimbus: qcom-ngd: Simplify with scoped for each OF child loop Date: Fri, 16 Jan 2026 17:09:42 +0000 Message-ID: <20260116170942.733674-1-srini@kernel.org> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Krzysztof Kozlowski Use scoped for-each loop when iterating over device nodes to make code a bit simpler. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio Signed-off-by: Srinivas Kandagatla --- Hi Greg, Here is one slimbus patch which can go for 6.20 If its not too late, could you please queue these as 6.20 material. Thanks, Srini drivers/slimbus/qcom-ngd-ctrl.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctr= l.c index ba3d80d12605..7338b38697d0 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1514,26 +1514,22 @@ static int of_qcom_slim_ngd_register(struct device = *parent, const struct ngd_reg_offset_data *data; struct qcom_slim_ngd *ngd; const struct of_device_id *match; - struct device_node *node; u32 id; int ret; =20 match =3D of_match_node(qcom_slim_ngd_dt_match, parent->of_node); data =3D match->data; - for_each_available_child_of_node(parent->of_node, node) { + for_each_available_child_of_node_scoped(parent->of_node, node) { if (of_property_read_u32(node, "reg", &id)) continue; =20 ngd =3D kzalloc(sizeof(*ngd), GFP_KERNEL); - if (!ngd) { - of_node_put(node); + if (!ngd) return -ENOMEM; - } =20 ngd->pdev =3D platform_device_alloc(QCOM_SLIM_NGD_DRV_NAME, id); if (!ngd->pdev) { kfree(ngd); - of_node_put(node); return -ENOMEM; } ngd->id =3D id; @@ -1546,7 +1542,6 @@ static int of_qcom_slim_ngd_register(struct device *p= arent, if (ret) { platform_device_put(ngd->pdev); kfree(ngd); - of_node_put(node); return ret; } ngd->pdev->dev.of_node =3D node; @@ -1556,7 +1551,6 @@ static int of_qcom_slim_ngd_register(struct device *p= arent, if (ret) { platform_device_put(ngd->pdev); kfree(ngd); - of_node_put(node); return ret; } ngd->base =3D ctrl->base + ngd->id * data->offset + --=20 2.51.0