From nobody Tue Feb 10 18:36:50 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81AF41EB9F2 for ; Fri, 16 Jan 2026 17:08:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768583332; cv=none; b=WXYVR9+Rta9ItNSnLc4xDPMKKdO5OEVJF5QqwkRz7Mz5FAzKtRqgo4gWLoED0H16Uvd4A44VimTAoa0UlAscrkweKkf+wQb3ONfIc6h9TRUe1VCyjlz6SHoCxqgfaPcBjBv9ulbiuCGZ4qFFEY8fDb4qQ4pIFcgKjoYYmfedXmY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768583332; c=relaxed/simple; bh=xalV058SKYsbOfQDOPwrKjTKWuMEye2pJqfJ2cCNPwk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m1nmwpdAUTYLAj+z/b7LvJ12UqgRPAELZ7CnBP2wf8viYudGSVJooM1TXzkwJac0LIyQ/tFFaqElZVu2pk+yFfP2f0JQyJNborchpos/F1rMNuyO/D+68xDeheih3GKeHXO/xxuI5H/4DtIv438LCqzeb+rbRA26eOv4hWaeCvM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ld2wwJ85; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ld2wwJ85" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CA42C19423; Fri, 16 Jan 2026 17:08:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768583332; bh=xalV058SKYsbOfQDOPwrKjTKWuMEye2pJqfJ2cCNPwk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ld2wwJ85PdSlARM1Gb2yDi2ll223Qg7Bi6CpLHEnZQkM85Q+lHXM1ap7oKlgsMaXO lI6ycT0OkYCzBHzLkDqdZUiPfL95mX0MpcGM5vfO5Ryf12mxfOq3WMk9zCKKe4+E/F 8K8/Rzwgd1gEQjCsheeX0d+xHygyl0xBup/OdrBV+89JUbmqD0slytFnX59Bj/JeQz XLZswgYn7ydgsRqVhmlX8AiofsIzQ6yksvCwcTA0DhFv4aFHlPicTNeCntkV8QqSuD xmU3DdoFwf+UyJXr46fQLeiGZvfjXWURnjX8oM8LKM+W6E5kboQ2sC9G+VNIAJwrFl NkGHLPTDPl5ig== From: srini@kernel.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Srinivas Kandagatla Subject: [PATCH 2/4] nvmem: Simplify with scoped for each OF child loop Date: Fri, 16 Jan 2026 17:08:44 +0000 Message-ID: <20260116170846.733558-3-srini@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260116170846.733558-1-srini@kernel.org> References: <20260116170846.733558-1-srini@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Krzysztof Kozlowski Use scoped for-each loop when iterating over device nodes to make code a bit simpler. Signed-off-by: Krzysztof Kozlowski Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index ff68fd5ad3d6..c6180cf1dd91 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -789,11 +789,10 @@ static int nvmem_validate_keepouts(struct nvmem_devic= e *nvmem) static int nvmem_add_cells_from_dt(struct nvmem_device *nvmem, struct devi= ce_node *np) { struct device *dev =3D &nvmem->dev; - struct device_node *child; const __be32 *addr; int len, ret; =20 - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { struct nvmem_cell_info info =3D {0}; =20 addr =3D of_get_property(child, "reg", &len); @@ -801,7 +800,6 @@ static int nvmem_add_cells_from_dt(struct nvmem_device = *nvmem, struct device_nod continue; if (len < 2 * sizeof(u32)) { dev_err(dev, "nvmem: invalid reg on %pOF\n", child); - of_node_put(child); return -EINVAL; } =20 @@ -817,7 +815,6 @@ static int nvmem_add_cells_from_dt(struct nvmem_device = *nvmem, struct device_nod info.nbits < 1 || info.bit_offset + info.nbits > BITS_PER_BYTE * info.bytes) { dev_err(dev, "nvmem: invalid bits on %pOF\n", child); - of_node_put(child); return -EINVAL; } } @@ -830,7 +827,6 @@ static int nvmem_add_cells_from_dt(struct nvmem_device = *nvmem, struct device_nod ret =3D nvmem_add_one_cell(nvmem, &info); kfree(info.name); if (ret) { - of_node_put(child); of_node_put(info.np); return ret; } --=20 2.51.0