From nobody Mon Feb 9 01:46:47 2026 Received: from relay10.grserver.gr (relay10.grserver.gr [37.27.248.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94C3F285CA7; Fri, 16 Jan 2026 13:32:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=37.27.248.198 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768570337; cv=none; b=N4aHd18IPLCLa0+ba6hFh9ZwJ5D6dTXr+3N4FlZWuiHsKidN/0daeQJc6HqNAVLsnzfKb2XSggsSpJaIUgwZk18aKoB9uGTPsTXNzzMYzxwN1b0k/qog6hmeDgfo79Wy4DHjdXERfIAk/G4he5pQrcElm/cXIp25/QuQBmh5NiE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768570337; c=relaxed/simple; bh=oVmVmGx2Jxe9gL5rFYVzpSsCRWpAFbqQZGCD2uDSYvY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F7aC/+qiXlFa5HaVlBPgwpsT3LpNSndbZUZuPOBbCFlnbaHwIArZgAuPui6fSHWgkN99+SV0cCz3ikri9zUkAGOy9jS3CLmos3TtK360pqOzZYqdVnRleeW+xds5NiD0zBkYgsQTnC+6agUP1FvlMDEP9jPQG+1zN+P/hoLARGY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=antheas.dev; spf=pass smtp.mailfrom=antheas.dev; dkim=pass (2048-bit key) header.d=antheas.dev header.i=@antheas.dev header.b=m4kIjjIo; arc=none smtp.client-ip=37.27.248.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=antheas.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=antheas.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=antheas.dev header.i=@antheas.dev header.b="m4kIjjIo" Received: from relay10 (localhost.localdomain [127.0.0.1]) by relay10.grserver.gr (Proxmox) with ESMTP id 4370442B00; Fri, 16 Jan 2026 15:32:04 +0200 (EET) Received: from linux3247.grserver.gr (linux3247.grserver.gr [213.158.90.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by relay10.grserver.gr (Proxmox) with ESMTPS id CF24A429B3; Fri, 16 Jan 2026 15:32:02 +0200 (EET) Received: from antheas-z13 (unknown [IPv6:2a05:f6c3:fefd:0:42c:a43d:2848:c282]) by linux3247.grserver.gr (Postfix) with ESMTPSA id 9372520253A; Fri, 16 Jan 2026 15:32:01 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=antheas.dev; s=default; t=1768570322; bh=74mtRGk4u2sX2DL2XwBX/3rE2+bjcyiUEvuPvyRuVzc=; h=From:To:Subject; b=m4kIjjIojH7Am1HYC/JHzRt4Di+NXAszwySqgJSmC4G6MVji6chzoaBZqDIgU3i9d LyNRvexcCdkeivbIc4ZP4lT3BIf4PTZ1B8i/7qC0GpcLjvEND5d2Wb9KGKuZXPlQMm As9GRHFidEDV7VjwEy5ruTFPaOOFpKSkPtyUN5anqtybuhg2/+kXHb5kHGp1w3VTsU I3LTQjaAuVoSE4m9ivgnwi9G76iDM0nkj/LjiHYAMnkEX+y+RuiIE01tfgmli+BIU7 pcMgX0F20SuxcUkZv8pei9P1F81TgrnkC8agvFKf3EuGoO/1quDtjb3KbHBpIbz+D+ GnsDTq9bUoSYA== Authentication-Results: linux3247.grserver.gr; spf=pass (sender IP is 2a05:f6c3:fefd:0:42c:a43d:2848:c282) smtp.mailfrom=lkml@antheas.dev smtp.helo=antheas-z13 Received-SPF: pass (linux3247.grserver.gr: connection is authenticated) From: Antheas Kapenekakis To: platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Corentin Chary , "Luke D . Jones" , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Denis Benato , Antheas Kapenekakis , Denis Benato Subject: [PATCH v11 04/11] HID: asus: fortify keyboard handshake Date: Fri, 16 Jan 2026 14:31:43 +0100 Message-ID: <20260116133150.5606-5-lkml@antheas.dev> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260116133150.5606-1-lkml@antheas.dev> References: <20260116133150.5606-1-lkml@antheas.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-PPP-Message-ID: <176857032226.3550930.14109064583325225588@linux3247.grserver.gr> X-PPP-Vhost: antheas.dev X-Virus-Scanned: clamav-milter 1.4.3 at linux3247.grserver.gr X-Virus-Status: Clean Content-Type: text/plain; charset="utf-8" Handshaking with an Asus device involves sending it a feature report with the string "ASUS Tech.Inc." and then reading it back to verify the handshake was successful, under the feature ID the interaction will take place. Currently, the driver only does the first part. Add the readback to verify the handshake was successful. As this could cause breakages, allow the verification to fail with a dmesg error until we verify all devices work with it (they seem to). Since the response is more than 16 bytes, increase the buffer size to 64 as well to avoid overflow errors. In addition, add the report ID to prints, to help identify failed handshakes. Reviewed-by: Benjamin Tissoires Reviewed-by: Denis Benato Acked-by: Benjamin Tissoires Signed-off-by: Antheas Kapenekakis --- drivers/hid/hid-asus.c | 34 ++++++++++++++++++++++++++++++---- 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 6ec7322284b1..e1291dcd99fd 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -49,7 +49,7 @@ MODULE_DESCRIPTION("Asus HID Keyboard and TouchPad"); #define FEATURE_REPORT_ID 0x0d #define INPUT_REPORT_ID 0x5d #define FEATURE_KBD_REPORT_ID 0x5a -#define FEATURE_KBD_REPORT_SIZE 16 +#define FEATURE_KBD_REPORT_SIZE 64 #define FEATURE_KBD_LED_REPORT_ID1 0x5d #define FEATURE_KBD_LED_REPORT_ID2 0x5e =20 @@ -395,15 +395,41 @@ static int asus_kbd_set_report(struct hid_device *hde= v, const u8 *buf, size_t bu =20 static int asus_kbd_init(struct hid_device *hdev, u8 report_id) { + /* + * The handshake is first sent as a set_report, then retrieved + * from a get_report. They should be equal. + */ const u8 buf[] =3D { report_id, 0x41, 0x53, 0x55, 0x53, 0x20, 0x54, 0x65, 0x63, 0x68, 0x2e, 0x49, 0x6e, 0x63, 0x2e, 0x00 }; int ret; =20 ret =3D asus_kbd_set_report(hdev, buf, sizeof(buf)); - if (ret < 0) - hid_err(hdev, "Asus failed to send init command: %d\n", ret); + if (ret < 0) { + hid_err(hdev, "Asus handshake %02x failed to send: %d\n", + report_id, ret); + return ret; + } =20 - return ret; + u8 *readbuf __free(kfree) =3D kzalloc(FEATURE_KBD_REPORT_SIZE, GFP_KERNEL= ); + if (!readbuf) + return -ENOMEM; + + ret =3D hid_hw_raw_request(hdev, report_id, readbuf, + FEATURE_KBD_REPORT_SIZE, HID_FEATURE_REPORT, + HID_REQ_GET_REPORT); + if (ret < 0) { + hid_warn(hdev, "Asus handshake %02x failed to receive ack: %d\n", + report_id, ret); + } else if (memcmp(readbuf, buf, sizeof(buf)) !=3D 0) { + hid_warn(hdev, "Asus handshake %02x returned invalid response: %*ph\n", + report_id, FEATURE_KBD_REPORT_SIZE, readbuf); + } + + /* + * Do not return error if handshake is wrong until this is + * verified to work for all devices. + */ + return 0; } =20 static int asus_kbd_get_functions(struct hid_device *hdev, --=20 2.52.0