From nobody Sun Feb 8 05:29:17 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E2803093AD for ; Fri, 16 Jan 2026 09:57:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768557479; cv=none; b=dyueA1nsHl0wtlpYC8Jdy8kLbCXlk7PG2ga2ROTQ+xARSgKjdqm+Kb0wT44SGVCfrLxwBuO541gnrkwwEdom0Oc6TgX4Kq7lOXeNQhBSyS5wscyLpbsJuhf0wNMVC+RegrJ3odt2zaSEHhmJ+eEEXT2A42Rh1umUTFX3S4jwKOM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768557479; c=relaxed/simple; bh=zPajOeekjwnH1L2PhS0ee7WaYai94vHkoloTqOoAN40=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=m8oYg/qw36w5ydo227p9FRCbDR+GLQuo01jznpA0z3RNNmesJruWjVFYGcLOehuYQy2GmHXgqcZxX3P93j1M0UiKCm17wgXld552T1zoQC+6UhUipdu4NRpGnvMpuf3UfJDukj8STRf5Lg11E5SzayffTt/jPWtGZ8oJ9n1EILg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jv3/nlXf; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jv3/nlXf" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-81c72659e6bso1648239b3a.0 for ; Fri, 16 Jan 2026 01:57:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768557477; x=1769162277; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=z9cPCZbEtZqLhkXtHvfyAqgg+9cdVAULaffu1JjYDN8=; b=Jv3/nlXfhvQFpiEurxigKUSHBU7WN0QprWzBMEaL/q7SL/hpZ/kFUjwcutb/ofL619 Hc6pH/G/pxG2pOhqHCAT4mQFIAutJEOYcNDrWfbGJyDEDGa0jHo0zBQD4f7UXbb6LVMb V6oT/F+SsMQWoI9dWjkg7xtT1womNWd/go56zbFZ1cewaDokMElV+jBEKBM91vqIlkMI C1t4ehRsUElV8JpK/9Qw4PRdW9yX5nZc0IdQ7Op8ujtaB+EIRFW1YoNQ3VGR9qRAV+z3 2ZVHLf/Pnr3S5Xlfw2vWQgAf0TSXMKfpoxuGTh5w4/1TjSmcCH8+IoUlBoVSPSG76f20 ctzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768557477; x=1769162277; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=z9cPCZbEtZqLhkXtHvfyAqgg+9cdVAULaffu1JjYDN8=; b=DDLdh3Cau6gx/fl2/Noz4BrFRZlZ9in2sd+8aMZX3GAMZR1iXyjX8wfOQzTtaSfzlT 0gTn2IwaJ24aHY+pETPt4KAbRxjq1WHPk7VBj+4On/iZJEyrQNQlpca0uPdd20+fiCdK hSbZ7eKK7KyrRjDy5ME1b9X+XeFij0g2RK7vhrhGm9znZGW9DLWtfVZEurmS8s+tWr/d QetLyAoZ6dma4l9/t/PyHXudU8qae8XOc6PeyvQfF/+DJbj+GCkv4dM6NWJV8AkDxzk2 JCT5vYPJxQ/kPxBlBClQc4CZ9bIAEI16cZ/JGLt878FpDXSkjsSexFMizHIiBSzo+wwq BKiw== X-Forwarded-Encrypted: i=1; AJvYcCVVGr9P43ZhYqON/fuCHOatq9TYBQ0lRy3dQ1VGRo8HGBFtSZH6/a3PXshDcyCn+8tJE1VlAL/fkIUqFH0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywj+KYNGm3AFnqbcisMWjFOObJvzxpfBj0JXYG+4ntWqRtwwHS0 6Ze+iWSCE98cdkDW//QWtVsit//QoPkjnPLAm8/b/aTwyJbHhOzf4GeZ X-Gm-Gg: AY/fxX5Cu+YYOhtW7eHcd0sxyXieVCfhnID8xuWSexPuyc+rvuryD8lGOTWjFS5J36I 62YNE3vxvjvfXsnJbJldgvavTXTqI7FR/1iaC3h6TTW8vTUx36Bmdi/miVPcRAXdqTbY5eyxihJ FFsuX+2/0CNcH0QinfitI6JfKSNThq1FgCAB4oTLlF12zWoCNaowtth4mcviXgBDV+7Y27xfpmd mt9ly+G/ckocwtbEeW6OA+Awn7+TFM3JJxpBMjKwWE/oybQS+CYY3XH8h2rkn+ek9J8wVZ4jCwT uS8gYyq/lOqAU8iJgiWATdLr6c/j3ljMTJ7zXsYwYbL733fczAxor/J53LvNwlDK/of6C1hRO90 gP+tRwx4md8/D1i5UZ6sHcW+7n+S7q11KVv2Q7CE6gvSdNwawCxUD5YGvhbF//k3bgIvNzPXzH4 F9qRBGbPRA/rKISBVpQAiUqkwWITT0aeFnFq25CmGcXZVPnEwnE8g2l0cpMeGQRtWuJWkodqfxm np50kiPfrIFHbXQYX/viWMZ3E5h4w2lInfx0DeL0h7ezk0= X-Received: by 2002:a05:6a00:4c86:b0:81f:4063:f1ef with SMTP id d2e1a72fcca58-81fa03a1fe2mr2502376b3a.54.1768557477372; Fri, 16 Jan 2026 01:57:57 -0800 (PST) Received: from c8971f1abf06.ap-southeast-2.compute.internal (ec2-54-252-206-51.ap-southeast-2.compute.amazonaws.com. [54.252.206.51]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81fa108b252sm1645230b3a.7.2026.01.16.01.57.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 01:57:56 -0800 (PST) From: Weigang He To: deller@gmx.de Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Weigang He , stable@vger.kernel.org Subject: [PATCH] video: of_display_timing: fix refcount leak in of_get_display_timings() Date: Fri, 16 Jan 2026 09:57:51 +0000 Message-Id: <20260116095751.177055-1-geoffreyhe2@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" of_parse_phandle() returns a device_node with refcount incremented, which is stored in 'entry' and then copied to 'native_mode'. When the error paths at lines 184 or 192 jump to 'entryfail', native_mode's refcount is not decremented, causing a refcount leak. Fix this by changing the goto target from 'entryfail' to 'timingfail', which properly calls of_node_put(native_mode) before cleanup. Fixes: cc3f414cf2e4 ("video: add of helper for display timings/videomode") Cc: stable@vger.kernel.org Signed-off-by: Weigang He --- drivers/video/of_display_timing.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_t= iming.c index bebd371c6b93e..1940c9505dd3b 100644 --- a/drivers/video/of_display_timing.c +++ b/drivers/video/of_display_timing.c @@ -181,7 +181,7 @@ struct display_timings *of_get_display_timings(const st= ruct device_node *np) if (disp->num_timings =3D=3D 0) { /* should never happen, as entry was already found above */ pr_err("%pOF: no timings specified\n", np); - goto entryfail; + goto timingfail; } =20 disp->timings =3D kcalloc(disp->num_timings, @@ -189,7 +189,7 @@ struct display_timings *of_get_display_timings(const st= ruct device_node *np) GFP_KERNEL); if (!disp->timings) { pr_err("%pOF: could not allocate timings array\n", np); - goto entryfail; + goto timingfail; } =20 disp->num_timings =3D 0; --=20 2.34.1