From nobody Mon Feb 9 14:32:03 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0F6F3090CD; Fri, 16 Jan 2026 08:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768551131; cv=none; b=m9vBte+ZMO8j8cwemqk1j1gqsFy55Bs64mkg4L0KJJk4tp3kxq7bQWD7xxZgOOZYVkD0x33DiHlnqPU4HJGCwCcTfHvKfbnxnJCh/8fz54v+i/DOaPD9m40pL5UuFjStIabHfaMis2slpNBVqgcR+JEHG8XZRN0oOzPxbxHjWkg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768551131; c=relaxed/simple; bh=7tBqV9j7P8G1fB3I5YNIZFvB/n4tcIoLisJnBZeapCg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q3oOLVLiXs/VbGuultlcsvSErQb82HDbIsD3ELdXJOGeLG1mdRFWQ4dDCbXqfrFtAyUTBZw9YJxsP4RmGveLmlT4s0BayjmeEX4cYHFzlCT5eqs1l7tLcgpYP/l6j8omWnBcz2/cA59NSuy74LKE2DWqUaNa5P+fEFe4UWKcJWg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n241nB2t; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n241nB2t" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 009A6C19424; Fri, 16 Jan 2026 08:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768551131; bh=7tBqV9j7P8G1fB3I5YNIZFvB/n4tcIoLisJnBZeapCg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n241nB2ttxCxrTSV8LZ0ESEcnklduNofHgJzhiXHXavGZ3qhkEm5hcHf5bAEvuSIe XcDMpTloo7zXoccWfEydTeOZF7M2pSGbI06ztsTrpFbD/R48qhSWzfa5sl6e9hihFT 6xOY7c+jORvIm49DozmuVy6hfSVyf2nRmhJ1gQ312suLbkM5Eicz0OAuj17KkKvgkp 3OXgxq4IyCW4Up2LhXQtq0fqIl7WsIgPRKb6VYfyE1MiYsS8WDsNQ+SxaNWDW7zm2R g7GVXABlbBhKOq1d9w1cxcJ6Tsuf1gZ9xVA2ZLCyHWqMNt3HiYonccZRpg9acVjCGL ZXpTyISb4DZyQ== From: Tzung-Bi Shih To: Benson Leung , Greg Kroah-Hartman , "Rafael J . Wysocki" , Danilo Krummrich , Bartosz Golaszewski , Linus Walleij Cc: Jonathan Corbet , Shuah Khan , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev, linux-kselftest@vger.kernel.org, tzungbi@kernel.org, Laurent Pinchart , Wolfram Sang , Simona Vetter , Dan Williams , Jason Gunthorpe , linux-gpio@vger.kernel.org Subject: [PATCH 21/23] selftests: revocable: Add test case for DEFINE_REVOCABLE() Date: Fri, 16 Jan 2026 08:10:34 +0000 Message-ID: <20260116081036.352286-22-tzungbi@kernel.org> X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog In-Reply-To: <20260116081036.352286-1-tzungbi@kernel.org> References: <20260116081036.352286-1-tzungbi@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add selftest case to verify DEFINE_REVOCABLE() can successfully access the resource. Signed-off-by: Tzung-Bi Shih --- .../drivers/base/revocable/revocable_test.c | 12 ++++++ .../revocable/test_modules/revocable_test.c | 37 +++++++++++++++---- 2 files changed, 42 insertions(+), 7 deletions(-) diff --git a/tools/testing/selftests/drivers/base/revocable/revocable_test.= c b/tools/testing/selftests/drivers/base/revocable/revocable_test.c index f024164e9273..723e5ea9ec84 100644 --- a/tools/testing/selftests/drivers/base/revocable/revocable_test.c +++ b/tools/testing/selftests/drivers/base/revocable/revocable_test.c @@ -14,6 +14,9 @@ * * - Try Access Macro: Same as "Revocation" but uses the * REVOCABLE_TRY_ACCESS_WITH() and REVOCABLE_TRY_ACCESS_SCOPED(). + * + * - Define Macro: Verifies DEFINE_REVOCABLE() can successfully access the + * resource. */ =20 #include @@ -26,6 +29,7 @@ #define TEST_DATA "12345678" #define TEST_MAGIC_OFFSET 0x1234 #define TEST_MAGIC_OFFSET2 0x5678 +#define TEST_MAGIC_OFFSET3 0x9abc =20 FIXTURE(revocable_fixture) { int pfd; @@ -133,4 +137,12 @@ TEST_F(revocable_fixture, try_access_macro2) { EXPECT_STREQ("(null)", data); } =20 +TEST_F(revocable_fixture, define_macro) { + char data[16]; + + READ_TEST_DATA(self->cfd, TEST_MAGIC_OFFSET3, data, + "failed to read test data"); + EXPECT_STREQ(TEST_DATA, data); +} + TEST_HARNESS_MAIN diff --git a/tools/testing/selftests/drivers/base/revocable/test_modules/re= vocable_test.c b/tools/testing/selftests/drivers/base/revocable/test_module= s/revocable_test.c index 1b0692eb75f3..d3bd0ce3a645 100644 --- a/tools/testing/selftests/drivers/base/revocable/test_modules/revocable= _test.c +++ b/tools/testing/selftests/drivers/base/revocable/test_modules/revocable= _test.c @@ -13,6 +13,7 @@ #define TEST_CMD_RESOURCE_GONE "resource_gone" #define TEST_MAGIC_OFFSET 0x1234 #define TEST_MAGIC_OFFSET2 0x5678 +#define TEST_MAGIC_OFFSET3 0x9abc =20 static struct dentry *debugfs_dir; =20 @@ -22,15 +23,27 @@ struct revocable_test_provider_priv { char res[16]; }; =20 +struct revocable_test_consumer_priv { + struct revocable_provider *rp; + struct revocable *rev; +}; + static int revocable_test_consumer_open(struct inode *inode, struct file *= filp) { - struct revocable *rev; struct revocable_provider *rp =3D inode->i_private; + struct revocable_test_consumer_priv *priv; =20 - rev =3D revocable_alloc(rp); - if (!rev) + priv =3D kzalloc(sizeof(*priv), GFP_KERNEL); + if (!priv) return -ENOMEM; - filp->private_data =3D rev; + + priv->rp =3D rp; + priv->rev =3D revocable_alloc(rp); + if (!priv->rev) { + kfree(priv); + return -ENOMEM; + } + filp->private_data =3D priv; =20 return 0; } @@ -38,9 +51,10 @@ static int revocable_test_consumer_open(struct inode *in= ode, struct file *filp) static int revocable_test_consumer_release(struct inode *inode, struct file *filp) { - struct revocable *rev =3D filp->private_data; + struct revocable_test_consumer_priv *priv =3D filp->private_data; =20 - revocable_free(rev); + revocable_free(priv->rev); + kfree(priv); return 0; } =20 @@ -51,7 +65,8 @@ static ssize_t revocable_test_consumer_read(struct file *= filp, char *res; char data[16]; size_t len; - struct revocable *rev =3D filp->private_data; + struct revocable_test_consumer_priv *priv =3D filp->private_data; + struct revocable *rev =3D priv->rev; =20 switch (*offset) { case 0: @@ -69,6 +84,14 @@ static ssize_t revocable_test_consumer_read(struct file = *filp, REVOCABLE_TRY_ACCESS_SCOPED(rev, res) snprintf(data, sizeof(data), "%s", res ?: "(null)"); break; + case TEST_MAGIC_OFFSET3: + { + DEFINE_REVOCABLE(rev_on_stack, priv->rp); + + REVOCABLE_TRY_ACCESS_WITH(rev_on_stack, res); + snprintf(data, sizeof(data), "%s", res ?: "(null)"); + } + break; default: return 0; } --=20 2.52.0.457.g6b5491de43-goog