From nobody Sat Feb 7 18:20:49 2026 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D40A22D979F for ; Fri, 16 Jan 2026 07:30:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768548611; cv=none; b=uzoFu1dLyYLvmtEOiCyN8odMr1594l+XtOox72VKKosR8NzKs6JEHrmb7CYfUNxbCd8Tn8bN2jKY081gJVqvZj11qovJs4KWSt5JwtmPvjKTWrBDMcfBRzUsAD+x6jcgoGXoq7dhmGqdoQjQ09wnofP/Urbg13TcbMtKm+axIWE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768548611; c=relaxed/simple; bh=kfc2gu+JDiA504aEuqqB2yOn1wTCL0D1jfoSwyCjLNg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=d8pLIH22Rea4v6erV9tYcGg/I7qPQR9EcTzrs11xhikWudfliOAr3uqClYUpSNDpnGajjQlA7nBc3IaV5MV7EzzFs6hhx7Z2QyH6jAp9ZiOodWHe6zreaVumwpTeTpcLQJlu/bspYjIF/K5or0fAINIZgvLbLSF4Gqgruzo0i+4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I7sj79pE; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I7sj79pE" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-81f4f4d4822so760521b3a.3 for ; Thu, 15 Jan 2026 23:30:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768548609; x=1769153409; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8z9dR9n/XbIPD+NwoXj4aiKTiL+BG3no3tdpgFPxOgg=; b=I7sj79pEEVb6YqTkpYa8ZQ7DkuAuYNUQ0F9DO11/w656RPFABpxnFUnD1EklZnk11H B+3vj5avKulXmgiLrNr2KqWsGoCNxQ1VXGwwX1mA6VlYBr7cpJkGN+LdswGzfQ0946Z5 sF4BX6MfgIj0xF8FauYwX/2mGEhDuahzNt7zJ5Drd5R/FCzI7EPwvfd01uxocUyyeyJn upSqZ9YxibY+qlXTUcuziyjxdl0dCObch8AkJVyXxzqUwKX2arLfjtUE45eUJH/dVLgG DS5VICsYbCgI1irqvMD4f3OMo43008Dc/R/EDBDqHUF3vY0LTioTL/MKlemOU48HXtN3 GJIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768548609; x=1769153409; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8z9dR9n/XbIPD+NwoXj4aiKTiL+BG3no3tdpgFPxOgg=; b=cUo6iu64SH/vqWnSCvuxflOrzAuTC8TW3s4eyI4m1RJnycRI2s3MVwUtyXFHDDOqw1 Mtg+FFmmIuoPxDN8CkoJMxAApUw/8N1255qLnGT1C4/lq/nuTKvx9F8sRMsif2VtsQBU Oj/bXRTRKMfLaPLXnMZR3FrUMcA4Vi7g/afbd0swz74knls+Jzh7IgYR6XMQC38uTRAs DuEDSmQXKvIBbh4UUOoiBEw7COrW8PJXmnd7/MzMf0deE5m9nEleY4FQOE1ccZa2uBr5 k5sUb5vN1DCQLbn24K6tm/CFwbCexGRIQfXQ1SpueDqxnGhySfkQIXLIQPJBOBkVhPP9 PHRg== X-Forwarded-Encrypted: i=1; AJvYcCUeWD5Ba2qTz4V+OhgZbIvm2pJSEEOgr2xMDTqt6xKBdHr4B2IipiANHQYMyksTieKXuLlFPOqVA9o7kXU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz05Rtrt69w/7N63zN5CrdfHZtOTDb70YfKagoOJnTinFq8wi6g Y0Mp+3/BUMMtpICecAtWPj7FK7MFnTYAkGk0VnEp2uzkiAMAVeuY+WAb X-Gm-Gg: AY/fxX6jAGj614/WQNPO+Srj5TfAAhaF0Xh0K+Vl52hs/wtqzGMyxyefzEdqGhiHSmz ltFYuGPhU/qrPiM4WI9G49TvXkYPRvWIYMmj0V9sOU9uRNuCw90miQRKeH8ZnEaK6AHZtqkSh57 Z6RmvbPklcz0OnXea02cx6IbWsmCoc4bddmTmOcExa8n8xCsDgqzob0mPoGvpq8gw5mtmJw4GII 9VFrqYwUW5q2/2tpoGNtDX1ziPi+aiUl+Hcq7QZnemSTllyR1qkYF5f7Y+VY3xJC9zf02eB2U6E 4PuIusIsy2Bbd+hgUvigFJY2zVqzqnraywKts8n6lf4YjVch1EW8k91N7qzVhX19g1N8KJObIz9 l5j8RNB/VqAnC7mYvnX07tre4+VlEG/UhkGFXa+eduf3WkjIfP1+Bf7W/YyBpLFfmS730P+MxO1 Or8VSPSQPtE+r8fobEvbP+uNGXjeEaWCiHKXnp2Knv01YoLltRFs+gtZoTVBMnpDksmc8EPxn0L NT+MTdGby99RreJ0ETT0CvoBHbl5jb0z3eAbO3e1mH8lK0= X-Received: by 2002:a05:6a00:4008:b0:81e:6d2d:a121 with SMTP id d2e1a72fcca58-81fa03395bbmr2087675b3a.62.1768548608940; Thu, 15 Jan 2026 23:30:08 -0800 (PST) Received: from c8971f1abf06.ap-southeast-2.compute.internal (ec2-54-252-206-51.ap-southeast-2.compute.amazonaws.com. [54.252.206.51]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81fa1291a48sm1261509b3a.50.2026.01.15.23.30.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 23:30:08 -0800 (PST) From: Weigang He To: "Rafael J . Wysocki" , Daniel Lezcano Cc: Zhang Rui , Lukasz Luba , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Weigang He , stable@vger.kernel.org Subject: [PATCH] thermal/of: fix device node refcount leak in thermal_of_cm_lookup() Date: Fri, 16 Jan 2026 07:30:02 +0000 Message-Id: <20260116073002.86597-1-geoffreyhe2@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" of_parse_phandle() returns a device_node pointer with refcount incremented. The caller must use of_node_put() when done. thermal_of_cm_lookup() acquires a reference to tr_np via of_parse_phandle() but fails to release it on multiple paths: - When tr_np !=3D trip->priv (continue path) - When thermal_of_get_cooling_spec() returns true (early return) - At the end of each loop iteration Add the missing of_node_put() calls on all paths to prevent the reference count leak. Fixes: 423de5b5bc5b ("thermal/of: Fix cdev lookup in thermal_of_should_bind= ()") Cc: stable@vger.kernel.org Signed-off-by: Weigang He --- drivers/thermal/thermal_of.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c index 1a51a4d240ff6..ef3e5d4e3b6e8 100644 --- a/drivers/thermal/thermal_of.c +++ b/drivers/thermal/thermal_of.c @@ -284,8 +284,10 @@ static bool thermal_of_cm_lookup(struct device_node *c= m_np, int count, i; =20 tr_np =3D of_parse_phandle(child, "trip", 0); - if (tr_np !=3D trip->priv) + if (tr_np !=3D trip->priv) { + of_node_put(tr_np); continue; + } =20 /* The trip has been found, look up the cdev. */ count =3D of_count_phandle_with_args(child, "cooling-device", @@ -294,9 +296,12 @@ static bool thermal_of_cm_lookup(struct device_node *c= m_np, pr_err("Add a cooling_device property with at least one device\n"); =20 for (i =3D 0; i < count; i++) { - if (thermal_of_get_cooling_spec(child, i, cdev, c)) + if (thermal_of_get_cooling_spec(child, i, cdev, c)) { + of_node_put(tr_np); return true; + } } + of_node_put(tr_np); } =20 return false; --=20 2.34.1