From nobody Mon Feb 9 00:00:59 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C409825F988 for ; Fri, 16 Jan 2026 05:31:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768541484; cv=none; b=ViHHaUupu4RBEQT2otpBZlHZasCxAoLpfEsqUqpLOCVJGeEcsAjcqJ46NEvpZSA3+VGYU1T07aX0AwKFJaK6snXw2jKh+zluTeD82NqEFxerj+3iqlouGIoG7SZLDdhB4coybd6y0rqYok8d78QxnATgw2tnX7a9wGLEjFUmjDQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768541484; c=relaxed/simple; bh=LxAFQ/PuS51/b2fdXorHZqmZszJfXIjHKDO11JupKSc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CkJoTRV8gNCw95nqqIZS3ArPUvy7GIAQdOwgLnGybc2ZF+TgvWCiKgcsvvu83jNAA4cc9nLblTSPPrTQts/vHG+H8qQnPX406PNyM7ftFie5lbRVEH5u7SZKGTQz2HBOcMEhcvCr4ygNmEpgnlPAZE2p7Vc82vtKcZTGRtvaKuk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RgBVtX56; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RgBVtX56" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-34c708702dfso848842a91.1 for ; Thu, 15 Jan 2026 21:31:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768541482; x=1769146282; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GSJnTVssl9yM7jTQ7fA+3wPh5JaxbcwXiyjgA89qwC8=; b=RgBVtX56Km7SuqFEEk06EkymFBMsQBc35ouv1nT6kKKJVbduHLx/dCfQ0S4TCEMPa8 YLZfM4PKs+j+XbgLK+D7jOJBWUH789+AFlQjiAvj6u3UgBmnKpw+MuyEjhk8sDQ2eKV3 qB8/hpi9v7C1KhwbXMQd7UjqdEGfITA54mApX9UWWYjLE5s+T9pkWtSIIQeH0N8XijhI Nd2g0/7aPs/zu+tYt/f0cPxyNkOLCrhZTIIy1W/ApijWtBkD/KQpvt9Ha672l9llSxVD 9G8c7PmtAgo4SlgGyZA15gfJ7GZuiRAtnfiK7KneoIfb9ES3KpuEV26HNp/kw0hYN05W Js+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768541482; x=1769146282; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GSJnTVssl9yM7jTQ7fA+3wPh5JaxbcwXiyjgA89qwC8=; b=TChBpwQw4Uu93TfsHVMEWpvOBBXgsy1lqM08MEKFDjf/MDitLhElLB9p/lO+mYDgHY 9CevLTV0NxYv+EyWy9H8hWkMzsvABaQtnE5Y0P5PGUoW51N/2YGPBnH2hAbL+tVI3dQJ IOhMnpgw33WzhLMZ+yuh/6aqkXM7HmvcWANXUMaDM+SvrIa8kf+PtR264nx2/FvDaR1O lsQLc8PZQ3mH+wPrd034KIdLc4bSEr2T3p5X0LEkkRj6HnvPQ8c74sCe2G6HQ0SuOS0+ nen17XNVNEHDtdUjKMFSj3+G4SEVHdFMAukz8FRdI83s88tbpy+LOvJ54x9N5zR8Aj3z PfCw== X-Forwarded-Encrypted: i=1; AJvYcCX9djTFhpROxjy+NzwWdEarKFvjDThS/VpkqUer2hQchreuOf13Pdx3jsk0jmsizRFBZPgg2TAd9JagfWo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4OGxFgCza1fvx0tOrGngpMetnQwVEWXHSs4+AcWEEdDP9bghH BvjqGgaqHczl71d1divO7TVXeUl/CEwMRGVPfdnrOAfCHUY2zOIQFOgW X-Gm-Gg: AY/fxX7LxSPrEtkZZmTFczDssjKmok06YeSxR49cOeq6vIe1mwwq25Pp75VamTmMiNa tCSV/ZilT/4TS2j0YV+/Nb9AQYNWR8fvOGdmN66V8eaqGDYs+GcAwBEQEWp6LrrvO9rGvRIWvBh I8B2BEwpIFjTYsw6xzwvLX0+Q56tW8S90IW1DQa0kduMHeUaVez0uRrolqoWKCoSyxeKq0m4XVK YPCV6FPq+WW8DELLxy9qxqZjoJgtzczAkrMpkPMdlCL1SFyQtENzoE6br+ilabQZJwdiw6wdGs6 3mj3b3WGy3E4Rmi6go9QjNojClyIZHZfUco8gnhoS/ZoZ2wBCSi7anRjMRetIJjrKlYFpKovjHI EfjRcoEAUwjPW4mc+c2WgYI0ym1cUQaYe4mYSSfSBTOEZUAmniwal1K4naoCRW2qaRIGHgPnQyE cRX3hjg/AwG/6qAv+6Ow== X-Received: by 2002:a17:90b:5603:b0:340:2a16:94be with SMTP id 98e67ed59e1d1-35272ef6716mr1407280a91.4.1768541482009; Thu, 15 Jan 2026 21:31:22 -0800 (PST) Received: from snowman ([2401:4900:4ffd:9a9f:7003:5e9c:3fa9:4130]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35274445a03sm297321a91.7.2026.01.15.21.31.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 21:31:21 -0800 (PST) From: Khushal Chitturi To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, straube.linux@gmail.com, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH v3 1/4] staging: rtl8723bs: fix operator and type cast spacing Date: Fri, 16 Jan 2026 11:00:49 +0530 Message-ID: <20260116053052.4198-2-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260116053052.4198-1-khushalchitturi@gmail.com> References: <20260116053052.4198-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix spacing around operators and type casts in rtw_xmit.c to comply with the kernel coding style. Signed-off-by: Khushal Chitturi --- Changelog: v2 -> v3: Resubmitting as versioned series. v1 -> v2: No changes. drivers/staging/rtl8723bs/core/rtw_xmit.c | 89 +++++++++++++---------- 1 file changed, 50 insertions(+), 39 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 21690857fd62..bbc42db1c828 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -78,7 +78,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, stru= ct adapter *padapter) } pxmitpriv->pxmit_frame_buf =3D (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitpriv= ->pallocated_frame_buf), 4); =20 - pxframe =3D (struct xmit_frame *) pxmitpriv->pxmit_frame_buf; + pxframe =3D (struct xmit_frame *)pxmitpriv->pxmit_frame_buf; =20 for (i =3D 0; i < NR_XMITFRAME; i++) { INIT_LIST_HEAD(&pxframe->list); @@ -238,7 +238,9 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) pxmitbuf->padapter =3D padapter; pxmitbuf->buf_tag =3D XMITBUF_CMD; =20 - res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_CMDBUF_SZ+XM= ITBUF_ALIGN_SZ, true); + res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, + MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ, + true); if (res =3D=3D _FAIL) { res =3D _FAIL; goto exit; @@ -248,7 +250,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) pxmitbuf->pend =3D pxmitbuf->pbuf + MAX_CMDBUF_SZ; pxmitbuf->len =3D 0; pxmitbuf->pdata =3D pxmitbuf->ptail =3D pxmitbuf->phead; - pxmitbuf->alloc_sz =3D MAX_CMDBUF_SZ+XMITBUF_ALIGN_SZ; + pxmitbuf->alloc_sz =3D MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ; } } =20 @@ -274,7 +276,7 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv) { int i; struct adapter *padapter =3D pxmitpriv->adapter; - struct xmit_frame *pxmitframe =3D (struct xmit_frame *) pxmitpriv->pxmit_= frame_buf; + struct xmit_frame *pxmitframe =3D (struct xmit_frame *)pxmitpriv->pxmit_f= rame_buf; struct xmit_buf *pxmitbuf =3D (struct xmit_buf *)pxmitpriv->pxmitbuf; =20 rtw_hal_free_xmit_priv(padapter); @@ -321,7 +323,9 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv) for (i =3D 0; i < CMDBUF_MAX; i++) { pxmitbuf =3D &pxmitpriv->pcmd_xmitbuf[i]; if (pxmitbuf) - rtw_os_xmit_resource_free(padapter, pxmitbuf, MAX_CMDBUF_SZ+XMITBUF_ALI= GN_SZ, true); + rtw_os_xmit_resource_free(padapter, pxmitbuf, + MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ, + true); } =20 rtw_free_hwxmits(padapter); @@ -736,7 +740,7 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p pattrib->subtype =3D WIFI_DATA_TYPE; pattrib->priority =3D 0; =20 - if (check_fwstate(pmlmepriv, WIFI_AP_STATE|WIFI_ADHOC_STATE|WIFI_ADHOC_MA= STER_STATE)) { + if (check_fwstate(pmlmepriv, WIFI_AP_STATE | WIFI_ADHOC_STATE | WIFI_ADHO= C_MASTER_STATE)) { if (pattrib->qos_en) set_qos(&pktfile, pattrib); } else { @@ -787,15 +791,15 @@ static s32 xmitframe_addmic(struct adapter *padapter,= struct xmit_frame *pxmitfr rtw_secmicsetkey(&micdata, &pattrib->dot11tkiptxmickey.skey[0]); } =20 - if (pframe[1]&1) { /* ToDS =3D=3D 1 */ + if (pframe[1] & 1) { /* ToDS =3D=3D 1 */ rtw_secmicappend(&micdata, &pframe[16], 6); /* DA */ - if (pframe[1]&2) /* From Ds =3D=3D 1 */ + if (pframe[1] & 2) /* From Ds =3D=3D 1 */ rtw_secmicappend(&micdata, &pframe[24], 6); else rtw_secmicappend(&micdata, &pframe[10], 6); } else { /* ToDS =3D=3D 0 */ rtw_secmicappend(&micdata, &pframe[4], 6); /* DA */ - if (pframe[1]&2) /* From Ds =3D=3D 1 */ + if (pframe[1] & 2) /* From Ds =3D=3D 1 */ rtw_secmicappend(&micdata, &pframe[16], 6); else rtw_secmicappend(&micdata, &pframe[10], 6); @@ -810,16 +814,20 @@ static s32 xmitframe_addmic(struct adapter *padapter,= struct xmit_frame *pxmitfr =20 for (curfragnum =3D 0; curfragnum < pattrib->nr_frags; curfragnum++) { payload =3D (u8 *)round_up((SIZE_PTR)(payload), 4); - payload =3D payload+pattrib->hdrlen+pattrib->iv_len; + payload =3D payload + pattrib->hdrlen + pattrib->iv_len; =20 - if ((curfragnum+1) =3D=3D pattrib->nr_frags) { - length =3D pattrib->last_txcmdsz-pattrib->hdrlen-pattrib->iv_len-((pa= ttrib->bswenc) ? pattrib->icv_len : 0); + if ((curfragnum + 1) =3D=3D pattrib->nr_frags) { + length =3D pattrib->last_txcmdsz - pattrib->hdrlen - + pattrib->iv_len - + ((pattrib->bswenc) ? pattrib->icv_len : 0); rtw_secmicappend(&micdata, payload, length); - payload =3D payload+length; + payload =3D payload + length; } else { - length =3D pxmitpriv->frag_len-pattrib->hdrlen-pattrib->iv_len-((patt= rib->bswenc) ? pattrib->icv_len : 0); + length =3D pxmitpriv->frag_len - pattrib->hdrlen - + pattrib->iv_len - + ((pattrib->bswenc) ? pattrib->icv_len : 0); rtw_secmicappend(&micdata, payload, length); - payload =3D payload+length+pattrib->icv_len; + payload =3D payload + length + pattrib->icv_len; } } rtw_secgetmic(&micdata, &mic[0]); @@ -1108,8 +1116,10 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter,= struct sk_buff *pkt, struct if (bmcst || (rtw_endofpktfile(&pktfile) =3D=3D true)) { pattrib->nr_frags =3D frg_inx; =20 - pattrib->last_txcmdsz =3D pattrib->hdrlen + pattrib->iv_len + ((pattrib= ->nr_frags =3D=3D 1) ? llc_sz:0) + - ((pattrib->bswenc) ? pattrib->icv_len : 0) + mem_sz; + pattrib->last_txcmdsz =3D pattrib->hdrlen + pattrib->iv_len + + ((pattrib->nr_frags =3D=3D 1) ? llc_sz : 0) + + ((pattrib->bswenc) ? pattrib->icv_len : 0) + + mem_sz; =20 ClearMFrag(mem_start); =20 @@ -1158,7 +1168,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padap= ter, struct sk_buff *pkt, s mem_start =3D pframe =3D (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET; pwlanhdr =3D (struct ieee80211_hdr *)pframe; =20 - ori_len =3D BIP_AAD_SIZE+pattrib->pktlen; + ori_len =3D BIP_AAD_SIZE + pattrib->pktlen; tmp_buf =3D BIP_AAD =3D rtw_zmalloc(ori_len); subtype =3D GetFrameSubType(pframe); /* bit(7)~bit(2) */ =20 @@ -1211,14 +1221,14 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *pad= apter, struct sk_buff *pkt, s /* conscruct AAD, copy address 1 to address 3 */ memcpy(BIP_AAD + 2, &pwlanhdr->addrs, sizeof(pwlanhdr->addrs)); /* copy management fram body */ - memcpy(BIP_AAD+BIP_AAD_SIZE, MGMT_body, frame_body_len); + memcpy(BIP_AAD + BIP_AAD_SIZE, MGMT_body, frame_body_len); /* calculate mic */ if (omac1_aes_128(padapter->securitypriv.dot11wBIPKey[padapter->security= priv.dot11wBIPKeyid].skey - , BIP_AAD, BIP_AAD_SIZE+frame_body_len, mic)) + , BIP_AAD, BIP_AAD_SIZE + frame_body_len, mic)) goto xmitframe_coalesce_fail; =20 /* copy right BIP mic value, total is 128bits, we use the 0~63 bits */ - memcpy(pframe-8, mic, 8); + memcpy(pframe - 8, mic, 8); } else { /* unicast mgmt frame TX */ /* start to encrypt mgmt frame */ if (subtype =3D=3D WIFI_DEAUTH || subtype =3D=3D WIFI_DISASSOC || @@ -1267,9 +1277,10 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *pada= pter, struct sk_buff *pkt, s memcpy(pframe, pattrib->iv, pattrib->iv_len); pframe +=3D pattrib->iv_len; /* copy mgmt data portion after CCMP header */ - memcpy(pframe, tmp_buf+pattrib->hdrlen, pattrib->pktlen-pattrib->hdrlen= ); + memcpy(pframe, tmp_buf + pattrib->hdrlen, + pattrib->pktlen - pattrib->hdrlen); /* move pframe to end of mgmt pkt */ - pframe +=3D pattrib->pktlen-pattrib->hdrlen; + pframe +=3D pattrib->pktlen - pattrib->hdrlen; /* add 8 bytes CCMP IV header to length */ pattrib->pktlen +=3D pattrib->iv_len; if ((pattrib->icv_len > 0) && (pattrib->bswenc)) { @@ -1375,7 +1386,7 @@ void rtw_count_tx_stats(struct adapter *padapter, str= uct xmit_frame *pxmitframe, struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; u8 pkt_num =3D 1; =20 - if ((pxmitframe->frame_tag&0x0f) =3D=3D DATA_FRAMETAG) { + if ((pxmitframe->frame_tag & 0x0f) =3D=3D DATA_FRAMETAG) { pkt_num =3D pxmitframe->agg_num; =20 pmlmepriv->LinkDetectInfo.NumTxOkInPeriod +=3D pkt_num; @@ -2070,7 +2081,7 @@ signed int xmitframe_enqueue_for_sleeping_sta(struct = adapter *padapter, struct x =20 spin_lock_bh(&psta->sleep_q.lock); =20 - if (psta->state&WIFI_SLEEP_STATE) { + if (psta->state & WIFI_SLEEP_STATE) { u8 wmmps_ac =3D 0; =20 if (pstapriv->sta_dz_bitmap & BIT(psta->aid)) { @@ -2083,20 +2094,20 @@ signed int xmitframe_enqueue_for_sleeping_sta(struc= t adapter *padapter, struct x switch (pattrib->priority) { case 1: case 2: - wmmps_ac =3D psta->uapsd_bk&BIT(0); + wmmps_ac =3D psta->uapsd_bk & BIT(0); break; case 4: case 5: - wmmps_ac =3D psta->uapsd_vi&BIT(0); + wmmps_ac =3D psta->uapsd_vi & BIT(0); break; case 6: case 7: - wmmps_ac =3D psta->uapsd_vo&BIT(0); + wmmps_ac =3D psta->uapsd_vo & BIT(0); break; case 0: case 3: default: - wmmps_ac =3D psta->uapsd_be&BIT(0); + wmmps_ac =3D psta->uapsd_be & BIT(0); break; } =20 @@ -2214,20 +2225,20 @@ void wakeup_sta_to_xmit(struct adapter *padapter, s= truct sta_info *psta) switch (pxmitframe->attrib.priority) { case 1: case 2: - wmmps_ac =3D psta->uapsd_bk&BIT(1); + wmmps_ac =3D psta->uapsd_bk & BIT(1); break; case 4: case 5: - wmmps_ac =3D psta->uapsd_vi&BIT(1); + wmmps_ac =3D psta->uapsd_vi & BIT(1); break; case 6: case 7: - wmmps_ac =3D psta->uapsd_vo&BIT(1); + wmmps_ac =3D psta->uapsd_vo & BIT(1); break; case 0: case 3: default: - wmmps_ac =3D psta->uapsd_be&BIT(1); + wmmps_ac =3D psta->uapsd_be & BIT(1); break; } =20 @@ -2259,7 +2270,7 @@ void wakeup_sta_to_xmit(struct adapter *padapter, str= uct sta_info *psta) =20 pstapriv->tim_bitmap &=3D ~BIT(psta->aid); =20 - if (psta->state&WIFI_SLEEP_STATE) + if (psta->state & WIFI_SLEEP_STATE) psta->state ^=3D WIFI_SLEEP_STATE; =20 if (psta->state & WIFI_STA_ALIVE_CHK_STATE) { @@ -2274,7 +2285,7 @@ void wakeup_sta_to_xmit(struct adapter *padapter, str= uct sta_info *psta) if (!psta_bmc) goto _exit; =20 - if ((pstapriv->sta_dz_bitmap&0xfffe) =3D=3D 0x0) { /* no any sta in ps mo= de */ + if ((pstapriv->sta_dz_bitmap & 0xfffe) =3D=3D 0x0) { /* no any sta in ps = mode */ xmitframe_phead =3D get_list_head(&psta_bmc->sleep_q); list_for_each_safe(xmitframe_plist, tmp, xmitframe_phead) { pxmitframe =3D list_entry(xmitframe_plist, @@ -2327,20 +2338,20 @@ void xmit_delivery_enabled_frames(struct adapter *p= adapter, struct sta_info *pst switch (pxmitframe->attrib.priority) { case 1: case 2: - wmmps_ac =3D psta->uapsd_bk&BIT(1); + wmmps_ac =3D psta->uapsd_bk & BIT(1); break; case 4: case 5: - wmmps_ac =3D psta->uapsd_vi&BIT(1); + wmmps_ac =3D psta->uapsd_vi & BIT(1); break; case 6: case 7: - wmmps_ac =3D psta->uapsd_vo&BIT(1); + wmmps_ac =3D psta->uapsd_vo & BIT(1); break; case 0: case 3: default: - wmmps_ac =3D psta->uapsd_be&BIT(1); + wmmps_ac =3D psta->uapsd_be & BIT(1); break; } =20 --=20 2.52.0