From nobody Mon Feb 9 14:15:18 2026 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD9E923EA83 for ; Fri, 16 Jan 2026 03:50:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768535443; cv=none; b=S9U021SlIj38slFDi39Ax9dARH3PYOXRuuKUHUfSgxBoyhTNx6w0il9FWSPCXVm8MyAeEeGf6X7g9mO0R4sVx8le1KyaLoCA5v6cr3Gff51Hz3KInWoWhmYS+tH5H1FeN3tBtIQNW7F1j5Tl+21Q9FyI9b+Hp8+2YrQUybBN0Vk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768535443; c=relaxed/simple; bh=zY4lZ/WMgcwk7KKWgJshhVk7lhJb+yixU/AKr0hQg7o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oM5sNNO6q7OpxNghv0jNwWUdCyBmyqqv3TQLkrTdottYe/9GPs2sDivzF81OsXiF5j8HDxGKmvOoaIU3gCKc0ht4DSSYNgAu565+qrYwZx2hTS9Ry4TjQuQyMo6nvCK1kywhtzuaSiOFa159MX1B/EpnlTbRk8MsisP1y18tPm8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Lpl0y07W; arc=none smtp.client-ip=209.85.216.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Lpl0y07W" Received: by mail-pj1-f66.google.com with SMTP id 98e67ed59e1d1-34f634dbfd6so1143754a91.2 for ; Thu, 15 Jan 2026 19:50:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768535441; x=1769140241; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=slOe1FPJhANQ1vYoC8HEpAu7LLkuMBjol/KDdw72Pdw=; b=Lpl0y07WMPHwr8G+d0TDk9fDHg5C0Xs9Yw+7OgBcZ13/8xY8Ht1zjp47PYY17pYSSD /2lDmt+KJDvUZTqVukCJKTXoINUfeeQdNrme+1dWmD6HrWeILqLZFx8l3SaswgBo+uEf C8UbmxbEtIzYRKHPVBgGvBOQYMrMVZM6rQ61gF65I9+ENOemJjERZGkrbdr4+54LxhVq PxXSxQ7o++yHedCwDA19rk+Hsxh2XCeVyKUVbaZIZ+mSrJGPyLLO8nrVd6SK9kgEwXpz rNF/5MKOJ2NTIM+XWuIHNUinLdorjSOW8JfQATDvly0Gz18oJvPwabH0aW2OXvpUOM+v vDzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768535441; x=1769140241; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=slOe1FPJhANQ1vYoC8HEpAu7LLkuMBjol/KDdw72Pdw=; b=jb3t/ZXDMyD8HwszXQnirwhOp4m6PnQ1rnusS26w8Jrt2rY8SSMZUjgjgga/kn5qN4 yOjxiTpJtlHVnNYYrddaqPG9uq5YkX3f/1mFXab8hwed3d4/GtJwlvFZkwBYwzP65wXe wg1Fq4i2RUOkZNvNFs32Hgvx34lm29eeuapDLpZyGfLBCSbcp9+I1cWl7MVZGJuKr0iK vWJTGMEoqC+SA3WSnltnHLAEca6iSYWqOOv5eI3sB2dxJjGp5OKmAZNRdr8X6MLfuETE Qqk5HedlqFuizziLS6C22oc1lY+mi4iuU2ZSJpAF/BgNlwB6Q8X32yf2V0xMeTBiUZm7 wSJA== X-Forwarded-Encrypted: i=1; AJvYcCUA6V0Yp4+U+VBeRrXduiGyPterTB0CPVrhGHhIbFWNvpjNCEFuwCaKu50WNduUB40Kkl1elIEE8CsWRaY=@vger.kernel.org X-Gm-Message-State: AOJu0YxZl+XS39xRlW88ynLvY9aw/w5AR8s92WkrCSRvjhm8qkzP59Qg qXQusnz8rT2HLuD8bacE8xUS046ZvfoQPdVsYo4Icf+Lhc49uM9yGukW X-Gm-Gg: AY/fxX55PNoAw0BPasUQYurAlZuC7dT3Pz4P9kNPsnTire4qZdThFPzxWsJ32Qa9r6W /y1J5ypSB7E/Y60Ft2gvWpUkWGw9GbWODIds+Brgnw4Kl0mrbgCnBA4aR0j7e5ZVEwNRQmHXQ7/ N9ZCzlKDi9Wcr9opQ9NAim+ib7a2fZkUtMIk2lcNYAdKDD11n/+7Fjh59rnLYR+7ckrPoKb804C c264EBeN1EwKJxcGlhiYzU7lsqNd/UrX8N0u8OLovGOBuVvwiATdBt9N/FEQaGWP2mD6SowBwcs nlGkp/7sZLaFlr6Zw9cgILx3eJYjoozJ4sfxukXla1LEgPWwACeS9iECLuCACTTqIkh+G50DguJ BoLVIHnFtM9rPIWFy2M1y95c6E09f+MH0f4jL5u3A+53L+9og65FH48VKZKfNbSc//MLpHOzqEw VFa6wJ7j4= X-Received: by 2002:a17:90b:2f44:b0:34a:48ff:694 with SMTP id 98e67ed59e1d1-35272fa908emr1225888a91.31.1768535441060; Thu, 15 Jan 2026 19:50:41 -0800 (PST) Received: from 7940hx ([160.187.0.149]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c5edf37c9d7sm684504a12.35.2026.01.15.19.50.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 19:50:40 -0800 (PST) From: Menglong Dong X-Google-Original-From: Menglong Dong To: ast@kernel.org Cc: daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, mattbobrowski@google.com, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH bpf-next 1/2] bpf: support bpf_get_func_arg() for BPF_TRACE_RAW_TP Date: Fri, 16 Jan 2026 11:50:23 +0800 Message-ID: <20260116035024.98214-2-dongml2@chinatelecom.cn> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260116035024.98214-1-dongml2@chinatelecom.cn> References: <20260116035024.98214-1-dongml2@chinatelecom.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For now, bpf_get_func_arg() and bpf_get_func_arg_cnt() is not supported by the BPF_TRACE_RAW_TP, which is not convenient to get the argument of the tracepoint, especially for the case that the position of the arguments in a tracepoint can change. The target tracepoint BTF type id is specified during loading time, therefore we can get the function argument conut from the function prototype instead of the stack. Signed-off-by: Menglong Dong --- kernel/bpf/verifier.c | 28 ++++++++++++++++++++++++---- kernel/trace/bpf_trace.c | 4 ++-- 2 files changed, 26 insertions(+), 6 deletions(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index faa1ecc1fe9d..6dee0defa291 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -23316,8 +23316,18 @@ static int do_misc_fixups(struct bpf_verifier_env = *env) /* Implement bpf_get_func_arg inline. */ if (prog_type =3D=3D BPF_PROG_TYPE_TRACING && insn->imm =3D=3D BPF_FUNC_get_func_arg) { - /* Load nr_args from ctx - 8 */ - insn_buf[0] =3D BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_1, -8); + if (eatype =3D=3D BPF_TRACE_RAW_TP) { + int nr_args; + + if (!prog->aux->attach_func_proto) + return -EINVAL; + nr_args =3D btf_type_vlen(prog->aux->attach_func_proto); + /* Save nr_args to reg0 */ + insn_buf[0] =3D BPF_MOV64_IMM(BPF_REG_0, nr_args); + } else { + /* Load nr_args from ctx - 8 */ + insn_buf[0] =3D BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_1, -8); + } insn_buf[1] =3D BPF_JMP32_REG(BPF_JGE, BPF_REG_2, BPF_REG_0, 6); insn_buf[2] =3D BPF_ALU64_IMM(BPF_LSH, BPF_REG_2, 3); insn_buf[3] =3D BPF_ALU64_REG(BPF_ADD, BPF_REG_2, BPF_REG_1); @@ -23369,8 +23379,18 @@ static int do_misc_fixups(struct bpf_verifier_env = *env) /* Implement get_func_arg_cnt inline. */ if (prog_type =3D=3D BPF_PROG_TYPE_TRACING && insn->imm =3D=3D BPF_FUNC_get_func_arg_cnt) { - /* Load nr_args from ctx - 8 */ - insn_buf[0] =3D BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_1, -8); + if (eatype =3D=3D BPF_TRACE_RAW_TP) { + int nr_args; + + if (!prog->aux->attach_func_proto) + return -EINVAL; + nr_args =3D btf_type_vlen(prog->aux->attach_func_proto); + /* Save nr_args to reg0 */ + insn_buf[0] =3D BPF_MOV64_IMM(BPF_REG_0, nr_args); + } else { + /* Load nr_args from ctx - 8 */ + insn_buf[0] =3D BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_1, -8); + } =20 new_prog =3D bpf_patch_insn_data(env, i + delta, insn_buf, 1); if (!new_prog) diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 6e076485bf70..9b1b56851d26 100644 --- a/kernel/trace/bpf_trace.c +++ b/kernel/trace/bpf_trace.c @@ -1734,11 +1734,11 @@ tracing_prog_func_proto(enum bpf_func_id func_id, c= onst struct bpf_prog *prog) case BPF_FUNC_d_path: return &bpf_d_path_proto; case BPF_FUNC_get_func_arg: - return bpf_prog_has_trampoline(prog) ? &bpf_get_func_arg_proto : NULL; + return &bpf_get_func_arg_proto; case BPF_FUNC_get_func_ret: return bpf_prog_has_trampoline(prog) ? &bpf_get_func_ret_proto : NULL; case BPF_FUNC_get_func_arg_cnt: - return bpf_prog_has_trampoline(prog) ? &bpf_get_func_arg_cnt_proto : NUL= L; + return &bpf_get_func_arg_cnt_proto; case BPF_FUNC_get_attach_cookie: if (prog->type =3D=3D BPF_PROG_TYPE_TRACING && prog->expected_attach_type =3D=3D BPF_TRACE_RAW_TP) --=20 2.52.0