From nobody Mon Feb 9 12:23:50 2026 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60179315D2D for ; Fri, 16 Jan 2026 01:05:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768525542; cv=none; b=pHBfBW/Ji/yxIepKlh8DbrSdgCEgFagWlWWnUpdgFmYLAGc/qsGNO+bR58dUOy6FUXBa53rGNkd4ClGJmZU1re3FnrlVSJX1LahL9AH6TkzGa3aUiJHrDjirorQ9/3d52FVDj4txDny7QKSBaKuA3/CQTpWLSeqwvesSy9Av19o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768525542; c=relaxed/simple; bh=sxn8m2wfjaMr0Go0RxIOhMpMUABI6p8vpxtI2DFz5oc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hoal9pWEQrJ2htMTSDlXfKbSbob5qOzdOav0RlxUPYv9q52AsMboz814po8gzxAS5JbE3b9nuk2Rk4lb8cgB/4x6SGl2zKVzzsnW7Vi1lHXs7YRZYekxkD8U+Oi9Nylez8dKcnIRhVM42bdTJLQ+5t/ebLq9M/1/IJ8aLa4Vq/w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zacbowling.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HQq7DeYZ; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zacbowling.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HQq7DeYZ" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-2b6b0500e06so914135eec.1 for ; Thu, 15 Jan 2026 17:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768525534; x=1769130334; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=mmo1wCmkMZsP9rEEVr9OwRQ+MJCKwHnawZH5r7i9q+E=; b=HQq7DeYZf8cJXVfj8I4nAb5/iATtVop0q+PjL1/Cvu8QC7S3DVa+pVXiAVczoGHN/H XAC8PnxtYVWAl4fHtGTdC5S3rHvNkGMdI+a/dpYMLXPVxKnK1aIyqBBVqMQQV4zdxLhD 1Iv8TPPDnphWMzq+dSXh5SBzaAD5jM7Pwf3burrNFqTRVlKNhGOzJoUSTnv2SPVdf3sN z7FpzUczp2HJ11LG+5lmPx5eo6SLwvA7uxQ+MIEN9KWPzd0ZcPYmHhfpJ/laugk/iDol 6mPQRJROtGrYrS2sFq6Udwh5ziT+tdyzJ7Wy/5DPHuA3wxWGYYzK8kJzTr3u/WL3ygy2 uxhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768525534; x=1769130334; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mmo1wCmkMZsP9rEEVr9OwRQ+MJCKwHnawZH5r7i9q+E=; b=cTupxVQDl5FBLLTSTd7B2cDq833IkebLfRdBZAnY8Xo2TfWLJTl4JhMp1azW3Tzxl3 YNa9uzATbLouZAVVvDseuEmujeCTK24138X0Ekfb88wgTOHbcFO8ip9EvDxJr0/PZzRP PpR4bw7PHk9K993cRXzelciS1wGBWlSx6yXh6dvoIrKrwvoVtp+wz5qsTzFGcCHFffts RRZ9D7O7PF4O8qjZrTtih7ll8vwi9S1wrUd1ZDdnVYKsOVkKLu3NUMSp/GnqmvgTTfv3 gBY6t9fPa1CYyzYZRdRPXEqTtndEuKOfOeVuYti+MpRFYqlXHixNcFjEO4N3Bt99Dovf sDAA== X-Forwarded-Encrypted: i=1; AJvYcCU92YsQSmTvbaB1EQ9hOGY7xNHrG6j7/i/o78mpmpGQeQoi7q9CQGfMEv3AF1gMyjT9aml+b3DVhtQiTP8=@vger.kernel.org X-Gm-Message-State: AOJu0YyZklaF8rXN4XMQcpkT8CT3O1bhWYMoHgX2HZLQjonBImo5kyGq IMQu0mJvT/reAAwK8U6ZfnEU5HJ0AMd3fggpm4RvgXdMrO23pyrjPJqJ X-Gm-Gg: AY/fxX6RYKgIdmjQ0hACMJbN7oYnPo87jLrqqpeBDdKT233XxlCNMeQkGKPddwcU2wh i7Fx/VEEd7PZKVLs4+NU8W+KqxCeEHxwJDdbCBdVdUP3F6YTYlal28y5ceoEkUR560133lKSnt2 xrKu3Jj/yT8QwS0E+rBXx7n5ohS9ffTUwL21KI3OXU887RMKHqBkpZn0F8t17VjelQqIMcmlXkz H4m5vdOG0pDL8wjL7fztgCdjKsXhLkyzSf3562UOsAA9+T7njtogWWr3iJhv66FSgZF+lV1MeE2 2IAIyMR1tocslJ1Wza/gqttO0FbSJ7yRpl/+5sNsLrQZxCVSrX9iK5q508AR+CxPtdmiZ8HUf5c w3EmDEyvKlBcYd+RP3q5XHmHmuIHLimAewvhYz9dvMcxRXUSpIgsx24t68n6zO/+8EFOF/5ubyD yyEgX6Ls78+1VK0IKbsrrDXR/Lz7jVKHIF+tHFkEQtGkztc6s91+La2sqp8NUrdg== X-Received: by 2002:a05:7300:2d06:b0:2a4:61d1:f433 with SMTP id 5a478bee46e88-2b6b3f2a8ccmr1281770eec.16.1768525533543; Thu, 15 Jan 2026 17:05:33 -0800 (PST) Received: from zcache.home.zacbowling.com ([2001:5a8:60d:bc9:f1d2:502c:a6ff:5556]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b6b367cbc9sm1019884eec.32.2026.01.15.17.05.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 17:05:33 -0800 (PST) Sender: Zac Bowling From: Zac To: sean.wang@kernel.org Cc: deren.wu@mediatek.com, kvalo@kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-wireless@vger.kernel.org, lorenzo@kernel.org, nbd@nbd.name, linux@frame.work, ryder.lee@mediatek.com, sean.wang@mediatek.com, Zac Bowling , Zac Bowling Subject: [PATCH v4 07/21] wifi: mt76: mt7925: add error handling for BSS info MCU command in sta_add Date: Thu, 15 Jan 2026 17:05:05 -0800 Message-ID: <20260116010519.37001-8-zac@zacbowling.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260116010519.37001-1-zac@zacbowling.com> References: <20260116010519.37001-1-zac@zacbowling.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Zac Bowling Check return value of mt7925_mcu_add_bss_info() in mt7925_mac_link_sta_add() and propagate errors to the caller. BSS info must be set up before adding a station record. If this MCU command fails, continuing with station add would leave the firmware in an inconsistent state with a station but no BSS configuration. This can cause undefined behavior in the firmware, particularly during MLO link setup where multiple BSS configurations are being programmed. Reported-by: Zac Bowling Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver for mt= 7925 chips") Signed-off-by: Zac Bowling --- drivers/net/wireless/mediatek/mt76/mt7925/main.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/main.c b/drivers/net= /wireless/mediatek/mt76/mt7925/main.c index d966e5ab50..a7e1e673c4 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/main.c @@ -899,11 +899,14 @@ static int mt7925_mac_link_sta_add(struct mt76_dev *m= dev, /* should update bss info before STA add */ if (vif->type =3D=3D NL80211_IFTYPE_STATION && !link_sta->sta->tdls) { if (ieee80211_vif_is_mld(vif)) - mt7925_mcu_add_bss_info(&dev->phy, mconf->mt76.ctx, - link_conf, link_sta, link_sta !=3D mlink->pri_link); + ret =3D mt7925_mcu_add_bss_info(&dev->phy, mconf->mt76.ctx, + link_conf, link_sta, + link_sta !=3D mlink->pri_link); else - mt7925_mcu_add_bss_info(&dev->phy, mconf->mt76.ctx, - link_conf, link_sta, false); + ret =3D mt7925_mcu_add_bss_info(&dev->phy, mconf->mt76.ctx, + link_conf, link_sta, false); + if (ret) + return ret; } =20 if (ieee80211_vif_is_mld(vif) && --=20 2.52.0