From nobody Mon Feb 9 15:09:53 2026 Received: from mail-dy1-f171.google.com (mail-dy1-f171.google.com [74.125.82.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E368315D37 for ; Fri, 16 Jan 2026 01:05:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768525552; cv=none; b=akEr4xnB/7uN5+o2xuMmASEc4XcR1/SnWs6taadvEZrZLocyAO/V2xmeO2KIuXhPZL3jDlWZOnbjrKK9DGW2XbchZJgkMgRRp+l1n7QlniQTVgVTPBvLFDVoALf6xgOKnGglWjuQVKZJWU+OHTzIGacu+UFvpzEB4qH9cg3uFIs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768525552; c=relaxed/simple; bh=RL2egL+gt/RYZ+mDWmObhYGMsncwjLrPK8QRWukDVTM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sWNKIymaiND/IPOIWKSHo1m0n331qrfrNjuRUypnAcchaXB3NkueKPT1lks+qAYKVC0OoNI3kcFlG77B8pDUtnMyWDa1BEPNyoMwmJ1UAgYkEwr48EE+vqXvftB6OkllCtzPyqsgMD/29P5wl+YgPj7nK+ZUmLetSJIZue2hQ70= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zacbowling.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PPJXptpw; arc=none smtp.client-ip=74.125.82.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zacbowling.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PPJXptpw" Received: by mail-dy1-f171.google.com with SMTP id 5a478bee46e88-2ae287a8444so744580eec.0 for ; Thu, 15 Jan 2026 17:05:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768525541; x=1769130341; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=SmoSCGQL2mRlPPuo0uD512LAshqRjYzmZB3+T0TG3ug=; b=PPJXptpwWOI/pWfflSYTHtGDLMOQp+dr2qSkO3m/IhF2uORooGcJFeVVPJkG9bq3SL 1EQZsiNHvoL1M2/4Whf8u+Z+54dRe0VKDQ14tCHWUqSjM9TXg2lFYVasl7Iu10KKiRwa SrgenHXxBzc331kg2e2q0DAAfFiU6AMut/ppoVolMns2aJ3Qstl4EgGi/eoaRsnPz2oe pgYkA/QCw31d8nvM6yxsMYfyAjY/m9O2fj0iJfvFDqYcuJZ+cMQOKUG3qHWD8GrqwOd3 GVWEwAXmTZWiTDTXwCPzdz0YRtsS6vk8ZvXfOtV9YUeSqAnzUXgltMLdIY0UAcyxw45l D9nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768525541; x=1769130341; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SmoSCGQL2mRlPPuo0uD512LAshqRjYzmZB3+T0TG3ug=; b=CDS+g+4855QsPoJkiEbS9vzrRN2bVBI0YPj7PAxbtEe8x84Vdn1oDYchxmqHQ9fBPw rsTOCamRJXbMcmv2lvZSeIowO9NfbYR9q+YBIqSMt+v99yoW8aBNBhJSqwTw2QUblZWy oTyAa6UmNOx11WuMhouVP5rUYJOIU5gjtvcA8kDMg6mfvSy4+eKyww86Fs605ew401PN tHUjj8VYa6WQ+lzIRUWRbTmbKafe6llQuKJ2i3qD9UVotFsqdfqjptnpkOy/oo/DQrtI 4yygmCr1z2nm1JawcPaj62RePeBRcNZeoBujpw5t/wefrM2InaN9CrwI+5UGYybFsR13 zzkw== X-Forwarded-Encrypted: i=1; AJvYcCUIcXYd/oVedsRL5hGrtDydWtAMNjCVm/cmV0HCE38gSm/HqfAu21XVLtAxCA2mRBW/pA2PyV9YAfJx9TY=@vger.kernel.org X-Gm-Message-State: AOJu0YyloLm7qiWivhkKJeQDPGxOSnRgoivhsAuJM7YRbbU9xSdjhIXa 0LatY7bCofxzIHc9EwXKNeRtPGLE1jw6dXhlOTjJe5l8lyXAcYgWax0unxxlnms1 X-Gm-Gg: AY/fxX5p4pWu/O2ZsJxrhMy1MEqNjZmwIjpSX7E3MupnITlGNf5alRHML2C/3O/PVFn +H6aFg2FEgnbZi36DvNVvYDF7Dz+0cYVv1qqaetvViwc55NMyGa17Hq1dDqAIxKCSeOuJmI31t1 iccEwPDc+b3onqN1aAWStrXVa4Nn+iKypJImNkWjutKtkp15sVouPdWzNmsY2Ta5MWl2we6RNRY gmF/qyzHSzAJJcSuo8oyHz7yx2euakzsiMjTUaIFw/+qE3O2Wl+rcgDeAecUjR73bY6y/nzuyC4 AYKlxeZvyynxtNQmVOOjLG1jY6HocAWaUSk5UeMWOwOb11o2Uzl/4JQOQPYTIB7Xib7bV3WQqJh KEOY02+hxTykKQ330WxLEVm1J0otF9qfKoDWoPYSTijv+8tORQJW8N2QEZXMxbwl0BqgkwqFFk0 6XulHYxgsdp9vXzVdvsKZKcaGxCT/UimoZyuHiaMI2BGb/AJEm/8qp8ndEHp95/A== X-Received: by 2002:a05:7300:5353:b0:2ab:f490:79f9 with SMTP id 5a478bee46e88-2b6b35a1060mr1657052eec.21.1768525540952; Thu, 15 Jan 2026 17:05:40 -0800 (PST) Received: from zcache.home.zacbowling.com ([2001:5a8:60d:bc9:f1d2:502c:a6ff:5556]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b6b367cbc9sm1019884eec.32.2026.01.15.17.05.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 17:05:40 -0800 (PST) Sender: Zac Bowling From: Zac To: sean.wang@kernel.org Cc: deren.wu@mediatek.com, kvalo@kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-wireless@vger.kernel.org, lorenzo@kernel.org, nbd@nbd.name, linux@frame.work, ryder.lee@mediatek.com, sean.wang@mediatek.com, Zac Bowling , Zac Bowling Subject: [PATCH v4 12/21] wifi: mt76: mt7925: fix key removal failure during MLO roaming Date: Thu, 15 Jan 2026 17:05:10 -0800 Message-ID: <20260116010519.37001-13-zac@zacbowling.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260116010519.37001-1-zac@zacbowling.com> References: <20260116010519.37001-1-zac@zacbowling.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Zac Bowling During MLO roaming, mac80211 may request key removal after the link state has already been torn down. The current code returns -EINVAL when link_conf, mconf, or mlink is NULL, causing 'failed to remove key from hardware (-22)' errors in the kernel log. This is a race condition where: 1. MLO link teardown begins, cleaning up driver state 2. mac80211 requests group key removal for the old link 3. mt792x_vif_to_bss_conf() or related functions return NULL 4. Driver returns -EINVAL, confusing upper layers Observed kernel log errors during roaming: wlp192s0: failed to remove key (1, ff:ff:ff:ff:ff:ff) from hardware (-22) wlp192s0: failed to remove key (4, ff:ff:ff:ff:ff:ff) from hardware (-22) And associated wpa_supplicant warnings: nl80211: kernel reports: link ID must for MLO group key The fix: When removing a key (cmd !=3D SET_KEY), if the link state is already gone, return success (0) instead of error. The key is effectively removed when the link was torn down. Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver for mt= 7925 chips") Reported-by: Zac Bowling Tested-by: Zac Bowling Signed-off-by: Zac Bowling --- drivers/net/wireless/mediatek/mt76/mt7925/main.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/main.c b/drivers/net= /wireless/mediatek/mt76/mt7925/main.c index 852cf8ff84..7cf6faa1f6 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/main.c @@ -605,8 +605,15 @@ static int mt7925_set_link_key(struct ieee80211_hw *hw= , enum set_key_cmd cmd, mconf =3D mt792x_vif_to_link(mvif, link_id); mlink =3D mt792x_sta_to_link(msta, link_id); =20 - if (!link_conf || !mconf || !mlink) + if (!link_conf || !mconf || !mlink) { + /* During MLO roaming, link state may be torn down before + * mac80211 requests key removal. If removing a key and + * the link is already gone, consider it successfully removed. + */ + if (cmd !=3D SET_KEY) + return 0; return -EINVAL; + } =20 wcid =3D &mlink->wcid; wcid_keyidx =3D &wcid->hw_key_idx; --=20 2.52.0