From nobody Sat Feb 7 23:10:57 2026 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BB8E1A9F96 for ; Fri, 16 Jan 2026 00:31:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768523519; cv=none; b=dDC5KjI4eE9Qxlb7YIkGajmKzjGyeWNeYjMgbWT73PiCD+FeWlwFjFNN1bkqSabe53SJXc3RMbvmK5av6PvLBzB+KP+x1qicqLMvkB3x5Y6NOXZkErUNGq75/gFBp3YS8f4F5GO4RM5VDYoT+JVlqsV7DeYoIT7UV9nvxqpHhvE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768523519; c=relaxed/simple; bh=rJO87xfkyFtWUxU4oZC6QGw58jHCE4tTEXdOG3x6dSw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jijRSYUN8DLlVzXgT5KBlZVHtWMuLZefEdCPg1ayvzjG830Ysez1r1O3TDM3M3+fnO/qCeQrsxrqb2dOPUcb+NEGs4qB4TN+f9pdy5tn+pbd9NbZmX8rdCAuCO+NU99+ib4iSqyhBhG59WjTAqT7tF6SXF+FgDQFV3dAkID/Tns= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lRu3+yX8; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lRu3+yX8" Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-2b05fe2bf14so3311697eec.1 for ; Thu, 15 Jan 2026 16:31:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768523518; x=1769128318; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=x1pHaIXvJMGgJtXRxcfBLUJYd85Jy5r23UW4kbJOj2w=; b=lRu3+yX8uPaicOIPDEYp8HmmVPc67T/jLvUS9cyImym+k21777JHVWXQzbMB3kY3eH tMTqJIYMotAProgUX7yoILf1rkzlC0EWLIprXHjCvYITzrQfaATuBiwuxUC7Z46e4gAg 2EEVZQkBQ5qunpWYeLvsv6ZfPU2X0/CpPsLlRuP2a+SAxSC6vApfpLozOe/0hWgx7caQ j4lITAsBpmLV69uQF9TVJnMdYIIsOwbESW8aPvmMB7Uq9/5ic0DnoAb/eei+qHDAY0SG GcK4GJvnay37O0iCE3W0+psm98O8RixQJMxlRzaX2NT8H5OudamfU2Gbe/B53qMybyBo SSJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768523518; x=1769128318; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=x1pHaIXvJMGgJtXRxcfBLUJYd85Jy5r23UW4kbJOj2w=; b=Q5iWn6FYVyqG8xSklVuPybyiHCFaTLYrDCNgINSVK9SKOR4yhlZ726htQndtCqvWiB 0Ba68UOp2rl0PfaBFNeuEUTPL7vJnM0Vn+mJJBYAagh3rDxAXLORb5ccaKxVUZF8OJGw z5p8KQxSfhFdlR01aqZC4/NeDJ1KGAMiCo3GzG/zC/h2OIEF6dK+L5NBe+Uu1WXmYPzc 3pWkxTNS2Q/j+WtlL3TzmsFAxGhGDO+cr7Dn5K+ivlEcQOI7zjhGhqc4QnfZIu8vh65+ dMmmfgu1VOAEbauEdV0DVQ/DI3sYa+eyh0ZL5WhCPD0TbQIOYgK5X7UPtB+wfXbpBXz8 RdBA== X-Forwarded-Encrypted: i=1; AJvYcCV7SXAhjykZzrVQKqbU5W4tmfrBPX5A90F+z0qEVaLFVhxsjrPH9tXeZDm9Kvgh3rqEt/H0x34ZMjPncZ8=@vger.kernel.org X-Gm-Message-State: AOJu0YzJ6Z4olgtUUs4+bu+DCee9+8r1PATIc9wFLofuA6LYMeAn4MdC PIWEwb0shjRF/xLQ/TVyL+8eapN3YN/aQVH+VRojzW1ELwEgv3gBv54i X-Gm-Gg: AY/fxX7Qm9JFwufWfloE5o+dRxA8iNWfYoeVimIGAl0Bs/kk9oL/Y2If2oYq4DXBaDt 9FsbsXZbxmZqpLcpOdyqmLUsBEU7zT+H3tusd3RP0nJRIhpIWpRRw20DCvfy59tVXiOkGN1DnLl Bt1qkTdICt4eoolZ+1kxcrwhY1tBmMK15LulIlCrfai+CxOO7hAt46e3TgxpxdK/K0gfFBqdBEt imY3WA/0uae29F0AL6GussvbozT/gguFMnx0Z4Kz3pbH25wxnzQoD050aXqVObw2RTo3l+aS1nd gO/HzO/H0bRY1Qvojwe7Fa/GXINL2mrcJRgBJifMriuLOqaPF+z5CtRsUH4wCy86gNBchgpD6/W HwlmehWyKD+37v1T3fME+8GnoCh4zEqnHbz/BYlCrcK3bnsl5exk5GhSM6JJH6cI2CVjO0PX2O/ HgkTYoiw/qnQ== X-Received: by 2002:a05:7300:6d15:b0:2b0:5609:a58c with SMTP id 5a478bee46e88-2b6b4119739mr1608456eec.32.1768523516110; Thu, 15 Jan 2026 16:31:56 -0800 (PST) Received: from localhost ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b6b34c11dasm1041106eec.2.2026.01.15.16.31.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 16:31:55 -0800 (PST) From: Inochi Amaoto To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Joel Stanley Cc: Inochi Amaoto , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yixun Lan , Longbin Li Subject: [PATCH net-next] net: ethernet: litex: use devm_register_netdev() to register netdev Date: Fri, 16 Jan 2026 08:31:50 +0800 Message-ID: <20260116003150.183070-1-inochiama@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use devm_register_netdev to avoid unnecessary remove() callback in platform_driver structure. Signed-off-by: Inochi Amaoto --- drivers/net/ethernet/litex/litex_liteeth.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ether= net/litex/litex_liteeth.c index 829a4b828f8e..0de166528641 100644 --- a/drivers/net/ethernet/litex/litex_liteeth.c +++ b/drivers/net/ethernet/litex/litex_liteeth.c @@ -232,12 +232,13 @@ static void liteeth_setup_slots(struct liteeth *priv) =20 static int liteeth_probe(struct platform_device *pdev) { + struct device *dev =3D &pdev->dev; struct net_device *netdev; void __iomem *buf_base; struct liteeth *priv; int irq, err; =20 - netdev =3D devm_alloc_etherdev(&pdev->dev, sizeof(*priv)); + netdev =3D devm_alloc_etherdev(dev, sizeof(*priv)); if (!netdev) return -ENOMEM; =20 @@ -248,7 +249,7 @@ static int liteeth_probe(struct platform_device *pdev) priv->netdev =3D netdev; priv->dev =3D &pdev->dev; =20 - netdev->tstats =3D devm_netdev_alloc_pcpu_stats(&pdev->dev, + netdev->tstats =3D devm_netdev_alloc_pcpu_stats(dev, struct pcpu_sw_netstats); if (!netdev->tstats) return -ENOMEM; @@ -276,15 +277,15 @@ static int liteeth_probe(struct platform_device *pdev) priv->tx_base =3D buf_base + priv->num_rx_slots * priv->slot_size; priv->tx_slot =3D 0; =20 - err =3D of_get_ethdev_address(pdev->dev.of_node, netdev); + err =3D of_get_ethdev_address(dev->of_node, netdev); if (err) eth_hw_addr_random(netdev); =20 netdev->netdev_ops =3D &liteeth_netdev_ops; =20 - err =3D register_netdev(netdev); + err =3D devm_register_netdev(dev, netdev); if (err) { - dev_err(&pdev->dev, "Failed to register netdev %d\n", err); + dev_err(dev, "Failed to register netdev %d\n", err); return err; } =20 @@ -294,13 +295,6 @@ static int liteeth_probe(struct platform_device *pdev) return 0; } =20 -static void liteeth_remove(struct platform_device *pdev) -{ - struct net_device *netdev =3D platform_get_drvdata(pdev); - - unregister_netdev(netdev); -} - static const struct of_device_id liteeth_of_match[] =3D { { .compatible =3D "litex,liteeth" }, { } @@ -309,7 +303,6 @@ MODULE_DEVICE_TABLE(of, liteeth_of_match); =20 static struct platform_driver liteeth_driver =3D { .probe =3D liteeth_probe, - .remove =3D liteeth_remove, .driver =3D { .name =3D DRV_NAME, .of_match_table =3D liteeth_of_match, --=20 2.52.0