From nobody Tue Feb 10 14:32:56 2026 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85A803A4AB6 for ; Fri, 16 Jan 2026 14:42:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768574535; cv=none; b=St0jHGLGOowl413aefOJIG+5vdF2U6OfUqY0YRvPWOT4HTrC4XUAWQRILFE5RC9puOGDIsNaFsKnV926zlgDHbocVQf+7oHVK37RM1AhsP9ileEFI25SmMiicLXxmIGnRqRBX0VTE1gEcacHw/5gpYY0hAmGUD1/IGi9rIt1fq4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768574535; c=relaxed/simple; bh=rwjTCDMA9Wsjf35FH7xh4HLESbauleYKcWwiCc9dZr0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sLAjR5L/9ZNG67fuC0W/DxFTZ0cS532Pgus4JdOPPOGdA0KZRh0Cz54/lxwu8j5XBvpgSZcHlCHB3ZpPgUW4NTbdo0LnOtO5clXO4DjB1PapOtI+l0lyzmwCdbLq4DFgZiWJlAT2a+cRwZtNqqdCT/c+Yk8UmMyUvMX6Pscztog= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=XZ/eqAuB; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=svAOfNPn; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=XZ/eqAuB; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=svAOfNPn; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="XZ/eqAuB"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="svAOfNPn"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="XZ/eqAuB"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="svAOfNPn" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E35B9337FD; Fri, 16 Jan 2026 14:40:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1768574438; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yKwoNuW0XcCU6x7RZ8PJjscrQbHgYsoJBCDr/kRfhfw=; b=XZ/eqAuBT7WuVhdJmN7eXywGl7+1eyE+etpinsBWT5k4S2KOKn2WVB4JQNmwSS7T4/fCUS /hyLQSemksIVTEcqfrE2zfzByuFKoReJeiAISwysywzne6e9IrZ6yGYnW9oYtz8clLmfR7 GwERLirKCEvUNM9aicv6P+JnOD9vnek= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1768574438; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yKwoNuW0XcCU6x7RZ8PJjscrQbHgYsoJBCDr/kRfhfw=; b=svAOfNPn04sZZKaLeflwCVl7grXOPjQ9A9RtZrYa1aFi97LX/qDB2N3nSU7qqF6W5q6cKF 3c40G3OsuUuWTBCA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1768574438; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yKwoNuW0XcCU6x7RZ8PJjscrQbHgYsoJBCDr/kRfhfw=; b=XZ/eqAuBT7WuVhdJmN7eXywGl7+1eyE+etpinsBWT5k4S2KOKn2WVB4JQNmwSS7T4/fCUS /hyLQSemksIVTEcqfrE2zfzByuFKoReJeiAISwysywzne6e9IrZ6yGYnW9oYtz8clLmfR7 GwERLirKCEvUNM9aicv6P+JnOD9vnek= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1768574438; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yKwoNuW0XcCU6x7RZ8PJjscrQbHgYsoJBCDr/kRfhfw=; b=svAOfNPn04sZZKaLeflwCVl7grXOPjQ9A9RtZrYa1aFi97LX/qDB2N3nSU7qqF6W5q6cKF 3c40G3OsuUuWTBCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B7D313EA65; Fri, 16 Jan 2026 14:40:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id SOyZLOZNamnydgAAD6G6ig (envelope-from ); Fri, 16 Jan 2026 14:40:38 +0000 From: Vlastimil Babka Date: Fri, 16 Jan 2026 15:40:40 +0100 Subject: [PATCH v3 20/21] mm/slub: remove DEACTIVATE_TO_* stat items Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260116-sheaves-for-all-v3-20-5595cb000772@suse.cz> References: <20260116-sheaves-for-all-v3-0-5595cb000772@suse.cz> In-Reply-To: <20260116-sheaves-for-all-v3-0-5595cb000772@suse.cz> To: Harry Yoo , Petr Tesarik , Christoph Lameter , David Rientjes , Roman Gushchin Cc: Hao Li , Andrew Morton , Uladzislau Rezki , "Liam R. Howlett" , Suren Baghdasaryan , Sebastian Andrzej Siewior , Alexei Starovoitov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, bpf@vger.kernel.org, kasan-dev@googlegroups.com, Vlastimil Babka X-Mailer: b4 0.14.3 X-Spam-Score: -4.30 X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[18]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[linux.dev,linux-foundation.org,gmail.com,oracle.com,google.com,linutronix.de,kernel.org,kvack.org,vger.kernel.org,lists.linux.dev,googlegroups.com,suse.cz]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; R_RATELIMIT(0.00)[to_ip_from(RLwn5r54y1cp81no5tmbbew5oc),to(RL941jgdop1fyjkq8h4)] X-Spam-Level: X-Spam-Flag: NO The cpu slabs and their deactivations were removed, so remove the unused stat items. Weirdly enough the values were also used to control __add_partial() adding to head or tail of the list, so replace that with a new enum add_mode, which is cleaner. Reviewed-by: Suren Baghdasaryan Signed-off-by: Vlastimil Babka Reviewed-by: Hao Li --- mm/slub.c | 31 +++++++++++++++---------------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 7ec7049c0ca5..c12e90cb2fca 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -324,6 +324,11 @@ static void debugfs_slab_add(struct kmem_cache *); static inline void debugfs_slab_add(struct kmem_cache *s) { } #endif =20 +enum add_mode { + ADD_TO_HEAD, + ADD_TO_TAIL, +}; + enum stat_item { ALLOC_PCS, /* Allocation from percpu sheaf */ ALLOC_FASTPATH, /* Allocation from cpu slab */ @@ -343,8 +348,6 @@ enum stat_item { CPUSLAB_FLUSH, /* Abandoning of the cpu slab */ DEACTIVATE_FULL, /* Cpu slab was full when deactivated */ DEACTIVATE_EMPTY, /* Cpu slab was empty when deactivated */ - DEACTIVATE_TO_HEAD, /* Cpu slab was moved to the head of partials */ - DEACTIVATE_TO_TAIL, /* Cpu slab was moved to the tail of partials */ DEACTIVATE_REMOTE_FREES,/* Slab contained remotely freed objects */ DEACTIVATE_BYPASS, /* Implicit deactivation */ ORDER_FALLBACK, /* Number of times fallback was necessary */ @@ -3268,10 +3271,10 @@ static inline void slab_clear_node_partial(struct s= lab *slab) * Management of partially allocated slabs. */ static inline void -__add_partial(struct kmem_cache_node *n, struct slab *slab, int tail) +__add_partial(struct kmem_cache_node *n, struct slab *slab, enum add_mode = mode) { n->nr_partial++; - if (tail =3D=3D DEACTIVATE_TO_TAIL) + if (mode =3D=3D ADD_TO_TAIL) list_add_tail(&slab->slab_list, &n->partial); else list_add(&slab->slab_list, &n->partial); @@ -3279,10 +3282,10 @@ __add_partial(struct kmem_cache_node *n, struct sla= b *slab, int tail) } =20 static inline void add_partial(struct kmem_cache_node *n, - struct slab *slab, int tail) + struct slab *slab, enum add_mode mode) { lockdep_assert_held(&n->list_lock); - __add_partial(n, slab, tail); + __add_partial(n, slab, mode); } =20 static inline void remove_partial(struct kmem_cache_node *n, @@ -3375,7 +3378,7 @@ static void *alloc_single_from_new_slab(struct kmem_c= ache *s, struct slab *slab, if (slab->inuse =3D=3D slab->objects) add_full(s, n, slab); else - add_partial(n, slab, DEACTIVATE_TO_HEAD); + add_partial(n, slab, ADD_TO_HEAD); =20 inc_slabs_node(s, nid, slab->objects); spin_unlock_irqrestore(&n->list_lock, flags); @@ -3996,7 +3999,7 @@ static unsigned int alloc_from_new_slab(struct kmem_c= ache *s, struct slab *slab, n =3D get_node(s, slab_nid(slab)); spin_lock_irqsave(&n->list_lock, flags); } - add_partial(n, slab, DEACTIVATE_TO_HEAD); + add_partial(n, slab, ADD_TO_HEAD); spin_unlock_irqrestore(&n->list_lock, flags); } =20 @@ -5064,7 +5067,7 @@ static noinline void free_to_partial_list( /* was on full list */ remove_full(s, n, slab); if (!slab_free) { - add_partial(n, slab, DEACTIVATE_TO_TAIL); + add_partial(n, slab, ADD_TO_TAIL); stat(s, FREE_ADD_PARTIAL); } } else if (slab_free) { @@ -5184,7 +5187,7 @@ static void __slab_free(struct kmem_cache *s, struct = slab *slab, * then add it. */ if (unlikely(was_full)) { - add_partial(n, slab, DEACTIVATE_TO_TAIL); + add_partial(n, slab, ADD_TO_TAIL); stat(s, FREE_ADD_PARTIAL); } spin_unlock_irqrestore(&n->list_lock, flags); @@ -6564,7 +6567,7 @@ __refill_objects_node(struct kmem_cache *s, void **p,= gfp_t gfp, unsigned int mi continue; =20 list_del(&slab->slab_list); - add_partial(n, slab, DEACTIVATE_TO_HEAD); + add_partial(n, slab, ADD_TO_HEAD); } =20 spin_unlock_irqrestore(&n->list_lock, flags); @@ -7031,7 +7034,7 @@ static void early_kmem_cache_node_alloc(int node) * No locks need to be taken here as it has just been * initialized and there is no concurrent access. */ - __add_partial(n, slab, DEACTIVATE_TO_HEAD); + __add_partial(n, slab, ADD_TO_HEAD); } =20 static void free_kmem_cache_nodes(struct kmem_cache *s) @@ -8719,8 +8722,6 @@ STAT_ATTR(FREE_SLAB, free_slab); STAT_ATTR(CPUSLAB_FLUSH, cpuslab_flush); STAT_ATTR(DEACTIVATE_FULL, deactivate_full); STAT_ATTR(DEACTIVATE_EMPTY, deactivate_empty); -STAT_ATTR(DEACTIVATE_TO_HEAD, deactivate_to_head); -STAT_ATTR(DEACTIVATE_TO_TAIL, deactivate_to_tail); STAT_ATTR(DEACTIVATE_REMOTE_FREES, deactivate_remote_frees); STAT_ATTR(DEACTIVATE_BYPASS, deactivate_bypass); STAT_ATTR(ORDER_FALLBACK, order_fallback); @@ -8823,8 +8824,6 @@ static struct attribute *slab_attrs[] =3D { &cpuslab_flush_attr.attr, &deactivate_full_attr.attr, &deactivate_empty_attr.attr, - &deactivate_to_head_attr.attr, - &deactivate_to_tail_attr.attr, &deactivate_remote_frees_attr.attr, &deactivate_bypass_attr.attr, &order_fallback_attr.attr, --=20 2.52.0