From nobody Sun Feb 8 18:14:26 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B409F221277 for ; Fri, 16 Jan 2026 12:58:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768568286; cv=pass; b=sFkFxhYFGtOh8xiJPp1Bazv5tVL3hKHYQDMUy8ykYafQjVarDLoYivVu3I0iXCrygLM0YSFlvh15HyO34KyKqArSfn7x00g/VEdUYKRIdLTxpIl0OHmJUiGeQ0t6DMEmRmbsX1kZpLoRyRxIkfgYQyD+bc5UPWFGvHGTpWc67Dg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768568286; c=relaxed/simple; bh=NU3WMZrBWfT7gMgh/ChFpiRuUuIc/JYVhuCrMD+wSSc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EnnrIca2KoWjl1mU8WhCapA4ghpeGt5Iyz7bucAOgNHdgFO7FnucD3Loxg6tpLJDCFPAiGS9MXLlxcGRezVuQxjuNvgmxZ8el2LOt/WCDQH01lsShPA/PdytWAEhnC6K2YBYqn0fCL9u4f4Qa4eAupPC0+eduGbyScD2AWaY53Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=f+gC34Au; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="f+gC34Au" ARC-Seal: i=1; a=rsa-sha256; t=1768568270; cv=none; d=zohomail.com; s=zohoarc; b=WSJP/yiH7VxKbkhjiiIh1pQCXWeVuS2LnIZNFL5IBH9C84NJyok5N3Z9EH9tISKhbY1CAOcSFPrcaAm8QdN86lIF5aXc8JxdWAppR9PF1xtuaZDrX+LhF/gDjGOiCSeZyojqJI1r/1E4w9Ys6sPJlyZ2M5+eSAfHrGZtxvmApLw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768568270; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=7Vs6Hx5M5iOCZHlPNzxvtAfQld9Y5HN4gfBASmzYMnk=; b=SEb9lC+yzEShEJoVVHNKx43Rt3NRtdPv+0eIAdomoN0K+eRnvxbV9+O0eJ4rIBI9KPft1tzi113EZPlPX2rBcgscyiyGbLHkuNJ0Z1l1UdWmGymn4Xu07ACGARkMml6ahzaP2x54wQK5Z3nqirmwMvZnXsRBFOcpXQ+9K1pjzMM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768568270; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=7Vs6Hx5M5iOCZHlPNzxvtAfQld9Y5HN4gfBASmzYMnk=; b=f+gC34AuvCeGoZ/o1xqrTOP+x5gH3NaKyVolXbYc6XqY28XV6wRJQptkGfnjgluZ 12GcOG3UZLtYU6q5y1iuCuo463qyiFu5rutmpSi3KPnQeZwI4CVRmHJ9avt+gN4yJvF 8TpcRI1Zq2NrVT5v2DQu9ablNC8eg4HawKiOhWFk= Received: by mx.zohomail.com with SMTPS id 1768568269688536.57292235551; Fri, 16 Jan 2026 04:57:49 -0800 (PST) From: Nicolas Frattaroli Date: Fri, 16 Jan 2026 13:57:30 +0100 Subject: [PATCH v10 1/4] drm/panthor: Rework panthor_irq::suspended into panthor_irq::state Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260116-panthor-tracepoints-v10-1-d925986e3d1b@collabora.com> References: <20260116-panthor-tracepoints-v10-0-d925986e3d1b@collabora.com> In-Reply-To: <20260116-panthor-tracepoints-v10-0-d925986e3d1b@collabora.com> To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chia-I Wu , Karunika Choo Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 To deal with the threaded interrupt handler and a suspend action overlapping, the boolean panthor_irq::suspended is not sufficient. Rework it into taking several different values depending on the current state, and check it and set it within the IRQ helper functions. Co-developed-by: Boris Brezillon Signed-off-by: Boris Brezillon Signed-off-by: Nicolas Frattaroli Reviewed-by: Boris Brezillon Reviewed-by: Steven Price --- drivers/gpu/drm/panthor/panthor_device.h | 35 +++++++++++++++++++++++++---= ---- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_device.h b/drivers/gpu/drm/pan= thor/panthor_device.h index f35e52b9546a..8597b388cc40 100644 --- a/drivers/gpu/drm/panthor/panthor_device.h +++ b/drivers/gpu/drm/panthor/panthor_device.h @@ -61,6 +61,17 @@ enum panthor_device_pm_state { PANTHOR_DEVICE_PM_STATE_SUSPENDING, }; =20 +enum panthor_irq_state { + /** @PANTHOR_IRQ_STATE_ACTIVE: IRQ is active and ready to process events.= */ + PANTHOR_IRQ_STATE_ACTIVE =3D 0, + /** @PANTHOR_IRQ_STATE_PROCESSING: IRQ is currently processing events. */ + PANTHOR_IRQ_STATE_PROCESSING, + /** @PANTHOR_IRQ_STATE_SUSPENDED: IRQ is suspended. */ + PANTHOR_IRQ_STATE_SUSPENDED, + /** @PANTHOR_IRQ_STATE_SUSPENDING: IRQ is being suspended. */ + PANTHOR_IRQ_STATE_SUSPENDING, +}; + /** * struct panthor_irq - IRQ data * @@ -76,8 +87,8 @@ struct panthor_irq { /** @mask: Current mask being applied to xxx_INT_MASK. */ u32 mask; =20 - /** @suspended: Set to true when the IRQ is suspended. */ - atomic_t suspended; + /** @state: one of &enum panthor_irq_state reflecting the current state. = */ + atomic_t state; }; =20 /** @@ -409,12 +420,17 @@ static irqreturn_t panthor_ ## __name ## _irq_raw_han= dler(int irq, void *data) { \ struct panthor_irq *pirq =3D data; \ struct panthor_device *ptdev =3D pirq->ptdev; \ + enum panthor_irq_state old_state; \ \ - if (atomic_read(&pirq->suspended)) \ - return IRQ_NONE; \ if (!gpu_read(ptdev, __reg_prefix ## _INT_STAT)) \ return IRQ_NONE; \ \ + old_state =3D atomic_cmpxchg(&pirq->state, \ + PANTHOR_IRQ_STATE_ACTIVE, \ + PANTHOR_IRQ_STATE_PROCESSING); \ + if (old_state !=3D PANTHOR_IRQ_STATE_ACTIVE) \ + return IRQ_NONE; \ + \ gpu_write(ptdev, __reg_prefix ## _INT_MASK, 0); \ return IRQ_WAKE_THREAD; \ } \ @@ -423,6 +439,7 @@ static irqreturn_t panthor_ ## __name ## _irq_threaded_= handler(int irq, void *da { \ struct panthor_irq *pirq =3D data; \ struct panthor_device *ptdev =3D pirq->ptdev; \ + enum panthor_irq_state old_state; \ irqreturn_t ret =3D IRQ_NONE; \ \ while (true) { \ @@ -435,7 +452,10 @@ static irqreturn_t panthor_ ## __name ## _irq_threaded= _handler(int irq, void *da ret =3D IRQ_HANDLED; \ } \ \ - if (!atomic_read(&pirq->suspended)) \ + old_state =3D atomic_cmpxchg(&pirq->state, \ + PANTHOR_IRQ_STATE_PROCESSING, \ + PANTHOR_IRQ_STATE_ACTIVE); \ + if (old_state =3D=3D PANTHOR_IRQ_STATE_PROCESSING) \ gpu_write(ptdev, __reg_prefix ## _INT_MASK, pirq->mask); \ \ return ret; \ @@ -445,14 +465,15 @@ static inline void panthor_ ## __name ## _irq_suspend= (struct panthor_irq *pirq) { \ pirq->mask =3D 0; \ gpu_write(pirq->ptdev, __reg_prefix ## _INT_MASK, 0); \ + atomic_set(&pirq->state, PANTHOR_IRQ_STATE_SUSPENDING); \ synchronize_irq(pirq->irq); \ - atomic_set(&pirq->suspended, true); \ + atomic_set(&pirq->state, PANTHOR_IRQ_STATE_SUSPENDED); \ } \ \ static inline void panthor_ ## __name ## _irq_resume(struct panthor_irq *p= irq, u32 mask) \ { \ - atomic_set(&pirq->suspended, false); \ pirq->mask =3D mask; \ + atomic_set(&pirq->state, PANTHOR_IRQ_STATE_ACTIVE); \ gpu_write(pirq->ptdev, __reg_prefix ## _INT_CLEAR, mask); \ gpu_write(pirq->ptdev, __reg_prefix ## _INT_MASK, mask); \ } \ --=20 2.52.0