From nobody Mon Feb 9 04:30:02 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 842CD35E546 for ; Fri, 16 Jan 2026 11:01:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768561293; cv=none; b=Kp2WDAYK6Ssd6Q7iBPJRJAkjpagXKn2QaEjEAiFgRx7G5SAsk5ndXayJfZ3Y+tQnOJ2mVj5kQWnye+GCIh1+DVW/QBnrEvwpuhClOUssYcmCsaRqlsLcXd9XyPh0ZtI//Ej6dy2zJZw4Mx5Zo0KgvypKRU6JM2Ef0ax2AoOignE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768561293; c=relaxed/simple; bh=DBroTzEvTTv60Jmf1hJFudo/s1CU1IeoEpCPGQGOR9E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=J0tQ/lyJ9kQnkL+COR4zFbsatpGyw0mpPO/cTl71zVjbDfllQtMcZOAzzwDuTmlbOrf51d/mT9zG+XWXfg3lJIz9/mECNeNdQHzQp0x98FO6nHYrjIQ0VzxnmHnq2MFM6gDqxHy2At3DkXrKDUT5nkjnd2bWB4hfrD1exb6PfoQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T5h4+xua; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RdaEft1q; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T5h4+xua"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RdaEft1q" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60G86Yta4100521 for ; Fri, 16 Jan 2026 11:01:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gZNQGei6/+R4IWa9zF26FwhPVN8758eSQx0EedexqFI=; b=T5h4+xuamwwmUylz 6BF8aZr0peE/KaHyxjYGgeN502NKQGo+yNLz/vOFX7HRZZAD+IizZdF66Vun/R7A BlVFk6ccNdZRPVvV/ls650rbrxOnyxHadgcMG945EPP0DX/QppXzp+qyRmDkJQjp 9CMVWMYzeljiTuBVAAyiynOBYEdqDqG47K3b1XAT5acJqo0198R3K9pjQsSaLDKt iquTkA8dJG0hnwpaHtS/MOzKNUX1wFyqSWV9LP+OrDcL5GNaN/6kHLJ0qvNmiY9H CvE+l1B6RMUGeDvHpCeJpVQmvMmg/I+H14dNR6hGoaXQcJ5K+5wLcEe+U1I2VyDq 5WMNHw== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bq9751v0f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 16 Jan 2026 11:01:29 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-5ecf43202a3so1352637137.0 for ; Fri, 16 Jan 2026 03:01:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768561289; x=1769166089; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gZNQGei6/+R4IWa9zF26FwhPVN8758eSQx0EedexqFI=; b=RdaEft1qnSB+Rdrq7QVuxdPFb7A/F2FTP9sSSRW3BPZG6gV/8UYetEzb6MddB+ghHA CzlKZw/hnoqhtzYu+7EoPdldOqdPhf0P3bRCAl8aFRo0bA8v/YGrnXbN33qakooT7HC8 eb6lA0ZDCWHpujJkyiGsle704yb/aLSZ3VXalg6TwtzAFSOwxJWvxSAgdjo5RJySJS5m 8ffm8jwpKOe/ZJHgckgohbNVypyOjU5oobIBwFlEPcdSEeLJx1jx36uQgFWuOCSIMJFy Drn9sQ6d0pOQBCllpzgRSlSU3oVAAeqX8HIEsJbmzwW5EHOOGPLnfnEBp9VPrhlVOtjz O3FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768561289; x=1769166089; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=gZNQGei6/+R4IWa9zF26FwhPVN8758eSQx0EedexqFI=; b=XOQ4wEa/qsXWX7Cb/PeUuIO3/+zZJt4pmxGk6u8w4cfWq+/88tXEEWM9bvcl4IpqQi B4gekn/8qrkgPd2TcL1gRgj6HP+/03UaGwSX+m2n19m/BL0pJ2KfcvMwHKGTYIXs/k+o 05UUPk5YMA27N7zdv352i28hRvthu7W1QQF5CLTzlUifwNpZCF2wYaqCNxycOgGKk02q CWt3+dQ1s/UGf2EfS9B41bOk7X6fdi6LfMeZ/GA/4imNWY12j+f9EKtxnu4Xnpnp59bf GjexedTjH4U3BSnQvCDKrDW169Z1EOWVpDo4BIXVule8t0pz0R+QvhyxrLZqYO91vFmn sM+Q== X-Gm-Message-State: AOJu0Yyom9DYdR6bs8G7EeajDG0WfryOMxHWrYhnuj7g65g26adwXmkD Rb+XFPIz/vgAjTCnUTMS71WQAP+oHOiUyEfBfybFLYMcSeYKERKUBQb+E84C7HQU1es71Jeq3B+ tpSXsmyE8g5haOZsXp3MnNvKM+8B5ZLsw7mgLYseorh6okEWNNVj5MvzPffzSkolMwos= X-Gm-Gg: AY/fxX4744QbNTXvf7zYHNZ6bHG1XblLJTo/lG/oxkmlN+ysHvkSAYIdivGf+uEhZcO 3vodyD92/1N8oM7XFvlpkZ1tv30APsSEOdLE5Y/rsR7VD88R/9SZJRfIta+po5NKpzv5FLsjY42 USYRZ9qSb3uZ6o2vWg3wnj67J7fq2TI/lQ63V7MYYinjlLENriCTyjCDaVGt/VobPFoZLR8Gv1g xmnlZRgY9mGDVyaPUyGH7E9yAdr8vIorBzCBxpV7caWlBOIJEnjP4ScadMxEPQLjg6Z+6O+1kQY 6fLs8lLLziwrd/+xydYfElB3jc3tmDgHoDasrUj3MoK4Fwse5E1UQWM/dXICX5J2Gscw0dJfnch Uc92Vx6wdeit5K/1pOqJxHXbFHANN2OMwQin6/pk= X-Received: by 2002:a05:6102:370c:b0:5ef:a52b:96ac with SMTP id ada2fe7eead31-5f1a6fcfd8cmr620613137.2.1768561288690; Fri, 16 Jan 2026 03:01:28 -0800 (PST) X-Received: by 2002:a05:6102:370c:b0:5ef:a52b:96ac with SMTP id ada2fe7eead31-5f1a6fcfd8cmr620603137.2.1768561288225; Fri, 16 Jan 2026 03:01:28 -0800 (PST) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:d1c:5bb0:db13:fc7d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47f4289b789sm93512975e9.1.2026.01.16.03.01.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 03:01:27 -0800 (PST) From: Bartosz Golaszewski Date: Fri, 16 Jan 2026 12:01:10 +0100 Subject: [PATCH 3/7] nvmem: check the return value of gpiod_set_value_cansleep() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260116-nvmem-unbind-v1-3-7bb401ab19a8@oss.qualcomm.com> References: <20260116-nvmem-unbind-v1-0-7bb401ab19a8@oss.qualcomm.com> In-Reply-To: <20260116-nvmem-unbind-v1-0-7bb401ab19a8@oss.qualcomm.com> To: Srinivas Kandagatla , Bartosz Golaszewski Cc: linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1386; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=DBroTzEvTTv60Jmf1hJFudo/s1CU1IeoEpCPGQGOR9E=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBpahp+4vAS0SyPRzmubfhsVwdKZ/8fT8lHNgAnO htgVp42s4eJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaWoafgAKCRAFnS7L/zaE w1PCD/41Lw2tmTpgS7kRQqQAJq6XVr+vSoWsUzbNPOYukTS/8gpgEI0Am6yUDpmhYgCQhj7FrZK hg5i3HfwcpXwpmfdxrVfa3aBwUuiqu+E+aMMj6p0Sod+tjLw+9MNhSeqYL2gd6BaSpa4pzr/dIV FKYMAt0d3Yw4+MXjIWrG1bZtsqw9bQLhWy4uqRy/K1i7hWZSjgRQVkqP/+SieTYy/at9sL3ICyp 8eFPWDTOdawN0UcoigYTdr122aqE2TvHhKeC5qPIoOrbDkUN54yvYlZZ2P6tuooqsG6FPdG+IMU QKQ1zwYV6McPBo5OlROeFuI0ijYnP9zpNe3MhAVVDHkufoHR8lgBmp6BvKqjPmdkMvlfCcIO+4u sHTifQH6MxokKJ62V1KnB7NuweUqt+q/bNdiDM2nPm9ajGXWjcTfb05ltVMdCT/DKhWKh4XUlrg alpVrtUudwCJITHpcVckoZ9ueelz1dz0Fgk36hyKLJleuL9A8ZCCHJZwaqEmko06IQzr66z2ACB YZu31goJoTR8Rv/oN4WAquhaEwf2az7JoBauPyFZifFZVarcAYh0sj1ekbkH2FpeB9+uiBuXCSP N05i+nM+TWbRsoNA2oUEDMCfw2d26slgfKwfF2byNEXCn+Dso56x+Sp3cw1zdEN+TyYOrQ8LCmt 4DlUPsrOPfd9eVQ== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE2MDA4MCBTYWx0ZWRfX+CUfp/Ed53te V13RMw63cfSuw4S9/aiorD+RlA3n+LeCwkyIpFMfbCXQtL6N4S16SSHC1iT+nGROcBSvAzJv0UJ 2hyOMbCiBo4KBOOtJNOUYNd3eEoOm8zNVcYQSXI1re2cAYMulp9yjRgdivV84vLIbp6WPdocffX SM5KSUTvQZkC8g5Ud9E9Tw0rSLpm2dJBkEaGPaU0do9NTYHzWZJE74krUD4qA/kja4xgwnnYYHQ pl2NcHu1dw/5LUD6bVfTHI23Tr3ZgvS3A6O8CfXasR7n+vtUB44wwVm+im763RsljSecUCBvx6O oH9IivhBvKOnXQ16BNYxV1DaxTH0kEJw2RWLeXVqRsshJ3cvEgQUdItqBAHMnluGsoeyF1r3ucj NCpt0aXNo6mRnNwLBTnAmhLVm8G7qEDDR6LZCC/EaKwMsgA63wUFzO1d0YL3h5k9iehC6k/wBix OOmiFbCRAP5av85WwAQ== X-Authority-Analysis: v=2.4 cv=Sv6dKfO0 c=1 sm=1 tr=0 ts=696a1a89 cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=ii2iuPLuu9iRZ_mRmhMA:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-GUID: gKhLukGL65CEEEXd6Op4p8Kv4cIMmLEp X-Proofpoint-ORIG-GUID: gKhLukGL65CEEEXd6Op4p8Kv4cIMmLEp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-16_03,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 impostorscore=0 bulkscore=0 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601160080 GPIO setters now return integer values and can indicate failures in lower abstraction layers. Check the return values of gpiod_set_value_cansleep() calls in nvmem core. Signed-off-by: Bartosz Golaszewski --- drivers/nvmem/core.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index c4a5f8ef65164ef6994343e6d26d3d302c9b00c3..454e0645d1545602cd193f66b54= bd5c5811ca5ed 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -64,16 +64,22 @@ static int __nvmem_reg_read(struct nvmem_device *nvmem,= unsigned int offset, static int __nvmem_reg_write(struct nvmem_device *nvmem, unsigned int offs= et, void *val, size_t bytes) { - int ret; + int ret, written; =20 if (!nvmem->reg_write) return -EOPNOTSUPP; =20 - gpiod_set_value_cansleep(nvmem->wp_gpio, 0); - ret =3D nvmem->reg_write(nvmem->priv, offset, val, bytes); - gpiod_set_value_cansleep(nvmem->wp_gpio, 1); + ret =3D gpiod_set_value_cansleep(nvmem->wp_gpio, 0); + if (ret) + return ret; =20 - return ret; + written =3D nvmem->reg_write(nvmem->priv, offset, val, bytes); + + ret =3D gpiod_set_value_cansleep(nvmem->wp_gpio, 1); + if (ret) + return ret; + + return written; } =20 static int nvmem_access_with_keepouts(struct nvmem_device *nvmem, --=20 2.47.3