From nobody Mon Feb 9 10:42:27 2026 Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 745512405EB for ; Fri, 16 Jan 2026 13:17:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768569448; cv=none; b=CBAEJCnU0LCoxOTXif3HtjRKQuBJT76MsVX99IZCJ/N4Y+zjkEzecH2HLnT+gCIobcIPaCM4LtbFOR1IHa1+oCtq67BOwDBKrPEiOZMlO2HI6qnXJFzjq+F2Yd03Zj4HX7ineqY85Kg0yFgejdoZndx7GudOJiN644dNVllx38M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768569448; c=relaxed/simple; bh=bCuXidJmykHrH5/xvuIi+xpUlM7CPaWZgEz+0RvmlPc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mjU5L5xzqG3pB/W62kJb2rRCzciyGNTrt2ogtJKbaq4Sof7wcUjrAIxAB7O78DHlz/sbXQYC92NkjbboG6ClDnuTfVBg1h+KsTeghTlEAk4X1iup/53kWTGO/YxuLLJToK1RkWx/R1PpYdPPQjgwuxN6B2CRr9EkRw9rjfZfnbU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=QTM7us57; arc=none smtp.client-ip=209.85.218.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="QTM7us57" Received: by mail-ej1-f66.google.com with SMTP id a640c23a62f3a-b8719aeebc8so377073366b.3 for ; Fri, 16 Jan 2026 05:17:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1768569445; x=1769174245; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dr1dBlLLfYPYJFN+bHMPl6dVd/Smnn8ihazbVyoDL5M=; b=QTM7us572usDv7AeGtPhpASxDmrX5F1AwqpHR7EV525CzknOU59DMIueJ8/VjToFvg cmEbT08FyE+QFpO1L9Pvc7OO3NSk18sq6LSW7yd8Nf3Qj74DrdbTeS9uwghxelNNCYj0 LERiEbgHdZYprYoKOvRSCBPRRWqDqk7SxWe7ek7yrWQibjUTKH4JbxkEzBSYQPgCJR4O hSko0JfMSbPqjMGtbQMmLTHXw5ji3D6rbmqiUg8GN6bFi+RSe5NxppaLXgyEIit8+M3/ Fz3LKIeuKHYXCi5e7rFp+NsStST4khP6gAaawa3qImFMxQgMtNl4cY7g4h47GulLih// n+1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768569445; x=1769174245; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=dr1dBlLLfYPYJFN+bHMPl6dVd/Smnn8ihazbVyoDL5M=; b=aloWJMznq/EXOc+hoNNqIk9bC0seY8ib91uQli6jQT5v4SvdSwlvsidQq7JwGbd9uL 9m6YHTgPYjG1kD0qjbCz1C1q1XoT0tYEFMKQIrYFLhkxkiZEkLhJKyrVYp7JqaB08e7J L325rESHdhKSlJHVR60DwHCD5x4xd9LenLnipOR+QJO+MrH/KcO9ga1ycgeunTVEJpJ3 UlOkcGewXEqZUf1zAf2PXkGREQjtswAtm9WaW/KHbcsfju4bPAbNWajh3qjmLvKmBjJn 5a4KyrCNF5JxJfSVZMLHAmTmq4HNYO5M9hxAD+WUNqocH/tPzrDPm/Xt8gOYQ6b1/I/y cU9Q== X-Forwarded-Encrypted: i=1; AJvYcCXQ+WLsbg1Ntc66Jc0W+fuVw+c61RVzFppfyCRK2OjUGllYdCTrnhMAZtneCRa0T4DF1jUUhj33gqhBfcA=@vger.kernel.org X-Gm-Message-State: AOJu0YykjjUVTL+Kv9L4MbySdMOQLJTud9hASCZYIL+fMhmW3/1xHJfv tGEAjbWPWLFxeyAhkgB3e/PbXV/rC1jgGpCLqV7ZW1FRBRrl+ARmFiy2Ld0WbuQ6t8s= X-Gm-Gg: AY/fxX4iDgllUHAwGNEO/vp3btEbuzDkPADisjoiFHx7Fr39jnS3kz7qXwkh5tN035l xer3ghRqqpf4pz8sRFsbHspa0SzdOzMtTueUSqHTHJgrGCBojAdeo43Qqem/vRTvJ5LF6CUd46y 5mkdkS7y1/1vPu+4o0wOgTmcCA3b85h7dKiK3Q7WvsaQAPgdEyvS4B9Ycm1nXiuxclBXufOJ+M5 AeqUNP6ErxFqFtR/NiewAnVVTWYveaLUWpVbhW3hAEy39stRwtW/6NMVjh1iVcTuS7CEebWQlYQ 21/SB9+CCjjKvZVYKlvOCpH1NUsTOj/jEgm+yt8ZlWEVVccsX8+5LwuGh9YaXpaFGmOpOuJ32It 1fQVzFy/FJus7zO09JNtS/dLezJXTB0q+P0/7cC+EdzYf2LkJSHfErNCJwF6yLPH6DuI4dfYBhQ +2ALsQRTdorud5/qHwlEu7nxm6BGS0wRKIwCFdiS1Ut1RltIZTwlN2qAqmE49m38jq X-Received: by 2002:a17:907:1c09:b0:b83:f538:c2a6 with SMTP id a640c23a62f3a-b8792d273femr262706366b.6.1768569444776; Fri, 16 Jan 2026 05:17:24 -0800 (PST) Received: from [172.16.240.99] (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8795a350dbsm235507366b.69.2026.01.16.05.17.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 05:17:24 -0800 (PST) From: Luca Weiss Date: Fri, 16 Jan 2026 14:17:20 +0100 Subject: [PATCH 1/5] interconnect: Add devm_of_icc_get_by_index() as exported API for users Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260116-milos-camcc-icc-v1-1-400b7fcd156a@fairphone.com> References: <20260116-milos-camcc-icc-v1-0-400b7fcd156a@fairphone.com> In-Reply-To: <20260116-milos-camcc-icc-v1-0-400b7fcd156a@fairphone.com> To: Georgi Djakov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1768569443; l=2212; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=bCuXidJmykHrH5/xvuIi+xpUlM7CPaWZgEz+0RvmlPc=; b=gWnOVQzJkci4lXcmtXJVm6rHU7f4/LCiwxPAkRBMrt9HO3Y81FpwwOdbP5nuH44jBz3Bhr6mu g+++h/05vt9DCDUphmho3T0LS2WKvANznToIrzPt/SpmQ9c1vKStIai X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= Users can use devm version of of_icc_get_by_index() to benefit from automatic resource release. Signed-off-by: Luca Weiss Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/interconnect/core.c | 20 ++++++++++++++++++++ include/linux/interconnect.h | 6 ++++++ 2 files changed, 26 insertions(+) diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c index 6cc979b26151..2242554525df 100644 --- a/drivers/interconnect/core.c +++ b/drivers/interconnect/core.c @@ -443,6 +443,26 @@ struct icc_path *devm_of_icc_get(struct device *dev, c= onst char *name) } EXPORT_SYMBOL_GPL(devm_of_icc_get); =20 +struct icc_path *devm_of_icc_get_by_index(struct device *dev, int idx) +{ + struct icc_path **ptr, *path; + + ptr =3D devres_alloc(devm_icc_release, sizeof(*ptr), GFP_KERNEL); + if (!ptr) + return ERR_PTR(-ENOMEM); + + path =3D of_icc_get_by_index(dev, idx); + if (!IS_ERR(path)) { + *ptr =3D path; + devres_add(dev, ptr); + } else { + devres_free(ptr); + } + + return path; +} +EXPORT_SYMBOL_GPL(devm_of_icc_get_by_index); + /** * of_icc_get_by_index() - get a path handle from a DT node based on index * @dev: device pointer for the consumer device diff --git a/include/linux/interconnect.h b/include/linux/interconnect.h index 4b12821528a6..75a32ad0482e 100644 --- a/include/linux/interconnect.h +++ b/include/linux/interconnect.h @@ -47,6 +47,7 @@ struct icc_path *of_icc_get(struct device *dev, const cha= r *name); struct icc_path *devm_of_icc_get(struct device *dev, const char *name); int devm_of_icc_bulk_get(struct device *dev, int num_paths, struct icc_bul= k_data *paths); struct icc_path *of_icc_get_by_index(struct device *dev, int idx); +struct icc_path *devm_of_icc_get_by_index(struct device *dev, int idx); void icc_put(struct icc_path *path); int icc_enable(struct icc_path *path); int icc_disable(struct icc_path *path); @@ -79,6 +80,11 @@ static inline struct icc_path *of_icc_get_by_index(struc= t device *dev, int idx) return NULL; } =20 +static inline struct icc_path *devm_of_icc_get_by_index(struct device *dev= , int idx) +{ + return NULL; +} + static inline void icc_put(struct icc_path *path) { } --=20 2.52.0 From nobody Mon Feb 9 10:42:27 2026 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C8F724A078 for ; Fri, 16 Jan 2026 13:17:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.67 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768569449; cv=none; b=kYwG3pomaiGDz4HSHIj1msIf4coNLX+7cx9t8Kk3kiNajIV4AsAOz5bq7s3Hnrr49yqfKRP5QUBDfKQBWMN2DIxAGgDnQAyQQEovC+QNCewxlucD05MhDApyCyJFxoSzwZvbBVJjdh0lxywknHlDi4g/ksb/Y203Hjwe59eCMmQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768569449; c=relaxed/simple; bh=RFosUcjwMh27o+Q0KFX/mCWwbK9ioGqTrDSRkowE9Gc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=H3u8vwcB3by08Nc+mRUHtz/1bCyKqSOcJWurAhMY0VPV8j+1/zkxk0b0zFoXj7cwR55XS2GcxPkEMyEPnse8uwgd9er/ApI954IagqgTeSIRQg2cYq0QrKZDUwvgP1k4P5WRAqWTMEoDYFkbn9B/+Ze8BM1U8BpcMn5E5+edVRE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=T+o61sVb; arc=none smtp.client-ip=209.85.218.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="T+o61sVb" Received: by mail-ej1-f67.google.com with SMTP id a640c23a62f3a-b879d5c1526so117450466b.1 for ; Fri, 16 Jan 2026 05:17:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1768569446; x=1769174246; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wcR1dmGQ0EElYWldmNS71m4JZ3C7rndmOwBL8aoBqb8=; b=T+o61sVbhnn6bIlhuZLu1xPXtQuo7Zgxn5V4NGuWt+DLSSWVRdwFdR310OwQ1ow2PM XANcXOm3h+RcOCLupWMZZsqijD5HCN77RoC1k3j0THCKzBaWuUEvdtrkgNMdyP+OjL77 JLmwD/qtKTFyMmjDwjbPLCjsve4XV0kUgPKvXwqBgPsmgmkphct6BzNzZin2tRvD2fo6 sYmwY3tjwujcfZ/LpypN5qFJ8ib46Clqa/pdj31jcb6LJO0dfU9VSusbL3mBehZG6F7j 3VZne8gDet1U1TXj7+X3vruzKOgY4CETPTedN3wBD/8b4nPSaU+EWLxZAEsLCek82DE3 Hi1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768569446; x=1769174246; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wcR1dmGQ0EElYWldmNS71m4JZ3C7rndmOwBL8aoBqb8=; b=Ur+b+/tDLv/lNP7lSx3qbKp/Rtj76CQuAKHAOzP44CJlzmgzmHISQky/GrfJP/lHk/ 7dpgjZFTRpIYacT64J3nBFCgtlPgcFIbgdLH4LE/itnF+NlXWmEDxYlVwb33KQWj8Faz dXvGL6w/EoZZQL9T20jIvpcM4GxEAXMxypJBkSxKeuyaakHlQtOEp/B4PTLQKcagROlt TURYrvJb4Va9nAZWkrA73r53ZeyUHoBuxSeVAG7PdwMhLb6cs7q0Dy3oPpQu1Ywo15/o +Iv7Cl/Zp/5OjssARpA5z+Y25CZjXRJOaxjWgEyqGT2WMRi/SDysNm5pLkiBNRmscRhs fXBQ== X-Forwarded-Encrypted: i=1; AJvYcCXQQ1PIRcJR4JlI2DIlNEFXOhqfB+fHCIOsIdIISGnT40gRUEJVcxx8L5eZpIaqshJL0MpB1QklJR7NfXU=@vger.kernel.org X-Gm-Message-State: AOJu0YzlZVYE5K2aYNdTysZI1X4Jsz6d/mHp3Q4p8/efsUAVqfOki6L4 4lVYFZCjAiK/xdj0nVOhNYswIc8fEekjKRZgAjjlDJCCEMTY0A6kBYSJq1wEkiN14/g= X-Gm-Gg: AY/fxX5s6iCzxzhue7BgYgAxxuLDyIKO3krYpE42zBjM9vfLpxutlMF33NYypuEtXXO S8mYWSTOvRqdfYu9R3fDqGSaIUZt+AbEieTocnCpNyzABFU7iVt+cZs83yA0MBZC79r2EUOS6UE RpMUw/9ccvWzIJ8+MeCzcT8YQ2/u4cA382+u3Ue+EHJYw7EGg6QH+RnWMevYfPLY/ATDvJa7gcB mABbHfbEJLlQ7X0uEq7IaO05BWc3nxQ2qw4mq/OKeLDD3+sTb+FyKRRnOJTVLYbpjNjVASHZujT CXDsWzrm/MHwjPbNXji8lAkpdUJDjAkM8wm6J7IfDUy4GYaUMZ/XXZYTgsN0/SC+0BZmoU1i0F1 xY3voPan/xDTm5L9uAx7t6NQyB+LUcyqreXdYkgWXV+C1iMTUmw2BipWQls1ZncymwYSx5hQSqX 1KKt+ScTGbCFsXQ+VMrmWbhvUqFypcuDBxL7iCb10jPXydocoCumrkyX6bGIa5+hEt X-Received: by 2002:a17:907:6ea3:b0:b7c:fe7c:e383 with SMTP id a640c23a62f3a-b87968e56f3mr211104066b.22.1768569445696; Fri, 16 Jan 2026 05:17:25 -0800 (PST) Received: from [172.16.240.99] (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8795a350dbsm235507366b.69.2026.01.16.05.17.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 05:17:25 -0800 (PST) From: Luca Weiss Date: Fri, 16 Jan 2026 14:17:21 +0100 Subject: [PATCH 2/5] dt-bindings: clock: qcom,milos-camcc: Document interconnect path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260116-milos-camcc-icc-v1-2-400b7fcd156a@fairphone.com> References: <20260116-milos-camcc-icc-v1-0-400b7fcd156a@fairphone.com> In-Reply-To: <20260116-milos-camcc-icc-v1-0-400b7fcd156a@fairphone.com> To: Georgi Djakov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1768569443; l=1598; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=RFosUcjwMh27o+Q0KFX/mCWwbK9ioGqTrDSRkowE9Gc=; b=F3TPfwyBjFhqKF+HInQg1A97Mf+OjLhk6olL+d0GTCGtvDhv0vHvyzaFIZ0sGqrZJTnArQl1p Qj4XSnuvOF/Ast/91GKxv4KyvwPnFE8nsTermX1yRcoTl4vnkMG8kVf X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= Document an interconnect path for camcc that's required to enable the CAMSS_TOP_GDSC power domain. Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml = b/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml index f63149ecf3e1..707b25d2c11e 100644 --- a/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml @@ -25,6 +25,10 @@ properties: - description: Sleep clock source - description: Camera AHB clock from GCC =20 + interconnects: + items: + - description: Interconnect path to enable the MultiMedia NoC + required: - compatible - clocks @@ -37,12 +41,16 @@ unevaluatedProperties: false examples: - | #include + #include + #include clock-controller@adb0000 { compatible =3D "qcom,milos-camcc"; reg =3D <0x0adb0000 0x40000>; clocks =3D <&bi_tcxo_div2>, <&sleep_clk>, <&gcc GCC_CAMERA_AHB_CLK>; + interconnects =3D <&mmss_noc MASTER_CAMNOC_HF QCOM_ICC_TAG_ALWAYS + &mmss_noc SLAVE_MNOC_HF_MEM_NOC QCOM_ICC_TAG_ALWA= YS>; #clock-cells =3D <1>; #reset-cells =3D <1>; #power-domain-cells =3D <1>; --=20 2.52.0 From nobody Mon Feb 9 10:42:27 2026 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 645362571DD for ; Fri, 16 Jan 2026 13:17:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768569451; cv=none; b=JtKe5h5U8DnWWbByIDibKMkxesasO9pACVAMFD0vUNoHNznJfW3SNEjFTrFbERAaZ/MGe2zNRc03dMOm03W+TWGqC+yhiuh8vBxQb1+Sgs7hCgjzrjpMHf1dOX4fL5vjqlAX7nfIHfayBgPXqMnBmXO/9ypYSJCj+bK8GVCulGk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768569451; c=relaxed/simple; bh=FtewN/DrAXamJnpTOxO78vEZuuizOqYgKqBWZjIni9M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JP+RbJq3pYN0TX8btgwTxpuRaGJDN4KQLBKkibGaflZggu+fY/HSblkONe76rCUl7xnprWYFji65mylYajSa7Hc2tNvrtMuraG0Tmjaf1H1eHyLrkVeTb0SaDJBkzUa1luGqJp82rFPq6GIkxBTneD72GEeV/ukCkSPPa/OeQ9U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=pg6Ka+tU; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="pg6Ka+tU" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-64d1ef53cf3so2889368a12.0 for ; Fri, 16 Jan 2026 05:17:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1768569446; x=1769174246; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rhlx5emzP9b47xqsIY5Q/RFPv9dsLYm4piEORREEnEQ=; b=pg6Ka+tU0otA06bz6j664W3d9RAvgCKItczkpyPmZezTBm9CszX45+8U7GzFE0UfT+ kawBbw2AT5hX8E5Nul/+y0PqIhB0zeBDLP4ONuYIaCa20rj6gAe1mT5jdBDT0hftYBs+ I6NSA8huxRIocQyDAesfxN0eX5H0S+bBNEw9GDuu1/cjk4xeX/LAHKqW8spBe9HcAktZ bE086vkdawczgx6qoB4oT2UFEFABCP/jTlUo59f1l/a8sx7+fbu9mwWdnR7etDR1hMdA TGT52dc6FF5i+1SvSeHbab4AzysPxrs/lhSdyYISUX4gOKAjo+f7vzFdIMPbt1D5PMba yNMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768569447; x=1769174247; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rhlx5emzP9b47xqsIY5Q/RFPv9dsLYm4piEORREEnEQ=; b=SfXLu1B6vbqjfWXMpzuRTfFPUVpOmQXCuf6wZeZVsQ+3x9kS+JPfLh+4fJ2IHJp0EP ZTYl1Yp8+N8c8OBG5D8nZcrI5OoygTm0+mXyeA8VXvfdpADDhnDy6G9ai3oL0cryRwR+ aEzclODW8QIniB6AvyaWKaYWVC5OcpxiTOpjVq37apTq5hkxKQwY1IHFybf9WfBwbO49 qdM8bBLFfX89ax5mdJYbHijnCOTi3alafnKHrDo5mf+X7KlvCI5VHG2a63uwUYamUdpk M4GEIrWWwVeHgCdmT0zCWEYdC3FEpzXoLpS+gdEYEEyG7uNJNR8RenNw+cvLs/DeyTyd oPCg== X-Forwarded-Encrypted: i=1; AJvYcCXV5wmwdoRy/Rmwxg99DQfs4YRPVEMJlXy3LQTcSV53PRo7Fb8dLxqzT/sOHMGi0haX7hji7mWxZeCYEMs=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3v6g9VBdcg4MWz1dwHMK1NE+2t7eJqiWay9uRdiY/06BsCa5y KOBZEHYGCJWH3hJ2xVXPPb9n1eCtrPT15yEOqZUghKWihilKEODJij/TpipftWFlLGs= X-Gm-Gg: AY/fxX4dpO00WzpW7ZV2L6xZnQk1Sfg8rICzeuqoDyBVRB5zvJt9WkjMSlpl0+uXX/e ODMfhzp1npf61Z+fHhRCsSDJNJ3S0NDIY2O3+1McGpH5zyqMXJM2ZcUYL7yWt0Ilp9zKIzFf0Vf rxUZzcT1c+f5/KVqLQqof6YSFMYcdSZWIpKtufvBtzJxCfdptNi19ovo9fZxTI92tOpwQAn/FmL RfdXXKG5RKXrhwsmGy5nOn1QTbqhMCiLYWHMGPtUugefYIktEBEX68mdP4kNKaA1quGu8L7RjRs POqeDnOiLJJTpW5B1s057alCyNT4gSYGtzxRJ78WO7xwHE7Pf4+i46jTk87kwebuKzfDdoEBNEf NMoOQd+28yZxTrRvgUSlemirqhCSsPM80I91zqTuvYwzeizd5CwlHbxzwxt7F74ASOoizInKrqy 0JLjhb450hDkoVCH5q/E59O6MU8xYAQLPRU/y3BWKrmtfT0DFIaeAo3hYL9YkhaMyU/H87jnT9P ww= X-Received: by 2002:a17:907:702:b0:b87:2cf8:f7b2 with SMTP id a640c23a62f3a-b879324c7c0mr293012266b.56.1768569446608; Fri, 16 Jan 2026 05:17:26 -0800 (PST) Received: from [172.16.240.99] (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8795a350dbsm235507366b.69.2026.01.16.05.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 05:17:26 -0800 (PST) From: Luca Weiss Date: Fri, 16 Jan 2026 14:17:22 +0100 Subject: [PATCH 3/5] clk: qcom: gdsc: Support enabling interconnect path for power domain Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260116-milos-camcc-icc-v1-3-400b7fcd156a@fairphone.com> References: <20260116-milos-camcc-icc-v1-0-400b7fcd156a@fairphone.com> In-Reply-To: <20260116-milos-camcc-icc-v1-0-400b7fcd156a@fairphone.com> To: Georgi Djakov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1768569443; l=2630; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=FtewN/DrAXamJnpTOxO78vEZuuizOqYgKqBWZjIni9M=; b=x4GXwqWuo6jrdq33GBtT6tJ+qKr74k1xcIHAngz8zsb5pzHU3zqpcBtB/3sXgYHAwKBDQUV4/ MCX7Lg5LzliARKzTzK8Eg1nE2qFKjmTiYZqAzcdsWWTMObC+Om+nhzP X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= On newer SoCs like Milos the CAMSS_TOP_GDSC power domains requires the enablement of the multimedia NoC, otherwise the GDSC will be stuck on 'off'. Add support for getting an interconnect path as specified in the SoC clock driver, and enabling/disabling that interconnect path when the GDSC is being enabled/disabled. Signed-off-by: Luca Weiss --- icc_enable()/icc_disable() seems like a nice API but doesn't work without setting the bandwidth first, so it's not very useful for this driver, at least I couldn't figure out how to use it correctly. --- drivers/clk/qcom/gdsc.c | 19 +++++++++++++++++++ drivers/clk/qcom/gdsc.h | 5 +++++ 2 files changed, 24 insertions(+) diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c index 7deabf8400cf..ff1acaa3e008 100644 --- a/drivers/clk/qcom/gdsc.c +++ b/drivers/clk/qcom/gdsc.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -261,6 +262,8 @@ static int gdsc_enable(struct generic_pm_domain *domain) struct gdsc *sc =3D domain_to_gdsc(domain); int ret; =20 + icc_set_bw(sc->icc_path, 1, 1); + if (sc->pwrsts =3D=3D PWRSTS_ON) return gdsc_deassert_reset(sc); =20 @@ -360,6 +363,8 @@ static int gdsc_disable(struct generic_pm_domain *domai= n) if (sc->flags & CLAMP_IO) gdsc_assert_clamp_io(sc); =20 + icc_set_bw(sc->icc_path, 0, 0); + return 0; } =20 @@ -574,6 +579,20 @@ int gdsc_register(struct gdsc_desc *desc, if (!data->domains) return -ENOMEM; =20 + for (i =3D 0; i < num; i++) { + if (!scs[i] || !scs[i]->needs_icc) + continue; + + scs[i]->icc_path =3D devm_of_icc_get_by_index(dev, scs[i]->icc_path_inde= x); + if (IS_ERR(scs[i]->icc_path)) { + ret =3D PTR_ERR(scs[i]->icc_path); + if (ret !=3D -ENODEV) + return ret; + + scs[i]->icc_path =3D NULL; + } + } + for (i =3D 0; i < num; i++) { if (!scs[i] || !scs[i]->supply) continue; diff --git a/drivers/clk/qcom/gdsc.h b/drivers/clk/qcom/gdsc.h index dd843e86c05b..92ff6bcce7b1 100644 --- a/drivers/clk/qcom/gdsc.h +++ b/drivers/clk/qcom/gdsc.h @@ -9,6 +9,7 @@ #include #include =20 +struct icc_path; struct regmap; struct regulator; struct reset_controller_dev; @@ -74,6 +75,10 @@ struct gdsc { =20 const char *supply; struct regulator *rsupply; + + bool needs_icc; + unsigned int icc_path_index; + struct icc_path *icc_path; }; =20 struct gdsc_desc { --=20 2.52.0 From nobody Mon Feb 9 10:42:27 2026 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 801CB23B63E for ; Fri, 16 Jan 2026 13:17:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768569452; cv=none; b=LBLSSuN16k00pl2IAz4lXi6soXcU0q8LqFk+VAC2VgpFTo9ZDUaf7KcdVqgvtYbtHjsGriUrQLk98nqVtXajA2PELD2GHn7Va7Fi5HCgYQI8tUxyiGXpTyc5TPZnepCY/cZATQM0x2KdHvuk12bBdF3lx9KSdv8xRB6v+Sg+ECU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768569452; c=relaxed/simple; bh=5i0VsvUcS0SUwOVd0wGHGUe0uBItUE4uGBSE3yIgsYw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hxJliHGZW4A4X8A3iCqMTvF0vFo/CJrhi9GpdEZHJxN21KuYWzAfMXelhlfLyA6z2oRkoE2tkTxr/Jpi/QdcQIzoJILTYhvZy8V3LhoDG5yS+6m9H+an4cLLr5I9k0yTbZhEhxSFm0i3ifHvBOsshvLQj3g63Q+bayDgT5sJU4c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=mOjnHEaQ; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="mOjnHEaQ" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b7ffbf4284dso267203466b.3 for ; Fri, 16 Jan 2026 05:17:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1768569447; x=1769174247; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=duq39jBoqDFtabq63HAqX5adf5fdfb9r8RBQ2RPSZD0=; b=mOjnHEaQ0xxNRyxaRCwgz00PSnpOxde71MA1Cdyi1PZpG1XySlKbhbPekX1OJPrphr FBnSrVjmcOvp6VIwJxNpZkarwpgCNFaqwl7PUkzMNSG4VAIORELm6u0O+pw5p9Fe7uKv n76OKCHRioCRE3mJXgxGlZwM+tDreLGwshH9yNW7dikStHvDuIBm/qCRxG9hUipKtJV6 SuMtQqasEkJsxY1h3k/YQBnJq2xQmQfXdmEP8/lfuwflQHgvKGcWPoHCZpbsJUGFTRSA FrcopB4CMrUQDykTUbPwZkIgIh4fK5NREzImnnXvShug82Tj82j8k9o3tPdYflJQzFqf fEMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768569447; x=1769174247; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=duq39jBoqDFtabq63HAqX5adf5fdfb9r8RBQ2RPSZD0=; b=uxGcqcbM24aZT3lm1cAaQNqSf6ZJ5vjwk/A3DtD/VofX/XtdEA/1WReVixXL9B0ZRc U3Gn5uSAmrlGOoW0HUU+pYBAqH0Qr1zxAXS83rHpYVY3fobSqEUBe9yjPRBvDTkRN945 L09xnu4E3Y4yDCqjJW+sb+5wykLhrQVfQzbMFR6Tzf/jB6rmNhWol4RroWvGCqdJ3pYx RwAfoWyzl4H9gvqeAzq7zUzlBSeEhf+GHySro+hj6bsOQv+GGPCkzYbZ0ZSj3YJgObzE YbHtAe5rrmhiE8d8KxkvdTZfRQVPNZq4yoHI769fGxQi/o/omMCJDkKXLMT9nSnhNTf9 0ZGg== X-Forwarded-Encrypted: i=1; AJvYcCWDmsmfdIO2v8Vx9AVNQAbCB6koNXvMng+XPU4C0YrdMUoyYu6T6GMi8ZkkhVcV1PQMW0ydpH/Oz5kvUEM=@vger.kernel.org X-Gm-Message-State: AOJu0YwhPQyc7KMYaIpfkJ3SBF5gv7PlbTyGdtqh6enXOKUorcIaq3Ug jRbeFxX8ErIxR3pDyU/SvhZK5axIOlrGP4wUKCKfob1S23gs2d8mwsA9YWvmMpLenic= X-Gm-Gg: AY/fxX4jySG+4IQhiKz/ywc7RHMcBWHkYREpNn7GrV1qzAEIOKA5MMX5Q9Zi5j4qLF6 KoITz+z5fnVM7qscyvJsGsM9ZftFx1uScDHcoHXJXYms2Et9jpPw6kMx/7VHgEzUTkLen1DhH1W 5fny46T5YUEqph7V74OeK53uYOJjb1WdpGUC4jeSgF7ZTHYm8mwW9+8shBo7fcpa7SznKVuQa3X 1JjeADm4f/9+JqNZG/9dnUO/P1w9gcRRQ4dQ7bYCOp6GQ24OK2nu0mwpOxBOl6854EBxYBBTVox DjR6pmx9oMneXfOHOVCdVXjx0FjPcj5g4avQuE/BysYPt6Y9h+aaDBS4MRKnGloSbQ6/Ok/82OE +X+jAaY14nYoSTRZKvea/k4jplOAPQAzwoJK0Jkhy24CACEZZ6XPFMomAGHBsEl/siKh59/qeKC Ifj6aHwucbV/cipiJJnfnFwmPtNCurdzNSVVOX6a/dRnQl8vsUzk2aB6d9NmxDCFZr X-Received: by 2002:a17:907:25c7:b0:b73:398c:c5a7 with SMTP id a640c23a62f3a-b8793008849mr255921666b.41.1768569447170; Fri, 16 Jan 2026 05:17:27 -0800 (PST) Received: from [172.16.240.99] (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8795a350dbsm235507366b.69.2026.01.16.05.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 05:17:26 -0800 (PST) From: Luca Weiss Date: Fri, 16 Jan 2026 14:17:23 +0100 Subject: [PATCH 4/5] clk: qcom: camcc-milos: Declare icc path dependency for CAMSS_TOP_GDSC Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260116-milos-camcc-icc-v1-4-400b7fcd156a@fairphone.com> References: <20260116-milos-camcc-icc-v1-0-400b7fcd156a@fairphone.com> In-Reply-To: <20260116-milos-camcc-icc-v1-0-400b7fcd156a@fairphone.com> To: Georgi Djakov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1768569443; l=942; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=5i0VsvUcS0SUwOVd0wGHGUe0uBItUE4uGBSE3yIgsYw=; b=pxIbdFvn4Pi8X4MwhDSzKXEcKRx9BJ2hA91ot6BC8vc+Xctsgq8QVNEsD4kc47w1mvuNfbMGT fbkIhmEQvCTC+X+GuHJJaZKe/3EgLXqaOD5082PO4UqZCO8X7y851YF X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= This GDSC requires an interconnect path to be enabled, otherwise the GDSC will be stuck on 'off' and can't be enabled. Signed-off-by: Luca Weiss Reviewed-by: Dmitry Baryshkov --- drivers/clk/qcom/camcc-milos.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/clk/qcom/camcc-milos.c b/drivers/clk/qcom/camcc-milos.c index 0077c9c9249f..45e68165a2f0 100644 --- a/drivers/clk/qcom/camcc-milos.c +++ b/drivers/clk/qcom/camcc-milos.c @@ -30,6 +30,11 @@ enum { DT_IFACE, }; =20 +/* Need to match the order of interconnects in DT binding */ +enum { + DT_ICC_TOP_GDSC, +}; + enum { P_BI_TCXO, P_CAM_CC_PLL0_OUT_EVEN, @@ -1971,6 +1976,8 @@ static struct gdsc cam_cc_camss_top_gdsc =3D { }, .pwrsts =3D PWRSTS_OFF_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE, + .needs_icc =3D true, + .icc_path_index =3D DT_ICC_TOP_GDSC, }; =20 static struct clk_regmap *cam_cc_milos_clocks[] =3D { --=20 2.52.0 From nobody Mon Feb 9 10:42:27 2026 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A41926CE0A for ; Fri, 16 Jan 2026 13:17:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768569454; cv=none; b=OKVG8FDvnM+AWSrmKh401VwB5+BX7iqtNDoL4BZMGoAKwnK67WMvYPJsDZR7s0q4JTfOx4SSt/SMdbC2fZV5CjBNniXHEjBNEf83WJFc7dv0X/OLMhJYmVk+h6UWoPf5nf6EYpQYEodV7Rh/oCedyPnZMKu8IsQ/gHFbVzjbm/w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768569454; c=relaxed/simple; bh=v3yWlx3GbotL3G9AhcSN50C5SpvFDf2A//QxTjb64Xs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Fna8gZgRUrWimbu3P51cVRHyHJsgRmEuMRw904G2bW6seKm45E5MKdKvPwJmFcLZjIVprmNkV5ziNyXBgCcrFEd1GCD8wwbzsoQqyeila6rl5dKZ+hDVjYBqpAuK+rMCDK8YdLMzpPEY48VEtw9mDsTiJgvCmGiTjF9aPyTx7So= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=be3WEBYL; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="be3WEBYL" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-b8010b8f078so337588166b.0 for ; Fri, 16 Jan 2026 05:17:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1768569448; x=1769174248; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gJgg01NaZF2IVCPUnfeyk7TRyWFsft/f+OKB8cHgBK8=; b=be3WEBYLr9CQ8Uqbqh/EA5zPkEV/7hU5Jz3ypwBG0e9aSBTlqKJGbZ4u4eWPet+gdh shzQnn5Q5FFynUD5mizZ7QvHkgU5ruktjLctez4uCwUsh4lE5xMadbBfH348kl9chRI3 kx6GZ7w9ubrHP+JQU7yTFZn6QZt3+7vYNiNzqyXt5op3rQ/mREwzSfZscPSCw7B916i/ OljF6Tp8xDVIkbB3rWb6joPQ8Zv++tBZnhHVYc4xvzqCX5yO0fhZW0UYEVdu8YQyJg1z y8AzmtxG59iorijbkrEQYsppYqhv0InXGN8vJ1W4JJ+eIdcNCxULdk+LCSGs4KVugme/ Pr9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768569448; x=1769174248; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=gJgg01NaZF2IVCPUnfeyk7TRyWFsft/f+OKB8cHgBK8=; b=ezJvKxvph9Wp04dC4kuTSNyAkNYdscZGjAJmG3d5btfeJJSZl3iuuiQVXClLCfYU6O Hq4kvDqVopdYNmDDRwlkOrKQOS8sv4Y1QMzGREaIYFniF8WNh9r88SbejpFuZ0Y6J6TW yR16ep7a2n2rxnAuSMnQOooSB6w11y4Tlr4vEqpW2PxYxBemH09G65JYBMForxM2hRJy JjoUwEHzCEANUZS3XfJ8TL3Le0OMjRVdoIZeodHBZvht/qem1k6d9wCAeMWzP7UdeIJ6 mgvyisjF6SgyWf4k3cMki9aYLmL+eUZChfWXqemB+wQqeyQtuezDrwTtT2GWvlIAA7aj 8aPg== X-Forwarded-Encrypted: i=1; AJvYcCXduxOpMuzyffpPjNK+uu/yu3wagK/2oBWewyla2QT0LjYhPkVkHL//GEbAFSnsSnMbds1+1Wpfv8COkYU=@vger.kernel.org X-Gm-Message-State: AOJu0YyRNTnq9mgXmZ5fnp5bh8i4MJBFDbhgpgQHKNGEXM4C8/Ll+l+M KaEA+JaSJysDSKaHodx9k7gIYEHJec0R1p4aa21tO/vqKh5zvEeCYJ2DknlPSW8mBkQ= X-Gm-Gg: AY/fxX7QS8BTtCYe9pfc7MXAn1T7EyHvpq8WnJ3q2X252AxfRg9mXp3UyJdGP/wC47p 8s3y9QwPF4YBKbkf93Pl/7viWWSmeAu57N512i4G5fCw/rmhFszz9li1KRQkpsihYG3aEYStSmp BlXTuhgrwGGVwFkfb6CZ5G175gXtGJVFDtbUfEDOVFxfrJVLgMP0dsnFSRsekJbXx2sEgdyqrTl EH9BJ21HhL8mGVwzbBwkVzdqcSfmg8lr5Lm514yA2mjEK/xBixO1paDmKmnMce2POfcWfVbGvKY HRDzFF/E+t1tQuHRedKnho2spqPMDVP3taF6r+KDYfyiMOy4POJ6D6ebPbusSfWcR8XzJo4cdyq L0/OFVGSSc5v7g/lOD803gZdrpAxFgLu3LmnDS28s7frpO+plnW0bYZqIgFd9h4hsqjOGFyRCk8 gmp6JWI9UbAd1nvbkQL7jMGSt8IQye7meZDg7hYmS1e4jwN/y2ivhGC/vAJKmug+aW X-Received: by 2002:a17:907:940d:b0:b87:2d0f:d42c with SMTP id a640c23a62f3a-b8796bf55e7mr207695866b.63.1768569448338; Fri, 16 Jan 2026 05:17:28 -0800 (PST) Received: from [172.16.240.99] (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8795a350dbsm235507366b.69.2026.01.16.05.17.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 05:17:27 -0800 (PST) From: Luca Weiss Date: Fri, 16 Jan 2026 14:17:24 +0100 Subject: [PATCH 5/5] arm64: dts: qcom: milos: Add interconnects to camcc Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260116-milos-camcc-icc-v1-5-400b7fcd156a@fairphone.com> References: <20260116-milos-camcc-icc-v1-0-400b7fcd156a@fairphone.com> In-Reply-To: <20260116-milos-camcc-icc-v1-0-400b7fcd156a@fairphone.com> To: Georgi Djakov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1768569443; l=934; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=v3yWlx3GbotL3G9AhcSN50C5SpvFDf2A//QxTjb64Xs=; b=7wylF7yqR/1GoCG7yFRPMLqJokhikSOBv5u57rvVqHFkqjHgqmzQMvlpMhfx0Dl0hM+wLd8sL nNihUzL6AQiDwGvEwHERwtwD5doSABLP66k8esCiKpq1FwIUTJhh9H+ X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= The CAMSS_TOP_GDSC inside camcc requires an interconnect path to be enabled, otherwise the GDSC will be stuck on 'off' and can't be enabled. Add the interconnect path so that this requirement can be satisfied by the kernel. Signed-off-by: Luca Weiss Reviewed-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/milos.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom= /milos.dtsi index 0f69deabb60c..58b4c2966df1 100644 --- a/arch/arm64/boot/dts/qcom/milos.dtsi +++ b/arch/arm64/boot/dts/qcom/milos.dtsi @@ -1660,6 +1660,9 @@ camcc: clock-controller@adb0000 { <&sleep_clk>, <&gcc GCC_CAMERA_AHB_CLK>; =20 + interconnects =3D <&mmss_noc MASTER_CAMNOC_HF QCOM_ICC_TAG_ALWAYS + &mmss_noc SLAVE_MNOC_HF_MEM_NOC QCOM_ICC_TAG_ALWAYS>; + #clock-cells =3D <1>; #reset-cells =3D <1>; #power-domain-cells =3D <1>; --=20 2.52.0