From nobody Mon Feb 9 02:12:13 2026 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAF8C36997C for ; Fri, 16 Jan 2026 17:04:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768583046; cv=none; b=pKRw5QdXwXSB6UNfl24IglERWwY2GybWyFCjUQV4LV9E/XG51piiakMKIj07U1qjttIYO0UAxCsBiS5aDVHJiEdsIQdV5AuexmNfZgp88QZyM+pkkt/heQBzj6r2fBfmzfRQVO84c83bFmq5hhw7j9pxbjtcaTxXCvwdPYq/bx0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768583046; c=relaxed/simple; bh=Qs9lT5XeX2uwxu5pzH8HZjGceoTBvbZBllxvaSR3RSE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iZ2CjNTgJZSfmNLiwldHJtCj7cAQgSP52gSMCryHKIOjrEqX5RBDSsG1SeNTbMdkrh/OAvrMljRVo4NNOkFUYI8CkKVBQ87ET+dX1TDz9s3Vo/0AZKbfRyDpVHqq66iiHQnN3I4WHiGSb8sklnRpCSKQZdDoDfZc42BlgAIXr4A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=SpF4N0bB; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="SpF4N0bB" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 9EAA31A28EE; Fri, 16 Jan 2026 17:04:03 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 70AC6606F9; Fri, 16 Jan 2026 17:04:03 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 0CDBC10B68CC8; Fri, 16 Jan 2026 18:03:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1768583042; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=17sg1MEtS3JEHC+aKMPbN0je70cbqKxiScHC7KFqQ6I=; b=SpF4N0bBcN3OLgzywqK54Yy0Qcqn5lCD2SZbtl/jWePDWxYtRlku8fEtsCcs375eOccqgf 4FteQFLpdF25i0rFkRoNZtWBldDt34rVGuJeb5bfJPrF6/f5CTdw9i5cgdyJuX4+ZYm0zT cltRWJVdbq6LgTagfdf4qqCx0eujHZaMwyPnNlzLmZYaZU9wfo6xBNSvvzVTL/Owte9AoI QyjHqZ+1xhmtRyUlrnsiqe0QBWPtJwc7rfFQ3evM5ArTXRy2wgiy0YIej7ePUCbQ42196E FpeNeyKKr9t77af3zWahZWEWLQoQMh2hKePv5I3PQnASOgQzsrIRipmEmEe4PA== From: "Kory Maincent (TI.com)" Date: Fri, 16 Jan 2026 18:02:25 +0100 Subject: [PATCH v4 25/25] rm/tilcdc: Add support for DRM_BRIDGE_ATTACH_NO_CONNECTOR Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260116-feature_tilcdc-v4-25-2c1c22143087@bootlin.com> References: <20260116-feature_tilcdc-v4-0-2c1c22143087@bootlin.com> In-Reply-To: <20260116-feature_tilcdc-v4-0-2c1c22143087@bootlin.com> To: Jyri Sarha , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , Bartosz Golaszewski , Tony Lindgren , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: Markus Schneider-Pargmann , Bajjuri Praneeth , Luca Ceresoli , Louis Chauvet , Thomas Petazzoni , Miguel Gazquez , Herve Codina , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, "Kory Maincent (TI.com)" X-Mailer: b4 0.14.3 X-Last-TLS-Session-Version: TLSv1.3 Convert the driver to use the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag when attaching bridges. This modernizes the driver by delegating connector creation to the bridge subsystem through drm_bridge_connector_init() instead of manually searching for connectors created by the bridge. The custom tilcdc_encoder_find_connector() function is removed and replaced with the standard drm_bridge_connector infrastructure, which simplifies the code and aligns with current DRM bridge best practices. This change is safe as there are now no in-tree devicetrees that connect tilcdc to bridges which do not support the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag. Signed-off-by: Kory Maincent (TI.com) Reviewed-by: Luca Ceresoli --- Changes in v4: - Select missing DRM_BRIDGE_CONNECTOR and DRM_DISPLAY_HELPER config dependency in Kconfig --- drivers/gpu/drm/tilcdc/Kconfig | 2 ++ drivers/gpu/drm/tilcdc/tilcdc_encoder.c | 37 ++++++++++++++---------------= ---- 2 files changed, 18 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig index a36e809f984cd..80f53bdd0ace0 100644 --- a/drivers/gpu/drm/tilcdc/Kconfig +++ b/drivers/gpu/drm/tilcdc/Kconfig @@ -6,9 +6,11 @@ config DRM_TILCDC select DRM_KMS_HELPER select DRM_GEM_DMA_HELPER select DRM_BRIDGE + select DRM_BRIDGE_CONNECTOR select DRM_PANEL_BRIDGE select VIDEOMODE_HELPERS select BACKLIGHT_CLASS_DEVICE + select DRM_DISPLAY_HELPER help Choose this option if you have an TI SoC with LCDC display controller, for example AM33xx in beagle-bone, DA8xx, or diff --git a/drivers/gpu/drm/tilcdc/tilcdc_encoder.c b/drivers/gpu/drm/tilc= dc/tilcdc_encoder.c index 546fe7e6ee815..680a2ac6ab594 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_encoder.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_encoder.c @@ -8,45 +8,40 @@ =20 #include #include +#include #include #include =20 #include "tilcdc_drv.h" #include "tilcdc_encoder.h" =20 -static -struct drm_connector *tilcdc_encoder_find_connector(struct drm_device *dde= v, - struct drm_encoder *encoder) -{ - struct drm_connector *connector; - - list_for_each_entry(connector, &ddev->mode_config.connector_list, head) { - if (drm_connector_has_possible_encoder(connector, encoder)) - return connector; - } - - drm_err(ddev, "No connector found for %s encoder (id %d)\n", - encoder->name, encoder->base.id); - - return NULL; -} - static int tilcdc_attach_bridge(struct drm_device *ddev, struct drm_bridge *bridg= e) { struct tilcdc_drm_private *priv =3D ddev_to_tilcdc_priv(ddev); + struct drm_connector *connector; int ret; =20 priv->encoder->base.possible_crtcs =3D BIT(0); =20 - ret =3D drm_bridge_attach(&priv->encoder->base, bridge, NULL, 0); + ret =3D drm_bridge_attach(&priv->encoder->base, bridge, NULL, + DRM_BRIDGE_ATTACH_NO_CONNECTOR); if (ret) return ret; =20 - priv->connector =3D tilcdc_encoder_find_connector(ddev, &priv->encoder->b= ase); - if (!priv->connector) - return -ENODEV; + connector =3D drm_bridge_connector_init(ddev, &priv->encoder->base); + if (IS_ERR(connector)) { + drm_err(ddev, "bridge_connector create failed\n"); + return PTR_ERR(connector); + } + + ret =3D drm_connector_attach_encoder(connector, &priv->encoder->base); + if (ret) { + drm_err(ddev, "attaching encoder to connector failed\n"); + return ret; + } =20 + priv->connector =3D connector; return 0; } =20 --=20 2.43.0