From nobody Mon Feb 9 15:09:09 2026 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF1E93A0EA8 for ; Fri, 16 Jan 2026 17:03:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768582995; cv=none; b=DiBQXIw7ySr/mgEbR5vs3h3zdivPDNnXJv6zkfLg2frxsgz4X8vGZHahx6QmuqQJSbOqM2XXLarEDDrLuoYBXtwGTRsvmrCCL8F/BboFh8HVKF6DtLNdoB5GtIi2JadJNtwGKV1h0+c2bqxN4LCnSMNQ+H3AWSejTSy6nIanjcY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768582995; c=relaxed/simple; bh=jcmDMKuB3NKchJBz1UNAlh32ulFYZPsRcV5IwEVeukQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PcaynIwwtFDcwdrQr11ups7tlPUn1N8G/e4Ku/rrWDxbwJYS8T3CH+D32dzFeTAaFiGIyj0SKPY+FwvMXndnLzNXeh3UFv8Ve6bkbxahtIw1bersrTRoRyTR94qHI/pf00Gx1KqZfIL3pnnh87kQhB0v2MzBDV7hLEpFjPRRmVQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=RuqQuA8z; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="RuqQuA8z" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 88CF81A28D5; Fri, 16 Jan 2026 17:03:12 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 5A2F0606F9; Fri, 16 Jan 2026 17:03:12 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7DC0E10B68C92; Fri, 16 Jan 2026 18:03:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1768582990; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=avfjFTg9tMKVnyCWaSaxl741W7BD+VSfWM41OCpSvng=; b=RuqQuA8z88w2LeqQgDoI6zOUncj/6K4qXs0bHroSzVks9kfg4lJzJewnLkYawNUHi8ebrh GTB3KR/1/GyCP5z1gEi1sho5gRIRZerj+zSrFUqinBVCw85MCMQvKL98xCetHm3XJIGo4r jyFmA0lgGTMxEznDMMB7gAI2DVb+uJXQIt9KmKApDebdGiKvwfwh9ZiaTTN6pMgaf+SZu2 yJ+gDrabnlnlGmn6RQm4tOKWre8moz5xz9heeAObXf6atWMBIWH5hdMKxbyp34f+PAbCWz eAZiBqTaEU2gYaDELEKQja5oxue2lFIansJRcrgb7Er3R1rLNA4nvz824QNZLA== From: "Kory Maincent (TI.com)" Date: Fri, 16 Jan 2026 18:02:11 +0100 Subject: [PATCH v4 11/25] drm/tilcdc: Rename external_encoder and external_connector to encoder and connector Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260116-feature_tilcdc-v4-11-2c1c22143087@bootlin.com> References: <20260116-feature_tilcdc-v4-0-2c1c22143087@bootlin.com> In-Reply-To: <20260116-feature_tilcdc-v4-0-2c1c22143087@bootlin.com> To: Jyri Sarha , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , Bartosz Golaszewski , Tony Lindgren , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: Markus Schneider-Pargmann , Bajjuri Praneeth , Luca Ceresoli , Louis Chauvet , Thomas Petazzoni , Miguel Gazquez , Herve Codina , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, "Kory Maincent (TI.com)" X-Mailer: b4 0.14.3 X-Last-TLS-Session-Version: TLSv1.3 Remove the "external_" prefix from encoder and connector members in the tilcdc driver. These are internal driver structures and the "external" naming is misleading. The simpler names better reflect that these are the primary encoder and connector managed by this driver. Also rename tilcdc_attach_external_device() to tilcdc_encoder_create() for consistency and to better describe the function's purpose. Reviewed-by: Luca Ceresoli Signed-off-by: Kory Maincent (TI.com) --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++-- drivers/gpu/drm/tilcdc/tilcdc_drv.h | 4 ++-- drivers/gpu/drm/tilcdc/tilcdc_external.c | 21 +++++++++------------ drivers/gpu/drm/tilcdc/tilcdc_external.h | 2 +- 4 files changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/t= ilcdc_drv.c index d911d413682ef..4b9fa819358a2 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c @@ -335,11 +335,11 @@ static int tilcdc_init(const struct drm_driver *ddrv,= struct device *dev) } #endif =20 - ret =3D tilcdc_attach_external_device(ddev); + ret =3D tilcdc_encoder_create(ddev); if (ret) goto unregister_cpufreq_notif; =20 - if (!priv->external_connector) { + if (!priv->connector) { dev_err(dev, "no encoders/connectors found\n"); ret =3D -EPROBE_DEFER; goto unregister_cpufreq_notif; diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.h b/drivers/gpu/drm/tilcdc/t= ilcdc_drv.h index 717529a331009..dafb00908d1d4 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.h +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.h @@ -75,8 +75,8 @@ struct tilcdc_drm_private { =20 struct drm_crtc *crtc; =20 - struct drm_encoder *external_encoder; - struct drm_connector *external_connector; + struct drm_encoder *encoder; + struct drm_connector *connector; =20 bool irq_enabled; }; diff --git a/drivers/gpu/drm/tilcdc/tilcdc_external.c b/drivers/gpu/drm/til= cdc/tilcdc_external.c index 81c90c2754c6c..11ac9673ba98a 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_external.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_external.c @@ -37,21 +37,20 @@ int tilcdc_attach_bridge(struct drm_device *ddev, struc= t drm_bridge *bridge) struct tilcdc_drm_private *priv =3D ddev->dev_private; int ret; =20 - priv->external_encoder->possible_crtcs =3D BIT(0); + priv->encoder->possible_crtcs =3D BIT(0); =20 - ret =3D drm_bridge_attach(priv->external_encoder, bridge, NULL, 0); + ret =3D drm_bridge_attach(priv->encoder, bridge, NULL, 0); if (ret) return ret; =20 - priv->external_connector =3D - tilcdc_encoder_find_connector(ddev, priv->external_encoder); - if (!priv->external_connector) + priv->connector =3D tilcdc_encoder_find_connector(ddev, priv->encoder); + if (!priv->connector) return -ENODEV; =20 return 0; } =20 -int tilcdc_attach_external_device(struct drm_device *ddev) +int tilcdc_encoder_create(struct drm_device *ddev) { struct tilcdc_drm_private *priv =3D ddev->dev_private; struct drm_bridge *bridge; @@ -65,13 +64,11 @@ int tilcdc_attach_external_device(struct drm_device *dd= ev) else if (ret) return ret; =20 - priv->external_encoder =3D devm_kzalloc(ddev->dev, - sizeof(*priv->external_encoder), - GFP_KERNEL); - if (!priv->external_encoder) + priv->encoder =3D devm_kzalloc(ddev->dev, sizeof(*priv->encoder), GFP_KER= NEL); + if (!priv->encoder) return -ENOMEM; =20 - ret =3D drm_simple_encoder_init(ddev, priv->external_encoder, + ret =3D drm_simple_encoder_init(ddev, priv->encoder, DRM_MODE_ENCODER_NONE); if (ret) { dev_err(ddev->dev, "drm_encoder_init() failed %d\n", ret); @@ -94,6 +91,6 @@ int tilcdc_attach_external_device(struct drm_device *ddev) return 0; =20 err_encoder_cleanup: - drm_encoder_cleanup(priv->external_encoder); + drm_encoder_cleanup(priv->encoder); return ret; } diff --git a/drivers/gpu/drm/tilcdc/tilcdc_external.h b/drivers/gpu/drm/til= cdc/tilcdc_external.h index 285a132f3035d..c8f87f59024e6 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_external.h +++ b/drivers/gpu/drm/tilcdc/tilcdc_external.h @@ -7,5 +7,5 @@ #ifndef __TILCDC_EXTERNAL_H__ #define __TILCDC_EXTERNAL_H__ =20 -int tilcdc_attach_external_device(struct drm_device *ddev); +int tilcdc_encoder_create(struct drm_device *ddev); #endif /* __TILCDC_SLAVE_H__ */ --=20 2.43.0