From nobody Tue Feb 10 05:41:20 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FA5434BA54 for ; Fri, 16 Jan 2026 19:35:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768592159; cv=none; b=X6hK41DD8hvSrYaGLrpoHxMTXSiXGh2xR3TW4954+snFKGtiSttsl4ibKaCEcQCNueDxLcwmrMicZczHAzhPX8uJ+lNk5tr5NpvAnhsaaxj3uCHRahkciezbpRLq00Evtw4jrc2r1KkrVRADFOqfjaGv8dURY3uYx0Is2dQUN8U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768592159; c=relaxed/simple; bh=ajUWlkXh/WeruZi/fZoonvdk1N6Xwdk976vaNLYbaEI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=epiCJLq+efILiIdO0PBr4RM6GdrAOc2x/0D9ai/i1RcFb5Bf9xZrN0KOSfPMziKLc9ZsqvRex50dPXjTl7FUBCdLlkXochOE+IfHd8geBEk2ZN35rfSKLGrVeWpuKrR4QRXmFLwTfY/mq8ymiGkAAO3kzo2TGAKeUE9ZacZK5A4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vgpbi-000805-HI; Fri, 16 Jan 2026 20:35:42 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vgpbg-000yKB-1m; Fri, 16 Jan 2026 20:35:39 +0100 Received: from hardanger.blackshift.org (p54b152ce.dip0.t-ipconnect.de [84.177.82.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 9601E4CEEE3; Fri, 16 Jan 2026 19:35:39 +0000 (UTC) From: Marc Kleine-Budde Date: Fri, 16 Jan 2026 20:35:18 +0100 Subject: [PATCH can v2 5/5] can: usb_8dev: usb_8dev_read_bulk_callback(): fix URB memory leak Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260116-can_usb-fix-memory-leak-v2-5-4b8cb2915571@pengutronix.de> References: <20260116-can_usb-fix-memory-leak-v2-0-4b8cb2915571@pengutronix.de> In-Reply-To: <20260116-can_usb-fix-memory-leak-v2-0-4b8cb2915571@pengutronix.de> To: Vincent Mailhol , Wolfgang Grandegger , Sebastian Haas , "David S. Miller" , Frank Jungclaus , socketcan@esd.eu, Yasushi SHOJI , Daniel Berglund , Olivier Sobrie , =?utf-8?q?Remigiusz_Ko=C5=82=C5=82=C4=85taj?= , Bernd Krumboeck Cc: kernel@pengutronix.de, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, Marc Kleine-Budde , stable@vger.kernel.org X-Mailer: b4 0.15-dev-47773 X-Developer-Signature: v=1; a=openpgp-sha256; l=1841; i=mkl@pengutronix.de; h=from:subject:message-id; bh=ajUWlkXh/WeruZi/fZoonvdk1N6Xwdk976vaNLYbaEI=; b=owEBbQGS/pANAwAKAQx0Zd/5kJGcAcsmYgBpapMJL919z3NV/cvyu6WS0eMw8l8h/oh8JD6WN 3MXUVhIQ5GJATMEAAEKAB0WIQSf+wzYr2eoX/wVbPMMdGXf+ZCRnAUCaWqTCQAKCRAMdGXf+ZCR nInsB/sF2kH/HpMUjXiqJn5r3uD1Xw9LLCopEGGr8Eh2adUpDnZccvkKuAlN5S0q8+6gjW1eUqw +QZuVXhhwZByK5z8ibEvhagAeJZF9Qc6+83HY3ZQaxpTmlunQcGarvTp1EA00BcQR7so8jAO9Va Oxx/kpz1836r4AWMXa5MRnL9QlCcm+XdubyTD+g4l/Rg5LpV7h1U0Fx5DWX4VQGqEbvmhhncBfn 8QN8+63cQS/48ZeO5szX3xwW4BCJ3Soj7tM7Nse0/2lvSzcDIBDgC7acinqchXfFWoGmUZnLNL9 pyjigAJ1O+R79Ctw82noRTbhoX+nrH5UVZ+JW6f9stZKtxqa X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Fix similar memory leak as in commit 7352e1d5932a ("can: gs_usb: gs_usb_receive_bulk_callback(): fix URB memory leak"). In usb_8dev_open() -> usb_8dev_start(), the URBs for USB-in transfers are allocated, added to the priv->rx_submitted anchor and submitted. In the complete callback usb_8dev_read_bulk_callback(), the URBs are processed and resubmitted. In usb_8dev_close() -> unlink_all_urbs() the URBs are freed by calling usb_kill_anchored_urbs(&priv->rx_submitted). However, this does not take into account that the USB framework unanchors the URB before the complete function is called. This means that once an in-URB has been completed, it is no longer anchored and is ultimately not released in usb_kill_anchored_urbs(). Fix the memory leak by anchoring the URB in the usb_8dev_read_bulk_callback() to the priv->rx_submitted anchor. Fixes: 0024d8ad1639 ("can: usb_8dev: Add support for USB2CAN interface from= 8 devices") Cc: stable@vger.kernel.org Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/usb_8dev.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/usb/usb_8dev.c b/drivers/net/can/usb/usb_8dev.c index 7449328f7cd7..3125cf59d002 100644 --- a/drivers/net/can/usb/usb_8dev.c +++ b/drivers/net/can/usb/usb_8dev.c @@ -541,11 +541,17 @@ static void usb_8dev_read_bulk_callback(struct urb *u= rb) urb->transfer_buffer, RX_BUFFER_SIZE, usb_8dev_read_bulk_callback, priv); =20 + usb_anchor_urb(urb, &priv->rx_submitted); + retval =3D usb_submit_urb(urb, GFP_ATOMIC); + if (!retval) + return; + + usb_unanchor_urb(urb); =20 if (retval =3D=3D -ENODEV) netif_device_detach(netdev); - else if (retval) + else netdev_err(netdev, "failed resubmitting read bulk urb: %d\n", retval); } --=20 2.51.0