From nobody Sun Feb 8 20:08:43 2026 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011000.outbound.protection.outlook.com [52.101.70.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66FF63090C9; Fri, 16 Jan 2026 16:29:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.0 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768580981; cv=fail; b=EwV800TgFRdw3V4QKR3mrwueIpS+UBahqJdY01c6sngkuvqKLj4EYieRbocQzPFaF51IFKvnKWn7rDQ+OGj8j+sgwD26F8As+WLVDcVZ9IlJ5U5x8+CE25nJJRd1doQcAmh0umN43ED4TPox4RCVcykmVIQ/iLY9wfR6+FKn2tA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768580981; c=relaxed/simple; bh=0s6uiKHv37flI+riV1pXyuMRgyZ7LuQsN+bdg/6Yfgc=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=clY29odggyo+zFBeVIbu28XNCMknJYURqWpgIpb+a6ZSsXdaGaXrTh6Umc+IKyWRgGmyOaXITxDB5AdXi1dYTplAJbWnL0sFv4uwP74LtMpQxQ/Yv9kIX+Rd8oRw41FcSp6nLpjTjlv7mCWUb2Y0ssnfk8cIzDmoAoONKhARYh0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=lf9NfbWB; arc=fail smtp.client-ip=52.101.70.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="lf9NfbWB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GNm4ksULxrq4dSmKAatM2RfXzY6mnE/oCwYuqEmrDkLYSmQeuXlZEhM7DBTzu3MFZ/WryFF2T5LYJMGMXd1TQx6VmmyaLpFxrFS76oPl9H2KWMD2Zh1eryp9FJVw1ytTZUL4Pov5/37LLpmDqliow1KS2KSCFkkUOltD2e18NMxhNHI6VQG/lNdhr1qiAW5NQWE3hkM9duI43N9mjNw2JHHo9iI9LQ1h+TvTHxXm22ILPkTZHx9HwPJeo/KeVHLxPDuetKyzuS9kgLjMyWnZ5BxNos6cjiXOXA6DBKDtqvPP7J5j7tw9HOox5nhPNjqhcEZxzo3Mj6yGdcrziyok7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zMfu8YX5EFWjefaKoq0ooAG5IDfnoeQp0TYjN5gpe/U=; b=ShjtGwtvTZezYUiEhSS6oDd68G6VCT2O0dWecvPgwv6pabjPUxBkXylMlhTVT+TBOs13uZzj64ctDjN+K+W2Gciav0arHMkWrZOE5btCstuXFVgh1XHY5s87g9uUrad12A+JxbDVKDhd6/600UBmkMU4et34J+0fdYBb5dj3WSxVHU5M9YMkSOscMlnl8bEXcFsxolMwgNjrTShhf5ZOINSN1Ray1eM6Nat97OBw7IzvQMZQr1rnJKH+96Rqc6dcitbPLqdnIZxX13T+jlpELwm0FCHSSWRfOaDqCoFFgC7UhPtfBPwtUOrARw3+ZfV0PFeFByOQQ4B463pjmKMdFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zMfu8YX5EFWjefaKoq0ooAG5IDfnoeQp0TYjN5gpe/U=; b=lf9NfbWB7SXimKWtaEK+mhYvfw+DE/V/F1QUCv5JVFdRuXmxHmOseoBMks1sPyQsLIAve8owjc7LEGoXUdJdiVh2rD14Rh6qDluSJRXy7+kaLLAQfwAeSjrrx3JAfspFM7CdX1H5kSWpbQsAwciYlt9v6usQXzG7K7mIlJMYgs41hwrU9o/0xtGFldVbbpakYQFregKE721KauvqS+nJTz/gqchkbth3Ukzee48um7R7jnD+EDWDLWZirtmns9IoenpJXuCeZqD6J04eoUoKe4lSK0lshPyxmzG2qxchstk9SWxDeFEJO0NmLbtgxLXksPbxGBVwtnnIDq+ZBVIz8A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU2PR04MB8951.eurprd04.prod.outlook.com (2603:10a6:10:2e2::22) by DU4PR04MB11433.eurprd04.prod.outlook.com (2603:10a6:10:5d7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.6; Fri, 16 Jan 2026 16:29:38 +0000 Received: from DU2PR04MB8951.eurprd04.prod.outlook.com ([fe80::753c:468d:266:196]) by DU2PR04MB8951.eurprd04.prod.outlook.com ([fe80::753c:468d:266:196%4]) with mapi id 15.20.9478.004; Fri, 16 Jan 2026 16:29:38 +0000 From: Frank Li Date: Fri, 16 Jan 2026 11:29:19 -0500 Subject: [PATCH v4 1/4] media: nxp: use dev_err_probe() to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260116-cam_cleanup-v4-1-29ce01640443@nxp.com> References: <20260116-cam_cleanup-v4-0-29ce01640443@nxp.com> In-Reply-To: <20260116-cam_cleanup-v4-0-29ce01640443@nxp.com> To: Philipp Zabel , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rui Miguel Silva , Laurent Pinchart , Martin Kepplinger-Novakovic , Purism Kernel Team Cc: linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , Alexander Stein X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1768580970; l=5258; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=0s6uiKHv37flI+riV1pXyuMRgyZ7LuQsN+bdg/6Yfgc=; b=UvuZupgM5juo9D15p9Dx2rs2KbhXko+jw8ftSPCfPE2tkWvLLyoCdWFJs3yAqF9JNuj8W+xUm HXXH2fU4Qy/B3ZIZG5PNL+xmooGUTLsZ+q9V6Pp31NFsSNL2NzAzOwo X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0127.namprd05.prod.outlook.com (2603:10b6:a03:33d::12) To DU2PR04MB8951.eurprd04.prod.outlook.com (2603:10a6:10:2e2::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8951:EE_|DU4PR04MB11433:EE_ X-MS-Office365-Filtering-Correlation-Id: a1092b6a-5fe4-4ff4-16b0-08de551c7123 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|19092799006|52116014|7416014|366016|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZHUwUFVWb0I3RDE5ZlhEd09TQVoxT1lvcEFYY2hjcndDVFRKSG5LSU1tT3Q3?= =?utf-8?B?ZVlEeVhWRlBoRk1lTkIrcjFyVjR6ZHNnbUJtZTBoZDFGRWZnaDY5eU9GZlFL?= =?utf-8?B?NWltaTd2SDBQbjNCMTlxd1BTRHBENWlGVTVuenAxbEI5OVZiTUdUaXFlZ0FU?= =?utf-8?B?SUd1bmlCVUJZSHJqV21CN1JNRGdUUk9LN2l1Z0U4b2hEbDhjNU8vRDVsOWhB?= =?utf-8?B?ZGI2ZG9BM1JrSmZXSDEzdmxnQ2VtVktrZXJZelNRZkllNW56OHRlbUtYWkNW?= =?utf-8?B?eCtjenpYcTh2R2pNYTRRWjVMZm1OMHpDQVNzNG5NL1RrcUFERW9qaytvWkdl?= =?utf-8?B?ZGJWeUJlN1FrbnkvQUo4c2IzbDNNbjkwdGFyeFcvdGtoV3E0VVlCdEVzV0Za?= =?utf-8?B?alRwWkZBYnkvcDdqSUU1ejM0WWlpeUt1VS9uaUdTNzF1bWdhL0c1K0ljV1Bn?= =?utf-8?B?UGFJemZIelBFN2lFNmxzNzV0R1UyRVdveHhEYVpvMnVaTE1CSFlWS0hxSmhW?= =?utf-8?B?U2JFTU1JMGhDbkpUMjZMZm05NXZocXhaenQzK0ZxSGE1b2ZtOGtmZGYvdGs1?= =?utf-8?B?YTZibE9TdVh0MnBsVWRBYWVNSFVPcjZHK1RJOU9sMitLVTlYMnRjeHdYVHJo?= =?utf-8?B?NnU0SzVpVldpUGVoVWhqVTZ1eTJra3BkWVBqbDV0MXJEeVR2NFl0QkhYVERM?= =?utf-8?B?U0tCZHExdFBXUWJYdFJ1THVpdHBGTE5OM1VWWkJENi9rQ2o5NmdrNlVkK2NW?= =?utf-8?B?QURVVWppaXBXTGZxbkxsa1JJNWFJR0pJWkNvbXA5NFZBWXVtbVoxaU0yNENt?= =?utf-8?B?N3pISnM5MDgrbzBIbE80ZXhtcDlPc0tqMml0K2hOWnd4aTRkUkNpd2oyNmJW?= =?utf-8?B?blY5dVV3eWExSk5QeTZTMlN6b1AvZ0NtTVREUlZFRXVOMXBOVDRyd0Z1SWky?= =?utf-8?B?NzZSdjZqVkhEcDZaRVpGTGNTUjZlcEFuV2E4SlBmWVFJU2NJNzhMaWdab3Vt?= =?utf-8?B?YVJCRmY3NW5SVFRrYkJFQ1hBV01xQ3Z2eDRYTjVacVNVRFJpS3pLTXhzZGxa?= =?utf-8?B?ZGNtUUZOYVhYcGpEMGRCazd2bnExTzZFVlMraklDOVhCLzA0Y1crQlpnZHcr?= =?utf-8?B?ZFBMQ1FVUFVYL2VJZ1drN0srbFFVdXI5UjhOT1E1ZTJ6aWo1REZtN0twMmJa?= =?utf-8?B?YWNjYUMwOUFSMHNkaFZLRFdUQmhOSUd6RVZ5Wko4bkgzUlVvNW1jT1JZSk5T?= =?utf-8?B?M2toRkIzNkxQOUhyaUhqYWxpc0EyVHNpOWRRM3dzVWtWS3pHQXVGMW9KRklp?= =?utf-8?B?VzgzOW85RU5pT1YwcVM4QnN6bUpIenRqeGE1dlZFVXF4TFpFbDAyK3V2UFNl?= =?utf-8?B?b1J3L2E4cytZRHp3VjRHVExIbE9aejE2N3VraWdobWo4NU9EckdkT1FRN0ZN?= =?utf-8?B?VjloU09IZHNJZnBFQmNQcm1scjFEN09XMXdqbTQzeU9ZU2FUZ0h0ZlAwSTc0?= =?utf-8?B?RXJCaThlQ04vajF3ZUF4WlFOdXFqK2dkUmgrOGFXV1F6clFraVNJWWQzZk5v?= =?utf-8?B?dWg1c0tUZWlQZ05UQSs0dHdhWEZ1eGV1dG1KdGxKMTNHK0pFWVYxMng1bk5M?= =?utf-8?B?OUd3L3dQVW5SbEV0OHBKMnpjVlVza1AyMVk0Q0xJb0VieDc0RnlsbTlNSnB0?= =?utf-8?B?d1FpRU04b1NXOEpWemVlMkFEaDJNVHJmdC95empvVTVXeDJMWWJvYStkSFBs?= =?utf-8?B?cWdGOUVlamhPcllIYmpmSENZeHdFM0N4MW4zaDczZFZWSC9YNDYrL0F2VHZm?= =?utf-8?B?aFg3UWVxRFNMWE9MQm9TTzdoamNqa2xRTm9OdXVMSGRDUmlXZlJZamVkL1JJ?= =?utf-8?B?ZGdNQzhSQTkyT0hlQ2JVRmMrOHdpUnZmUTNjdVBLRGw5KzdjWDZtWFc3YjFT?= =?utf-8?B?cXIwcUFCa1YxY29hNjlBdFRuOE80enNaa0NWZTk1MGJuQ1ppUVBxcDVpcUE1?= =?utf-8?B?T0VXSVdHaGhlOTJwUmgwQzY0Ulh3S01ZejFGQkJxN3NGWEplRVZaY0w5QTND?= =?utf-8?B?cTlnbWRydXovRmdzdW9IdUNrSHZQZ2pyc3JGZnlRM2tJQmt3TGNQRmZnWDVo?= =?utf-8?B?NkVzWFlFeU9ibG9EeUtTR2dUb0Z5V1dZNWhqRk9TWjNCaWFFTWoxK0JJblU3?= =?utf-8?Q?pXHKAQMp9iBL9lo5W9e/LYZs+EOVgPoh54T0QLuQ1XtT?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8951.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(19092799006)(52116014)(7416014)(366016)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RG5mblh3R3Y5Mi9VOVVCM1lnM01VbkxEVHcrVHJ1VGdjdWJFUFhSTVdmUnFN?= =?utf-8?B?RXVkdzhsWWxEeEVNVHpsWDZWcGdHSmdyRlRSdmkweDdCMW9vN1M4VDBIRnlF?= =?utf-8?B?K054UExOWi9rc2pmdTlJZEs4VS9TZ0lmYmdzb2tmaXdiai9ZZGF4Zm5FRWp3?= =?utf-8?B?SjdGNWo2eStEQTZmelpBUjJibHBWMVVWL1BTNkwxcklhREhnT2tGWDd3Y1Zy?= =?utf-8?B?aWpocnJjZW9xSVE2ckZqODlFNzg5a2pZbHE4aHB4dUxTTW10c3BZZUtiZy9N?= =?utf-8?B?Q1ozS1IxL29SZ2VwUFkxUjBhMERVcDRQM1Z3T0FQa2JMVk5rc3EwNlRPVmlB?= =?utf-8?B?QjNPYjhlM0Z0WFQ0cHNzUThxc0Rmd0VGM281cnlyQlM0aGFtdlEvc2dyMFRQ?= =?utf-8?B?SW85ZEl6cC9PcmNMcGM2OFdKSXU5WWJ5cHhmVVJ4QUZDam52L25VRTBjeFpF?= =?utf-8?B?ZkI3ditKN0hMT09zMTlMS1drRVdPZXFHK2FyYi9xVDZUbTRvQlVBQkxPaGQz?= =?utf-8?B?a0NpOGprUnk0UHJZTVhiVEpBOGpRZmZhTHR0MS93bUF6Rk5XUHM0Vm5Cc1Qz?= =?utf-8?B?MXpiSTRGY3ErbzQ3bEhjOTQ2dnoyUmlDZEo0Sjd6cjNmOVgwVU1Od2xrdWkx?= =?utf-8?B?VmVRanpYK2dXcVVNcEIvTS84MGdUN21POGtJVmZCcEM2SFV0ZmY5b0p6UnFU?= =?utf-8?B?R2tqMlBTYjZZdG5MSnpKWnFCRGlieTRINzE3NWZVMGJuYzlOZ0VHMTlMQ2x1?= =?utf-8?B?aFNTQ0tlSFJxcHVuaTdmV1lCYk5wM0tVWFNIMTZMOXgweTdlbzdwQ3FiWFlF?= =?utf-8?B?cE9pNi9RNW4zbmp3K2RDMmx2UStDNjI1NXRXMlVEb1hubmFQYURHUUhoZzha?= =?utf-8?B?cmpidi9BVDlhY2tIUmN5dWlaRzM2bUpDWVFTeTNlSllMSUs2c2VNSHZGdTdQ?= =?utf-8?B?UHk3dUVGQURWd3lhNUZsSE1rNC9aelF1d1lLU2EvM1B3S0dBWFRJR3I4OUxj?= =?utf-8?B?U0UvazhIWTNEWEU0R08wQzYyNnNMbkphRGNUeUpuRGJtU2ZPeHVYbTNpOER6?= =?utf-8?B?WFZxYnZmOHRiUXpHa0Y1T2pyeTFFR3djR21JZlQxVU9tYW9NLys1V3FDVVJT?= =?utf-8?B?TlIwcUFRQnhzbW83RWNYaEJDbzRxaGUzTGVEZEozbTdJemVKcEZIaERNUEhv?= =?utf-8?B?T1piRVRxVU52Um42Q2NQejBNS3NSTVNETjRDQzc3QlZSS0JPT1p2VXhrd0hS?= =?utf-8?B?MlB6UkNhT3Q1OGVYYW9KdHJ3Ujk2WVd0cU12OFE2SzhabGVmK3B3Tkp5R0lE?= =?utf-8?B?bVFSMWpQSHkvYXVYUmtVb2czaHJET3dzTXNET3FYSHlkTmUvdEdoQTlPMXU2?= =?utf-8?B?M1FDTlVRSzEzeDZzSDU5dlhQSFBkb282R3RVNGxVWkNoOXZwWFpoa1FjQkM1?= =?utf-8?B?RXRpNCtKQXBYdlgrZk5mcW0yeHVSU3F2clZzbGdtSEFrZXJubEhMa1U1SUNT?= =?utf-8?B?by9zZHRqMGtBQUFmckRpS3NpeHVXaXJoUmF4WWRzVWg5S25iRC81Mmw4dnhM?= =?utf-8?B?WGx5YUJSM0dCUXNqTFdQTUdXaEhKY0xnT2lDN0Z4b2F0cUxObTl0WFhTbEFO?= =?utf-8?B?ZXRaYmkySm56MDViTDRsTWd4bnh4eTErcGx0Z1VwMmJuNHdGZ3RHcnF0UHNv?= =?utf-8?B?dWZpOEZJQXZENzRkVW13SnRNODl2WGlhUkd3cUdQS3pjZmJzMHJXOUJFLzJi?= =?utf-8?B?ODRPSkhrRjhUTWsxR2x2VEJ5ZkIrV2EvVU9PREFBenlCTUE2QU5VWCtLWG5t?= =?utf-8?B?bHhIYm05cXRVRGhGNHZKTUw0Ukt5Sy85T29JL2ZlQlJEMEwxekNDODQvQVpn?= =?utf-8?B?eCtramcwQzdobmxkTjdKR05EVzNwQ2ZKOEladVR1RVFja2JZQVltOG1WMnpZ?= =?utf-8?B?R0lWVUJjdXNlaFI0TktHYk5paEdDNXBlUm5pNWNwdjE3MjhUckRWOVVjVnZQ?= =?utf-8?B?d0txUHpyb3ZBdG1wa3UwS3RGU2RJMSs4eGhKTTJmR00rMnIycW5RVTRvUnpr?= =?utf-8?B?ZkR6dWUxTGh6MkJndWltSnI2VWZKaE1WTjlkMjNIWFNVbFl4S0JGL3U2cnhL?= =?utf-8?B?U1lUZGpFQVB1REpaeXRSQmVXcmZ4bUdBeEE0SXlNRlg1S2hNUlpNR0N3ZDg3?= =?utf-8?B?MWJjWWtrUDhTdE1ncHRvbHAraUZYcnNzUFZvb3RHbTlRM3dlM0NUOERXTnRS?= =?utf-8?B?eHdNWU9aaHA4ODFweEdCMlB1Q0VtcXRIOU5yQlVtNkdqU0Y2UENhdldDTzRI?= =?utf-8?Q?phV4/8pi/E88sxEsjV?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1092b6a-5fe4-4ff4-16b0-08de551c7123 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8951.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2026 16:29:37.9884 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lOQFJ8xCNr9TMTzuG3vGdGwxuqvQu2IU7qk6Pja4MS1AbTFjBdnyNs1SfBsBoaO1AineYfkPIS3hs9MU3gyQrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR04MB11433 Use dev_err_probe() to simplify the code. Drop the explicit error message after returning from imx8mq_mipi_csi_parse_dt(), as the error is already reported by this helper. No functional change. Reviewed-by: Laurent Pinchart Reviewed-by: Alexander Stein Signed-off-by: Frank Li --- Change in v3 - add Alexander Stein's review tag - fix error message grammer change in v2: - add Laurent Pinchart review tags - wrap error message to new line - remove error code print in dev_err_probe(); - drop error messaage at imx8mq_mipi_csi_parse_dt() --- drivers/media/platform/nxp/imx-mipi-csis.c | 6 ++--- drivers/media/platform/nxp/imx7-media-csi.c | 14 ++++-------- drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 33 ++++++++++++-----------= ---- 3 files changed, 21 insertions(+), 32 deletions(-) diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/pla= tform/nxp/imx-mipi-csis.c index 088b2945aee33731c565f049dd17721356300b84..ce93d868746f002c22e2f86b1e0= aa84ec1a76061 100644 --- a/drivers/media/platform/nxp/imx-mipi-csis.c +++ b/drivers/media/platform/nxp/imx-mipi-csis.c @@ -1547,10 +1547,8 @@ static int mipi_csis_probe(struct platform_device *p= dev) /* Now that the hardware is initialized, request the interrupt. */ ret =3D devm_request_irq(dev, irq, mipi_csis_irq_handler, 0, dev_name(dev), csis); - if (ret) { - dev_err(dev, "Interrupt request failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "Interrupt request failed\n"); =20 /* Initialize and register the subdev. */ ret =3D mipi_csis_subdev_init(csis); diff --git a/drivers/media/platform/nxp/imx7-media-csi.c b/drivers/media/pl= atform/nxp/imx7-media-csi.c index 933a5f39f9f4c9b43ca8d2a1819d0145981266e6..7ddc7ba06e3d4e007013821f67d= 783898a15461f 100644 --- a/drivers/media/platform/nxp/imx7-media-csi.c +++ b/drivers/media/platform/nxp/imx7-media-csi.c @@ -2218,11 +2218,9 @@ static int imx7_csi_probe(struct platform_device *pd= ev) =20 /* Acquire resources and install interrupt handler. */ csi->mclk =3D devm_clk_get(&pdev->dev, "mclk"); - if (IS_ERR(csi->mclk)) { - ret =3D PTR_ERR(csi->mclk); - dev_err(dev, "Failed to get mclk: %d", ret); - return ret; - } + if (IS_ERR(csi->mclk)) + return dev_err_probe(dev, PTR_ERR(csi->mclk), + "Failed to get mclk\n"); =20 csi->irq =3D platform_get_irq(pdev, 0); if (csi->irq < 0) @@ -2236,10 +2234,8 @@ static int imx7_csi_probe(struct platform_device *pd= ev) =20 ret =3D devm_request_irq(dev, csi->irq, imx7_csi_irq_handler, 0, "csi", (void *)csi); - if (ret < 0) { - dev_err(dev, "Request CSI IRQ failed.\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "Request CSI IRQ failed.\n"); =20 /* Initialize all the media device infrastructure. */ ret =3D imx7_csi_media_init(csi); diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/= platform/nxp/imx8mq-mipi-csi2.c index 0851f4a9ae52d3096f454da643cfdc5017e000b1..83da050a1dcbad1d41c94de0e35= 2dcafe3f25e62 100644 --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c @@ -951,10 +951,9 @@ static int imx8mq_mipi_csi_parse_dt(struct csi_state *= state) int ret =3D 0; =20 state->rst =3D devm_reset_control_array_get_exclusive(dev); - if (IS_ERR(state->rst)) { - dev_err(dev, "Failed to get reset: %pe\n", state->rst); - return PTR_ERR(state->rst); - } + if (IS_ERR(state->rst)) + return dev_err_probe(dev, PTR_ERR(state->rst), + "Failed to get reset\n"); =20 if (state->pdata->use_reg_csr) { const struct regmap_config regmap_config =3D { @@ -977,24 +976,22 @@ static int imx8mq_mipi_csi_parse_dt(struct csi_state = *state) =20 ret =3D of_property_read_u32_array(np, "fsl,mipi-phy-gpr", out_val, ARRAY_SIZE(out_val)); - if (ret) { - dev_err(dev, "no fsl,mipi-phy-gpr property found: %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "property %s not found\n", + "fsl,mipi-phy-gpr"); =20 ph =3D *out_val; =20 node =3D of_find_node_by_phandle(ph); - if (!node) { - dev_err(dev, "Error finding node by phandle\n"); - return -ENODEV; - } + if (!node) + return dev_err_probe(dev, -ENODEV, + "Error finding node by phandle\n"); + state->phy_gpr =3D syscon_node_to_regmap(node); of_node_put(node); - if (IS_ERR(state->phy_gpr)) { - dev_err(dev, "failed to get gpr regmap: %pe\n", state->phy_gpr); - return PTR_ERR(state->phy_gpr); - } + if (IS_ERR(state->phy_gpr)) + return dev_err_probe(dev, PTR_ERR(state->phy_gpr), + "failed to get gpr regmap\n"); =20 state->phy_gpr_reg =3D out_val[1]; dev_dbg(dev, "phy gpr register set to 0x%x\n", state->phy_gpr_reg); @@ -1017,10 +1014,8 @@ static int imx8mq_mipi_csi_probe(struct platform_dev= ice *pdev) state->pdata =3D of_device_get_match_data(dev); =20 ret =3D imx8mq_mipi_csi_parse_dt(state); - if (ret < 0) { - dev_err(dev, "Failed to parse device tree: %d\n", ret); + if (ret < 0) return ret; - } =20 /* Acquire resources. */ state->regs =3D devm_platform_ioremap_resource(pdev, 0); --=20 2.34.1 From nobody Sun Feb 8 20:08:43 2026 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011033.outbound.protection.outlook.com [52.101.70.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A9B833E35D; Fri, 16 Jan 2026 16:29:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.33 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768580985; cv=fail; b=jSsYZUQH43b96OhAM8OGHQ7VMPCx+ZZJxmVF6YmMF6BwzgUOXl3GfO+kGrcg/BQed0t7DjdAJUF80ZxK0XqiZ4ouJA/BXKsU4caRkmLvn+hOCvuLVm2IQkozK6pxpq6g26oxL2x4J5EJK/fdTqbwbaNvSlEHzFdiUGOUff/Edts= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768580985; c=relaxed/simple; bh=yPwnUBOev/x/308wqg/c0rNtCFlwwv3fG4kMS/h4VvQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=bponmtBd9V7aivSE9WCeUJZnwEV/NFU6dFkrVOt6druIfIdJ+L039Zgo0nu4vwDtpFA/cp+ZYS8OSse9j6Imq5BJN/TKe5hyA86IhKNgmmPwDr29I0izyj6yrj6z7uyeVBipUswPjZsw6KAYlo/WoWNMYVNpbvE7byEXHJj+ijE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=kKnU2FmO; arc=fail smtp.client-ip=52.101.70.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="kKnU2FmO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=I84wGvGFIP5nUpE4fqzO4ltUbXtt/V+iTmGegnc3jDAMffJFFgVA3W6++clY3KbGZ5vxnUw5FnP7XkHxY6lERcWXmt2va3oRTnyfH6/nQUc4NOYUMe1VCrSdXGd6aTxuwq5hY2Ry4lw7CbOIRNOKQL+9Kfnaagh4FMw7zRr0WSrP7qwQD1xXxpefOZrCaLGG0EV/59gqeFgwEVsUQZrmgImd4NSoSRz0x6lHdhEOdznBFk8dbO+32CPLPZGcOuuB1QQyV09NwWJtHZH4r0zfJcFaLZ+QC03oca5WgogNsRdIRpYvM6Wb/5kGogl40hSTdhXWb5i4r9dfGGHKnNlygQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nzPs5H92nXDeok0MjXa/DcPz5kXR2XdL8jcuKSirt3E=; b=Fd4IWpXz0TCGsJ4fODZ1l816tABAXpkED+0GP8apptNWWNui3U3ueNCbXtzENqZVGObzgvLl9V4P6usbiBLb5eacOm/DAiyNHW9AeBISCDLJWe9jrDobb0tDL4cwxOhCPv6+RYFEXe8wueO487kkPvfR4YzMU7GyHqwHIhTFjOQCKgJBuBq2DxeOxCr5+lFOs557NHnxCSpXd9ZqJEeML4k34et5kVFP4qTqkb+5IbAIWh8sv/sz7Ll1hh74PmDpxI6LZaauu1yJ9gif16M8oF3Ou3iNYARbUR41AuzUDNiKQHlJ7/XyuNz/0/0/qOib3baTNyc2W22We15rX/Tstg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nzPs5H92nXDeok0MjXa/DcPz5kXR2XdL8jcuKSirt3E=; b=kKnU2FmO1kH73WLY+Ia+n6qqBh1GIYnpgXoWLCcyEmKvW0moyWY+LqgaZnpdUxU16yTaIshknVD5EIrWBUpeym5sJXNM3v1d0wUcCUyqTVvnGTQyOyhRujRcca66pLO308zhio/8Ggz+lzm5IrgV+DlOLWdhy5Cs2LFq+W4Pl/mS7jACMqdHTrMGInf5hZbOF+WkaT/toszohawQggg0CxNF/M+ZPDKZm0Jm596aJ/+bL4/YT6P7Gr2yWfvfKas9YprJQhjbD/Ls+m9Liw9qKe2dxBRU6X/OMz1nyedyXmZBb9Xy/kK/EzuXZRrz/9k/0LfMXLBxaXQ+W6q2E8RSVg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU2PR04MB8951.eurprd04.prod.outlook.com (2603:10a6:10:2e2::22) by DU4PR04MB11433.eurprd04.prod.outlook.com (2603:10a6:10:5d7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.6; Fri, 16 Jan 2026 16:29:41 +0000 Received: from DU2PR04MB8951.eurprd04.prod.outlook.com ([fe80::753c:468d:266:196]) by DU2PR04MB8951.eurprd04.prod.outlook.com ([fe80::753c:468d:266:196%4]) with mapi id 15.20.9478.004; Fri, 16 Jan 2026 16:29:41 +0000 From: Frank Li Date: Fri, 16 Jan 2026 11:29:20 -0500 Subject: [PATCH v4 2/4] media: nxp: imx8-isi: use devm_pm_runtime_enable() to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260116-cam_cleanup-v4-2-29ce01640443@nxp.com> References: <20260116-cam_cleanup-v4-0-29ce01640443@nxp.com> In-Reply-To: <20260116-cam_cleanup-v4-0-29ce01640443@nxp.com> To: Philipp Zabel , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rui Miguel Silva , Laurent Pinchart , Martin Kepplinger-Novakovic , Purism Kernel Team Cc: linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1768580970; l=1806; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=yPwnUBOev/x/308wqg/c0rNtCFlwwv3fG4kMS/h4VvQ=; b=UNNFadMrBcvcpxNreQ04VzRKLPC/DQAdvhLXtiuqouKn9hd3AH6bmIZlxjuzfOE5XWR12MDkX gmf+0pYz9abBSd8IULGGUkbVZj0F6faGzIWIvzrYUsvZf3K+Z79WqGW X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0127.namprd05.prod.outlook.com (2603:10b6:a03:33d::12) To DU2PR04MB8951.eurprd04.prod.outlook.com (2603:10a6:10:2e2::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8951:EE_|DU4PR04MB11433:EE_ X-MS-Office365-Filtering-Correlation-Id: 156cec2c-07a1-41c0-f344-08de551c7331 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|19092799006|52116014|7416014|366016|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?U3NFZXZXR2xBeUtqRjZqK0QwbkZSYUxESUR0cGUvTDRFc1M0Q0RUS3VPMHli?= =?utf-8?B?clc0d3RWTDhmeTd3M015ZTYxc2ROZE01L21UdklLRHd6a2EyMmZILzRaN0Ri?= =?utf-8?B?cFJueXVzTVIvQXordkl5bVlnZHZUMDEzMFA4aDBjVjdqVnkxY1hTbXJJSSs4?= =?utf-8?B?OGxES0d5NGZjK0t4bit2dDE5NWg5UlhFS0JSNFJYU2RUQ0FGMWg4b1VZbmR3?= =?utf-8?B?dCt0SW9sUzEvdEJ6bGNLYk90eVlQUFhzREhFV01FMmNWK3hMUUd0VFpUMXJ2?= =?utf-8?B?TnVXNmthWTJxZWhQNzdlMGI3d3YyTStFSk12ZkFSRlJSUGxjVElqRVdVM1Fr?= =?utf-8?B?M3UrTmZueUZGMXVQbVpXWWExK09pWGY0ZStCQVJONXpBMzRCTW53bXlLclht?= =?utf-8?B?TGhJbDRyYXNNOHRHTk5OWDFCeW0wTmtsS0kzYk11ODdiT2crU1VRNFV0UGFN?= =?utf-8?B?aVJVbmx5eURiOXc5RHhPNTNIaEV6eFc5UmVRRUVFV3VTQ2NPUkYxV2kyRytj?= =?utf-8?B?bkVnbUtqc0daM3hnVXF0a1d6WGJDaTJmTVltR1VLSFZaekZVbXhJVmVDUlo0?= =?utf-8?B?YmhsTWJlVk0xa3Y1MEp1NHQwd1lJL2xES2pDc1J6M2d5OXNJd00yMUtzZW4w?= =?utf-8?B?MTB0b1FBR0VrV2lSQTJyMEJNanBiNU9MT2JQSGorSDV0R3h0eDYzOEpYa1Mx?= =?utf-8?B?dzA4VUZwNkNNMWltU1FZdWNlR1M3L2t4akx6QitGR2w5UytCVkRIeGxmYndE?= =?utf-8?B?T2dTUTdOa2F4Qy9wc2c1RnBCR09OcTNWSjBheXBKenJqNGNpUUtPclJHUlVs?= =?utf-8?B?a2I0NElrV2lrSkN4TGs0ZUw0aVJJTUcwY1VDTG1kOVd5RnRiUjhGVHZPZkt3?= =?utf-8?B?d21pbnhhMmdXTXdHRE9RL2xMK1N4Z2NTZmhsVnZid3FkOXRDZzNacnFzNmRh?= =?utf-8?B?Z2wyTnRUcTdVMTEyQ2svdTV4VGdPdUtHOFdMSnVQb0YxaE5KQnNNR2ZZRHZS?= =?utf-8?B?enhoblJEWThESXowcW1XcDFpOEtOclNDV0NhODh0bVdJL0d3Z3VlUUJBalBo?= =?utf-8?B?SHZTU2RSME5rdWphOUJJUk1DZjlwb2VYb1dOT0VSODlDK0JiNGRiRmNJcTA5?= =?utf-8?B?Q0dTMGtUbEw0SkhTVDYvWjI1bTFqdktpOXNwYmF3NDNSdVk2ajBiZmZmWGxP?= =?utf-8?B?SzJuTUNiTXdlWVkxeE0xQzcyOGl5OHRkRHBaOEFpREVCVXM2TWJobnBTMit0?= =?utf-8?B?dGF6d0hmdTZJc1J2MWxJbWUxUEE1alVqZlVDdS8vN1lXNStVbkI0amlXaUJv?= =?utf-8?B?dDZDVmkvQk9VMkk3bE9rcGpoZFlPVEpsd0dSNmFKU2RoYjBRTzNWUkdpV01K?= =?utf-8?B?eGhWMDVoaEY2R0xaMFpVazhwUkYyQWFXYWRrek9EeEtCMThyUjFicEZmV1ZL?= =?utf-8?B?WmErOFB1ZDZ1WmI2cXVveWg4ZHBJbFAxbWhGQ1NOaDY0QVNNcmNDTmwvTkc0?= =?utf-8?B?eFpJOHo0Z0VRV1Q5RlYwWlRHNEJRMXNTVHR6OE1na0xZeWp1dWFqM3QwUVlP?= =?utf-8?B?cnlvVllIUjBHa0o5dVZoUzNZcEg0b1JtRzAyRWQ3UTJzUU9teGc5VCs3Y0ph?= =?utf-8?B?Y25lSG1xVmtsQlJTb0UyejIrZnkxcldpL3dUZm9POXdrcUVkaXdFNHY4OGpn?= =?utf-8?B?NTRWOXdsWXBTYWZWQUpzNmVjZ3Q3ZzNnQ21xR1BsOWRuYVNCeXpuTGxpbVBs?= =?utf-8?B?SjZiU0x5cDJmMGN3ZlBOMEN1U0Z3UnQzOEdXcUVrUGl4MXhJUnhJWnNYcUZJ?= =?utf-8?B?R010Uy9ibWVJSTYweTBxWW1FKzdtcTY5Tm05c3UzdUp2TUJDSXhBb0hRRDFL?= =?utf-8?B?NlBSUFRJdUVFZ0haa05kaFNwUWI0cGE3Z3lsVHdHN1dudWlGZEpSNGhZV1o2?= =?utf-8?B?bzl4VWkvanZYb21FMmFuWU1IOXpRTU5GcVBHYjlib1VwN294eVkybVBZNm53?= =?utf-8?B?ZGMyUys5ZTVwY3p4YjJqSWNaQm81YStPWmhHeVVZZ0NkTlhWdzJYdTBadnQy?= =?utf-8?B?TVN2UEc4L3o3S0FJVkdpVWNrSnZQYlcxckFKVHRBdUVOYjJNUGV2c1RXS1dU?= =?utf-8?B?SUtvUUlENlJIUnZ5SG92WFYzUW9IUmpBNkRyVjlyUmRJdTVaQ3YvSldVUXVO?= =?utf-8?Q?qitF/aUV3FTstz+cQ7KIGWXoFIMRlQt3v45A5IUcog22?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8951.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(19092799006)(52116014)(7416014)(366016)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTRJUVFzRjU0NlMvS2MxUlMvZktVaUF1bFB4Zm1PZERqWXk5b0tuVkdzU21M?= =?utf-8?B?S0Q1Y0NGT0tDOVkvL090dHkvZlFVRWdUV3kzb1pKQTFQNElCc2FCZEl2a0lN?= =?utf-8?B?aXlENTlIdWpoeCtSaU0rcVA5R0srSS9FUzJBWitnUjhtc0J4OEE3Vkd5bEh6?= =?utf-8?B?b1J5RTk5eUNYZXV2K3N4bXdEQ3haREhlYkdIOWpYaWpBTEZnbzhMVTREVnRw?= =?utf-8?B?bVVIc1dIRWsvdVFUS1JyMlBlSW5JUDA5OFNuMFd1TVdXVnVzMTR2WVl6RUJ5?= =?utf-8?B?clF4TnJKOVNqeEE4NVpBQmQwWXBGZDFnaGp4R0NSN0k0Z29WeEdHcENyaDcz?= =?utf-8?B?UnJKd0djVC8yNjJ0VEN0YkM2Y0pHdURpSmRtdml4VzN6NDRHUlMzUGdraHZY?= =?utf-8?B?ME5zUTFsZi9uY3grbUgxdkZaVlg5aXpTMTZCeVViQnFZL2J0YXI2S3VTdzF5?= =?utf-8?B?bnpkVll6WE1VbllsSmR0c0p0RDZmZlJJbnNvQmUwU3hkb214UnBKaldMQnRi?= =?utf-8?B?bmdDUGFYWVdFc1MwaHV5dHl6eWJoUHUzNWt6UGwweUx5SkN2Vmlub2ZsaTJw?= =?utf-8?B?bEg0bW1CRHlWeGMxbCtOMmo1T1dpczJYTTU2dTBhZXFlQ1Zja1l4QlJPbVNM?= =?utf-8?B?d2NITW9ncWZmQ3o0RTY0M1VmcC9HdXNtTi9mY1pSeXJqcm1iZnhPODJOZlpq?= =?utf-8?B?Rk5qQlk0ajVoUEpMWUZpZE42V1Zra0JObXV0MGJIM1FlcWM0UGV2OE1tNmlp?= =?utf-8?B?c1hweW9hazJiZm9JM2VwZ2FQMXQ4QlhJa1NTSlhOcnpUUk91RlQzWEpDUWh5?= =?utf-8?B?UU4xeldadkdUSDduTUMvNlBHQ3UvcUdZV0FCOWlVODNOMDFwc3QvVDVTQzUv?= =?utf-8?B?NnN6bTFmcU9vSVFrT3gzUTdiLytUaTVMNGdOOFdBY0pUZStsLzRBa3JkTEN0?= =?utf-8?B?Mjl6Rk9IZ0pQM0lmSjg5cnlUSlAraGgzbzV0VmltVGwvOHFCM2RNVHhlQlFE?= =?utf-8?B?MHc5a0Ruc2FaOW8zZCtiTTRua054WDhaYXFsU0FyZFV4YmRUWHBRUnlDQmsz?= =?utf-8?B?dElBWFkxMDFxajZPSzkxQ3lMZXU0SUNZTFhDNWNhSjQrMnZyWDJSTHNoQkxh?= =?utf-8?B?OG91ZTg5VVVYVmtMTlUrQmRKYzFVS0JrbTJKWHVTU2lscDV3VW40SnY1VS9O?= =?utf-8?B?T1EzMldTKzB6eUVlZG9yVkJGTStaTC93TG5JTy9qMlZmMG5tWGluNUV5YkJo?= =?utf-8?B?Smh5TXBmRnlJWWFHR3NXQ0kwaE1LSnFlTkxtZXNpc09iRDFQU0ZubjJjVGV1?= =?utf-8?B?cW1KL2ZwL2lhMzV6c3A5T2kzcWhZQ1dBZW1RTHN1V1hhVENlUnBCekI2RGZz?= =?utf-8?B?czAvc1lUQ3Z6S2RLNVBHZXNlL3VwUVRjeXBjbXhSdlRYVHA0ZFdHbzA3STQ0?= =?utf-8?B?QWRhNWxMMGVQN0RlK2s5ZXU3QTRTRnlBWlpKcDJXL3MrRnFOYTcxMG1VQU9z?= =?utf-8?B?WkQ4cVA0MDZ4RlFqZWJOcTJ5RXdqYlNMb1JtdlNTSDg1bmZnOExNMkpQM2k0?= =?utf-8?B?SlBWeDR5dDNQUVQzbXFzakZ6UkxzYzZUdFQ0ckNvd3RkTW1KdnBudkYyQ2p2?= =?utf-8?B?L01kTDg2enF6dFhPZ0FFSDBNVm5INU1wSUEyMklVN0xyVk1rOHRQWU82cGN6?= =?utf-8?B?MXZjc3ZxVUpWM1crVFdaOHllOCtZU3o5amlaOVAvRkQvOWFUUi9CYjc4S2Nj?= =?utf-8?B?RkRsdnRiUFdyT3B4Qml6N0tPMEtEM2MyeXhHWE5mVlo2WmVnZE1BaWoxNC9K?= =?utf-8?B?ZnJhTGtRYjh4dnNOUTgzRGxKV1hmTzNvanVidDc5VU5RaE0yL2pBbys4dWJF?= =?utf-8?B?aXhzU0RTWXVlZEc5Y0dtZTlkc0oyVU1aZzdOYkJadmI4eTVBRWx4eHY3RGpD?= =?utf-8?B?RGVuNmFTaW9kVlkzODZ4RlVEZzlvMktXbnk5d2JBTjFVK1FCbEZiV1RpeHhV?= =?utf-8?B?Wkp1UWFldHRuelRiYVZMaDdRWEZ0TXRwc205MVRWN01lL0VTSGlNZTFGNXlE?= =?utf-8?B?MDVwMzh3U1AzNXN6c1J6VWN3aUl5UmFwdTVPWjFrMWdUcHJib1MrZmdsVlFa?= =?utf-8?B?REo3ZmVneGYyTTB0MXg1UE90emtUR3g3YXJUUU5pdEFORzc4MGIwbmZ6eGRT?= =?utf-8?B?cXI1SFN0eklrSFJNbTh6OW9qcXArRXc1RkNBYmJCNkoxQi9rb3RrTi9UQWNU?= =?utf-8?B?QjJYQjhGSHZuVzFtMnpSTi9DZ1A1L2g0NFNaQVMxQkFyS3Nhc3NGM3ZPSTZZ?= =?utf-8?Q?05iikBwfHscJ/uYrZt?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 156cec2c-07a1-41c0-f344-08de551c7331 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8951.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2026 16:29:41.4502 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HRvXjB2qOc/a0+lNjikyb5wrv2wSWKxTK0AhnivYDhrcFHFOQng3ZRo7Izat2Mbcpmrr0haOb8go889Gu/FWwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR04MB11433 Use devm_pm_runtime_enable() to simplify code. Change to use dev_err_probe() because previous goto change to return. No functional change. Signed-off-by: Frank Li Reviewed-by: Laurent Pinchart --- change in v2 - remove error code print at dev_err_probe. --- drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.c index c3d411ddf492eb27b372763ce5d344a90c6ec524..486092511d1f9381c250ddcf844= fc74c61a789b7 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -499,13 +499,14 @@ static int mxc_isi_probe(struct platform_device *pdev) dma_size =3D isi->pdata->has_36bit_dma ? 36 : 32; dma_set_mask_and_coherent(dev, DMA_BIT_MASK(dma_size)); =20 - pm_runtime_enable(dev); + ret =3D devm_pm_runtime_enable(dev); + if (ret) + return ret; =20 ret =3D mxc_isi_crossbar_init(isi); - if (ret) { - dev_err(dev, "Failed to initialize crossbar: %d\n", ret); - goto err_pm; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to initialize crossbar\n"); =20 for (i =3D 0; i < isi->pdata->num_channels; ++i) { ret =3D mxc_isi_pipe_init(isi, i); @@ -528,8 +529,7 @@ static int mxc_isi_probe(struct platform_device *pdev) =20 err_xbar: mxc_isi_crossbar_cleanup(&isi->crossbar); -err_pm: - pm_runtime_disable(isi->dev); + return ret; } =20 @@ -548,8 +548,6 @@ static void mxc_isi_remove(struct platform_device *pdev) =20 mxc_isi_crossbar_cleanup(&isi->crossbar); mxc_isi_v4l2_cleanup(isi); - - pm_runtime_disable(isi->dev); } =20 static const struct of_device_id mxc_isi_of_match[] =3D { --=20 2.34.1 From nobody Sun Feb 8 20:08:43 2026 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011033.outbound.protection.outlook.com [52.101.70.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27F1D394493; Fri, 16 Jan 2026 16:29:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.33 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768580990; cv=fail; b=oAZI2z9lmuz4jjP262FR7mtQGIQMpOMXj6XV5vadAU80po9M+7UvIB+fUtHoyJr3ZcgmyUlQPxb+MHHOZ3/inKHxFENl6jOAaqAw0pCnfAWsOUWEGV5oQTuY3Mm2vLv6EHd4OIUDJshcTS4O1z+I9EZvv9zC6jZYxXTrUpshA68= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768580990; c=relaxed/simple; bh=ggarBXI8DTznTxxWLsJejWRICilIKfxfUK92ruvIhTQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=D0myt6OFV1V4/Bho8iycpfyhEhfp6n09yLtILZ6/LGP8lLC4MBWMDqkoZYfU/WaXYVm4UNJeBtwfOBWrwtLPN6N83w9fKmTgKtrielEDLeG5+d7FdKh2gySBbFDEpn2TYUcxQKhjzYVHJdbyIsZoBSdLGIecnzfGxHz9+Y9nhbY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=WMwqWeDU; arc=fail smtp.client-ip=52.101.70.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="WMwqWeDU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GG0+JB6t0x58bHEPa+c23j9oSqLyhrZHXY8ttfcdfefIbWckamXJ6t7r8ksekQMtaMUJKT+/i9Cz6KUruxGXemIojFVNFT2mEI6f0gX/BKDl5CSRGEbalYl0OBxAaIL1V3E7xyXowaswsIGDVLFW6KOE3KW8fWPEQWnq4KpMyFf2ZOmLwMS/bZ1dtOB+wZJNAApcoOS2KoOqI/WsVQXDDEIw75RBJbxwrplYRFo/LZMUD15Xbz18G4zElCKl47wLCTM4UA3Ym7aPl0r+SFY6i7zPEqBZtnmse7v2jybNwQp6IOlsCKKkMcG9H3iZLZR5owE1VETBNNll8HzFDC/LkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MAfCTj2KyQyc1yseMNKmcAowJNNKLGToeK0n0d1F5Hs=; b=Wf07QF8FyKUJGCP8BioL/kg8CtAImgM0Jw6NltElvvyymW2HDx+p0puiJW3cVsrKeYsyk9ap6tWL3YQqFWA6CrLZdTex53lbIFU8GsEtBf4Zea8sgoBUrnYj+oZClYRBax0zWBwG/w2FMeOJBYqS3qqY1DWVhh1xjgcwrXFNpcIRSIViroymTo/fvstGaFEvotHIfSdlEEoIxnPlJovAI+7A2satd745DwAXN67bgTEsxz6Q73MKXPDh84u2aMFva1HtVxG2mz/ewGcsvx/T+jWLG1UW38D/MR0dlii0xI2BpInff1Q4pTcXDgk7S34Nhtf4N3oGcjnP6lseKRmYpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MAfCTj2KyQyc1yseMNKmcAowJNNKLGToeK0n0d1F5Hs=; b=WMwqWeDU6tFD4LIkRqkUn35UyDzwFyPeOulJNc3gHwIowggWIk1bd1PTBZ33oC/H2fOUccQLR39ltHTaKoUul9c6NH8NgcTGlsOQgiZ2MdNItu28PmVkLW7taF7T/XR5ORaA5+TmJa3OdANqSEj+sr/7lOCeB1ZVigrSmH9scJX4olieQkbhwRv8HMIJ1HdTirhuAe0jfysT4Cf5yWgX2nvTS6zuHMSY0pYU3n4LZOTLFIte6DhGfNPyhWkfLKHV6b3mi3Mc9G9d9CptAqUEKX1cGCy6DmeQnIGaGyJm3wRCsmmgF/MAysO4mA9cYOjwT/szYt58P2CZ6gutxuY1JA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU2PR04MB8951.eurprd04.prod.outlook.com (2603:10a6:10:2e2::22) by DU4PR04MB11433.eurprd04.prod.outlook.com (2603:10a6:10:5d7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.6; Fri, 16 Jan 2026 16:29:44 +0000 Received: from DU2PR04MB8951.eurprd04.prod.outlook.com ([fe80::753c:468d:266:196]) by DU2PR04MB8951.eurprd04.prod.outlook.com ([fe80::753c:468d:266:196%4]) with mapi id 15.20.9478.004; Fri, 16 Jan 2026 16:29:44 +0000 From: Frank Li Date: Fri, 16 Jan 2026 11:29:21 -0500 Subject: [PATCH v4 3/4] media: nxp: use cleanup __free(fwnode_handle) simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260116-cam_cleanup-v4-3-29ce01640443@nxp.com> References: <20260116-cam_cleanup-v4-0-29ce01640443@nxp.com> In-Reply-To: <20260116-cam_cleanup-v4-0-29ce01640443@nxp.com> To: Philipp Zabel , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rui Miguel Silva , Laurent Pinchart , Martin Kepplinger-Novakovic , Purism Kernel Team Cc: linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1768580970; l=5228; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=ggarBXI8DTznTxxWLsJejWRICilIKfxfUK92ruvIhTQ=; b=h4DyLSO9bA4t8fIdIvuy6pNaQn2mXlCe5LGgBRG7vjyCPXrvyavK5V6DScSrXjWdNFSEhdpOg GFjF0++kubcDWTut+3UVvvz6T/3++hNOZ7FrRQVDM19xBnS1yq0ZIOD X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0127.namprd05.prod.outlook.com (2603:10b6:a03:33d::12) To DU2PR04MB8951.eurprd04.prod.outlook.com (2603:10a6:10:2e2::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8951:EE_|DU4PR04MB11433:EE_ X-MS-Office365-Filtering-Correlation-Id: e1cbf23b-c2b5-4f5a-99e0-08de551c7540 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|19092799006|52116014|7416014|366016|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cjNlWS82YmNyTGZ5SVk5L3dFMWg4R2hQeHRQRk92ZDdsMk4ySDdPSk9oSWZ4?= =?utf-8?B?MVI4NUpLRUx0anlBNW1zY3RNcFlQZkxKWmdtVEw5UHkwWTlsM1IyVlFMWDVC?= =?utf-8?B?VEhKbzVDMlJyd1VXdWFUK2w4L2pvMUJNdVY0dTFIWGE1bVd5ZSs0QVZoSGdN?= =?utf-8?B?Q3pVeWlIdHJpejZ2cUhwMkZ2WE1vZEFwM2hjUGMvcEhNYWkyZlRNSjdlSERl?= =?utf-8?B?UUh6QVhFR2ZNeGtodGFXZjJuNmpvUkpvcXVkcEhSdmpZWGUwWnd3d05yNms2?= =?utf-8?B?cEJLQ3lEb2hvaTBpbkVjUzN2S0ZHQ0k2MjJLN1Q2WmkzcVNrN1pwQWRwZTd2?= =?utf-8?B?VDJ6K1hFNVVHdDh1djYrTUtBUTk3S21SVWg2cXJ4bVY0V3NoajNHTE44VDhC?= =?utf-8?B?S0xTRzFKTzRuQWdIZElaNk5pTWdqakN2UjFVUHl1T0NMcStMaTJFbm15K1Iy?= =?utf-8?B?R2NMWlIwWExzaThaVitTd0djaDVyZ1BDMWZYb1ZJcmRRQU9wYWRBejROeHVN?= =?utf-8?B?UHg0UEt4eERxdE9uanQ0dVlIN3YrZ1FrbzBmMWRxS3NuV0JkTVZmWCtLcGp5?= =?utf-8?B?Ti9DU3o1Y05RRVVvOStZUVJUNGZMK1crdkNYeVdVQmhXUkRPT2Y0TlF3WTV0?= =?utf-8?B?NmpOaUNwMUc1bU4zbWxvME1UbkhsNUdhVzVxYm94SlFJdjhVbER3ZGtYSTBp?= =?utf-8?B?OXNhbXlMY280QVhoU0RDSVVIUlB1dDAwU3F1SmpJbU5CUVdmdW1saGNYK2Nu?= =?utf-8?B?OHdMc1owSC9BdDRDaDlLSVNVU1piZ0ptems4K3JKUWwrRU1oT0UwdzAxMUhH?= =?utf-8?B?a3N4cUNhdHhUd3M5ZFpwN2xUeGtPajdsV3o5bWdtVFRvdG5POWg3UXVZbFZ1?= =?utf-8?B?Z1JPcUFHSFAvakN1cjA4K2dMeU1QZ3pzbmYvWVdieWhSUTdaWHVnUXFGUkZr?= =?utf-8?B?aEZFWDBINi9VVkI2SVN2V1Y1WjRYTGFvbnNDdlZidjQrbzYrVzhQTWFHMG1X?= =?utf-8?B?MDh5WG1KYUJPU3Z3QjZTelFLYUFRaXdLaHFXQzBtdFI5MGNRK2ZhVThIaUZQ?= =?utf-8?B?Q2hwNUpvSmRJWXIxWTErQnF6alVYQkJGMzNnQXNETzFra3RUN1BFL2RFbmpr?= =?utf-8?B?dXd4a01TeW90cEk3UWxhVGdIUms0ZDYvSDk4OCtFMzFlYnBkcmZSMVhZaVJh?= =?utf-8?B?ZkRjVk1IbnBNNG02SjJNYmltdWI3S3VldVhXY0ZCM3JGTzY4dHV4OU93RVNX?= =?utf-8?B?MmtyWllRd0l4b242WnJzdlhYdU43a0hjbHRueW1YdG5iL2g1WEdNYUhoYkhB?= =?utf-8?B?Si9ZUjRxdHhndnRWdjdmZEFTZWF2YnUzcTNOWW5VQUZHL044YXI2WnZFYXZ4?= =?utf-8?B?bWloM0Z1bXJjMHFlRWdQSmxHRjdDM25wc1h2R1RpY1UzR1d6UzBMM2E5Z2ZS?= =?utf-8?B?TmdFZ1JrZXZTa0tFNVdxbGpSejBORXZzeklwdVdCSTI1MDAvZjcyL2lmcXhG?= =?utf-8?B?eTdOYlZpMnhuNTQxVS9MbnJZNVgyVW15RWUzOW9aNzlzNVAwVCtzczBqdG81?= =?utf-8?B?YnM5R0xCVXkxS3pZSXo0YUs5dTNQYThEWkExWCtVQm92eEJ1c1hJTVRLSURU?= =?utf-8?B?VW4xdlNZVi83V1Rod3NlS3U1L2ZRRElZUk4wWDVnZUdzT2NRYW9NTXZBZHd5?= =?utf-8?B?Y1ZSY1FGVFRRRTh2TzlvSGJ5VUhNSTRRSmYyeXVkOE1DNHVIOFBqMFdtcHV3?= =?utf-8?B?dGVVNHFZSnVMaytBVTN2bnVGK2htMVBnL2pWVlNCUVRlOTBrMklxQjA2SEFr?= =?utf-8?B?WWNuQ0lyd0M3WThuZGFTL2lxUUx6TDM5enFOc3g4SnFqZkZzRmlhb3hxUXNB?= =?utf-8?B?c2RBaHByTXpENnBQQ29yNDI4RXdJemdnUEdSbDltR1dOMTJxMGZQYkdwWEpq?= =?utf-8?B?d2lWL25OZTYvZkRyU1U2VFVWTVNXZjdoNUZPVk1KUjZsclZVSHdRWVdNVW1v?= =?utf-8?B?ZkV4WGwzTHppamRBMThJVWlKWk9lTUhoZkh6SUt1b05xLyt5a05kT21obGJL?= =?utf-8?B?TTAxZmZqS0lFMTcwYjNETHVaeERNSGNwVGM2UUNlVnNGSHlRV2JXYmhtc3Fp?= =?utf-8?B?ekZhV0pWaFRxenVHWC9qdFIvTjRlTkNsejlTeTN2RnZMKytKTUFqS0dqTFg5?= =?utf-8?B?YVE9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8951.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(19092799006)(52116014)(7416014)(366016)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUpXUmdpOTZlMS9LSzFxUW1tZEZZSG0yMng0OE9BeXUvUjJSVHlTSHl0Lzcx?= =?utf-8?B?U2tqOU9FQjhjdmloSFBPZUdqQXV6Q3d1MnA4YVFVUjNQSGxDUGxkc2VmUFgr?= =?utf-8?B?bVR0bk5wUUlHV2k1d2kvTUgweGE1MTRPbCtaOTdqdlFrNm1ySE1OK0tCSXhu?= =?utf-8?B?cTlFL1ZXVUhHZElBKyt2d0QvVGRWb2ZLWUp3ZHkwVXVIU2NGejIvRkg0Q3li?= =?utf-8?B?L2wzb1Fob0l0d3BjdEhHcGoxWlJ6YkdUWDJIWVBhUDQ3VGxpTCtIQjFDZytx?= =?utf-8?B?WWRNZmY2b3htQzVPcW9hTFhHU0R3U1BvWE9rNGhsUVRrYUNoUy9IQWU2ZmVy?= =?utf-8?B?T0paUGIxMlRCNmdLTlJMQ3hHWThtd3lrVndoMzZ2Mmh0QlQzL3hKMEVTaWlT?= =?utf-8?B?eVQvMTJFd2czVmJSczJYNi9xdDVSMkRtZm9TOTdqVU94a0ZyYk9LQkI5OW1T?= =?utf-8?B?M3VEek1SL1dsMHdSdytUbGxqa2lpZEhDRXNPMnlLNUVOOGxSY3M3ZFI1OUhK?= =?utf-8?B?R0wxeU42VmJJSGpodUtCUFI0Q1RkYjVSNUhZK2RLeTBPVjkzT0h4T2hqeXNo?= =?utf-8?B?MzhkWGR3QUoyRXltY3hrN2FhdldRR1lRZ2tuYzQvc0JSdnkwZVFEcy94cDFE?= =?utf-8?B?ZytWMlJMY2ZJVW02dzc4UEhsWHdaeGpOME1YcWVJRUpDdGU2UXMrQ1JFM25L?= =?utf-8?B?bnBIbHQrR2dXYUdRV2lVWE5BcWFMaDBvZ2VxZDRteG9hdW83MGg0SFp1ck1a?= =?utf-8?B?dUk0dWxXeFhjQVQwN1o5YXhjNlRiTTBPSjQxMjZqeEhmTWdUTWZKM254QTRW?= =?utf-8?B?ekEwQkVUYW4zdWMyZy94K0VNNFo4T05UTVhwc0hER2xlK1pxbnM4UWhVTG1Q?= =?utf-8?B?Y0ZIZGM1bXRGaExwR0F5NjEvVVdhaEQ3ZHkzdko4d3dRUExTaXdqeG5TT2Fh?= =?utf-8?B?M2FKVUZEUy9LTTk5OGdDdTdic1IzZmxmQW1JTFBjekhMWVgrZ2pIQVRBWWVs?= =?utf-8?B?WVJ1cWJQWUxMbkk4TFRuclE2OHVCNE01VW8vNCtLTnJwSjJtSmpPaGN4Z3NF?= =?utf-8?B?ckRDa2JtNEZEVUViblByN3V0cVpDQ1p0NzMxMDRyUG9vaEZ6Y0p5cUVmcWZo?= =?utf-8?B?K3hrbEg2VGxmSFFrdmxrUTd6VHNWeitoS2xBR3UrSmlramtxblIvcmlTZ1NF?= =?utf-8?B?MkJ3eDJEM0pESnR3SnVYM01KRzZpdGVQQ01KeTNzOE8wT2tpZzU0S014a3Ji?= =?utf-8?B?THZTZmRUbXpibnVwZ3duN2Rsc2l6eVZ1cnBGdW5UMS9IOE8xQURUdUh2L2pV?= =?utf-8?B?TjJDd1d0b2xTMjFvQjhUT3VMNDZnQU9NblduNjREQjJibnN2OFFBc0x5QzJw?= =?utf-8?B?M01DNTBCdHBQclRjckFQNWJ4QlpXeUI1VE1WcnFKRktFbitTZmptcTJTZ294?= =?utf-8?B?UzQrckVpMWdzRXhINURmVWE3S0dFT0t2blV4a2RLOU5jZlpqMlM2bitIbngr?= =?utf-8?B?MVVRREVZR25tL1hqZHFyR05tVS8wWmZJTlN6b3lkUk5KSjlpMWJRbU43QjVy?= =?utf-8?B?d2JKY2I2dzFhUy9WMHV0TmhqNWFNYXo3VmpkbG9TSFRWcWk3cVYyTGphYTlQ?= =?utf-8?B?dm1jb1JMc1RyOXpQSXh6Mis2V3Y0Ny9BclZMeGZYVEkvd3RVcTVuT3czWml3?= =?utf-8?B?VUVBLzhjMUZoeTJJRG9WUjA0TEpzN0JKZ25ESGtpeWtFZVluaHhGdFJLN0R3?= =?utf-8?B?Unk3ZHc5TE9vQ0pIcWQ3K244U2RXTm9vN0xyeXN3bEVHeVk1bVVwTXVKR3oz?= =?utf-8?B?bDIvWG1DNE1sR1A4Q1BURnJJL3gveHg3amJHQ05Hcm52dEx3STYwejRPQjNT?= =?utf-8?B?cE5ISU1PQ2U3UW1JM3lFUm1yYW9NVC9rbFZUN2Rmamk5KzNKUzljcDV4blpE?= =?utf-8?B?cFppcGpmbFp5NjFidFEvd2ZobW1VdHFrNG5YY2RQSFZrUDMxSWJUYytYR1Rx?= =?utf-8?B?OXZ5bnk5V0tSbml2aFVKakFYTmZkeWxWa25GaWtoYnk4bW9TbEJHMTc4S3VY?= =?utf-8?B?a1RpNVlXb1doSVg0cHU1Z0hsSktIQlhjS2ZjaDYwaVRBL0pKT1dXemdpaXdL?= =?utf-8?B?QVBwYTBubndEMkt1aE4zZXIxa0xHazU2ajhaWGoxb1dWT2g1NURpWmYrV3Ro?= =?utf-8?B?WmtwUDBwWVFqR3RBZEVaT0hSQ241STFZNkpFZ1Rrc0ZCVlpGalNTSzJxajlI?= =?utf-8?B?cE5GMVJRVXUzUGhPM0ZhK0hpdGZweDVHV3kyZEVGWFl1NlljM1l0cVBoNjl4?= =?utf-8?Q?3EJfvhEu4xfg28YO0E?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1cbf23b-c2b5-4f5a-99e0-08de551c7540 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8951.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2026 16:29:44.9077 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SOSyA3N9KM+8Wi6Jf9t49OnzECK0yDp6eUvc5jAVs/HurpQgupSk3Wasisu5ekWo3VI8Lq+o9jYkIFJnHUElyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR04MB11433 Use cleanup __free(fwnode_handle) simplify code. No functional change. Signed-off-by: Frank Li Reviewed-by: Laurent Pinchart --- change in v3 - Rollback to v1 version to align guide at cleanup.h. - Ref similar link Link: https://lore.kernel.org/r/20240904044825.1048256-1-dmitry.torokho= v@gmail.com Link: https://patch.msgid.link/20251208020750.4727-3-krzysztof.kozlowsk= i@oss.qualcomm.com 452e0adff2618 Input: iqs7222 - use cleanup facility for fwnodes 52776177d8b7e Input: iqs626a - use cleanup facility for fwnodes 9a540b67a9c26 Input: iqs269a - use cleanup facility for fwnodes cc3b18f9fedec i3c: master: Fix confusing cleanup.h syntax change in v2. - move variable define to top. - remove dev_err_probe() change --- drivers/media/platform/nxp/imx-mipi-csis.c | 25 ++++++++---------------= -- drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 25 ++++++++---------------= -- 2 files changed, 16 insertions(+), 34 deletions(-) diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/pla= tform/nxp/imx-mipi-csis.c index ce93d868746f002c22e2f86b1e0aa84ec1a76061..9a43fd1eb0bcee7ac0c47f28ad8= 9012de45a70d9 100644 --- a/drivers/media/platform/nxp/imx-mipi-csis.c +++ b/drivers/media/platform/nxp/imx-mipi-csis.c @@ -12,6 +12,7 @@ * */ =20 +#include #include #include #include @@ -1349,27 +1350,26 @@ static int mipi_csis_async_register(struct mipi_csi= s_device *csis) .bus_type =3D V4L2_MBUS_CSI2_DPHY, }; struct v4l2_async_connection *asd; - struct fwnode_handle *ep; unsigned int i; int ret; =20 v4l2_async_subdev_nf_init(&csis->notifier, &csis->sd); =20 - ep =3D fwnode_graph_get_endpoint_by_id(dev_fwnode(csis->dev), 0, 0, - FWNODE_GRAPH_ENDPOINT_NEXT); + struct fwnode_handle *ep __free(fwnode_handle) =3D + fwnode_graph_get_endpoint_by_id(dev_fwnode(csis->dev), 0, 0, + FWNODE_GRAPH_ENDPOINT_NEXT); if (!ep) return -ENOTCONN; =20 ret =3D v4l2_fwnode_endpoint_parse(ep, &vep); if (ret) - goto err_parse; + return ret; =20 for (i =3D 0; i < vep.bus.mipi_csi2.num_data_lanes; ++i) { if (vep.bus.mipi_csi2.data_lanes[i] !=3D i + 1) { dev_err(csis->dev, "data lanes reordering is not supported"); - ret =3D -EINVAL; - goto err_parse; + return -EINVAL; } } =20 @@ -1381,12 +1381,8 @@ static int mipi_csis_async_register(struct mipi_csis= _device *csis) =20 asd =3D v4l2_async_nf_add_fwnode_remote(&csis->notifier, ep, struct v4l2_async_connection); - if (IS_ERR(asd)) { - ret =3D PTR_ERR(asd); - goto err_parse; - } - - fwnode_handle_put(ep); + if (IS_ERR(asd)) + return PTR_ERR(asd); =20 csis->notifier.ops =3D &mipi_csis_notify_ops; =20 @@ -1395,11 +1391,6 @@ static int mipi_csis_async_register(struct mipi_csis= _device *csis) return ret; =20 return v4l2_async_register_subdev(&csis->sd); - -err_parse: - fwnode_handle_put(ep); - - return ret; } =20 /* -----------------------------------------------------------------------= ------ diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/= platform/nxp/imx8mq-mipi-csi2.c index 83da050a1dcbad1d41c94de0e352dcafe3f25e62..9d946b68cf59d9f4fb3413fc902= 19efd380d9d95 100644 --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c @@ -6,6 +6,7 @@ */ =20 #include +#include #include #include #include @@ -717,27 +718,26 @@ static int imx8mq_mipi_csi_async_register(struct csi_= state *state) .bus_type =3D V4L2_MBUS_CSI2_DPHY, }; struct v4l2_async_connection *asd; - struct fwnode_handle *ep; unsigned int i; int ret; =20 v4l2_async_subdev_nf_init(&state->notifier, &state->sd); =20 - ep =3D fwnode_graph_get_endpoint_by_id(dev_fwnode(state->dev), 0, 0, - FWNODE_GRAPH_ENDPOINT_NEXT); + struct fwnode_handle *ep __free(fwnode_handle) =3D + fwnode_graph_get_endpoint_by_id(dev_fwnode(state->dev), 0, 0, + FWNODE_GRAPH_ENDPOINT_NEXT); if (!ep) return -ENOTCONN; =20 ret =3D v4l2_fwnode_endpoint_parse(ep, &vep); if (ret) - goto err_parse; + return ret; =20 for (i =3D 0; i < vep.bus.mipi_csi2.num_data_lanes; ++i) { if (vep.bus.mipi_csi2.data_lanes[i] !=3D i + 1) { dev_err(state->dev, "data lanes reordering is not supported"); - ret =3D -EINVAL; - goto err_parse; + return -EINVAL; } } =20 @@ -749,12 +749,8 @@ static int imx8mq_mipi_csi_async_register(struct csi_s= tate *state) =20 asd =3D v4l2_async_nf_add_fwnode_remote(&state->notifier, ep, struct v4l2_async_connection); - if (IS_ERR(asd)) { - ret =3D PTR_ERR(asd); - goto err_parse; - } - - fwnode_handle_put(ep); + if (IS_ERR(asd)) + return PTR_ERR(asd); =20 state->notifier.ops =3D &imx8mq_mipi_csi_notify_ops; =20 @@ -763,11 +759,6 @@ static int imx8mq_mipi_csi_async_register(struct csi_s= tate *state) return ret; =20 return v4l2_async_register_subdev(&state->sd); - -err_parse: - fwnode_handle_put(ep); - - return ret; } =20 /* -----------------------------------------------------------------------= ------ --=20 2.34.1 From nobody Sun Feb 8 20:08:43 2026 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011033.outbound.protection.outlook.com [52.101.70.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C13B396D3A; Fri, 16 Jan 2026 16:29:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.33 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768580992; cv=fail; b=WrJuOOu2W0yN17SZ7AxEGmEVqPZqVbeNKY02E/5WTKHXOfSZ7zVXQ2+d3mV2pK6QUas57x4awSqttb4uEYkf4mTYUKZTAna0yGwDB1V37eIbWlBcuC2i5dT1Lj70Y+ZmroPC4Wlf8B2lrISSjIIIyGDxR3uwIZ6HD/MJ4hveZuo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768580992; c=relaxed/simple; bh=V5s0+xr4FB+C7enMAsRsoO8JlZONnC0dplnnICAkgaE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=AdNFfuzSJ+iziWQwzDY6cCPMsBoBhRcnpC0ejtSihzTXzvgdFiWEoc+i1K2pbkhWfTsfgEN7liARUVaU+8RbASgL+DHBUrrAvQuRbhi4X9Y7Q2KPodwrc0j9V7Y3x1HU/AjA+z4hDleWvlyFyGpxuwsGSwZWn1RJvWlYFwo0Okw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=UgwnJQ5r; arc=fail smtp.client-ip=52.101.70.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="UgwnJQ5r" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nYvbiU9xyuO+o+9L06HCHuxNyVL6mogM1XRInf3UYdPMF2/8WEYSsPFK2iN7z+lQ+1ZYYtMKU3gVBokNNxH/eORmCGO2aQZVkUTiriH/Tj1J7FL6I2aJ1cMQnqzIaoQn1vbg1u8vnT+VVcPXwMxKT03zSSSjpymHZN5uE1f10GGkbq5gT1EIbTnz0xbafmtXZeZh2EA1r5xU38MP/n4SZ0m3HeEUWJdyEDKTAp+gYoB0iA3KY52t2fRltsq9iOdoZm3MGVOGeYDunVXR45E5K9mIyZ8PBguq6PkNQk1+sF2lFpiKO8OBca5WC76l+FA82uiO46HsCSo3GUP8oGaLAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OT8Z2TYJROLREx5o2oyzXBC9PH9tHUMT+3xPPO86YC8=; b=g7vGNNnUlXqfNGWLFMEQ8sudP6+pSw9xM2VV1nQxhyE3OTSvm22tp3k5mEgzenBhAI6Y93Y+JfKtRdUNAbdPbaO0mZy93AkQohtrBjuIMUDtfb4NtYjhQqjR+jElpDScPP1qTby25UWENk7ZXQYFR7emVis9Blhn0P0fqKyxMx3KPbIzW1xSbxR38k9nyRNjolq7VaQgeeD0QgcaXEtT+fir2gUNpN314eh4iTGBhbo3CmSKfTvzR4by52xfKtGVfpsLnWaMFYi4SAMTV6PaQzA2o/6bWu11AinBHomt6b1n63yGtpLGQhkC9M+iawGsO3iahyJmYacmVrIF9lIOkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OT8Z2TYJROLREx5o2oyzXBC9PH9tHUMT+3xPPO86YC8=; b=UgwnJQ5rueCy3F7MluIjI6QhTyaQ2VuJYPjFAd34v/QnAmTySfLvRyniack+b0jOD6Ifekd3sdRCdPk2aQ2ytyJEOTh1I6GPP/dWOnWSTzD2lucNQp6z8c6stlcDFBf63AVm3evmmfNGCGgwXhnreShwqgCeXchHiC63CMtYcM/TLohHzvQfToZ7SmK/DuImjJI4eBK5IpjTac4d+8OnRzIZmeit0XiFjzxcCWcCB2LAk1Q3FUysrktyk0kuPlaYOwBERmsvxcW4GxwDd6npk1dZcCFQbuRkHMwlQV5LExfEwDVf9GnrsF1wdJrnnU97oaf2bjInwNlzONbPPpZ0sA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU2PR04MB8951.eurprd04.prod.outlook.com (2603:10a6:10:2e2::22) by DU4PR04MB11433.eurprd04.prod.outlook.com (2603:10a6:10:5d7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.6; Fri, 16 Jan 2026 16:29:48 +0000 Received: from DU2PR04MB8951.eurprd04.prod.outlook.com ([fe80::753c:468d:266:196]) by DU2PR04MB8951.eurprd04.prod.outlook.com ([fe80::753c:468d:266:196%4]) with mapi id 15.20.9478.004; Fri, 16 Jan 2026 16:29:48 +0000 From: Frank Li Date: Fri, 16 Jan 2026 11:29:22 -0500 Subject: [PATCH v4 4/4] media: nxp: Add dev_err_probe() to all error paths in *async_register() helpers Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260116-cam_cleanup-v4-4-29ce01640443@nxp.com> References: <20260116-cam_cleanup-v4-0-29ce01640443@nxp.com> In-Reply-To: <20260116-cam_cleanup-v4-0-29ce01640443@nxp.com> To: Philipp Zabel , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rui Miguel Silva , Laurent Pinchart , Martin Kepplinger-Novakovic , Purism Kernel Team Cc: linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1768580970; l=5116; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=V5s0+xr4FB+C7enMAsRsoO8JlZONnC0dplnnICAkgaE=; b=yNK415qQ5JA0O/95SMngBnTVPAyeaIqB5Xho3mo4Ic1aA8+OZDq0uqBM+bunHF32xErEUgDAe U4Lq6pOjP6+CeujWtpIP81iK/nx/f81p1u+/36eH0hbj7Cbby8KBXNC X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0127.namprd05.prod.outlook.com (2603:10b6:a03:33d::12) To DU2PR04MB8951.eurprd04.prod.outlook.com (2603:10a6:10:2e2::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8951:EE_|DU4PR04MB11433:EE_ X-MS-Office365-Filtering-Correlation-Id: 8bd43185-5cd6-49fd-b3d8-08de551c774e X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|19092799006|52116014|7416014|366016|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Nm5XMW9zMTJ4WG0zUWlESjVKeTJNVUI4MUM2YXVpSGRtUzNhazZNam1tNUdN?= =?utf-8?B?LzBZOHpBQThhbU1uUW9ZUVVIeVBmNTNqTERtZlhQMkNrSnE1WC80c3phTy9U?= =?utf-8?B?SDZrL3FRWENGb0RXZnRHK3VXMjRQaDBQUmgwTGdiN0FHdDJNK05OTWRTUFRD?= =?utf-8?B?WHRJR0ZVRzB2ZktYejhNMnRtU011bEdKQndwK2pVbzF4bUxZMU4yZVVXLzha?= =?utf-8?B?Uk9tYTZ1MUY5dDFkeXlIL3JhTndFOThLM1BpK2ljV1phd0NTV0o0Uk1GeXND?= =?utf-8?B?aUFLaE5RSjI1NlAxSC8wVWhZOGJJSU1WT1JWbUphSWxFdzJJblhSUGFSL1ZD?= =?utf-8?B?NjBTOTIxa0lnZGxEZDFHbFE2RXFKYndXbVByUjdNZytOVlNFUEtzYmZkbVlm?= =?utf-8?B?UGUxSEd3ZC96UVU1UHUxV2htQllZeGlGTkROM3NEVTlVQlNTZzlHczIvelNF?= =?utf-8?B?c04wUDhJdWhsTWhJMFMxSmNIZG5JZjNPcExaZmRLOXZvaVpVeGFNeXBHdEJW?= =?utf-8?B?MEdjQmhFajVJZnlrd0ZoNUVudkxtc1B0Q0xUTFVoSWFIM3ZIMGJxZjJ5SnVD?= =?utf-8?B?dHZDQ0lldnRMdHRLU2hETmdYdWhaZWU3ZjV1b2NlNERxbkVWaC9hT3ZLK2Q4?= =?utf-8?B?bkEyajJ3UkF3RVVGVFB1V0h6M0V3RjNGU2NxQjRoVnJJUCs2WmxXcWRQbW56?= =?utf-8?B?dktzYTZSdXhLRzV2VGNBRHppaHJjNUlLNVBoUzRBLzFuQ0EwR1BiWldZTEdV?= =?utf-8?B?YXo4UlJobFN1ck1TeGZoYzQ1N2xMUUlJWGJTU0JqNlFtQWFqWWRNalBoczJm?= =?utf-8?B?aTlqcTRUS2t6RkR5VjdVSEJaeGxLeHQybkN6OEc5a3A3VEhlOUlySXUreFBu?= =?utf-8?B?UHFOQ1N4eDVtMGg4SHVkR0EvUlFjdFFXUktpUGxhZ2lPeDFwMCs2RFBVa05m?= =?utf-8?B?SmxvOW1xWFp0RkFoMSt5SEp3R2cyMW1pdVRaNkJnd2FnZGdXNmc1R1QySGI1?= =?utf-8?B?a0VQSldacksreGdnVktZUlIxU3h5UjRpMkw1azJEWHBHZVdtUlo2T2JjcjBB?= =?utf-8?B?c2xvbytPMDBuYkdPZ0VteTZLQlJOaElLNVB3UGJSR21OeDg1RHJ1TzMyMy9m?= =?utf-8?B?cG93ZkN5d05rZDhIME1iVVRPY2lnNVdGci9teDQ5Y0V6cjFVQzZGUWZVUktp?= =?utf-8?B?TEcySi9BOTdhR0JwWlB5S1A1RmlaVGFTQnlYUWYwR1ViTVM4QXB0cU1HaFcv?= =?utf-8?B?dncvZzBZNXF2bk12eUNkSXVYU2tCUHF1RWpiTnVFTVhyVEhQcXZudlJvT090?= =?utf-8?B?YUdqTVNIOVB1Q0lEMnlYcnRxcVAvL1RJNzBjZXNoNEZYRnhndlhXVWFQazhP?= =?utf-8?B?UTBBUjdKRGFBKzZCa3VrSUsrUkdkK0VTTkV1ZXNtbXZhOXlIbXhEd3ptNDNO?= =?utf-8?B?SDhBV3llVXc5d0dKcW9JSHZKQjhOSWdISWtmekc2K1V6VU1wajJ5SEgzZ1M1?= =?utf-8?B?QnMxOHViMVpzYVcyWFBNQnR0Z1RobGIvdWZQbVAvU2NxVVJYeFMzaTE2NmtR?= =?utf-8?B?TGU1b2YwbnNhcDVYL1ZtaThjZHZzQ0dKSlhWZ3ZkWG9BQkNyZkV6OVphN2hw?= =?utf-8?B?NmpGR2JDYzRHZlVTb0k1ZUkycDF1K1g1MjlqVXFkMlgwZTlwbXlOSTV6dE94?= =?utf-8?B?ejFzT2pTc2JaTjN4enpGYlhFVzVZYlRpVlZPa2RJZ0pkZW0wR2xLSWZHR1lh?= =?utf-8?B?cGN2ZXRtcXpCS2pmSWJmZ2kzQVBJQ3poeUFzN2c4MnNhTkV0QVlnNnBza055?= =?utf-8?B?a1o5amxOQmVjQTJYT1RYeEdVSFg1YVd0Ym54NzR2S09hcWJWbEJBT3VUbkg2?= =?utf-8?B?ek9iQW9EQ05jM01taUdRWWJzRnA3LzJLNzFFd3BGMnJnQzlZUi9CQjVTUSth?= =?utf-8?B?SDlRMDZEU3oyYzcrWHFWa0JCZVdDRHA4aVRBT09WeVc0SnFYNUIyTFZGcDI2?= =?utf-8?B?U1diZmhLZHUyc0tGbVY3eDhxY0RXM0MrR0pmS29wMXovYjVQblBOdzhMblds?= =?utf-8?B?MDFrdHpVeE0vdWxkZC9iLzliVVVmNXRmOHdZMGtkUDMySVBHWmpQSHRKZzZz?= =?utf-8?B?a2laQ0hHYi9oVXpVOXdlSHRINU1XYUVzSktRYjRTcThndGlPeWRnQWd1RFE0?= =?utf-8?Q?VDmC8d8ZfDQfLkB4o0Osiz/qTfJZStp0QvXslII8mNtS?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8951.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(19092799006)(52116014)(7416014)(366016)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1M2TVAydm82ZHptdVZyNC9rY01DbUdPTWFhR0RpNnZQWjlqekExcU4vTWVo?= =?utf-8?B?VWYvUzZrb3NQZ1dycldHcy9jbUJOK0RjMDYvYVh3VWhGWUNBdU1mRVc4bVM2?= =?utf-8?B?dklDZlQvTzdMWHpZaEtPSDNKWjYvUWJSRVdFaUpvSVNKMlAvcEI4emtEWFBl?= =?utf-8?B?cERjVWVxUFNpR2hzSGZOTEFjOVBQRHlqQUN5QmJKdlBPOWQ2L1VWc3pHUWVw?= =?utf-8?B?L3dVdUtEYzRCUDAwVW1CWW0zclYyeU5tN0dqOVhNSFkySUlyTnkrWUdFQ2JE?= =?utf-8?B?S0FpZFBIaW9kNjhTeWhtWWJmL2NwU1IzaGY5a3YxNEdWMG81eWN2c1MxTnQr?= =?utf-8?B?NitHaXBtaVZucmNIUnBVZlR5clBVN3puamlWS29qd3dleDhmRUVpMjB2KzlR?= =?utf-8?B?NGlCa0F0eGExR3NCeVFIanpXaVZZZk8waXRxd1BvTDRyN3FNRTM4NUxXbjVS?= =?utf-8?B?NUVySkd3anlIOGRxZWZqZnJOV1lHY1R0eVVSbmFpVlAxaHh6dGx3QndhdXJv?= =?utf-8?B?cDRNWEk0Qkc4NDdEbXdEbjZKUGtlK1ZNVDc0ZnBTbWpQZEhhWnFZS2ZsMGJo?= =?utf-8?B?V3d1c2xUYkhrWlRmS09SUXJrKzlJd2pIUWJrVDhMTGNXZVVZMUxPdW4rc25l?= =?utf-8?B?RHNHdFNRTWNFK05oc1JqVkZXL1VCN2NyTEFIZitLY0RUbmRsc0xKbGdKYUtx?= =?utf-8?B?V1g5WWNBWUowRGlVTCtuV202LzBWUWpDeWtmOEhFWFZPbk5TWlAyVkt5TjZR?= =?utf-8?B?NEo0ejhtNnZ4bXAzMVFwZHRKR2IxZkJYSjdZb0l3Q3ROcVNJOGM0OUE0QmFT?= =?utf-8?B?QUpFOTh0NWxyWDcxTmU0Sk5lMmxlMCtqZzBsN1ZsT09jQUFzT2xaRWNlTmlt?= =?utf-8?B?NmRPMGhRcThmQWNYK1dhZzhra0FzYk1kTXprcnBabVEvbGpRbFRZa3MzeUV5?= =?utf-8?B?K2UvV2N4WC9OWEdXdUF6Ymt2UHhIN2pTQTJrQ3Rlam9PN3pmWHFrcnQ5S2Rk?= =?utf-8?B?S0NwSEVLcXJ1dWZHUjRlUXZZZjU5UkRLRzB5QTFVZS8yZFNpWFF5ZHFBS3BL?= =?utf-8?B?eTdJdm1aSTlwc3BlSUJUZTFRTjVCM09lVFZXVWVMQWVCazBLa3U5ZGEwM0h0?= =?utf-8?B?c2hCRldBOTE2MEVuZFpIQVhwVUNabDMyN0EyZUFIMEh2SHU0czBPeDdFRUZ0?= =?utf-8?B?K2xHOHIyZ0VmWk9aYWdZdjcvTlJ4bVFBeW9wL0dSOG9QS2hqZ0JCN0VtRFRN?= =?utf-8?B?K2VZMUxLMmpqRUVRbm1iVXNsa1U5ZG1VN3B4ODIxT3RWQStqWjZ4STNOUysx?= =?utf-8?B?RGNiMU45SzREUGQzSU96ODNNZW03S21HaC9QZHBKa1BmazlHYUNPbEJQdFI4?= =?utf-8?B?UUdNc3grYmhudlpvcERIdnY0Wnh6U2phcWs2djBObEpzZXhxbmtPY3NWNGtJ?= =?utf-8?B?MHpnKzFvWVRWcnQzRXZpV09rWUFDN3dML0doQVFiS1ZDcEw3bUUvV2ZsWnNs?= =?utf-8?B?SUVsbXVMcXRwVFIwcmVOMG45S1hIaUV2YkdGYXNSRGtiZUFKZnZwMVRDN2JB?= =?utf-8?B?d2ViajBFN0JkMTBzQkZnODFYV0dTT1FadVRFVVF3QXFIWDVnODJRbk1iY3lt?= =?utf-8?B?Ym5rcEptdGdHcWpSTzRIOFFBZEtzK2ZDTHNmcVFibUN6ajBza3Z0TFU4TzN0?= =?utf-8?B?OThaQ0RYd2tRcXJoUWxQcG5ja3lFTXloRGhMeUJWUHYvUnFPMngzK1ByVXZV?= =?utf-8?B?aVdEN0NzREthZWV4OTdJc0VOaU96WUhlY2RaOW9pYVVodnVldzJ2dGNFUWhS?= =?utf-8?B?eDJXTUNGZGFpSGxUY1pDdEhVTGJBeWpKeFNObnNJek1XWEF3enI1SjVaMW1H?= =?utf-8?B?OThYM25rT0wxR2FjVnJ5QlJHNkI2dCs2M2dSMGt4amdERjN6ckRLaFkzSm5m?= =?utf-8?B?QmFQckpjS2FZTDI2YkFQWUsyQTg1a0IrWnJYTFF1d0hUNGViYnVGVXRLTkIx?= =?utf-8?B?UE1zNmwyZ2NKVFN0enlHN0JwTGVsbmFLcmJteEk2VFJWWkh2R3NzMnNqbHkr?= =?utf-8?B?ek9sWGdocnpMS3A1WFR1ZXV1L0lad3ljR2lNK2lPUVg1SDJuMVNLVkYrWTRF?= =?utf-8?B?L2hwRjhDa3Zva0hvNzFKWDdIOVdXS0xtYVV5R2hGTHFTWWRsZVQ3QjNObDNS?= =?utf-8?B?RXhzZUFWRERtNUFlYkd0cU1WOGhFU0p4TlFMODFEeGc1NGZmaEJnMmFGMDFX?= =?utf-8?B?VG05LzdWenZvOHIySXB2YUQzdHNDYXpBYkQ3Y1VjenA2UURsNkE3enJUNmRM?= =?utf-8?Q?PafOf/KICER0SvAQds?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8bd43185-5cd6-49fd-b3d8-08de551c774e X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8951.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2026 16:29:48.3694 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7ANDBOEIGKrAHK3Uu6s6Z+ywzPwAZzAWod1XmaRSCYQcFQ9JuWht5pe//svhyUCS5ZRpZPCNzGnQ2lklz25IBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR04MB11433 Add dev_err_probe() to all error branches in the *async_register() helpers to provide clearer diagnostic information when device registration fails. Drop the explicit error message after returning from mipi_csis_async_register(), as the error is already reported by this helper. No functional change. Signed-off-by: Frank Li --- change in v2 - new patch --- drivers/media/platform/nxp/imx-mipi-csis.c | 31 ++++++++++++++++-------= ---- drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 27 ++++++++++++++--------- 2 files changed, 35 insertions(+), 23 deletions(-) diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/pla= tform/nxp/imx-mipi-csis.c index 9a43fd1eb0bcee7ac0c47f28ad89012de45a70d9..85098824f4917b3cda3aa71c4ed= 0a41939283e12 100644 --- a/drivers/media/platform/nxp/imx-mipi-csis.c +++ b/drivers/media/platform/nxp/imx-mipi-csis.c @@ -1359,18 +1359,18 @@ static int mipi_csis_async_register(struct mipi_csi= s_device *csis) fwnode_graph_get_endpoint_by_id(dev_fwnode(csis->dev), 0, 0, FWNODE_GRAPH_ENDPOINT_NEXT); if (!ep) - return -ENOTCONN; + return dev_err_probe(csis->dev, -ENOTCONN, + "failed to get remote endpoint\n"); =20 ret =3D v4l2_fwnode_endpoint_parse(ep, &vep); if (ret) - return ret; + return dev_err_probe(csis->dev, ret, + "failed to parse endpoint\n"); =20 for (i =3D 0; i < vep.bus.mipi_csi2.num_data_lanes; ++i) { - if (vep.bus.mipi_csi2.data_lanes[i] !=3D i + 1) { - dev_err(csis->dev, - "data lanes reordering is not supported"); - return -EINVAL; - } + if (vep.bus.mipi_csi2.data_lanes[i] !=3D i + 1) + return dev_err_probe(csis->dev, -EINVAL, + "data lanes reordering is not supported"); } =20 csis->bus =3D vep.bus.mipi_csi2; @@ -1382,15 +1382,22 @@ static int mipi_csis_async_register(struct mipi_csi= s_device *csis) asd =3D v4l2_async_nf_add_fwnode_remote(&csis->notifier, ep, struct v4l2_async_connection); if (IS_ERR(asd)) - return PTR_ERR(asd); + return dev_err_probe(csis->dev, PTR_ERR(asd), + "failed to add remote fwmode to notifier\n"); =20 csis->notifier.ops =3D &mipi_csis_notify_ops; =20 ret =3D v4l2_async_nf_register(&csis->notifier); if (ret) - return ret; + return dev_err_probe(csis->dev, ret, + "failed to register notifier\n"); =20 - return v4l2_async_register_subdev(&csis->sd); + ret =3D v4l2_async_register_subdev(&csis->sd); + if (ret) + return dev_err_probe(csis->dev, ret, + "failed to register subdev\n"); + + return 0; } =20 /* -----------------------------------------------------------------------= ------ @@ -1549,10 +1556,8 @@ static int mipi_csis_probe(struct platform_device *p= dev) platform_set_drvdata(pdev, &csis->sd); =20 ret =3D mipi_csis_async_register(csis); - if (ret < 0) { - dev_err(dev, "async register failed: %d\n", ret); + if (ret < 0) goto err_cleanup; - } =20 /* Initialize debugfs. */ mipi_csis_debugfs_init(csis); diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/= platform/nxp/imx8mq-mipi-csi2.c index 9d946b68cf59d9f4fb3413fc90219efd380d9d95..b3b9e9dc8a95c76628d573824c1= 2f9391fb7b4a0 100644 --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c @@ -727,18 +727,18 @@ static int imx8mq_mipi_csi_async_register(struct csi_= state *state) fwnode_graph_get_endpoint_by_id(dev_fwnode(state->dev), 0, 0, FWNODE_GRAPH_ENDPOINT_NEXT); if (!ep) - return -ENOTCONN; + return dev_err_probe(state->dev, -ENOTCONN, + "failed to get remote endpoint fwnode\n"); =20 ret =3D v4l2_fwnode_endpoint_parse(ep, &vep); if (ret) - return ret; + return dev_err_probe(state->dev, ret, + "failed parse endpoint fwnode\n"); =20 for (i =3D 0; i < vep.bus.mipi_csi2.num_data_lanes; ++i) { - if (vep.bus.mipi_csi2.data_lanes[i] !=3D i + 1) { - dev_err(state->dev, - "data lanes reordering is not supported"); - return -EINVAL; - } + if (vep.bus.mipi_csi2.data_lanes[i] !=3D i + 1) + return dev_err_probe(state->dev, -EINVAL, + "data lanes reordering is not supported"); } =20 state->bus =3D vep.bus.mipi_csi2; @@ -750,15 +750,22 @@ static int imx8mq_mipi_csi_async_register(struct csi_= state *state) asd =3D v4l2_async_nf_add_fwnode_remote(&state->notifier, ep, struct v4l2_async_connection); if (IS_ERR(asd)) - return PTR_ERR(asd); + return dev_err_probe(state->dev, PTR_ERR(asd), + "failed add fwnode to notifier\n"); =20 state->notifier.ops =3D &imx8mq_mipi_csi_notify_ops; =20 ret =3D v4l2_async_nf_register(&state->notifier); if (ret) - return ret; + return dev_err_probe(state->dev, ret, + "failed to register notifier\n"); =20 - return v4l2_async_register_subdev(&state->sd); + ret =3D v4l2_async_register_subdev(&state->sd); + if (ret) + return dev_err_probe(state->dev, ret, + "failed to register subdev\n"); + + return 0; } =20 /* -----------------------------------------------------------------------= ------ --=20 2.34.1