From nobody Tue Feb 10 05:27:21 2026 Received: from mail-244122.protonmail.ch (mail-244122.protonmail.ch [109.224.244.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A98F0227E83 for ; Thu, 15 Jan 2026 19:20:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.122 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504860; cv=none; b=TwF/MJiPsuvLHbUB8D3w+z/t1kD0YmIAZ4ioxJIdTAIh3UK1pv5H6dFjwyME3gbXHsxvD+4BC2wYWdQTwENlNg2+5ujiTCsn+T2ho/kFZDNr0EbCfZx3sOIqMiiHk48JJHNwBzNEdYUD8t4rV4RSWENF76Oac3cHtE2m0b5SfOQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504860; c=relaxed/simple; bh=oZ2/o4CmQ9PfUSbI98laLaE5VcoE4k2Wn5hbFv3qKSA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cXhgeRe2tdH+ebU4ZwK0Re3PIdp75LYooaE/EmQ5GFk2WtBQY1/PJB1bsZ8m1juHOTt8ecyPcO1pIMhc1EnItDlaVscsNY8DkDV4nAPYMk5Yk3WKlWhuPdIltNp6kUYKHzbqPGCdp2qHcHecFcPflo+/55LrDFhDeYrnZqafozw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=BSP4atJM; arc=none smtp.client-ip=109.224.244.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="BSP4atJM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768504850; x=1768764050; bh=oZ2/o4CmQ9PfUSbI98laLaE5VcoE4k2Wn5hbFv3qKSA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=BSP4atJMsiDHg1R3uZ5QDuVQFHUv9Ov6SownRztjRzBU/Jy5LUD+5Wi329kbDh1D1 mWUbgeREwr6lZhLDai1VyVLoF3+R/81L44CQJkSRA+g71fQJUZD2pb5xLUR1RU5ZVz MM1Bh0gi88JJObtND82Z3hP03X1vDEa+oTVXLPhwtm8NWIpstoeQOQRfK0dXf0i1Qr XJ4LRoOhoQ1FmVp7qQiXtzLKov6djh64/0cSBj2sGSzRXnnwprUiDWztsZt6bDrVL2 kPzVFcdI/zE6XeYFMKgKA6lEspPaQmCABOCvu+Q4mpEaz9dnl5k25qVHk2rPzQ+J/q CSlL53ca3Mfdg== Date: Thu, 15 Jan 2026 19:20:45 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v2 08/12] gpib: hp_82341: Unify *allocate_private Message-ID: <20260115191925.52268-9-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> References: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: b697956e053b13b3e3e7c3cbf8c2984861d06382 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Replace kmalloc/memset pairs to kzalloc. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v2: Replace kmalloc/memset pairs to kzalloc. drivers/gpib/hp_82341/hp_82341.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpib/hp_82341/hp_82341.c b/drivers/gpib/hp_82341/hp_82= 341.c index 1a2ad0560e14..4a2440fe160f 100644 --- a/drivers/gpib/hp_82341/hp_82341.c +++ b/drivers/gpib/hp_82341/hp_82341.c @@ -693,8 +693,9 @@ static int hp_82341_attach(struct gpib_board *board, co= nst struct gpib_board_con int retval; =20 board->status =3D 0; - if (hp_82341_allocate_private(board)) - return -ENOMEM; + retval =3D hp_82341_allocate_private(board); + if (retval < 0) + return retval; hp_priv =3D board->private_data; tms_priv =3D &hp_priv->tms9914_priv; tms_priv->read_byte =3D hp_82341_read_byte; --=20 2.43.0