From nobody Mon Feb 9 19:05:27 2026 Received: from mail-24418.protonmail.ch (mail-24418.protonmail.ch [109.224.244.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27E262EBDDE for ; Thu, 15 Jan 2026 19:20:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504849; cv=none; b=i9ZS4Lt1GPGzwScEHxXcmFUO8tyDcy82IE9gJ6L3fzrNOFYrCVJUHu3JAJzv5i7d/fsmfh9N+A3Zt61flXP8ggQgN8V8x8+AC7HX8HYHTnw+Zi7WIXJBTovIPD4RGbfpgdhIFqs50v9yadwUSbkajYpATs0PTgPVWUzsB4NgddY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504849; c=relaxed/simple; bh=iH9cS/xFBtGfTslgJ2Bm5/fCnbKgeaStv67+ULILVZY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aO4wcpFx28wtYH3RKlziO+BseSNnrqpeQRwTPvZGsaePk6kOx9HRQFEX0xgGQbLE1/qtPLLOHe521LbZ6Q7/0G11T7yLe1aKWPsm9G0GdC7RCsF3rqrLW1u9wzSXcetbu1uHwBLwtA47AjcPmx+li1TIcZr/mRnn6H8NwC3faOk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=ndTYmZet; arc=none smtp.client-ip=109.224.244.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="ndTYmZet" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768504844; x=1768764044; bh=iH9cS/xFBtGfTslgJ2Bm5/fCnbKgeaStv67+ULILVZY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ndTYmZetht6CougKO1Nz8WpdED3G4XLZ9ZT0bWXKteHBlgZfPCktv2lvmFTKze46S Zhmny6yKCxMKkvyaZ5fUT3NQ8zuKwGdqvgsjhtW4rPyR1ZihZmmpkhuLGcOGfrlEYb b6+FsS8jbfHPcN6W2qsNe3Iu9zqDCLseQUmbpftjLDrB3qN9y4bOroyYIdowXZQ+DU u/0FKfusvtMKMxoyMq+w6NROzyFnsB21deNYMRu6dJmOG0CwI01w7pVUlBa2n0PRSH INM2GTmoTKsZnc2ssKjNluDaw8rHF1YoDN4U/INu1BIzdsp1/abK6awBpQHYpV1DDG gkQjNeU3Z/Szw== Date: Thu, 15 Jan 2026 19:20:40 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v2 07/12] gpib: hp_82335: Unify *allocate_private Message-ID: <20260115191925.52268-8-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> References: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: f5bec98bffe5f6b915acb4dca50c90ecdce21dc0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Replace kmalloc/memset pairs to kzalloc. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v2: Replace kmalloc/memset pairs to kzalloc. drivers/gpib/hp_82335/hp82335.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpib/hp_82335/hp82335.c b/drivers/gpib/hp_82335/hp8233= 5.c index d0e47ef77c87..871079dd1088 100644 --- a/drivers/gpib/hp_82335/hp82335.c +++ b/drivers/gpib/hp_82335/hp82335.c @@ -212,7 +212,7 @@ static int hp82335_allocate_private(struct gpib_board *= board) { board->private_data =3D kzalloc(sizeof(struct hp82335_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; return 0; } =20 @@ -253,8 +253,9 @@ static int hp82335_attach(struct gpib_board *board, con= st struct gpib_board_conf =20 board->status =3D 0; =20 - if (hp82335_allocate_private(board)) - return -ENOMEM; + retval =3D hp82335_allocate_private(board); + if (retval < 0) + return retval; hp_priv =3D board->private_data; tms_priv =3D &hp_priv->tms9914_priv; tms_priv->read_byte =3D hp82335_read_byte; --=20 2.43.0