From nobody Mon Feb 9 21:37:30 2026 Received: from mail-24418.protonmail.ch (mail-24418.protonmail.ch [109.224.244.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53C5B2F546D for ; Thu, 15 Jan 2026 19:20:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504828; cv=none; b=pWEp2UskeoV8BWS1hVMKQFA+dtf+4d4kcHYLdJCadkYmxmy6lb0L2RkrOLptfLbpGRdg0AjtaHeqF3QK1LBthB96vNMURaoEAosBBNmi7imGLY1Ir9lYfxGVhqw/EzkxNQiEKpArna8iSUySVleQ49EYE3ROONETGC570mPcaiI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504828; c=relaxed/simple; bh=69r6oVwYLdTQ/UQiPRGS0UQsYHOMGFBsQj7kHtHEBE0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AqE2F+qDoRBxY4AaLhEERIDnSnugq9x7b8YNI793UQLL/gypFwHNlx3mKJTBQaymYPMACAAaC9Rh0BgxYGN2kzti7wuadYdFzhfi5eEihxl+mPwPoOhXNz1UmQEp8wB1pz8jwiCEreyZTYEJtcVlcV6JLepjAxSXbMxo2EFhPh8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=d1q1sKXR; arc=none smtp.client-ip=109.224.244.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="d1q1sKXR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768504820; x=1768764020; bh=69r6oVwYLdTQ/UQiPRGS0UQsYHOMGFBsQj7kHtHEBE0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=d1q1sKXRJQXd4JZIXIF6LQZ5HZtlomKpBGrU0gbmOy5QwyXK6cwdOGNCEWWW4vUNb cLRMWkcknjcYZIReQ+cVBrlVw2h1bMr1DOkNTR/DLDHHS4ljCMmBaZRGjXyV5TKT1y h9suIw+zKwOSdyY568ylpQuLK+y8QpYDEq2ERAp0M+u0AMAWgHAudATGUaZSVh/N1f eRn+lwEisSBUndssNZtUEiRdfv8Q5AQC61cjnjly0PQcedHKTbCkCrzqq+MbPmSBbT V3nGmPF3c+1/5NoRFOMNlzY+g0NxtGkSIGhlyVjjQ54mXK/MkKrLEIvSyQ3m2M3+jv LnUE6tDB4yJUQ== Date: Thu, 15 Jan 2026 19:20:15 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v2 03/12] gpib: cec: Unify *allocate_private Message-ID: <20260115191925.52268-4-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> References: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: 13039ba83445e4d11661b5909ffcf7b21cd16d99 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Replace kmalloc/memset pairs to kzalloc. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v2: Replace kmalloc/memset pairs to kzalloc. drivers/gpib/cec/cec_gpib.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpib/cec/cec_gpib.c b/drivers/gpib/cec/cec_gpib.c index dbf9b95baabc..f2bb57352d31 100644 --- a/drivers/gpib/cec/cec_gpib.c +++ b/drivers/gpib/cec/cec_gpib.c @@ -220,11 +220,10 @@ static int cec_allocate_private(struct gpib_board *bo= ard) { struct cec_priv *priv; =20 - board->private_data =3D kmalloc(sizeof(struct cec_priv), GFP_KERNEL); + board->private_data =3D kzalloc(sizeof(struct cec_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; priv =3D board->private_data; - memset(priv, 0, sizeof(struct cec_priv)); init_nec7210_private(&priv->nec7210_priv); return 0; } @@ -239,11 +238,13 @@ static int cec_generic_attach(struct gpib_board *boar= d) { struct cec_priv *cec_priv; struct nec7210_priv *nec_priv; + int retval; =20 board->status =3D 0; =20 - if (cec_allocate_private(board)) - return -ENOMEM; + retval =3D cec_allocate_private(board); + if (retval < 0) + return retval; cec_priv =3D board->private_data; nec_priv =3D &cec_priv->nec7210_priv; nec_priv->read_byte =3D nec7210_ioport_read_byte; --=20 2.43.0