From nobody Mon Feb 9 19:53:30 2026 Received: from mail-106120.protonmail.ch (mail-106120.protonmail.ch [79.135.106.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69F04285CAD for ; Thu, 15 Jan 2026 19:21:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.120 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504881; cv=none; b=VZ+W6roxQs8FQyKSUH/hlW2+91Mk8AZY4XQtqU4NyR1Ygx4yrhQ1DtM35OVtBbk/LCqxKJZdI6ho0CkKobu5ohcBOy1tvbI6DMzumnnEg5D42Wwp2qqGC2BcK1MIJhnbBwatoZFxNqFs8m6t4Kssus8gTBb+P7n+n+w70DR/t/U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504881; c=relaxed/simple; bh=hCfrS+f8pTonIineyB/oYTMYtgCSrYmGS4kWwXF+Ft4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CMk19wLPSNxSp3hrkWd0vrfk46Wxpd0Fuco8lZMRhe0ogZdhgHBUNty80ILy9h7GiJ/lcVCXsGIG4l0YkQN8sVknj2730i/LER2CvusH4FKxS7fn/Zu7WEL43rE2LkQ++EoPByjlq96z+OiCx+4ymQ/3GC1OqdhW2sfarB6xrOI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=ZnLeKlfq; arc=none smtp.client-ip=79.135.106.120 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="ZnLeKlfq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768504873; x=1768764073; bh=hCfrS+f8pTonIineyB/oYTMYtgCSrYmGS4kWwXF+Ft4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ZnLeKlfqPgE3Jhw5N0HWtb505QcmhUY+n2b7ZNVaoQW8NbTLt9Ib7WJNVfkMu9sS2 c0XRA0mTyU1lJDLWIWCrKCTaZAmHoZeBRu0PDPpZoVnBfM3/VIvrUdKz4zsIlSFUYo vE3mGdIla17cAg/hJDb/dmJlj2gxda7QWo3kh6gvZebQhd4Zi5lrgOA4AzEp0S9OjX VIzOE4vOdU5uaCpZcU0U2sByKP5gI7LFkkYDz5h1hlme0uRkq5Prv8fGaYapELN0u4 Jk3lknocdwiTQ0jZwMmsy9XTUASptu0RiT9sTRKMCJtwghm4oz7ZSof0CfIf19SaYE OVreeqmeI7I8g== Date: Thu, 15 Jan 2026 19:21:06 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH v2 11/12] gpib: pc2: Unify *allocate_private Message-ID: <20260115191925.52268-12-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> References: <20260115191925.52268-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: 8e61838ed015b313a1db2669c1d2f45ed714f6bd Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Replace kmalloc/memset pairs to kzalloc. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- v2: Replace kmalloc/memset pairs to kzalloc. drivers/gpib/pc2/pc2_gpib.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpib/pc2/pc2_gpib.c b/drivers/gpib/pc2/pc2_gpib.c index 9f3943d1df66..11ba9ee1b6f8 100644 --- a/drivers/gpib/pc2/pc2_gpib.c +++ b/drivers/gpib/pc2/pc2_gpib.c @@ -237,11 +237,10 @@ static int allocate_private(struct gpib_board *board) { struct pc2_priv *priv; =20 - board->private_data =3D kmalloc(sizeof(struct pc2_priv), GFP_KERNEL); + board->private_data =3D kzalloc(sizeof(struct pc2_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; priv =3D board->private_data; - memset(priv, 0, sizeof(struct pc2_priv)); init_nec7210_private(&priv->nec7210_priv); return 0; } @@ -257,10 +256,12 @@ static int pc2_generic_attach(struct gpib_board *boar= d, const struct gpib_board_ { struct pc2_priv *pc2_priv; struct nec7210_priv *nec_priv; + int retval; =20 board->status =3D 0; - if (allocate_private(board)) - return -ENOMEM; + retval =3D allocate_private(board); + if (retval < 0) + return retval; pc2_priv =3D board->private_data; nec_priv =3D &pc2_priv->nec7210_priv; nec_priv->read_byte =3D nec7210_ioport_read_byte; --=20 2.43.0