From nobody Mon Feb 9 16:32:56 2026 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 313923C198E for ; Thu, 15 Jan 2026 18:14:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768500885; cv=none; b=nVoRGZNmNgDjr+iLfzWHikTpBUgON1U7giuE7xQe9iAYkR8w/pHYyRYzjq2rChk0GxExiMc1Vb4oH1gOUfrqe1thXdLMElyKPGRov7FM8JPqIw4KqlDDsfLS0tFAb7ef+Cngzl3AajFlPvxKXlQxDbfkzbm2IXIVg/yy22Dr2QM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768500885; c=relaxed/simple; bh=LzRPZjYTn14TUdyU+riMBqe259RejDqvfONwi1Pg3LM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Wa2HrkksOV0yL66dHU0M3JQ5yFF57SV74apGFaebk5201Q3tnGUnBQgRGIzV6TxzsDFHKeTHkRRT71PR2pDnlKVHuFe3JYZ78/DgBN9SsUzUrm/cSAR460CFeScG4BEmEHh+FoZZWCPY6C2+xF67SRU3+qecznCsYM5B6eTZL/k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YwDPQKcn; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YwDPQKcn" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-792815157f3so12684937b3.1 for ; Thu, 15 Jan 2026 10:14:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768500883; x=1769105683; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Fl1lTXpbNrtiLn0Tp+FPt+QeDg7+SN/+cxlb4rbkB8w=; b=YwDPQKcnmdO4kiZvD5XDA56MWE4gQzsMOkpBeGXukIzX5Wqpqrgj8OoFiWA2hOivGb 9qggbRS1/nOey6UOOa/2hqsVzTFWuSQw2RWUWjGP2kKyzgYw7IN63Kgu0mjo66/jd+m0 LXGynjEbrmhzSlsIMRT/yu1TzcV4vim/67HKbJIV6ibTVQUCZ0IPJJlXID0jzJM1YaAB lLeolxUNpLMVHBzwChNqPaUkZB89SNfgiBj7pz1c0Jz23elWULYYKX64tp3JH3XngaZg IKIsFIeldzbIQBpHCSmB/Ut88jHFqgULZGDkjXTclc+yk9pqP/Sm44YWYiHfgVlGSUs8 7GMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768500883; x=1769105683; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Fl1lTXpbNrtiLn0Tp+FPt+QeDg7+SN/+cxlb4rbkB8w=; b=g7dv4O0XXAbZMkk/GscUi/KodYUSHIiXumXVGq0fFSBGWPLzVnYPnjHiGh7uPOEASb bsLQI3eGbJzB4+3wSLMoYVAAtmeRi6YJAhi5u+NimcopUS2Sjo2OjwIcc5DfNSfaEuEP gG+PngCycP1D7gYJfz329RblKlOw0zmgdxXiEQ6MRCx63Nry2SZn/4Fd9fWNECz6T9R7 Z6uQiXK30OflVbZ4tBI4kLi4q45tVxhuT65+K/FrHFzV2rd8YLjag5W+pp7TzctIoJkK nrGo5nH5u2HW3SYnPW+P2pfydIz8vKMPiR2lYoyGUu31O+7th10ZAXZsLJOL1FYwj9Jb Bcxw== X-Forwarded-Encrypted: i=1; AJvYcCUde8iJmVARMg9oOgTsjgafE6jiA8MCEaB4cWbfA6TkUobUReqygBTea4/W2Q47TPR9IklEfhleV0zINbI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7Z9Iye4BQE0tr0CkdnQ9DTpsAly2RIVkrMQQP7842pAcgWYVw AsZrw++nak/HjdrV+Elhm0YLqqZk2Qa+nPhG5Ixtx8hBGasu1HUqAlsJ X-Gm-Gg: AY/fxX4LC9jx/nHQv5C+GY9ADGsmzZ6V0ZCCRvMuQ14VzixRlDIBWZN1oWQEeUjMl95 pklvaHWbJLQYgqe17LFHXUPyMirN6CzALXf6QHnXAsMcY/FRcl5ZVXnJz2IRcpuY6MedcFPUqH9 H1rPkxHsNBRgH6xd2J/m3VdJQ2pCyfiooZWFjCw1B8TZlC17IhwGUWUEUpRBi9jpNc7P7/j/X2p esoVo/LRJe9wxaKLYIXDvrt18hUqy0hroYG0crAphM6+JVhZIPKftC7XjtPBK/uB8OjIl85cQZ4 eZsSU2xaLjUnhbMPvGvtoIzSlFAeiSGynWMgVtOT7MeRIRxql/OEVKg68GcKlGJqcKiAcrFPRib iyHQmguFYa6KHkObtm3TKl6SxcMkS6dSDXDH/n0E5m0z04OVQ8c6ZeGizIXNqh6PDRRtKXy/k/j Z1bySy3XFMqg== X-Received: by 2002:a05:690c:39d:b0:78c:fd6:6c11 with SMTP id 00721157ae682-793c6701158mr564687b3.23.1768500883222; Thu, 15 Jan 2026 10:14:43 -0800 (PST) Received: from localhost ([2a03:2880:25ff:57::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-793c66c726dsm206407b3.8.2026.01.15.10.14.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 10:14:42 -0800 (PST) From: Joshua Hahn To: Andrew Morton Cc: David Hildenbrand , Muchun Song , Oscar Salvador , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 2/3] mm/hugetlb: Remove unnecessary if condition Date: Thu, 15 Jan 2026 13:14:36 -0500 Message-ID: <20260115181438.223620-3-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260115181438.223620-1-joshua.hahnjy@gmail.com> References: <20260115181438.223620-1-joshua.hahnjy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" if (map_chg) is always true, since it is nested in another if statement which checks for it already. Remove the check and un-indent for readability. if (unlikely(map_chg =3D=3D MAP_CHG_NEEDED && retval =3D=3D 0)) { ... if (map_chg) { ... } } No functional change intended. Signed-off-by: Joshua Hahn Acked-by: David Hildenbrand (Red Hat) Reviewed-by: SeongJae Park --- mm/hugetlb.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 88b9e997c9da..432a5054ca1d 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -3019,13 +3019,11 @@ struct folio *alloc_hugetlb_folio(struct vm_area_st= ruct *vma, =20 rsv_adjust =3D hugepage_subpool_put_pages(spool, 1); hugetlb_acct_memory(h, -rsv_adjust); - if (map_chg) { - spin_lock_irq(&hugetlb_lock); - hugetlb_cgroup_uncharge_folio_rsvd( - hstate_index(h), pages_per_huge_page(h), - folio); - spin_unlock_irq(&hugetlb_lock); - } + spin_lock_irq(&hugetlb_lock); + hugetlb_cgroup_uncharge_folio_rsvd( + hstate_index(h), pages_per_huge_page(h), + folio); + spin_unlock_irq(&hugetlb_lock); } } =20 --=20 2.47.3