From nobody Tue Feb 10 19:16:17 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F26D33D523E for ; Thu, 15 Jan 2026 17:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768498208; cv=none; b=BlBnOAZxhV3fj7g+NJTZZ1DVC8I0hqYze68vREYCTWIUY4+av/ISfHvKmEmUnmyd1kXAaLwObyQrO8aJX5Cs/36EJ4ygM4hC7U6GrJio36PBDMl3APMHfVmInFfrRFuL9acGbeZWZUCdMAUhL0rFHd/5Cw2Z3QwO03RGDhl//ZI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768498208; c=relaxed/simple; bh=pcZuVBEpKHuMkiFAbHRlsLm6TtFLtJutf7CGGP8HEhs=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jFKVq0iGUUiJ1NlOc4R/yPeND4+a35DxIchSijHVjRablqUuhNIXds19PEs+g65oySO/XF5g4Ksd0c6Pvm7zP5byAkf6fZ3fD9E5wYJxO59ftIGnKZbYDcG7FEkIJOQUJnn4kXON2+EvaA2v+X0nPJkL81x5IB13Jd518boSFac= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NF+WwPYU; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NF+WwPYU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768498206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uPVrOWC176arGNNcGQ7j00oHxNfVI2h958WatvwkW7A=; b=NF+WwPYUu+Wfr+qsoZ9W5v7PkJIKMkSvwoebkz9GgeoJOMseYKrtP6Ippuyq+0A0nzYeGX KPET5OBX8yugoL2TFXvfEzqxzevDE4qm+teKGa/EJfGMlWT/pISzHCygfHSq434Um80NAf KU/slBTqdQDYDMw7bj0RV7kUl+Oa3jw= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-30-xfMwIAJhMiSF0A-W9h2tGQ-1; Thu, 15 Jan 2026 12:30:02 -0500 X-MC-Unique: xfMwIAJhMiSF0A-W9h2tGQ-1 X-Mimecast-MFC-AGG-ID: xfMwIAJhMiSF0A-W9h2tGQ_1768498201 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EE91919560A3; Thu, 15 Jan 2026 17:30:00 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.64.87]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C874918004D8; Thu, 15 Jan 2026 17:29:55 +0000 (UTC) From: Wander Lairson Costa To: Steven Rostedt , Tomas Glozar , Wander Lairson Costa , Ivan Pravdin , Crystal Wood , Costa Shulyupin , John Kacur , Haiyong Sun , Tiezhu Yang , Daniel Wagner , Daniel Bristot de Oliveira , linux-trace-kernel@vger.kernel.org (open list:Real-time Linux Analysis (RTLA) tools), linux-kernel@vger.kernel.org (open list:Real-time Linux Analysis (RTLA) tools), bpf@vger.kernel.org (open list:BPF [MISC]:Keyword:(?:\b|_)bpf(?:\b|_)) Subject: [PATCH v3 17/18] rtla/utils: Fix resource leak in set_comm_sched_attr() Date: Thu, 15 Jan 2026 13:32:00 -0300 Message-ID: <20260115163650.118910-18-wander@redhat.com> In-Reply-To: <20260115163650.118910-1-wander@redhat.com> References: <20260115163650.118910-1-wander@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Content-Type: text/plain; charset="utf-8" The set_comm_sched_attr() function opens the /proc directory via opendir() but fails to call closedir() on its successful exit path. If the function iterates through all processes without error, it returns 0 directly, leaking the DIR stream pointer. Fix this by refactoring the function to use a single exit path. A retval variable is introduced to track the success or failure status. All exit points now jump to a unified out label that calls closedir() before the function returns, ensuring the resource is always freed. Fixes: dada03db9bb19 ("rtla: Remove procps-ng dependency") Signed-off-by: Wander Lairson Costa --- tools/tracing/rtla/src/utils.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/tracing/rtla/src/utils.c b/tools/tracing/rtla/src/utils.c index b029fe5970c31..1ea9980d8ecd3 100644 --- a/tools/tracing/rtla/src/utils.c +++ b/tools/tracing/rtla/src/utils.c @@ -362,22 +362,23 @@ int set_comm_sched_attr(const char *comm_prefix, stru= ct sched_attr *attr) =20 if (strtoi(proc_entry->d_name, &pid)) { err_msg("'%s' is not a valid pid", proc_entry->d_name); - goto out_err; + retval =3D 1; + goto out; } /* procfs_is_workload_pid confirmed it is a pid */ retval =3D __set_sched_attr(pid, attr); if (retval) { err_msg("Error setting sched attributes for pid:%s\n", proc_entry->d_na= me); - goto out_err; + goto out; } =20 debug_msg("Set sched attributes for pid:%s\n", proc_entry->d_name); } - return 0; =20 -out_err: + retval =3D 0; +out: closedir(procfs); - return 1; + return retval; } =20 #define INVALID_VAL (~0L) --=20 2.52.0