From nobody Sun Feb 8 07:07:21 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9932C2C0F97 for ; Thu, 15 Jan 2026 16:14:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768493675; cv=none; b=tI5GkDeJKfNg4fiPAw4ok3sak/GASl/OGllqNExJbkqxaQmYVHfxbQjeXGaRMh6d/GRAyqUU5Syj6R1ASo5iKa6ClbBnXlcF9ZWdps2uX27yJTtet+zwqEUtADzsEqBQXp0MLoOVDXdClF20ROhC4wD4p5F7KZLQ9Z4DK+zIBJ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768493675; c=relaxed/simple; bh=SG3gAxX5uI+mYJaZB/DrI4rghX4E5GArwv5tjfHImdQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=B1mzxaZpC5vEeSIZYqkNkjP3XtmUn6pTemg1SiTI5rt4VUipfVLHrJo2XSOnIUSEDGjIL4lfllxchSgFE53rhRAeZhSHFSzLEBQSIyMehL7O34l+vrDkpjG43UM85RztZgbctHIKwH5RRuw0keV9mRu8YaTVXp0lZ+E6C1RWpJc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eLWtmKU5; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eLWtmKU5" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-81ed3e6b8e3so531019b3a.2 for ; Thu, 15 Jan 2026 08:14:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768493674; x=1769098474; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WdzhQdQCCI8sk1ft08ExROcFhbamaZZ8QCwzd3zvMZU=; b=eLWtmKU5ZFQplXXEeZ1OOHCPzgk10s7GNurSHAnk0GoQAyyIm+0sCr5z2l78367/wL cVoWGjU1BoWN9p0H6uCHFGqscqpOmspAoa1zkk42PuHLguBIVzkWj8dNGKtLSn8X+vOK 6V0EJQSMZC/nlK+1IKpBC3ert6lc4T7od5Tk6hfAUDcgXubb3k7p/nrsH4aq+P5XZwfT HBGRfnkbnjnlEkpOIPLoC8XZvMOlsMlW0PIiH+3W2+C48tTr2RWeiljd9RfpaF8x26r6 CmJt4tmPMeWQP0xHaaCSjsMJ1qSdQLfZw/vzVJaLwuk1ugLkJfEMwC2Py1htsGGZ/JwD A6Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768493674; x=1769098474; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WdzhQdQCCI8sk1ft08ExROcFhbamaZZ8QCwzd3zvMZU=; b=KUhT8Ylnw36E1MJNT/yrb3uSWW685B15kWbjIgXKmv5TcVUFk/9VIfQrVEMX9ZAnWI kNtrfyBOwNzBJS7Y0UXXsU2G5yhlrtPQOlTA3lDluoGOJSwBkXUGB/fGFMgho3aWEMOO S/UHLjFzUGT6JCcd2MG4oxMYznnrT4nAZPkW2a4MHiBgUDL/ALLhNVIEhvS8+SU6E3ur 5dAtHfWZlD6oNOzxpmw5yR/XLcqS+JPRNuAEENT1whlFUoUWhJuZJ7BjpArHHDsgRVqs CKStJCDTSvdrikBhfhq5WMsDhVNw/CXta4AOPqJGq8nDX8Gzt6kZli/5PWMyzLVK3FMU hqYw== X-Forwarded-Encrypted: i=1; AJvYcCVjbD+dT1WguhBC2Jqvtl9T2S7fz06yjFOCM0yQSqZkT73uMvbzTUIBxt+Yn0d5SgX7L2t44pFPzAzlGnI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6XehdSwzY2k0msaJVkTqvt21xfjXIISUEBQgZWaa8uzeAjpV0 Dy/uRXaHvAmqk2HOW0vUPYwiCWESPdie+HhkOHPLAXBjXHmGkjcYN065 X-Gm-Gg: AY/fxX5pBFa+PkalIrG/WCrP/qBKLzrNdL/W5TiFhNUP9eyoM+P1wZ4euKEqN+ffIxn bqZPN7EE3hbigLxfxKyiUS4RnxSncwHxVQwOmZR00neXE2ruuYWj07KjjygFIR0yqZNTHzya/hW 06CQ+W4rc9oLS5ZuKXZqCkqA8hEKZQKafG87DSBvHuqZ/mXbRpj1SLxYLQM8WaBzXqGyS99LJ2u pd3hI0UuAiFTGGhpFXup4owEb/iUIY9MsE/xAtqSERndl6d0xw9D9Li4uYvEy2jTAK56jkhQNmP W7dX3Q7eOaiDF1b5B6L5+40j3Nwp03edflI4VWI/0ru4omgKXLsZ0u7p80xFiQ5BjP2vYgXKlCk 6bFaZt791MEv9UbMwmzydsMvAx1WEpYlAEvlAI2frEGf5wUmr5gwOT3CSrfyw+Qxlc9DAs4ZJMt xwCvCZdP5qBLlkOKlvocXJ0S2+zVmQOyncnEyFDNH+3vOUh+dhu6gfad6L488IUF59TsQ0zScGK D+4 X-Received: by 2002:a05:6a20:4322:b0:38d:e6f8:fd8c with SMTP id adf61e73a8af0-38dfe79c2b3mr238022637.67.1768493673828; Thu, 15 Jan 2026 08:14:33 -0800 (PST) Received: from localhost.localdomain (118-170-250-134.dynamic-ip.hinet.net. [118.170.250.134]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81f8e6a972dsm2873476b3a.61.2026.01.15.08.14.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 08:14:33 -0800 (PST) From: Hsieh Hung-En To: Mark Brown , Liam Girdwood Cc: Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Hsieh Hung-En Subject: [PATCH] ASoC: es8328: Propagate error codes from regmap updates Date: Fri, 16 Jan 2026 00:13:59 +0800 Message-Id: <20260115161359.41979-1-hungen3108@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In es8328_hw_params(), the return value of snd_soc_component_update_bits() was ignored. This could lead to silent failures where the hardware is left in an inconsistent state if a regmap write fails. Check the return value of regmap updates and propagate any errors back to the ALSA core. Return 0 on success to match the DAI ops convention. Signed-off-by: Hsieh Hung-En --- sound/soc/codecs/es8328.c | 34 +++++++++++++++++++++++----------- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/sound/soc/codecs/es8328.c b/sound/soc/codecs/es8328.c index bd74e896d602..38340f292282 100644 --- a/sound/soc/codecs/es8328.c +++ b/sound/soc/codecs/es8328.c @@ -461,6 +461,7 @@ static int es8328_hw_params(struct snd_pcm_substream *s= ubstream, { struct snd_soc_component *component =3D dai->component; struct es8328_priv *es8328 =3D snd_soc_component_get_drvdata(component); + int ret; int i; int reg; int wl; @@ -494,9 +495,12 @@ static int es8328_hw_params(struct snd_pcm_substream *= substream, es8328->mclkdiv2 =3D 0; } =20 - snd_soc_component_update_bits(component, ES8328_MASTERMODE, - ES8328_MASTERMODE_MCLKDIV2, - es8328->mclkdiv2 ? ES8328_MASTERMODE_MCLKDIV2 : 0); + ret =3D snd_soc_component_update_bits(component, ES8328_MASTERMODE, + ES8328_MASTERMODE_MCLKDIV2, + es8328->mclkdiv2 ? + ES8328_MASTERMODE_MCLKDIV2 : 0); + if (ret < 0) + return ret; =20 switch (params_width(params)) { case 16: @@ -519,18 +523,26 @@ static int es8328_hw_params(struct snd_pcm_substream = *substream, } =20 if (substream->stream =3D=3D SNDRV_PCM_STREAM_PLAYBACK) { - snd_soc_component_update_bits(component, ES8328_DACCONTROL1, - ES8328_DACCONTROL1_DACWL_MASK, - wl << ES8328_DACCONTROL1_DACWL_SHIFT); + ret =3D snd_soc_component_update_bits(component, ES8328_DACCONTROL1, + ES8328_DACCONTROL1_DACWL_MASK, + wl << ES8328_DACCONTROL1_DACWL_SHIFT); + if (ret < 0) + return ret; =20 es8328->playback_fs =3D params_rate(params); es8328_set_deemph(component); - } else - snd_soc_component_update_bits(component, ES8328_ADCCONTROL4, - ES8328_ADCCONTROL4_ADCWL_MASK, - wl << ES8328_ADCCONTROL4_ADCWL_SHIFT); + } else { + ret =3D snd_soc_component_update_bits(component, ES8328_ADCCONTROL4, + ES8328_ADCCONTROL4_ADCWL_MASK, + wl << ES8328_ADCCONTROL4_ADCWL_SHIFT); + if (ret < 0) + return ret; + } =20 - return snd_soc_component_update_bits(component, reg, ES8328_RATEMASK, rat= io); + ret =3D snd_soc_component_update_bits(component, reg, ES8328_RATEMASK, ra= tio); + if (ret < 0) + return ret; + return 0; } =20 static int es8328_set_sysclk(struct snd_soc_dai *codec_dai, --=20 2.34.1