From nobody Sun Feb 8 16:05:23 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C676634A791 for ; Thu, 15 Jan 2026 15:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768490642; cv=none; b=c0z0xMO6snBw2BVOHzzHDuAiZ6+39iKHsQrH+E2zsv3CwJlj0ykpgCsuXRd5pX/6UxHhuPLpdKFArpP9dOHvgkrcu3bkSENvGp9axRWwGjct6dL5AaPQbewQlziorVklAEzARetT9jRAqs2d5S8THXJosMZ2DiE4RKrYfwpZNxI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768490642; c=relaxed/simple; bh=kVWTYXzyEGu6bSvDdHUv5uwSixy3sg1Dshdh2TcYYyM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Tb09jDlXCyp2cTxxnCCDoqv5LrdjE82wmCOTS0XXuWYLfNj4MIatDwE/WYZjAJD1sgUQQH+dGWS/oQnInwTLrweTND6SS0xbu1bFDglHwfr68Y45InFF3hDrb0podA2aFJwl+9gwF16JUS8N2yTaQjqQ3V/0KMvwPKGkB1whAPE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jBz4zb6j; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jBz4zb6j" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2a110548cdeso7421835ad.0 for ; Thu, 15 Jan 2026 07:23:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768490631; x=1769095431; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ipChp6LQHB81vcBQdiF035Fn4p4lIhN+JvMnabyrpEk=; b=jBz4zb6jvs6kkxjF8Vx0Gdt5B8yjwkExcarUOtuiSUkcVoftWpdLt4T66XZrtrgGu8 S91sQ0Ifh7w0Az+ddN4PS9pAhDIXdGqDLbPktc3b9hOiXYKpe4INHvqbr6FlpEFVUgE+ 2l2az+qVuQcxR5p7Z8PhGck5LmVm6XMpGoIh4sfRtFCQ4hdA11DCzJoYVtmwPWQ3HC+i tTnvBGXEHxh0CM5U+IBH/7S/+DYLy4DqS33Rtk4ObPahrTx53L9fdHjYh9n+MVTicpKx tERyCs12wo+anYC2dyOZMqwuYIdrL7kehoBwWIi8k0Z2P1rNvGN40LLTJEenVALSqVqh z99Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768490631; x=1769095431; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ipChp6LQHB81vcBQdiF035Fn4p4lIhN+JvMnabyrpEk=; b=Fh1jAmoSOm+5XYaA4qjDws2DSFxqeQVPfjfAsp/7m+kqIVb2kIZwUcFjRdYaAdkCns G1Zxb38eL0PA++K1jz4zrB3ilwbHW2VuTUa9J0HnPhPR8AUpzYstqD3FOniNo0AoVoFR tCDaDTidTZr4W/Nu+eMWXDyqeCYCxSQ26Yv2xTIqoyPU8m3E0aGKC0jnCJBoOxYBygss YmK1+P1IWg3AMjTCTRsZq5RrgQG2QFKukh1sgiwE26AliXN7KNwQAkZ4D7jBD1R5zAFU DG3Dy6XZ0shTtKtaTXa8OC2nuUahHni8+Lec0XwNsOfFjbTtGLu9wirMZr4+0wXP3NfY PzeA== X-Forwarded-Encrypted: i=1; AJvYcCWg2/zzqC2mBpf/A19kBFOSfVtyvKXQ/UxEjCfqIUk6jJy/XVxOmj4Y8rxVcYtDkezg+03xWj8zRSH0GP4=@vger.kernel.org X-Gm-Message-State: AOJu0YwA3mNwOqMARWfXx7bdxUkY+DXWaEH0HbfJKZpIQicDwQIdCXvV D7PvKJFRm1xOR4dRqbj5b+o4+YkQPu4vh6yDo29Xk6L3fPakD/8270He X-Gm-Gg: AY/fxX5f6LfNn5Xb8XfBhK0uL7GmyHVr/NLDiv1VzPlImVyY4gcqpqUJnPYo6mFeBIu VUdERN0NDrkcZpsG7oND/zDem+xqbgNkAHv6wiG6orQK2nX8gYQaFi255DrMPN2i6Cg+P6332q6 4+WUiarAUzY1H2S0VIk7P3Llkhyb/19ijogNA+3+aTu4T3i+uYsQ3wD4SDNIOlsgy0Vfixb84/y lQx1US6OM0K6dWC2vrLGPTloWLBnFenCw5TBJhKlSLpZVS90D7+BedylCCcWCxM5hw8GZjxnD15 uWqySfm1d5B07ojxTxCOr179tRqGcfZ22ockbob/vEXf8NPBDYirQVJk1A0SvjaVkY/nLXqnJ8N 7WnA8NGF/qggs22x9xK2A29Vi77eVJKDcBIj/OT9MyHOSb2YvTfVFs22PBmzKHWKQOuI1/7d5rY mgbr4BR3o8/ouzhAJJpo2i+qTHOICm+w== X-Received: by 2002:a17:903:22c4:b0:29f:2b9:6cca with SMTP id d9443c01a7336-2a599e47d37mr67248555ad.44.1768490631442; Thu, 15 Jan 2026 07:23:51 -0800 (PST) Received: from localhost.localdomain ([103.215.237.163]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cb2d93sm258213645ad.63.2026.01.15.07.23.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 07:23:51 -0800 (PST) From: Karthikey Kadati To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Karthikey Kadati Subject: [PATCH v5] staging: octeon: Remove port status typedefs Date: Thu, 15 Jan 2026 20:53:27 +0530 Message-ID: <20260115152327.92654-1-karthikey3608@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove cvmx_pip_port_status_t and cvmx_pko_port_status_t typedefs and replace them with struct cvmx_pip_port_status and struct cvmx_pko_port_status to match Linux kernel coding style. This also updates the MIPS architecture headers to name the structs so they can be referenced by the staging driver, resolving the build failure found in v2. In v2, the anonymous struct definition in the header caused a compilation error when referenced in the driver. This patch names the structs in the headers and updates all usages to use the struct type directly, removing the typedefs as per coding style requirements. Signed-off-by: Karthikey Kadati --- Changes in v4: - Completely removed typedefs (Greg KH). In v3, the struct was named but the typedef keyword was retained. Now uses struct directly. - Clarified commit message regarding the robot report (it was a build failu= re due to anonymous structs, fixed by naming overlap with typedef removal). Changes in v3: - Address robot feedback. Changes in v2: - Initial attempt. --- arch/mips/include/asm/octeon/cvmx-pip.h | 4 ++-- arch/mips/include/asm/octeon/cvmx-pko.h | 6 +++--- drivers/staging/octeon/ethernet.c | 4 ++-- drivers/staging/octeon/octeon-stubs.h | 12 ++++++------ 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/arch/mips/include/asm/octeon/cvmx-pip.h b/arch/mips/include/as= m/octeon/cvmx-pip.h index 01ca7267a2ba..1e107a9aa650 100644 --- a/arch/mips/include/asm/octeon/cvmx-pip.h +++ b/arch/mips/include/asm/octeon/cvmx-pip.h @@ -236,7 +236,7 @@ typedef struct { uint64_t inb_octets; /* Number of packets with GMX/SPX/PCI errors received by PIP */ uint16_t inb_errors; -} cvmx_pip_port_status_t; +}; =20 /** * Definition of the PIP custom header that can be prepended @@ -365,7 +365,7 @@ static inline void cvmx_pip_config_diffserv_qos(uint64_= t diffserv, uint64_t qos) * @status: Where to put the results. */ static inline void cvmx_pip_get_port_status(uint64_t port_num, uint64_t cl= ear, - cvmx_pip_port_status_t *status) + struct cvmx_pip_port_status *status) { union cvmx_pip_stat_ctl pip_stat_ctl; union cvmx_pip_stat0_prtx stat0; diff --git a/arch/mips/include/asm/octeon/cvmx-pko.h b/arch/mips/include/as= m/octeon/cvmx-pko.h index f18a7f24daf8..4b83b2171c12 100644 --- a/arch/mips/include/asm/octeon/cvmx-pko.h +++ b/arch/mips/include/asm/octeon/cvmx-pko.h @@ -114,11 +114,11 @@ typedef enum { CVMX_PKO_LOCK_CMD_QUEUE =3D 2, } cvmx_pko_lock_t; =20 -typedef struct { +struct cvmx_pko_port_status { uint32_t packets; uint64_t octets; uint64_t doorbell; -} cvmx_pko_port_status_t; +}; =20 /** * This structure defines the address to use on a packet enqueue @@ -574,7 +574,7 @@ static inline int cvmx_pko_get_num_queues(int port) * @status: Where to put the results. */ static inline void cvmx_pko_get_port_status(uint64_t port_num, uint64_t cl= ear, - cvmx_pko_port_status_t *status) + struct cvmx_pko_port_status *status) { union cvmx_pko_reg_read_idx pko_reg_read_idx; union cvmx_pko_mem_count0 pko_mem_count0; diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/eth= ernet.c index eadb74fc14c8..6d03d23461e4 100644 --- a/drivers/staging/octeon/ethernet.c +++ b/drivers/staging/octeon/ethernet.c @@ -201,8 +201,8 @@ EXPORT_SYMBOL(cvm_oct_free_work); */ static struct net_device_stats *cvm_oct_common_get_stats(struct net_device= *dev) { - cvmx_pip_port_status_t rx_status; - cvmx_pko_port_status_t tx_status; + struct cvmx_pip_port_status rx_status; + struct cvmx_pko_port_status tx_status; struct octeon_ethernet *priv =3D netdev_priv(dev); =20 if (priv->port < CVMX_PIP_NUM_INPUT_PORTS) { diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon= /octeon-stubs.h index 35b5078ba51e..f6d502193789 100644 --- a/drivers/staging/octeon/octeon-stubs.h +++ b/drivers/staging/octeon/octeon-stubs.h @@ -386,7 +386,7 @@ union cvmx_ipd_sub_port_qos_cnt { } s; }; =20 -typedef struct { +struct cvmx_pip_port_status { uint32_t dropped_octets; uint32_t dropped_packets; uint32_t pci_raw_packets; @@ -409,13 +409,13 @@ typedef struct { uint32_t inb_packets; uint64_t inb_octets; uint16_t inb_errors; -} cvmx_pip_port_status_t; +}; =20 -typedef struct { +struct cvmx_pko_port_status { uint32_t packets; uint64_t octets; uint64_t doorbell; -} cvmx_pko_port_status_t; +}; =20 union cvmx_pip_frm_len_chkx { uint64_t u64; @@ -1260,11 +1260,11 @@ static inline int octeon_is_simulation(void) } =20 static inline void cvmx_pip_get_port_status(uint64_t port_num, uint64_t cl= ear, - cvmx_pip_port_status_t *status) + struct cvmx_pip_port_status *status) { } =20 static inline void cvmx_pko_get_port_status(uint64_t port_num, uint64_t cl= ear, - cvmx_pko_port_status_t *status) + struct cvmx_pko_port_status *status) { } =20 static inline cvmx_helper_interface_mode_t cvmx_helper_interface_get_mode(= int --=20 2.43.0