From nobody Sun Feb 8 04:17:50 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CD0A38B7B8 for ; Thu, 15 Jan 2026 12:39:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768480792; cv=none; b=TTURk2J6ROHhgDoETNvXmW3fju4LqBuxhhT7gPL0XjjP7MRm7lqfJyeBrMaHr6PE2AYKKYNzqaWuvUzXe5xTweJJTKfGWl7nOzZUKGKw13QApcUVXjU80wSX+cHro+jR5rmscqeW3pxbZbGYKy27TCl/HS+am3kPoKZCWGopWlc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768480792; c=relaxed/simple; bh=gKAqU+JWfFxMSx4Ys0uzjp3Qev3gJoDn4VvwqP7oNdQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kJ5LWEKCAP9+KflCPYdR8Fpab1hfCoq67j6iB3DWZaIPUfp386IT+9UOjK2rZHWiaY7LYur2S173aQOcOSEQMB2YrNoloObqwgy4ixik0U10sxL9wNQ8Ogdrm9qyFPIUSICOaCp6WezKtXmqH73RrtxnTtGpa69PvTIVUUZzAyk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ctTXEjgx; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ctTXEjgx" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-81e8a9d521dso530087b3a.2 for ; Thu, 15 Jan 2026 04:39:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768480791; x=1769085591; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EG2GU/SfS8q24OqJDu1HCz0B9H6lhX6kcQ5XkWsyYm0=; b=ctTXEjgxuKOaK7/WhnBGYRl8ZCvjXReHB6ePe4BuuRxLf8E72/cS4ZYeTVl7YU/5Yk oDkba5S84ySpsl8QEJffv9f/+eFcwWSrv/cEOOEpTdSI3puQZvcg1AxBo25wFnbBy/Z1 ANJ8IfuQBz2OBmKtAUCJs+G8ul5C39VgoROQE+kX1XgTihM1QHddfTUXzOIIt6atU5/X LGdQNGUJwNr5/bimOnL15b8udSdDWkBKyxVA360TMQgu9PUWWZeq8CkTCJxZqYNi+LQ3 Sp6CHoQnPligfJW7AdI2ED0eQW4YBXJxdUNs5Vgvsia0rnhNK3ietlkjmOJU9bGaOD36 IStw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768480791; x=1769085591; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EG2GU/SfS8q24OqJDu1HCz0B9H6lhX6kcQ5XkWsyYm0=; b=dPmtowl9V18Q+0VNUeZEAe2maL6exLwEhKFCwC/bET++cemiPoeVSePgXYShbfnPjq 0Ct8sYgzEGxwiLS836/63evso8CnB8gX3fjAZm/zBCncmu3lWJY4MaLppsMJPjDc8H0X HtkXW283tZf0GwSaP0IHKosIzOTCow2TpV1GZwkb89KRqSM7Lh+X6ywPJS4UuI9Wu3a3 HQMEE2Koc7HOQjAubGVIexxYIwCLp1wgIrBDpVhdstUSXAemqT2NOky2kELI4/cQ2PCi z4yQHxsBYyJjEc3iGgRrf5+WWmjBnAvpUvHehqTxZsciptrf1g126BWXG5hIVHpNVO66 ByBg== X-Forwarded-Encrypted: i=1; AJvYcCUdOvD3sEQny8gczpoangx7hG9u+weElrFVi8LS8seoVifEL0NmmySNEA1upEJjA7kqGX3g1TshxY9Va9w=@vger.kernel.org X-Gm-Message-State: AOJu0YwJHOlPlRkH/XXVQlXdVr+/gnJEDK90YD1y8yR92EwNVH4nb3dx 3vkBy9HP/dCwyXIj3khLG+UViQK/u8Dw4vge9wVtf+0G56ewQHnYmCbA X-Gm-Gg: AY/fxX4AAuNmSayUd8PBLNcfWgDgU6IksqPLVRusjTc57nxKb67wjf038B50xX4e3tl sxdFWSeBPbGvPrsRTtcgstfY2Y2M1ckK5vGTu+L+STc9tuv5087QC5jMeZdg3m1DXSOZxDATvmy z0uUxI/2T23AFtaCVEAuQIOoWgRMudg254UDu+1lJuHs+qP60OcXJKZfNsHrKQ+DCgNoVnBthJl 5o9XRq9/ml76uoVbNlj1EvcWZEkK/qWC9GecJ+Okb+nDeugZCBIwcWxNa8DEA7oiqmdaM3V9Eeo q9VQPCoXr9iN7v+BpuiuRLKWxddiHCWDaLrMauA0Kq8YZKwZj+6E0Vc3EIgyut8RvoJcCA3koR9 mR6BKJLGlTSqWMyCb0mVqPqGv8r40w0tWpTjF2sQfs0mTFs01+/se2M34s/c55yP6Lmupngc6ra N59jau2g3+HJuT0+0grHy3SB0NVxOcYQ== X-Received: by 2002:a05:6a20:6a26:b0:38d:f62a:a9f7 with SMTP id adf61e73a8af0-38df62aab6emr1179758637.5.1768480790754; Thu, 15 Jan 2026 04:39:50 -0800 (PST) Received: from localhost.localdomain ([103.215.237.163]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c54972a5e67sm18000315a12.35.2026.01.15.04.39.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 04:39:50 -0800 (PST) From: Karthikey Kadati To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Karthikey Kadati , kernel test robot Subject: [PATCH v4] staging: octeon: Remove port status typedefs Date: Thu, 15 Jan 2026 18:09:42 +0530 Message-ID: <20260115123942.83341-1-karthikey3608@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove cvmx_pip_port_status_t and cvmx_pko_port_status_t typedefs and replace them with struct cvmx_pip_port_status and struct cvmx_pko_port_status to match Linux kernel coding style. This also updates the MIPS architecture headers to name the structs so they can be referenced by the staging driver, resolving the build failure found in v2. In v2, the anonymous struct definition in the header caused a compilation error when referenced in the driver. This patch names the structs in the headers and updates all usages to use the struct type directly, removing the typedefs as per coding style requirements. Reported-by: kernel test robot Signed-off-by: Karthikey Kadati --- Changes in v4: - Completely removed typedefs (Greg KH). In v3, the struct was named but the typedef keyword was retained. Now uses struct directly. - Clarified commit message regarding the robot report (it was a build failu= re due to anonymous structs, fixed by naming overlap with typedef removal). Changes in v3: - Address robot feedback. Changes in v2: - Initial attempt. --- arch/mips/include/asm/octeon/cvmx-pip.h | 4 ++-- arch/mips/include/asm/octeon/cvmx-pko.h | 6 +++--- drivers/staging/octeon/ethernet.c | 4 ++-- drivers/staging/octeon/octeon-stubs.h | 12 ++++++------ 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/arch/mips/include/asm/octeon/cvmx-pip.h b/arch/mips/include/as= m/octeon/cvmx-pip.h index 01ca7267a2ba..1e107a9aa650 100644 --- a/arch/mips/include/asm/octeon/cvmx-pip.h +++ b/arch/mips/include/asm/octeon/cvmx-pip.h @@ -236,7 +236,7 @@ typedef struct { uint64_t inb_octets; /* Number of packets with GMX/SPX/PCI errors received by PIP */ uint16_t inb_errors; -} cvmx_pip_port_status_t; +}; =20 /** * Definition of the PIP custom header that can be prepended @@ -365,7 +365,7 @@ static inline void cvmx_pip_config_diffserv_qos(uint64_= t diffserv, uint64_t qos) * @status: Where to put the results. */ static inline void cvmx_pip_get_port_status(uint64_t port_num, uint64_t cl= ear, - cvmx_pip_port_status_t *status) + struct cvmx_pip_port_status *status) { union cvmx_pip_stat_ctl pip_stat_ctl; union cvmx_pip_stat0_prtx stat0; diff --git a/arch/mips/include/asm/octeon/cvmx-pko.h b/arch/mips/include/as= m/octeon/cvmx-pko.h index f18a7f24daf8..4b83b2171c12 100644 --- a/arch/mips/include/asm/octeon/cvmx-pko.h +++ b/arch/mips/include/asm/octeon/cvmx-pko.h @@ -114,11 +114,11 @@ typedef enum { CVMX_PKO_LOCK_CMD_QUEUE =3D 2, } cvmx_pko_lock_t; =20 -typedef struct { +struct cvmx_pko_port_status { uint32_t packets; uint64_t octets; uint64_t doorbell; -} cvmx_pko_port_status_t; +}; =20 /** * This structure defines the address to use on a packet enqueue @@ -574,7 +574,7 @@ static inline int cvmx_pko_get_num_queues(int port) * @status: Where to put the results. */ static inline void cvmx_pko_get_port_status(uint64_t port_num, uint64_t cl= ear, - cvmx_pko_port_status_t *status) + struct cvmx_pko_port_status *status) { union cvmx_pko_reg_read_idx pko_reg_read_idx; union cvmx_pko_mem_count0 pko_mem_count0; diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/eth= ernet.c index eadb74fc14c8..6d03d23461e4 100644 --- a/drivers/staging/octeon/ethernet.c +++ b/drivers/staging/octeon/ethernet.c @@ -201,8 +201,8 @@ EXPORT_SYMBOL(cvm_oct_free_work); */ static struct net_device_stats *cvm_oct_common_get_stats(struct net_device= *dev) { - cvmx_pip_port_status_t rx_status; - cvmx_pko_port_status_t tx_status; + struct cvmx_pip_port_status rx_status; + struct cvmx_pko_port_status tx_status; struct octeon_ethernet *priv =3D netdev_priv(dev); =20 if (priv->port < CVMX_PIP_NUM_INPUT_PORTS) { diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon= /octeon-stubs.h index 35b5078ba51e..f6d502193789 100644 --- a/drivers/staging/octeon/octeon-stubs.h +++ b/drivers/staging/octeon/octeon-stubs.h @@ -386,7 +386,7 @@ union cvmx_ipd_sub_port_qos_cnt { } s; }; =20 -typedef struct { +struct cvmx_pip_port_status { uint32_t dropped_octets; uint32_t dropped_packets; uint32_t pci_raw_packets; @@ -409,13 +409,13 @@ typedef struct { uint32_t inb_packets; uint64_t inb_octets; uint16_t inb_errors; -} cvmx_pip_port_status_t; +}; =20 -typedef struct { +struct cvmx_pko_port_status { uint32_t packets; uint64_t octets; uint64_t doorbell; -} cvmx_pko_port_status_t; +}; =20 union cvmx_pip_frm_len_chkx { uint64_t u64; @@ -1260,11 +1260,11 @@ static inline int octeon_is_simulation(void) } =20 static inline void cvmx_pip_get_port_status(uint64_t port_num, uint64_t cl= ear, - cvmx_pip_port_status_t *status) + struct cvmx_pip_port_status *status) { } =20 static inline void cvmx_pko_get_port_status(uint64_t port_num, uint64_t cl= ear, - cvmx_pko_port_status_t *status) + struct cvmx_pko_port_status *status) { } =20 static inline cvmx_helper_interface_mode_t cvmx_helper_interface_get_mode(= int --=20 2.43.0