From nobody Mon Feb 9 15:25:57 2026 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F2E6394469 for ; Thu, 15 Jan 2026 12:24:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768479879; cv=none; b=X4jSqWcB+7CMU4eRIQ7Wg2hiVJ41qBsIGcFh1fxhiXp0jgW6Hs4uBKnjf+DAvHMjMGElbToT040dE7mPn+/IlKuM/8U+m+vyQv217Z7xDVjY2n3LJjAnbVfrjKnfARbY93dU9shlDzBJsBF95B8zc43+HhZogBPmnqQ/ZMOUYvU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768479879; c=relaxed/simple; bh=aBIjT8HJMfYZDveJouRj4sa520yQuhHwAmIb09eSjwY=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=P5sr0Mh0AjV6BuSttk+Y/a43XfIpMP3kIDSy0+kS5z4QxSrOiNn74QSJu4exTlUerKIPnwE3mWgG1e/H0pyoYmtaZ2Y13mHz30h9J6kDlXiW+1G2gw2XA5HgezXBz3PZt0+SRH2NHzmZaomp0x0JkicO5NreYapPU/jdYqhyBKg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=sAsBEtxj; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="sAsBEtxj" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-64b9d01e473so1502318a12.2 for ; Thu, 15 Jan 2026 04:24:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1768479875; x=1769084675; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=RHmHZviAuhOhpKSUpCtTa1iFHF2rU7EWwgoioRxdGwg=; b=sAsBEtxjry09WtdDoDxsfmtDAFn6srXYSCIuOdt4eci7xEoiRLZ9GP4zch1VobcB0G 9q7bVYfHT6um35uVosex/ppf1++4WakbHSqjE9kvwjQKWpBCPoCUumpf1425ZK65UFSy gQhK6l+YPYp2aNJ2ri+hqOchu9T8KfozfddFlR5qcDGcisvwHfYIHzmtKx8/gD0aDwX/ EW9TeScHNy0yXbp7vrllSwikoKkGuJslDUQfXoWs1nX5ep0ze/cijoTV/q4yAWEiUdEm bMT6KUrJ0eXl5Ws+6TqkKcGql3ilCCRKJIzrBcO6MpHteBrkaFXVSNRYnRB4tS0dZ/1j MxGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768479875; x=1769084675; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=RHmHZviAuhOhpKSUpCtTa1iFHF2rU7EWwgoioRxdGwg=; b=a7X7o9vI9K6qAvphOaZg359h/YZFdsVcEIIE3z8X9KnQZcm/0iVoD7x+5PXEgYn7xU YFT30wOxa5Q6jMSDyws6ZB/tL25Y3uQ5jQ9OQuoh9Ww9/n/dJwaJ8W547tLw/QOMWt0T YPCLwYvVHV5yy0YWqS7Li0MyRHNyzZ0nViWMk1SOMk0rIlPkYeUEMcvZoNQK2RFvLI6i LajBiPjstXZx4cYE9vdf41g6EBDblrRm4PYcLPXcSaBQSKQwXK0VhcWhyDJqkyPGMg+6 71DRBLomQJryhwkU3aGJTaGREoWNP0rvRHMAE2lFk//52e1OXSonOIFIq69zbFzmdlSo jmaw== X-Forwarded-Encrypted: i=1; AJvYcCUJ1aFYkPHJRd7r1FSLalW3OiGXaH3Ai6AvZEWvjBi799vg/dSTzUWfv4Cb7GpjT8zW/GafGToLSZ31J/M=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7uwfvj8+j/LaKc3Zjd+Qq8k4mmg9YjPy5Xw0DEdmQ+zSSzdPo BNGC7cRxiK1QegIHtbtVs0yuIPHyRq7XmLnBZwjboiez/lQKHkwzozRm+KR8Thwq+88= X-Gm-Gg: AY/fxX638QfUhF3XaV+xj3MCXpr9aDjE0Lwb+0tBdX9zLvN0T+Zv0EWp1p7qkifjFiL i77jBk5MXMRYsADoxmuJhpGg7ylIP0sFCRxgiaCpaZfElqsYo0fXUA+QUnQtbG51UbVCE38ec46 hQjYuherydztEbDRHRd0L357rJ1r0wGQCHdhS8z0tFs5GZRYxXyqABej3HKu31u4sAZnTCJXgju 55P11dJEEye+HTtASuXHwUe8342ffggtingmVO4DCt86D3XdnuhWUDCieKqjOUzKI1KD4YRkG0j /SOpulSWEw5UokV8Rf2rUgwYSLcLU9XhkTjAn3sCzYatlDjaKbzXSg/c5DAP2CUdlcbkGPkC826 poH8JGOk9BpekimhFfVq9q0UueODcqsc933iv/BEnJ66d7uwUuhLZ8S3rpQ== X-Received: by 2002:a17:907:94c6:b0:b87:322d:a8d0 with SMTP id a640c23a62f3a-b87677a7effmr444832666b.41.1768479875341; Thu, 15 Jan 2026 04:24:35 -0800 (PST) Received: from localhost ([151.47.157.182]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b842a4cfe60sm2769696066b.45.2026.01.15.04.24.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 04:24:35 -0800 (PST) From: Francesco Lavra To: Lorenzo Bianconi , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] iio: imu: st_lsm6dsx: Set FIFO ODR for accelerometer and gyroscope only Date: Thu, 15 Jan 2026 13:24:29 +0100 Message-Id: <20260115122431.1014630-2-flavra@baylibre.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260115122431.1014630-1-flavra@baylibre.com> References: <20260115122431.1014630-1-flavra@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1747; i=flavra@baylibre.com; h=from:subject; bh=aBIjT8HJMfYZDveJouRj4sa520yQuhHwAmIb09eSjwY=; b=owEB7QES/pANAwAKAe3xO3POlDZfAcsmYgBpaNxlKHlBS2+YWZdjOWGvX/xqPbpahixKnyHdW ADRDgnr6CSJAbMEAAEKAB0WIQSGV4VPlTvcox7DFObt8TtzzpQ2XwUCaWjcZQAKCRDt8TtzzpQ2 XzHzC/9bPAfkua2tvZoY8F95CI+PUh8AHp8chR+la9DAB+xgwuEy1VBfyudpnOd4N2IG/R0cU1u 1dU3twNAuMt9bqfjCS0EYxlpp/PK5gqwmnoKZhpMgWi03YxSeD081GKWlhOoqvocqU2m0HtFxHk AOSEIUPwjRo9Zc38j24m+WSoXatJb9sW5yRP4YO56pS/t8Xy5iU5JnPKYaS+cKcZtEd5QWbFHeT MdtQdq1B0FscrBR5Fqoz4AS26+4H1NlfZXejsZtiInEGW9g7XdwAWYSPsaRtIAg+Gd59EinKpeS pp1n8ebh3+bOR73FMts7lsUoyRaRMzEK5/Y2Psa9Rg7CxbwH+V7vnkFb7N1s9G7uOKOO8m5Ae9H RcnSytiPYvVRyYZyz++f4iZzASIhYML9CSrO8tW/YYAhRgjQ7xJ3TNRjfVcCw03VsOnyyMLYK79 3SEQDdShEEyeX0mIRsNKpAFOqhw9i3o2jb8j0zuMf1sAlZ2gJZF44K7rgDfJoL//+ARMw= X-Developer-Key: i=flavra@baylibre.com; a=openpgp; fpr=8657854F953BDCA31EC314E6EDF13B73CE94365F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The st_lsm6dsx_set_fifo_odr() function, which is called when enabling and disabling the hardware FIFO, checks the contents of the hw->settings->batch array at index sensor->id, and then sets the current ODR value in sensor registers that depend on whether the register address is set in the above array element. This logic is valid for internal sensors only, i.e. the accelerometer and gyroscope; however, since commit c91c1c844ebd ("iio: imu: st_lsm6dsx: add i2c embedded controller support"), this function is called also when configuring the hardware FIFO for external sensors (i.e. sensors accessed through the sensor hub functionality), which can result in unrelated device registers being written. Add a check to the beginning of st_lsm6dsx_set_fifo_odr() so that it does not touch any registers unless it is called for internal sensors. Fixes: c91c1c844ebd ("iio: imu: st_lsm6dsx: add i2c embedded controller sup= port") Signed-off-by: Francesco Lavra --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c b/drivers/iio/i= mu/st_lsm6dsx/st_lsm6dsx_buffer.c index 55d877745575..1ee2fc5f5f1f 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c @@ -225,6 +225,10 @@ static int st_lsm6dsx_set_fifo_odr(struct st_lsm6dsx_s= ensor *sensor, const struct st_lsm6dsx_reg *batch_reg; u8 data; =20 + /* Only internal sensors have a FIFO ODR configuration register. */ + if (sensor->id >=3D ARRAY_SIZE(hw->settings->batch)) + return 0; + batch_reg =3D &hw->settings->batch[sensor->id]; if (batch_reg->addr) { int val; --=20 2.39.5