From nobody Sun Feb 8 02:56:11 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 771E83128CD for ; Thu, 15 Jan 2026 10:29:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768472991; cv=none; b=ZJnDPA3nnqlw35Q9U9UGoYjeJWXviOSDJrysnz5zZ7wlXLAq+ljxW1Q0dea1RpVm2zBmG8se9XxiwSi6K35fuXKQm0CUATFhAMDFwqZj3poXqHCT1NGvHrA/tVaVhPXVBCE8XXSSqRufcrtfx8Yy/kI240bKb8tm2EP1dVf3OI8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768472991; c=relaxed/simple; bh=qDuq0yGOKI22gOlKBf0PGwkkhhxaOIQfECBpMMLXSL8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bornwCaKtxtqdXaCTYNUrpC+D8uMBcSqk7LO3wJcFN8WOoKXytXYbvIBCJFY+/3yDgWH4w+yWqAjpkCImgbFGgtrTkI24W6dFZ5oJna/ceOzxJgwWDYEqR7dcDxGHmcqSfdS4uSiGdyCqAbmDRucalgvtNYOFIx3HtPUCajs2Ds= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F2L9n/jO; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F2L9n/jO" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-81df6a302b1so682071b3a.2 for ; Thu, 15 Jan 2026 02:29:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768472989; x=1769077789; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eND/NhtLaC/z2AB8mlhX2K83B1CurXmM8VX2+usxEK0=; b=F2L9n/jOe07PGjvgmUFXqqVNOt+K0chhxvlRMPv3lNGhf9LOSQDFTOInjXiHjw4IcY QMFTz/ggIC7LGSBAxQ4uGplKWvZjje63TTgclxUln7QBOuxkEr/8e/jBnwgF+1dBlj8a hlW3aojvsFIKCPIg9j8tCU0r75cPAusFQ5qVqP71xGLZ/SH7X2BWYOTMfvrfrhhBqGqS CdlcLYFDJYMIrn4makU3Lwo5lG8tb0viXdzSD2wG0rbA+zY+Tm+8KJ/m7nz5oNyE0hSI zLe/K0lGv32fA0zNIadL2Cn9EDnUSWjiUfaeC5RmfaxZfVL2cRYnMhv8vO4b1P8Ig2We caww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768472989; x=1769077789; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eND/NhtLaC/z2AB8mlhX2K83B1CurXmM8VX2+usxEK0=; b=bEpJOkaXxX5nZyGLzYdrQ6NnjpBdY0P7kxdwHW1e1Y0nNyqlZUhBbriZz/TNaQseNM N06rMG4VI1UR/erCjzynU5zAgXM3mYDbkVzCnYJ4XOzXvGi04xTm+KtluVsbHuVsmFV8 VGYPyYvvKSp1LjLEmPTsGyEPWIsY05iC6H2aBi/a9m/koeNoeS6J6DBviGVvPWGJdSE8 mwCuAnhvsjAoxqjfUR4K0IDnInZVbAD7T9kGahY9w+hRSyz3Ll25Y3OeNhuBXZkaaoP6 Q0r4sDrKilr/P/6/KLfItHeofad9f9BaFH0lbxaByxsi/pODt/SZAsb5M7Hha1VyMOGk 6KDQ== X-Forwarded-Encrypted: i=1; AJvYcCWt99/4r8LZcr/FctcUQCt/h6RfERmTQHWDSwnu0URuAJpfvk+BQKiFMbqUtxx2lN7Sg25oTABcxrIyzps=@vger.kernel.org X-Gm-Message-State: AOJu0Yw71sCsaTgZYcMGiWL1V3zQlr/btaRVJ1CiHbLu3v+mfh1ZbM9y 3NMMZSkMvkLejvtusWJaROsLF4XDHFHfzxoAdn9ESmcc2fMOl7jRLq3p X-Gm-Gg: AY/fxX4X0M4kqwH7e2+MhixMjcw4zGyy73pKa3Gy3GcfRN7A2C5Izr6WdjE4evWaRDb 0qj9ZypmqwtlSZoKgavocJHKrXHgELz67ES2GrfODEmAJCrpwpRBRJWdiEoAJraBipF83dj+kiP b3FVusDrGwYU9WJ8bIGQVMTkHcJMETGnecJ4cWhqo30MFLTH78QqBAUuEhNMR8NCHaNAxzMTkN0 Cx/frQx5zCoPIc+f4dyHAkdJAtj8p8Fe/eiGt5y51DHJShI9azbIgi1+I1vcrRiHXMoG4OYZEkZ UWiBcs+VXmt+m+X+JV6xmbwgpVvFqxEftWPU9PwbIXWZyEHVb0B6xvQWHq/Kv/J3LqVYPLYH5ur owBSr7hwr7I+nQOEeR1Kd9ZW2c9V/iYgH64YZ8QRE3KoJnFdr97CBuDNKJqbFyTFYCHk2Gl1SEo k3uXe/Cuunlo4wCEA= X-Received: by 2002:a05:6a00:ad0f:b0:81e:e0dc:6d00 with SMTP id d2e1a72fcca58-81f81fe065fmr5133493b3a.58.1768472988856; Thu, 15 Jan 2026 02:29:48 -0800 (PST) Received: from snowman ([223.196.193.117]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81f8e4f61fdsm2103488b3a.26.2026.01.15.02.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 02:29:48 -0800 (PST) From: Khushal Chitturi To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, hansg@kernel.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 1/4] staging: rtl8723bs: fix operator and type cast spacing Date: Thu, 15 Jan 2026 15:59:07 +0530 Message-ID: <20260115102910.10018-2-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115102910.10018-1-khushalchitturi@gmail.com> References: <20260115102910.10018-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix spacing around operators and type casts in rtw_xmit.c to comply with the kernel coding style. Signed-off-by: Khushal Chitturi --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 89 +++++++++++++---------- 1 file changed, 50 insertions(+), 39 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 21690857fd62..bbc42db1c828 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -78,7 +78,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, stru= ct adapter *padapter) } pxmitpriv->pxmit_frame_buf =3D (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitpriv= ->pallocated_frame_buf), 4); =20 - pxframe =3D (struct xmit_frame *) pxmitpriv->pxmit_frame_buf; + pxframe =3D (struct xmit_frame *)pxmitpriv->pxmit_frame_buf; =20 for (i =3D 0; i < NR_XMITFRAME; i++) { INIT_LIST_HEAD(&pxframe->list); @@ -238,7 +238,9 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) pxmitbuf->padapter =3D padapter; pxmitbuf->buf_tag =3D XMITBUF_CMD; =20 - res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_CMDBUF_SZ+XM= ITBUF_ALIGN_SZ, true); + res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, + MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ, + true); if (res =3D=3D _FAIL) { res =3D _FAIL; goto exit; @@ -248,7 +250,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) pxmitbuf->pend =3D pxmitbuf->pbuf + MAX_CMDBUF_SZ; pxmitbuf->len =3D 0; pxmitbuf->pdata =3D pxmitbuf->ptail =3D pxmitbuf->phead; - pxmitbuf->alloc_sz =3D MAX_CMDBUF_SZ+XMITBUF_ALIGN_SZ; + pxmitbuf->alloc_sz =3D MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ; } } =20 @@ -274,7 +276,7 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv) { int i; struct adapter *padapter =3D pxmitpriv->adapter; - struct xmit_frame *pxmitframe =3D (struct xmit_frame *) pxmitpriv->pxmit_= frame_buf; + struct xmit_frame *pxmitframe =3D (struct xmit_frame *)pxmitpriv->pxmit_f= rame_buf; struct xmit_buf *pxmitbuf =3D (struct xmit_buf *)pxmitpriv->pxmitbuf; =20 rtw_hal_free_xmit_priv(padapter); @@ -321,7 +323,9 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv) for (i =3D 0; i < CMDBUF_MAX; i++) { pxmitbuf =3D &pxmitpriv->pcmd_xmitbuf[i]; if (pxmitbuf) - rtw_os_xmit_resource_free(padapter, pxmitbuf, MAX_CMDBUF_SZ+XMITBUF_ALI= GN_SZ, true); + rtw_os_xmit_resource_free(padapter, pxmitbuf, + MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ, + true); } =20 rtw_free_hwxmits(padapter); @@ -736,7 +740,7 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p pattrib->subtype =3D WIFI_DATA_TYPE; pattrib->priority =3D 0; =20 - if (check_fwstate(pmlmepriv, WIFI_AP_STATE|WIFI_ADHOC_STATE|WIFI_ADHOC_MA= STER_STATE)) { + if (check_fwstate(pmlmepriv, WIFI_AP_STATE | WIFI_ADHOC_STATE | WIFI_ADHO= C_MASTER_STATE)) { if (pattrib->qos_en) set_qos(&pktfile, pattrib); } else { @@ -787,15 +791,15 @@ static s32 xmitframe_addmic(struct adapter *padapter,= struct xmit_frame *pxmitfr rtw_secmicsetkey(&micdata, &pattrib->dot11tkiptxmickey.skey[0]); } =20 - if (pframe[1]&1) { /* ToDS =3D=3D 1 */ + if (pframe[1] & 1) { /* ToDS =3D=3D 1 */ rtw_secmicappend(&micdata, &pframe[16], 6); /* DA */ - if (pframe[1]&2) /* From Ds =3D=3D 1 */ + if (pframe[1] & 2) /* From Ds =3D=3D 1 */ rtw_secmicappend(&micdata, &pframe[24], 6); else rtw_secmicappend(&micdata, &pframe[10], 6); } else { /* ToDS =3D=3D 0 */ rtw_secmicappend(&micdata, &pframe[4], 6); /* DA */ - if (pframe[1]&2) /* From Ds =3D=3D 1 */ + if (pframe[1] & 2) /* From Ds =3D=3D 1 */ rtw_secmicappend(&micdata, &pframe[16], 6); else rtw_secmicappend(&micdata, &pframe[10], 6); @@ -810,16 +814,20 @@ static s32 xmitframe_addmic(struct adapter *padapter,= struct xmit_frame *pxmitfr =20 for (curfragnum =3D 0; curfragnum < pattrib->nr_frags; curfragnum++) { payload =3D (u8 *)round_up((SIZE_PTR)(payload), 4); - payload =3D payload+pattrib->hdrlen+pattrib->iv_len; + payload =3D payload + pattrib->hdrlen + pattrib->iv_len; =20 - if ((curfragnum+1) =3D=3D pattrib->nr_frags) { - length =3D pattrib->last_txcmdsz-pattrib->hdrlen-pattrib->iv_len-((pa= ttrib->bswenc) ? pattrib->icv_len : 0); + if ((curfragnum + 1) =3D=3D pattrib->nr_frags) { + length =3D pattrib->last_txcmdsz - pattrib->hdrlen - + pattrib->iv_len - + ((pattrib->bswenc) ? pattrib->icv_len : 0); rtw_secmicappend(&micdata, payload, length); - payload =3D payload+length; + payload =3D payload + length; } else { - length =3D pxmitpriv->frag_len-pattrib->hdrlen-pattrib->iv_len-((patt= rib->bswenc) ? pattrib->icv_len : 0); + length =3D pxmitpriv->frag_len - pattrib->hdrlen - + pattrib->iv_len - + ((pattrib->bswenc) ? pattrib->icv_len : 0); rtw_secmicappend(&micdata, payload, length); - payload =3D payload+length+pattrib->icv_len; + payload =3D payload + length + pattrib->icv_len; } } rtw_secgetmic(&micdata, &mic[0]); @@ -1108,8 +1116,10 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter,= struct sk_buff *pkt, struct if (bmcst || (rtw_endofpktfile(&pktfile) =3D=3D true)) { pattrib->nr_frags =3D frg_inx; =20 - pattrib->last_txcmdsz =3D pattrib->hdrlen + pattrib->iv_len + ((pattrib= ->nr_frags =3D=3D 1) ? llc_sz:0) + - ((pattrib->bswenc) ? pattrib->icv_len : 0) + mem_sz; + pattrib->last_txcmdsz =3D pattrib->hdrlen + pattrib->iv_len + + ((pattrib->nr_frags =3D=3D 1) ? llc_sz : 0) + + ((pattrib->bswenc) ? pattrib->icv_len : 0) + + mem_sz; =20 ClearMFrag(mem_start); =20 @@ -1158,7 +1168,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padap= ter, struct sk_buff *pkt, s mem_start =3D pframe =3D (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET; pwlanhdr =3D (struct ieee80211_hdr *)pframe; =20 - ori_len =3D BIP_AAD_SIZE+pattrib->pktlen; + ori_len =3D BIP_AAD_SIZE + pattrib->pktlen; tmp_buf =3D BIP_AAD =3D rtw_zmalloc(ori_len); subtype =3D GetFrameSubType(pframe); /* bit(7)~bit(2) */ =20 @@ -1211,14 +1221,14 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *pad= apter, struct sk_buff *pkt, s /* conscruct AAD, copy address 1 to address 3 */ memcpy(BIP_AAD + 2, &pwlanhdr->addrs, sizeof(pwlanhdr->addrs)); /* copy management fram body */ - memcpy(BIP_AAD+BIP_AAD_SIZE, MGMT_body, frame_body_len); + memcpy(BIP_AAD + BIP_AAD_SIZE, MGMT_body, frame_body_len); /* calculate mic */ if (omac1_aes_128(padapter->securitypriv.dot11wBIPKey[padapter->security= priv.dot11wBIPKeyid].skey - , BIP_AAD, BIP_AAD_SIZE+frame_body_len, mic)) + , BIP_AAD, BIP_AAD_SIZE + frame_body_len, mic)) goto xmitframe_coalesce_fail; =20 /* copy right BIP mic value, total is 128bits, we use the 0~63 bits */ - memcpy(pframe-8, mic, 8); + memcpy(pframe - 8, mic, 8); } else { /* unicast mgmt frame TX */ /* start to encrypt mgmt frame */ if (subtype =3D=3D WIFI_DEAUTH || subtype =3D=3D WIFI_DISASSOC || @@ -1267,9 +1277,10 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *pada= pter, struct sk_buff *pkt, s memcpy(pframe, pattrib->iv, pattrib->iv_len); pframe +=3D pattrib->iv_len; /* copy mgmt data portion after CCMP header */ - memcpy(pframe, tmp_buf+pattrib->hdrlen, pattrib->pktlen-pattrib->hdrlen= ); + memcpy(pframe, tmp_buf + pattrib->hdrlen, + pattrib->pktlen - pattrib->hdrlen); /* move pframe to end of mgmt pkt */ - pframe +=3D pattrib->pktlen-pattrib->hdrlen; + pframe +=3D pattrib->pktlen - pattrib->hdrlen; /* add 8 bytes CCMP IV header to length */ pattrib->pktlen +=3D pattrib->iv_len; if ((pattrib->icv_len > 0) && (pattrib->bswenc)) { @@ -1375,7 +1386,7 @@ void rtw_count_tx_stats(struct adapter *padapter, str= uct xmit_frame *pxmitframe, struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; u8 pkt_num =3D 1; =20 - if ((pxmitframe->frame_tag&0x0f) =3D=3D DATA_FRAMETAG) { + if ((pxmitframe->frame_tag & 0x0f) =3D=3D DATA_FRAMETAG) { pkt_num =3D pxmitframe->agg_num; =20 pmlmepriv->LinkDetectInfo.NumTxOkInPeriod +=3D pkt_num; @@ -2070,7 +2081,7 @@ signed int xmitframe_enqueue_for_sleeping_sta(struct = adapter *padapter, struct x =20 spin_lock_bh(&psta->sleep_q.lock); =20 - if (psta->state&WIFI_SLEEP_STATE) { + if (psta->state & WIFI_SLEEP_STATE) { u8 wmmps_ac =3D 0; =20 if (pstapriv->sta_dz_bitmap & BIT(psta->aid)) { @@ -2083,20 +2094,20 @@ signed int xmitframe_enqueue_for_sleeping_sta(struc= t adapter *padapter, struct x switch (pattrib->priority) { case 1: case 2: - wmmps_ac =3D psta->uapsd_bk&BIT(0); + wmmps_ac =3D psta->uapsd_bk & BIT(0); break; case 4: case 5: - wmmps_ac =3D psta->uapsd_vi&BIT(0); + wmmps_ac =3D psta->uapsd_vi & BIT(0); break; case 6: case 7: - wmmps_ac =3D psta->uapsd_vo&BIT(0); + wmmps_ac =3D psta->uapsd_vo & BIT(0); break; case 0: case 3: default: - wmmps_ac =3D psta->uapsd_be&BIT(0); + wmmps_ac =3D psta->uapsd_be & BIT(0); break; } =20 @@ -2214,20 +2225,20 @@ void wakeup_sta_to_xmit(struct adapter *padapter, s= truct sta_info *psta) switch (pxmitframe->attrib.priority) { case 1: case 2: - wmmps_ac =3D psta->uapsd_bk&BIT(1); + wmmps_ac =3D psta->uapsd_bk & BIT(1); break; case 4: case 5: - wmmps_ac =3D psta->uapsd_vi&BIT(1); + wmmps_ac =3D psta->uapsd_vi & BIT(1); break; case 6: case 7: - wmmps_ac =3D psta->uapsd_vo&BIT(1); + wmmps_ac =3D psta->uapsd_vo & BIT(1); break; case 0: case 3: default: - wmmps_ac =3D psta->uapsd_be&BIT(1); + wmmps_ac =3D psta->uapsd_be & BIT(1); break; } =20 @@ -2259,7 +2270,7 @@ void wakeup_sta_to_xmit(struct adapter *padapter, str= uct sta_info *psta) =20 pstapriv->tim_bitmap &=3D ~BIT(psta->aid); =20 - if (psta->state&WIFI_SLEEP_STATE) + if (psta->state & WIFI_SLEEP_STATE) psta->state ^=3D WIFI_SLEEP_STATE; =20 if (psta->state & WIFI_STA_ALIVE_CHK_STATE) { @@ -2274,7 +2285,7 @@ void wakeup_sta_to_xmit(struct adapter *padapter, str= uct sta_info *psta) if (!psta_bmc) goto _exit; =20 - if ((pstapriv->sta_dz_bitmap&0xfffe) =3D=3D 0x0) { /* no any sta in ps mo= de */ + if ((pstapriv->sta_dz_bitmap & 0xfffe) =3D=3D 0x0) { /* no any sta in ps = mode */ xmitframe_phead =3D get_list_head(&psta_bmc->sleep_q); list_for_each_safe(xmitframe_plist, tmp, xmitframe_phead) { pxmitframe =3D list_entry(xmitframe_plist, @@ -2327,20 +2338,20 @@ void xmit_delivery_enabled_frames(struct adapter *p= adapter, struct sta_info *pst switch (pxmitframe->attrib.priority) { case 1: case 2: - wmmps_ac =3D psta->uapsd_bk&BIT(1); + wmmps_ac =3D psta->uapsd_bk & BIT(1); break; case 4: case 5: - wmmps_ac =3D psta->uapsd_vi&BIT(1); + wmmps_ac =3D psta->uapsd_vi & BIT(1); break; case 6: case 7: - wmmps_ac =3D psta->uapsd_vo&BIT(1); + wmmps_ac =3D psta->uapsd_vo & BIT(1); break; case 0: case 3: default: - wmmps_ac =3D psta->uapsd_be&BIT(1); + wmmps_ac =3D psta->uapsd_be & BIT(1); break; } =20 --=20 2.52.0 From nobody Sun Feb 8 02:56:11 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BF8F3624A4 for ; Thu, 15 Jan 2026 10:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768472999; cv=none; b=axQ8vgCvMH7iwIM+rguDiA2SVr6kOCotBgvYzBr6p5JhcZFGBUTwprOkCEvoKanVmKSddeuC17rwr1+72QtJ2I2dBTia3FFHSxg6BquWDbnX+EBPggGMRxqhkiYM2RR9ULu2Kf+MBSczxw7fk/Ib/CNKpWVr+IIYVtbrVzVrF28= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768472999; c=relaxed/simple; bh=MSoFKp0LmmZvHV7rSDfoOeOdR7GFOpphUpJmOesMH58=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=G90rk4Owr0L4waRbvM3yrnqrT+x4udTjt2Jtm5egH53oB8z/F/N95iLn3/u1IkUsVE+8A2rV9Mm2Bor2rOcDDKfaFzohxVwHeE8Kef4J8NMYWTRn/r0wju8oXZLRRBdi5/eIgGXlRGuWGQsQsgGAEBFZySPIxwz3uW+qz7KRBmk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MtQzRYww; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MtQzRYww" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-81f3c14027cso416812b3a.1 for ; Thu, 15 Jan 2026 02:29:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768472998; x=1769077798; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nYv7ARBp1kGaj0EE4/j9Qg31wyJiLU5Fgq9K+a3qdd8=; b=MtQzRYwwP/8lYAPzuWWmX1VbLbH5kLfqRmlmmcdUCKAd9gZG0BGGF/zgiWduKSx0qI OjvMNhCKbHu9lAobFgh10j8i5kfNqrg954745hVTIOiVP8n2RehFQT0DVE3xSLf4FLAF plhDd/2gaymqCbC91bhUnVHWN7K+v8rgtCgG0X9e8tk0nK71tnHRJHxx0FB8+QGbI+g6 b5tosifDWHDkOWOzs1Cv719wWbWFtHeoXMyfq8hpVytr3u9Df2rfovgmw4mI+0OX6xhT RzT7WZc7uUOQL+NaYG/HhGjU5EQ/pdD85zq+1zpKv2We2KAAXwsQdGDUDGODNVYhmhk2 zwcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768472998; x=1769077798; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nYv7ARBp1kGaj0EE4/j9Qg31wyJiLU5Fgq9K+a3qdd8=; b=Ib5GQU5Gm3+f7JFEk4B6Oa2Q0whRRH0EZY1Zkdy2KsawVtfUWme+undiF2t5sDL4zn 3OU3SFDM+FGYUZ7d01GbLSTZ0lh23szIsOSmt8KRWr2ScW8GDS96RkBHeIBzfScKIXnw 0GkXPIT9Euo+4HbKBnqHFXUJyY8ldadBWoik1NvqsAQ6zOqc7ARTbJWDxe/XeQ/GeQs0 W2ttkspL5OIytmagyabf8IQplsJtqIJNCA/OG/JOnVezFF75wruwixk6SMg9akfe1Hct PUZIHnO0JG8AsR+pGRQ+cUzw+Cgrg2+kSzfozI3YKJxxBt5DQau9/1bxY5ZZ8gZj9r6n EAOg== X-Forwarded-Encrypted: i=1; AJvYcCXEiXolSAnyTiTnOvXXcGXEkcXE7w+N97hGNsTkJh9ZDrUIXiJ5YFctglu40iZF9+zL6MvJFiels1DhEJY=@vger.kernel.org X-Gm-Message-State: AOJu0YytzUoy2s2JKkcd43r8Y9ppTAOekAF27UKbRtG3vqVFHWbKEz1Q SvUBISGP7P6+XlW09ivDvuaNjeorck4OK4zAEEq6ct82dEXhZdBS1Kzd X-Gm-Gg: AY/fxX6J+Qz9ZnJoGbi6QHpJKmQ09cW2kN98Xx6I4rPn0t2ZRv4fDstjcMtXnLJNCfR DRA+SS+eza5fAW0yiO5p7/KuHE9MCtBx++thOvEal3T6v1YHLaovEuCM2VJOSxmZNqPyKIybna5 MLibuKO+y3jQABvhf31ZfhzKbhOO75kIgn7Xq9L/nKK58u5XSMzrJNBvD7PykjBDVonykUvE3oB 3gkQ9V3cqG/pjmiP26SvjDAMQdp+TE8WyULW+0/ZvLkZUDz3LcyV2ixzVgULJV2EMACBd6et5us z1g20gGNtCDSFW4p0LMHd2E5JLPyqePn8KhlQgBRO/CGQUgKxvz/JFtTWMD6b4u/U/n3RH3+m2K q3cwgTqmAD9awHJREWLbU9Chh2fUfjrZk+CvMpNPF8wabUg0Sg/OH8ELM7LZ7DbhHaypbUvXDel Wpdfr1R0RTnJ3vadU= X-Received: by 2002:a05:6a00:b45:b0:81d:8872:941 with SMTP id d2e1a72fcca58-81f8f151963mr2294193b3a.26.1768472997849; Thu, 15 Jan 2026 02:29:57 -0800 (PST) Received: from snowman ([223.196.193.117]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81f8e4f61fdsm2103488b3a.26.2026.01.15.02.29.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 02:29:57 -0800 (PST) From: Khushal Chitturi To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, hansg@kernel.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 2/4] staging: rtl8723bs: simplify boolean expressions Date: Thu, 15 Jan 2026 15:59:08 +0530 Message-ID: <20260115102910.10018-3-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115102910.10018-1-khushalchitturi@gmail.com> References: <20260115102910.10018-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplify boolean expressions in rtw_xmit.c to comply with the kernel coding style Signed-off-by: Khushal Chitturi --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 38 ++++++++++++----------- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index bbc42db1c828..97e38ef62ac4 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -384,7 +384,8 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * } else { while (true) { /* IOT action */ - if ((pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_ATHEROS) && (pattrib= ->ampdu_en =3D=3D true) && + if ((pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_ATHEROS) && + (pattrib->ampdu_en) && (padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _AES_)) { pattrib->vcs_mode =3D CTS_TO_SELF; break; @@ -420,7 +421,7 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * /* to do list: check MIMO power save condition. */ =20 /* check AMPDU aggregation for TXOP */ - if (pattrib->ampdu_en =3D=3D true) { + if (pattrib->ampdu_en) { pattrib->vcs_mode =3D RTS_CTS; break; } @@ -482,10 +483,10 @@ static s32 update_attrib_sec_info(struct adapter *pad= apter, struct pkt_attrib *p memset(pattrib->dot11tkiptxmickey.skey, 0, 16); pattrib->mac_id =3D psta->mac_id; =20 - if (psta->ieee8021x_blocked =3D=3D true) { + if (psta->ieee8021x_blocked) { pattrib->encrypt =3D 0; =20 - if ((pattrib->ether_type !=3D 0x888e) && (check_fwstate(pmlmepriv, WIFI_= MP_STATE) =3D=3D false)) { + if ((pattrib->ether_type !=3D 0x888e) && (!check_fwstate(pmlmepriv, WIFI= _MP_STATE))) { res =3D _FAIL; goto exit; } @@ -639,8 +640,8 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p memcpy(pattrib->dst, ðerhdr.h_dest, ETH_ALEN); memcpy(pattrib->src, ðerhdr.h_source, ETH_ALEN); =20 - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { + if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) || + (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) { memcpy(pattrib->ra, pattrib->dst, ETH_ALEN); memcpy(pattrib->ta, pattrib->src, ETH_ALEN); } else if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { @@ -704,7 +705,8 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p if (!psta) { /* if we cannot get psta =3D> drop the pkt */ res =3D _FAIL; goto exit; - } else if ((check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) && (!(p= sta->state & _FW_LINKED))) { + } else if ((check_fwstate(pmlmepriv, WIFI_AP_STATE)) && + (!(psta->state & _FW_LINKED))) { res =3D _FAIL; goto exit; } @@ -880,7 +882,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr SetFrameSubType(fctrl, pattrib->subtype); =20 if (pattrib->subtype & WIFI_DATA_TYPE) { - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { /* to_ds =3D 1, fr_ds =3D 0; */ =20 { @@ -894,7 +896,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr =20 if (pqospriv->qos_option) qos_option =3D true; - } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) { + } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) { /* to_ds =3D 0, fr_ds =3D 1; */ SetFrDs(fctrl); memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN); @@ -903,8 +905,8 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr =20 if (pattrib->qos_en) qos_option =3D true; - } else if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { + } else if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) || + (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) { memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN); memcpy(pwlanhdr->addr2, pattrib->src, ETH_ALEN); memcpy(pwlanhdr->addr3, get_bssid(pmlmepriv), ETH_ALEN); @@ -962,7 +964,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr pattrib->ampdu_en =3D true; =20 /* re-check if enable ampdu by BA_starting_seqctrl */ - if (pattrib->ampdu_en =3D=3D true) { + if (pattrib->ampdu_en) { u16 tx_seq; =20 tx_seq =3D psta->BA_starting_seqctrl[pattrib->priority & 0x0f]; @@ -1113,7 +1115,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct =20 frg_inx++; =20 - if (bmcst || (rtw_endofpktfile(&pktfile) =3D=3D true)) { + if (bmcst || (rtw_endofpktfile(&pktfile))) { pattrib->nr_frags =3D frg_inx; =20 pattrib->last_txcmdsz =3D pattrib->hdrlen + pattrib->iv_len + @@ -1139,7 +1141,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct =20 xmitframe_swencrypt(padapter, pxmitframe); =20 - if (bmcst =3D=3D false) + if (!bmcst) update_attrib_vcs_info(padapter, pxmitframe); else pattrib->vcs_mode =3D NONE_VCS; @@ -1978,14 +1980,14 @@ s32 rtw_xmit(struct adapter *padapter, struct sk_bu= ff **ppkt) do_queue_select(padapter, &pxmitframe->attrib); =20 spin_lock_bh(&pxmitpriv->lock); - if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe) =3D=3D true)= { + if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe)) { spin_unlock_bh(&pxmitpriv->lock); return 1; } spin_unlock_bh(&pxmitpriv->lock); =20 /* pre_xmitframe */ - if (rtw_hal_xmit(padapter, pxmitframe) =3D=3D false) + if (!rtw_hal_xmit(padapter, pxmitframe)) return 1; =20 return 0; @@ -2029,7 +2031,7 @@ signed int xmitframe_enqueue_for_sleeping_sta(struct = adapter *padapter, struct x signed int bmcst =3D is_multicast_ether_addr(pattrib->ra); bool update_tim =3D false; =20 - if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D false) + if (!check_fwstate(pmlmepriv, WIFI_AP_STATE)) return ret; psta =3D rtw_get_stainfo(&padapter->stapriv, pattrib->ra); if (pattrib->psta !=3D psta) @@ -2154,7 +2156,7 @@ static void dequeue_xmitframes_to_sleeping_queue(stru= ct adapter *padapter, struc =20 ret =3D xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe); =20 - if (true =3D=3D ret) { + if (ret) { ptxservq =3D rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8= *)(&ac_index)); =20 ptxservq->qcnt--; --=20 2.52.0 From nobody Sun Feb 8 02:56:11 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FAFF3624D9 for ; Thu, 15 Jan 2026 10:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768473007; cv=none; b=Suqw/DIBv2Zf4xB0l9VaodEA//4UBp1zhjC4nXVQVD3N4ik+s6Ihp9REIkqMDpnMzNKBk+6WiGjrwnVeFeNNPFciW9U/9ZBFM0uyt0mr2NrakxeVGK+G3DJdvNqTf3kYdKkvZtVeq4zr9PA3GcHDFsGwxUI+o4M8uY7ct7U5+Rw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768473007; c=relaxed/simple; bh=1IfqwLQ8rmNZuSpE064nn95IekKLgbAApgwV0pAE3Ek=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BmzGyEvnKUt6b+gSdj1unvycz0D8Cwv/KBTVfpfIVwU1L1PTFN9lko04nSUFYGK6hFz5VRNUWYCcu1ulWM58IRRhpx8v7GhY7bIjWW5PTjgX5zUqTIPKCqK+kn0pgG1Fff9u2aeoAJ4bRIEC2rK7SOvqpGFUzl5ahShePuUFyyA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j/xwRfsC; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j/xwRfsC" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-81f4ba336b4so674090b3a.1 for ; Thu, 15 Jan 2026 02:30:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768473004; x=1769077804; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XBWLV/HmQ1dNh+9nZhN+gZEgShfI//0jD6CPugAchBY=; b=j/xwRfsCHWCzYOlGbFXSuAwZEY7u6haY0Jg8oNUIs9KUN76UOz78f2TBLmo0nGO/EP 2AO3kcPwHYn+0dZGH07tDo9C65ZOz2SK72I66VAILuRTbWPlQWt40daYZWBc5/WRFxxa fDAVeSmL8V8F7BCNYGDIFTtSh/wb34kAnAIAhMMLq+W7C6n43CC2fh8rmuS0k5luuP+W z/MlWZkhr9R+5FouGpjDEZCFJibIbVs4iyhGCT69wAzTnqx3tgG0YhldqVYSXz182kjg u92hPNIQ/dX3H39ceHwdrcVyBtW+C8UU/gjr/nB/PO2oOm4PVCkkhaVMompv7+N72iCZ A5Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768473004; x=1769077804; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XBWLV/HmQ1dNh+9nZhN+gZEgShfI//0jD6CPugAchBY=; b=IziziNJF/tRvWCI5okaXIszBBClJkiNdfZiygsyr+pewgTxqyk0Y4I8joCfbTsJGxA zkA3IfHhHwLPnO67e/unxwF6Bd8x3fTvCNzJykvoXaKOcKbhN37X0aePrIKVaQIPmj7U MkssKnIIaaubMKPSqYO7PsVyY4oETt0m6Edl8R8OP2Gg1RFrqoIfG0GruN0ug2kgKp+4 GGqPIuDiHATDhZ66kfN9mU3baCoa1FqVU6sXeK5u3Us0LNtwCv4/kH9vXwsW8KIQY6l/ cXvD5PKXWehomDY572c1dRz9CjW16E93ZlqP9C4MuCUlg482Uw2iqDCfkpwSxuaufz+H tUuQ== X-Forwarded-Encrypted: i=1; AJvYcCUfVog26lkheZ+bXJeGAPUBjFoJzDJWi1Tphkj16WmVfeFhloWYdbhVG6L759olYz7H9l59fnfM3S3b0zg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5MWD8cyt+mZ5p3HbRnK8FSYIKvVv3X3q40MDnHyFMnjBThLKq +zyicjA5Lr/WpN1cneWJ607YL2X1Krr5bwnaJX7K3u3xzudTfZHXqRdzNnPbP5Z/kzs= X-Gm-Gg: AY/fxX6GSN47Lokp6x2eTDtTflRlJi1zdm7r99zK5t2+3/Re6YKbo+84+yxi/Plg/Rs GqMJZojMIro8SwnUTErqIwpZ3DWdFqpigyUGgZcZcVHCGK4MYVQZ1Z6RNkod8rg3N7NibBuzLRy B9to8TqZ7h+qVDljxGIb6ZeyDEzjzPC9rosE7cR68MQzzcvMz+Exe4HxDtjNFkywHKHFKJPux9/ C5f3oVRomI7BDrkrz9oxjXFr0ivSNVVq8N9iyMgqqnxTQhA6xD5nNfmws9uxRUax7h0y2oqiHAX hKgVRLA8Yw4Q+xRttJv4ynoxpghyf7PfVPbXI93KcLxgry1DZ7YSrx2bcsHu6pYhg8sBsgPUxTQ Fn/5g5FkXAFqm1cghhggXPbgkVQOaaQG2Jb26DLRX4BHYAO0pThKx0ZgWii0OUIM8mxBCPQTz/s qPZaOLps2rkm72KJk= X-Received: by 2002:a05:6a00:2998:b0:81f:3d13:e07e with SMTP id d2e1a72fcca58-81f83d4252emr4812013b3a.41.1768473004458; Thu, 15 Jan 2026 02:30:04 -0800 (PST) Received: from snowman ([223.196.193.117]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81f8e4f61fdsm2103488b3a.26.2026.01.15.02.29.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 02:30:03 -0800 (PST) From: Khushal Chitturi To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, hansg@kernel.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 3/4] staging: rtl8723bs: rename CamelCase identifiers to snake_case Date: Thu, 15 Jan 2026 15:59:09 +0530 Message-ID: <20260115102910.10018-4-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115102910.10018-1-khushalchitturi@gmail.com> References: <20260115102910.10018-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename several CamelCase identifiers across the driver to follow kernel naming conventions. The following identifiers were renamed: 1) UserPriority to user_priority 2) NumTxOkInPeriod to tx_ok_in_period 3) HTOpMode to ht_op_mode Signed-off-by: Khushal Chitturi --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 17 ++++++++++------- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- drivers/staging/rtl8723bs/core/rtw_xmit.c | 17 +++++++++-------- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +- drivers/staging/rtl8723bs/include/rtw_mlme.h | 6 +++--- 5 files changed, 24 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl= 8723bs/core/rtw_cmd.c index ef2d92b5588a..005e6737e1af 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -1148,10 +1148,11 @@ u8 traffic_status_watchdog(struct adapter *padapter= , u8 from_timer) BusyThreshold =3D BusyThresholdLow; =20 if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > BusyThreshold || - pmlmepriv->LinkDetectInfo.NumTxOkInPeriod > BusyThreshold) { + pmlmepriv->LinkDetectInfo.tx_ok_in_period > BusyThreshold) { bBusyTraffic =3D true; =20 - if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > pmlmepriv->LinkDetectIn= fo.NumTxOkInPeriod) + if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > + pmlmepriv->LinkDetectInfo.tx_ok_in_period) bRxBusyTraffic =3D true; else bTxBusyTraffic =3D true; @@ -1159,18 +1160,20 @@ u8 traffic_status_watchdog(struct adapter *padapter= , u8 from_timer) =20 /* Higher Tx/Rx data. */ if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > 4000 || - pmlmepriv->LinkDetectInfo.NumTxOkInPeriod > 4000) { + pmlmepriv->LinkDetectInfo.tx_ok_in_period > 4000) { bHigherBusyTraffic =3D true; =20 - if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > pmlmepriv->LinkDetectIn= fo.NumTxOkInPeriod) + if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > + pmlmepriv->LinkDetectInfo.tx_ok_in_period) bHigherBusyRxTraffic =3D true; else bHigherBusyTxTraffic =3D true; } =20 /* check traffic for powersaving. */ - if (((pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod + pmlmepriv->Link= DetectInfo.NumTxOkInPeriod) > 8) || - (pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod > 2)) { + if (((pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod + + pmlmepriv->LinkDetectInfo.tx_ok_in_period) > 8) || + (pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod > 2)) { bEnterPS =3D false; =20 if (bBusyTraffic) { @@ -1214,7 +1217,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, = u8 from_timer) } =20 pmlmepriv->LinkDetectInfo.NumRxOkInPeriod =3D 0; - pmlmepriv->LinkDetectInfo.NumTxOkInPeriod =3D 0; + pmlmepriv->LinkDetectInfo.tx_ok_in_period =3D 0; pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod =3D 0; pmlmepriv->LinkDetectInfo.bBusyTraffic =3D bBusyTraffic; pmlmepriv->LinkDetectInfo.bTxBusyTraffic =3D bTxBusyTraffic; diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 98704179ad35..6b8923109c47 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2518,7 +2518,7 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter,= struct xmit_frame *pxmitfr s32 bmcst =3D is_multicast_ether_addr(pattrib->ra); =20 /* if (bmcst || (padapter->mlmepriv.LinkDetectInfo.bTxBusyTraffic =3D=3D = false)) */ - if (bmcst || (padapter->mlmepriv.LinkDetectInfo.NumTxOkInPeriod < 100)) + if (bmcst || (padapter->mlmepriv.LinkDetectInfo.tx_ok_in_period < 100)) return; =20 priority =3D pattrib->priority; diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 97e38ef62ac4..39477b7c443d 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -403,10 +403,11 @@ static void update_attrib_vcs_info(struct adapter *pa= dapter, struct xmit_frame * =20 /* check HT op mode */ if (pattrib->ht_en) { - u8 HTOpMode =3D pmlmeinfo->HT_protection; + u8 ht_op_mode =3D pmlmeinfo->HT_protection; =20 - if ((pmlmeext->cur_bwmode && (HTOpMode =3D=3D 2 || HTOpMode =3D=3D 3))= || - (!pmlmeext->cur_bwmode && HTOpMode =3D=3D 3)) { + if ((pmlmeext->cur_bwmode && + (ht_op_mode =3D=3D 2 || ht_op_mode =3D=3D 3)) || + (!pmlmeext->cur_bwmode && ht_op_mode =3D=3D 3)) { pattrib->vcs_mode =3D RTS_CTS; break; } @@ -605,17 +606,17 @@ static void set_qos(struct pkt_file *ppktfile, struct= pkt_attrib *pattrib) { struct ethhdr etherhdr; struct iphdr ip_hdr; - s32 UserPriority =3D 0; + s32 user_priority =3D 0; =20 _rtw_open_pktfile(ppktfile->pkt, ppktfile); _rtw_pktfile_read(ppktfile, (unsigned char *)ðerhdr, ETH_HLEN); =20 - /* get UserPriority from IP hdr */ + /* get user_priority from IP hdr */ if (pattrib->ether_type =3D=3D 0x0800) { _rtw_pktfile_read(ppktfile, (u8 *)&ip_hdr, sizeof(ip_hdr)); - UserPriority =3D ip_hdr.tos >> 5; + user_priority =3D ip_hdr.tos >> 5; } - pattrib->priority =3D UserPriority; + pattrib->priority =3D user_priority; pattrib->hdrlen =3D WLAN_HDR_A3_QOS_LEN; pattrib->subtype =3D WIFI_QOS_DATA_TYPE; } @@ -1391,7 +1392,7 @@ void rtw_count_tx_stats(struct adapter *padapter, str= uct xmit_frame *pxmitframe, if ((pxmitframe->frame_tag & 0x0f) =3D=3D DATA_FRAMETAG) { pkt_num =3D pxmitframe->agg_num; =20 - pmlmepriv->LinkDetectInfo.NumTxOkInPeriod +=3D pkt_num; + pmlmepriv->LinkDetectInfo.tx_ok_in_period +=3D pkt_num; =20 pxmitpriv->tx_pkts +=3D pkt_num; =20 diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/r= tl8723bs/hal/hal_btcoex.c index 9105594d2dde..ad2b79cb6f0a 100644 --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c @@ -366,7 +366,7 @@ static u8 halbtcoutsrc_Get(void *pBtcContext, u8 getTyp= e, void *pOutBuf) struct rt_link_detect_t *plinkinfo; plinkinfo =3D &padapter->mlmepriv.LinkDetectInfo; =20 - if (plinkinfo->NumTxOkInPeriod > plinkinfo->NumRxOkInPeriod) + if (plinkinfo->tx_ok_in_period > plinkinfo->NumRxOkInPeriod) *pU4Tmp =3D BTC_WIFI_TRAFFIC_TX; else *pU4Tmp =3D BTC_WIFI_TRAFFIC_RX; diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme.h b/drivers/staging= /rtl8723bs/include/rtw_mlme.h index 2a128568c6df..b40b10a854a9 100644 --- a/drivers/staging/rtl8723bs/include/rtw_mlme.h +++ b/drivers/staging/rtl8723bs/include/rtw_mlme.h @@ -93,9 +93,9 @@ struct sitesurvey_ctrl { }; =20 struct rt_link_detect_t { - u32 NumTxOkInPeriod; - u32 NumRxOkInPeriod; - u32 NumRxUnicastOkInPeriod; + u32 tx_ok_in_period; + u32 NumRxOkInPeriod; + u32 NumRxUnicastOkInPeriod; bool bBusyTraffic; bool bTxBusyTraffic; bool bRxBusyTraffic; --=20 2.52.0 From nobody Sun Feb 8 02:56:11 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29D6C364EBC for ; Thu, 15 Jan 2026 10:30:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768473012; cv=none; b=TjbHRQG+MdSuVVeJHl1eUfhbdfSUVJsb97ay80XiYTfMwvl+cLPDfPLp6LaxLTGa5L8Gho7zIK2XDNTAD5l2MqzlSAEsx92GWnPn99wi1fzQKbOb6jXl/nY1mKp6fW1ddpb1ZrWjVu0xlzyCiVjEAri3HP7OT3dr7TRVcjn6GU8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768473012; c=relaxed/simple; bh=lfzpup8sMXzgFKSAb9qsmed7Tm9dM3aPstuATL07vJ8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QPT3nhyszhkdqggpaLdAn4g3emyosvqUdz6/QXTB89AjvibdAC7xL7EzqKzsWuAe9retQ0J1BuF3U2mQ4MvvWyLhbprBmE/b4IK32/NWoefj9O1NVYNceO+HsU871mwqRJ6974pj7xVjBWd1N/3XIAhkznZQgEe1A9AkdzmAXsc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XEZk4fDk; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XEZk4fDk" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-81ef4b87291so395415b3a.0 for ; Thu, 15 Jan 2026 02:30:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768473009; x=1769077809; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Eu/zMPm8jNOPhQZ2KpPuGdbHBQhde0/v14GSW1jHftw=; b=XEZk4fDk/c7tyczYkPjvVE1ldqX5DMQajikK/hTz3HVqHkHa7sn5PdbHi1w3BhtguR pXozx5+tLiQCc5se4TyWsm7J5atAjFIbWBnW43tMjIILrHE6uFOiouosqaPXVrQGE9l4 fkIs+ch2kkeTxzHrpH92KLvpLQmFCGmMDALAuiRjDEFsgl0wyHkrRDWpmYtyfRgL2TaD 9MsK7H0+4gTYtr0bwYpK99vl3VXWPkdKmmMD+PTyhano2z7zxs7pLmlKl/aizy8qW7gJ rkwcG7BaPKtN44vDSmnPRF1pT3P9zEi6uGPVILdiKS4yy2VhrvjoCJQ5tD8P9ddExVVe EK4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768473009; x=1769077809; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Eu/zMPm8jNOPhQZ2KpPuGdbHBQhde0/v14GSW1jHftw=; b=p+VIOmISgVl+bWYbVUR9mhEOu7on5I9jp7dulT8XnTJPnm3/86y8TJbdMYNN0lUVrR LEFoxMLB5m6l/OrVRpmqmvzuDjy9rmkNhfC5PRRhtIKpmuD5LN4hW35HklPlbq39Tort 8dC7WIaD6YnHcNC84jKSY04oaXbK9/K22MlkefHm5nkdzZrkrc3ueNiSMMOPpwWQy04m KQWoUQuC8QCa6Akd4kpEPCb4BUqqcBtvSzOBdWp5MSDooiB6aVmze6LbaYVP9/6IEwz8 wlZDBCd5tBKMuX6TSXQ+xej17h+T7GzhwDtuLvJOXd4+I7ZBmYoHuIsWM4x1e4kaKMTb a6Vg== X-Forwarded-Encrypted: i=1; AJvYcCW/74mkqgThKL7kI6J1lDHICeipc73dM1FcDTwnqTi9az80laQkpF0A7+k3exfqXLiFcTKdSEJeVAdyjqI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7u4PsDM8s/QvzELWhw4KtGMdKhw73tRg8H4/1RtQeYyqNw1kp i84D5yd2/Mb+9z8/yh3qoGcaj5N+6GZzUciyLlqM+H0+8v32IguB/PW2 X-Gm-Gg: AY/fxX5qUNYZtGjrsS189iqUHAmWcMPZdWZ/MxuzXcCaCuc3Qo4d8ps2xzXZVU4q0N1 RJN6z6SMnd8iDJ2Z8LDWQ7oLmaDPKi48Um0avm1ZuCwxk5FVPJdehFAfUy++XtUchXDICA/qBt4 zCftvnazgKz7cLCT/nwdizhF3aVOrNVFXW5Fx+tOTGnIf/5/bZ2kBBrHEP8ci52tA8HH8Qkanj4 ld70Y6ySqdI1y48d7NrjHUaZT2TRpCU6CBK2owpzBHhO2Z+qfFvGSusctUyUDoKnlfZvtMmn6V3 lkzwXbAVDGztJSImxQVEIjoexFHZAMnbA+FhVT3/FSk18ic7mR61FgIkltwvFkHBT9QCt7oRHAr vHCtQrer0daxnvwklWzWPVa4skIsKOX5O/KiDK1dPxq0PhAKrzKtdO1TmXDYzb+nTxhwlhf8nqT CwwJmO1x458pR9N2Y= X-Received: by 2002:a05:6a00:4c87:b0:7f6:4922:89c4 with SMTP id d2e1a72fcca58-81f83d484d7mr5247539b3a.55.1768473009252; Thu, 15 Jan 2026 02:30:09 -0800 (PST) Received: from snowman ([223.196.193.117]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81f8e4f61fdsm2103488b3a.26.2026.01.15.02.30.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 02:30:08 -0800 (PST) From: Khushal Chitturi To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, hansg@kernel.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 4/4] staging: rtl8723bs: fix line length and alignment issues Date: Thu, 15 Jan 2026 15:59:10 +0530 Message-ID: <20260115102910.10018-5-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115102910.10018-1-khushalchitturi@gmail.com> References: <20260115102910.10018-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix multiple coding style issues in rtw_xmit.c to comply with the kernel coding style by splitting expressions and adjusting alignment. This patch resolves checkpatch.pl warnings caused by line length exceeding 100 columns and alignment with the open parenthesis. Signed-off-by: Khushal Chitturi --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 94 +++++++++++++++-------- 1 file changed, 60 insertions(+), 34 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 39477b7c443d..4cc41d1f4836 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -126,10 +126,14 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, = struct adapter *padapter) pxmitbuf->buf_tag =3D XMITBUF_DATA; =20 /* Tx buf allocation may fail sometimes, so sleep and retry. */ - res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ += XMITBUF_ALIGN_SZ), true); + res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, + (MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ), + true); if (res =3D=3D _FAIL) { msleep(10); - res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ = + XMITBUF_ALIGN_SZ), true); + res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, + (MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ), + true); if (res =3D=3D _FAIL) goto exit; } @@ -208,7 +212,9 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) pxmitbuf->padapter =3D padapter; pxmitbuf->buf_tag =3D XMITBUF_MGNT; =20 - res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_XMIT_EXTBUF_S= Z + XMITBUF_ALIGN_SZ, true); + res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, + MAX_XMIT_EXTBUF_SZ + XMITBUF_ALIGN_SZ, + true); if (res =3D=3D _FAIL) { res =3D _FAIL; goto exit; @@ -291,7 +297,9 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv) } =20 for (i =3D 0; i < NR_XMITBUFF; i++) { - rtw_os_xmit_resource_free(padapter, pxmitbuf, (MAX_XMITBUF_SZ + XMITBUF_= ALIGN_SZ), true); + rtw_os_xmit_resource_free(padapter, pxmitbuf, + (MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ), + true); =20 pxmitbuf++; } @@ -313,7 +321,9 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv) /* free xmit extension buff */ pxmitbuf =3D (struct xmit_buf *)pxmitpriv->pxmit_extbuf; for (i =3D 0; i < NR_XMIT_EXTBUFF; i++) { - rtw_os_xmit_resource_free(padapter, pxmitbuf, (MAX_XMIT_EXTBUF_SZ + XMIT= BUF_ALIGN_SZ), true); + rtw_os_xmit_resource_free(padapter, pxmitbuf, + (MAX_XMIT_EXTBUF_SZ + XMITBUF_ALIGN_SZ), + true); =20 pxmitbuf++; } @@ -367,7 +377,9 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * sz =3D pattrib->last_txcmdsz; =20 /* (1) RTS_Threshold is compared to the MPDU, not MSDU. */ - /* (2) If there are more than one frag in this MSDU, only the first fra= g uses protection frame. */ + /* (2) If there are more than one frag in this MSDU, + * only the first frag uses protection frame. + */ /* Other fragments are protected by previous fragment. */ /* So we only need to check the length of first fragment. */ if (pmlmeext->cur_wireless_mode < WIRELESS_11_24N || padapter->registryp= riv.wifi_spec) { @@ -437,7 +449,8 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * pattrib->vcs_mode =3D padapter->driver_vcs_type; } =20 -static void update_attrib_phy_info(struct adapter *padapter, struct pkt_at= trib *pattrib, struct sta_info *psta) +static void update_attrib_phy_info(struct adapter *padapter, struct pkt_at= trib *pattrib, + struct sta_info *psta) { struct mlme_ext_priv *mlmeext =3D &padapter->mlmeextpriv; =20 @@ -465,7 +478,8 @@ static void update_attrib_phy_info(struct adapter *pada= pter, struct pkt_attrib * pattrib->ch_offset =3D psta->htpriv.ch_offset; pattrib->ampdu_en =3D false; =20 - if (padapter->driver_ampdu_spacing !=3D 0xFF) /* driver control AMPDU Den= sity for peer sta's rx */ + /* driver control AMPDU Density for peer sta's rx */ + if (padapter->driver_ampdu_spacing !=3D 0xFF) pattrib->ampdu_spacing =3D padapter->driver_ampdu_spacing; else pattrib->ampdu_spacing =3D psta->htpriv.rx_ampdu_min_spacing; @@ -473,7 +487,8 @@ static void update_attrib_phy_info(struct adapter *pada= pter, struct pkt_attrib * pattrib->retry_ctrl =3D false; } =20 -static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_att= rib *pattrib, struct sta_info *psta) +static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_att= rib *pattrib, + struct sta_info *psta) { signed int res =3D _SUCCESS; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; @@ -512,7 +527,8 @@ static s32 update_attrib_sec_info(struct adapter *padap= ter, struct pkt_attrib *p } =20 /* For WPS 1.0 WEP, driver should not encrypt EAPOL Packet for WPS hands= hake. */ - if (((pattrib->encrypt =3D=3D _WEP40_) || (pattrib->encrypt =3D=3D _WEP1= 04_)) && (pattrib->ether_type =3D=3D 0x888e)) + if (((pattrib->encrypt =3D=3D _WEP40_) || (pattrib->encrypt =3D=3D _WEP1= 04_)) && + (pattrib->ether_type =3D=3D 0x888e)) pattrib->encrypt =3D _NO_PRIVACY_; } =20 @@ -564,7 +580,7 @@ static s32 update_attrib_sec_info(struct adapter *padap= ter, struct pkt_attrib *p memcpy(pattrib->dot118021x_UncstKey.skey, psta->dot118021x_UncstKey.skey= , 16); =20 if (pattrib->encrypt && - ((padapter->securitypriv.sw_encrypt) || (!psecuritypriv->hw_decrypted))) + ((padapter->securitypriv.sw_encrypt) || (!psecuritypriv->hw_decrypted= ))) pattrib->bswenc =3D true; else pattrib->bswenc =3D false; @@ -656,7 +672,9 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p pattrib->pktlen =3D pktfile.pkt_len; =20 if (pattrib->ether_type =3D=3D ETH_P_IP) { - /* The following is for DHCP and ARP packet, we use cck1M to tx these p= ackets and let LPS awake some time */ + /* The following is for DHCP and ARP packet, + * we use cck1M to tx these packets and let LPS awake some time + */ /* to prevent DHCP protocol fail */ =20 u8 tmp[24]; @@ -667,7 +685,7 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p if (pktfile.pkt_len > 282) {/* MINIMUM_DHCP_PACKET_SIZE) { */ if (pattrib->ether_type =3D=3D ETH_P_IP) {/* IP header */ if (((tmp[21] =3D=3D 68) && (tmp[23] =3D=3D 67)) || - ((tmp[21] =3D=3D 67) && (tmp[23] =3D=3D 68))) { + ((tmp[21] =3D=3D 67) && (tmp[23] =3D=3D 68))) { /* 68 : UDP BOOTP client */ /* 67 : UDP BOOTP server */ pattrib->dhcp_pkt =3D 1; @@ -778,7 +796,8 @@ static s32 xmitframe_addmic(struct adapter *padapter, s= truct xmit_frame *pxmitfr if (pattrib->encrypt =3D=3D _TKIP_) { /* encode mic code */ { - u8 null_key[16] =3D {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, = 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}; + u8 null_key[16] =3D {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, + 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}; =20 pframe =3D pxmitframe->buf_addr + hw_hdr_offset; =20 @@ -999,9 +1018,9 @@ s32 rtw_txframes_pending(struct adapter *padapter) struct xmit_priv *pxmitpriv =3D &padapter->xmitpriv; =20 return ((!list_empty(&pxmitpriv->be_pending.queue)) || - (!list_empty(&pxmitpriv->bk_pending.queue)) || - (!list_empty(&pxmitpriv->vi_pending.queue)) || - (!list_empty(&pxmitpriv->vo_pending.queue))); + (!list_empty(&pxmitpriv->bk_pending.queue)) || + (!list_empty(&pxmitpriv->vi_pending.queue)) || + (!list_empty(&pxmitpriv->vo_pending.queue))); } =20 /* @@ -1031,7 +1050,8 @@ u32 rtw_calculate_wlan_pkt_size_by_attribue(struct pk= t_attrib *pattrib) * 5. move frag chunk from pframe to pxmitframe->mem * 6. apply sw-encrypt, if necessary. */ -s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, = struct xmit_frame *pxmitframe) +s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, + struct xmit_frame *pxmitframe) { struct pkt_file pktfile; =20 @@ -1152,7 +1172,8 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct } =20 /* broadcast or multicast management pkt use BIP, unicast management pkt u= se CCMP encryption */ -s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *= pkt, struct xmit_frame *pxmitframe) +s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *= pkt, + struct xmit_frame *pxmitframe) { u8 *pframe, *mem_start =3D NULL, *tmp_buf =3D NULL; u8 subtype; @@ -1235,7 +1256,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padap= ter, struct sk_buff *pkt, s } else { /* unicast mgmt frame TX */ /* start to encrypt mgmt frame */ if (subtype =3D=3D WIFI_DEAUTH || subtype =3D=3D WIFI_DISASSOC || - subtype =3D=3D WIFI_REASSOCREQ || subtype =3D=3D WIFI_ACTION) { + subtype =3D=3D WIFI_REASSOCREQ || subtype =3D=3D WIFI_ACTION) { if (pattrib->psta) psta =3D pattrib->psta; else @@ -1249,11 +1270,11 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *pad= apter, struct sk_buff *pkt, s =20 /* according 802.11-2012 standard, these five types are not robust type= s */ if (subtype =3D=3D WIFI_ACTION && - (pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_PUBLIC || - pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_HT || - pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_UNPROTECTED_WNM || - pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_SELF_PROTECTED || - pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_P2P)) + (pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_PUBLIC || + pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_HT || + pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_UNPROTECTED_WNM || + pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_SELF_PROTECTED || + pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_P2P)) goto xmitframe_coalesce_fail; /* before encrypt dump the management packet content */ if (pattrib->encrypt > 0) @@ -1410,7 +1431,7 @@ void rtw_count_tx_stats(struct adapter *padapter, str= uct xmit_frame *pxmitframe, } =20 static struct xmit_buf *__rtw_alloc_cmd_xmitbuf(struct xmit_priv *pxmitpri= v, - enum cmdbuf_type buf_type) + enum cmdbuf_type buf_type) { struct xmit_buf *pxmitbuf =3D NULL; =20 @@ -1431,7 +1452,7 @@ static struct xmit_buf *__rtw_alloc_cmd_xmitbuf(struc= t xmit_priv *pxmitpriv, } =20 struct xmit_frame *__rtw_alloc_cmdxmitframe(struct xmit_priv *pxmitpriv, - enum cmdbuf_type buf_type) + enum cmdbuf_type buf_type) { struct xmit_frame *pcmdframe; struct xmit_buf *pxmitbuf; @@ -1768,7 +1789,8 @@ s32 rtw_xmitframe_enqueue(struct adapter *padapter, s= truct xmit_frame *pxmitfram return _SUCCESS; } =20 -struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, struct sta_= info *psta, signed int up, u8 *ac) +struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, struct sta_= info *psta, + signed int up, u8 *ac) { struct tx_servq *ptxservq =3D NULL; =20 @@ -2022,7 +2044,8 @@ inline bool xmitframe_hiq_filter(struct xmit_frame *x= mitframe) return allow; } =20 -signed int xmitframe_enqueue_for_sleeping_sta(struct adapter *padapter, st= ruct xmit_frame *pxmitframe) +signed int xmitframe_enqueue_for_sleeping_sta(struct adapter *padapter, + struct xmit_frame *pxmitframe) { signed int ret =3D false; struct sta_info *psta =3D NULL; @@ -2117,7 +2140,8 @@ signed int xmitframe_enqueue_for_sleeping_sta(struct = adapter *padapter, struct x if (wmmps_ac) psta->sleepq_ac_len++; =20 - if (((psta->has_legacy_ac) && (!wmmps_ac)) || ((!psta->has_legacy_ac) &= & (wmmps_ac))) { + if (((psta->has_legacy_ac) && (!wmmps_ac)) || + ((!psta->has_legacy_ac) && (wmmps_ac))) { if (!(pstapriv->tim_bitmap & BIT(psta->aid))) update_tim =3D true; =20 @@ -2137,7 +2161,8 @@ signed int xmitframe_enqueue_for_sleeping_sta(struct = adapter *padapter, struct x return ret; } =20 -static void dequeue_xmitframes_to_sleeping_queue(struct adapter *padapter,= struct sta_info *psta, struct __queue *pframequeue) +static void dequeue_xmitframes_to_sleeping_queue(struct adapter *padapter,= struct sta_info *psta, + struct __queue *pframequeue) { signed int ret; struct list_head *plist, *phead, *tmp; @@ -2158,7 +2183,8 @@ static void dequeue_xmitframes_to_sleeping_queue(stru= ct adapter *padapter, struc ret =3D xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe); =20 if (ret) { - ptxservq =3D rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8= *)(&ac_index)); + ptxservq =3D rtw_get_sta_pending(padapter, psta, pattrib->priority, + (u8 *)(&ac_index)); =20 ptxservq->qcnt--; phwxmits[ac_index].accnt--; @@ -2464,8 +2490,8 @@ struct xmit_buf *dequeue_pending_xmitbuf_under_survey= (struct xmit_priv *pxmitpri type =3D GetFrameSubType(pxmitbuf->pbuf + TXDESC_OFFSET); =20 if ((type =3D=3D WIFI_PROBEREQ) || - (type =3D=3D WIFI_DATA_NULL) || - (type =3D=3D WIFI_QOS_DATA_NULL)) { + (type =3D=3D WIFI_DATA_NULL) || + (type =3D=3D WIFI_QOS_DATA_NULL)) { list_del_init(&pxmitbuf->list); break; } --=20 2.52.0