From nobody Mon Feb 9 08:29:17 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A41535EDA1 for ; Thu, 15 Jan 2026 09:37:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768469859; cv=none; b=TKniVDZmoWe/lbBMoGaBELfRW+L81GB69nbRFwc/PI2rMz2r9Oex3g/8W8y0yzXWUMGhyl2k7HKPhy1NKdugNTUs6KN0cGmX1UQvRvbj29aAPuMABdT0EPk2drDr2M1XxMox9iNJGapF6dBPI7opE0FGwjxldHFB2ymW2ww0ewk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768469859; c=relaxed/simple; bh=fnFV8PBNQlippHm1HirX/EXSWFlF7ZQmPRG49u4zF0k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VJIY9mHDduclFSBtIThR0U0xNJ+/ZysPC+UFFqYQ87LxdqsTP1UOC/Qn9tgL51QGxXurYx/gquqU8My1Ff3Ouqbm2gCsnrZGMPg+a1rLv4SCAOfAbOODtsHakbxg7BDwq4TW/5Rtrjd6udizm6+aGAzt15E2NCexyv5S0lHeLZs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ceL96QWM; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ceL96QWM" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2a3e76d0f64so9064255ad.1 for ; Thu, 15 Jan 2026 01:37:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768469856; x=1769074656; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tlvyCIH2YNVvl+Z7egcO8FGfVtyV86Fgh9Yw7qPMcmQ=; b=ceL96QWMPmv5q1KiF5H29tWcNOy/+2YNlyfqXCMV500SNnHE0pt9umPTnB3eASthbl vKRJX3XOITzm/ArqnG1StqDdLq56ioNR6Xphp+fzxudo5fNg8gXBsbJGM5UB2YweIDLj xMmjfoZpU0+ck3V4tjkqW8IOlzC1bR84LAWG9A2LIJ5F9XBCiBqUMKsqM8vECd8pL/sK 20b/5dJaXGwI3lnCgQuGKXpUzEQ6zhvlvetal1zeQ+wVMYYXP2oW7iNzdF2nnuiumu45 +15OHlA8yXLUneMVkEjP5yi9cOUr1dgPV5PHNK48tcMYt5klWhquJwa1p9qEP9hYjLwl jmDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768469856; x=1769074656; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tlvyCIH2YNVvl+Z7egcO8FGfVtyV86Fgh9Yw7qPMcmQ=; b=ukOb42zGtPzzYTOFabQW6FuxJ9VoQmVC5IWj4iD21mO9hVG3vlX2wWVLknGEhYCSGZ B8nFzpttqe3Oamsye11M+/s8N2fmBid5cQ8jTwKBWfsw6EXaemzGh5Y3BlZbOWZc8lD1 x6LG3cnxDiyS8lNjGnCCBiT1zHxBYoB3NYl576e8qKKir80MOeKguk21yo1fOjJREEga o8GPqs35es4Sxw1X5kNtK2T/mYov6HVbuMl7HRxcsoms995o4UH7Td3QKAT7/zyQieYZ oFRDekCx9AsPPx7A/SLynbKMsZSa/RavIxGI7DIRJXEZjVtR2JA9LOQUOoKy2x9eDOxP DvUw== X-Forwarded-Encrypted: i=1; AJvYcCXMudNwIftJQQmvZ7dTl3LHl/B3XqWNpSL7CpdSvpJ9ZEo6JrNYsnDeVP9/4rPDo6yiW6l7WQj6dQskJZ8=@vger.kernel.org X-Gm-Message-State: AOJu0YwUG49s4Cqtk9HBfc9B+CNkvbNoTx5dIt8P4SCZ+g8O0jrFSOEV kTrmnWDtXpJT0hpYIwwDPo/yy+hlGhrkceeTubMfY2xM+sBlobEkHsLi X-Gm-Gg: AY/fxX6AIv+zb80oE0BZbgA3BvfXLyh2zxZIxLRKn2pK8QPV80GV2djkOgLxEN30/+7 +9mZ4ZHiCd2C06nq8wIHRMB20+OLzWBsavSvbcVdaOQ6FaFEuworvTk4gbE9QqjNx3/9hd0/+tW 58wTCM3JbYWeD/sKvDKv/rMrSsqQDIpR9nyOZdDHBw2PWubyZZL1zysmzMtijrgf6g8X7bhzT45 XMQvozklhZ88RqSyOSpc2jY7NTl5D7YhM3oG9DPgw0MntrcS5g26OS4SQyRK8ZlIACEpkNYSNvV Q6oiQqi4ZyLEoWPyWM9+Jj+o6Tls/SiqeGq6mXczNz2oE+VOiTT97J7oqnb3abohXwkVnqvjXvx nThX5/YjKjhPtVfsnhPD1hEyfp8Q9OIM4ZDEbnzda0b5wdsHQNorZ1yxZ+5qbKJ1dlhxqKvlT75 bvs3+eZVRXbxcGdiY= X-Received: by 2002:a17:902:ecc5:b0:2a1:3769:1d02 with SMTP id d9443c01a7336-2a7009be24emr27023875ad.12.1768469856248; Thu, 15 Jan 2026 01:37:36 -0800 (PST) Received: from snowman ([223.196.193.117]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c48dc1sm244063595ad.40.2026.01.15.01.37.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 01:37:35 -0800 (PST) From: Khushal Chitturi To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, hansg@kernel.org, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 3/4] staging: rtl8723bs: rename CamelCase identifiers to snake_case Date: Thu, 15 Jan 2026 15:04:38 +0530 Message-ID: <20260115093439.7588-4-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115093439.7588-1-khushalchitturi@gmail.com> References: <20260115093439.7588-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename several CamelCase identifiers across the driver to follow kernel naming conventions. The following identifiers were renamed: 1) UserPriority to user_priority 2) NumTxOkInPeriod to tx_ok_in_period 3) HTOpMode to ht_op_mode Signed-off-by: Khushal Chitturi nits tbswpo tbswpo --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 17 ++++++++++------- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- drivers/staging/rtl8723bs/core/rtw_xmit.c | 17 +++++++++-------- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +- drivers/staging/rtl8723bs/include/rtw_mlme.h | 6 +++--- 5 files changed, 24 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl= 8723bs/core/rtw_cmd.c index ef2d92b5588a..005e6737e1af 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -1148,10 +1148,11 @@ u8 traffic_status_watchdog(struct adapter *padapter= , u8 from_timer) BusyThreshold =3D BusyThresholdLow; =20 if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > BusyThreshold || - pmlmepriv->LinkDetectInfo.NumTxOkInPeriod > BusyThreshold) { + pmlmepriv->LinkDetectInfo.tx_ok_in_period > BusyThreshold) { bBusyTraffic =3D true; =20 - if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > pmlmepriv->LinkDetectIn= fo.NumTxOkInPeriod) + if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > + pmlmepriv->LinkDetectInfo.tx_ok_in_period) bRxBusyTraffic =3D true; else bTxBusyTraffic =3D true; @@ -1159,18 +1160,20 @@ u8 traffic_status_watchdog(struct adapter *padapter= , u8 from_timer) =20 /* Higher Tx/Rx data. */ if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > 4000 || - pmlmepriv->LinkDetectInfo.NumTxOkInPeriod > 4000) { + pmlmepriv->LinkDetectInfo.tx_ok_in_period > 4000) { bHigherBusyTraffic =3D true; =20 - if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > pmlmepriv->LinkDetectIn= fo.NumTxOkInPeriod) + if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > + pmlmepriv->LinkDetectInfo.tx_ok_in_period) bHigherBusyRxTraffic =3D true; else bHigherBusyTxTraffic =3D true; } =20 /* check traffic for powersaving. */ - if (((pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod + pmlmepriv->Link= DetectInfo.NumTxOkInPeriod) > 8) || - (pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod > 2)) { + if (((pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod + + pmlmepriv->LinkDetectInfo.tx_ok_in_period) > 8) || + (pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod > 2)) { bEnterPS =3D false; =20 if (bBusyTraffic) { @@ -1214,7 +1217,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, = u8 from_timer) } =20 pmlmepriv->LinkDetectInfo.NumRxOkInPeriod =3D 0; - pmlmepriv->LinkDetectInfo.NumTxOkInPeriod =3D 0; + pmlmepriv->LinkDetectInfo.tx_ok_in_period =3D 0; pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod =3D 0; pmlmepriv->LinkDetectInfo.bBusyTraffic =3D bBusyTraffic; pmlmepriv->LinkDetectInfo.bTxBusyTraffic =3D bTxBusyTraffic; diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 98704179ad35..6b8923109c47 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2518,7 +2518,7 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter,= struct xmit_frame *pxmitfr s32 bmcst =3D is_multicast_ether_addr(pattrib->ra); =20 /* if (bmcst || (padapter->mlmepriv.LinkDetectInfo.bTxBusyTraffic =3D=3D = false)) */ - if (bmcst || (padapter->mlmepriv.LinkDetectInfo.NumTxOkInPeriod < 100)) + if (bmcst || (padapter->mlmepriv.LinkDetectInfo.tx_ok_in_period < 100)) return; =20 priority =3D pattrib->priority; diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 97e38ef62ac4..39477b7c443d 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -403,10 +403,11 @@ static void update_attrib_vcs_info(struct adapter *pa= dapter, struct xmit_frame * =20 /* check HT op mode */ if (pattrib->ht_en) { - u8 HTOpMode =3D pmlmeinfo->HT_protection; + u8 ht_op_mode =3D pmlmeinfo->HT_protection; =20 - if ((pmlmeext->cur_bwmode && (HTOpMode =3D=3D 2 || HTOpMode =3D=3D 3))= || - (!pmlmeext->cur_bwmode && HTOpMode =3D=3D 3)) { + if ((pmlmeext->cur_bwmode && + (ht_op_mode =3D=3D 2 || ht_op_mode =3D=3D 3)) || + (!pmlmeext->cur_bwmode && ht_op_mode =3D=3D 3)) { pattrib->vcs_mode =3D RTS_CTS; break; } @@ -605,17 +606,17 @@ static void set_qos(struct pkt_file *ppktfile, struct= pkt_attrib *pattrib) { struct ethhdr etherhdr; struct iphdr ip_hdr; - s32 UserPriority =3D 0; + s32 user_priority =3D 0; =20 _rtw_open_pktfile(ppktfile->pkt, ppktfile); _rtw_pktfile_read(ppktfile, (unsigned char *)ðerhdr, ETH_HLEN); =20 - /* get UserPriority from IP hdr */ + /* get user_priority from IP hdr */ if (pattrib->ether_type =3D=3D 0x0800) { _rtw_pktfile_read(ppktfile, (u8 *)&ip_hdr, sizeof(ip_hdr)); - UserPriority =3D ip_hdr.tos >> 5; + user_priority =3D ip_hdr.tos >> 5; } - pattrib->priority =3D UserPriority; + pattrib->priority =3D user_priority; pattrib->hdrlen =3D WLAN_HDR_A3_QOS_LEN; pattrib->subtype =3D WIFI_QOS_DATA_TYPE; } @@ -1391,7 +1392,7 @@ void rtw_count_tx_stats(struct adapter *padapter, str= uct xmit_frame *pxmitframe, if ((pxmitframe->frame_tag & 0x0f) =3D=3D DATA_FRAMETAG) { pkt_num =3D pxmitframe->agg_num; =20 - pmlmepriv->LinkDetectInfo.NumTxOkInPeriod +=3D pkt_num; + pmlmepriv->LinkDetectInfo.tx_ok_in_period +=3D pkt_num; =20 pxmitpriv->tx_pkts +=3D pkt_num; =20 diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/r= tl8723bs/hal/hal_btcoex.c index 9105594d2dde..ad2b79cb6f0a 100644 --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c @@ -366,7 +366,7 @@ static u8 halbtcoutsrc_Get(void *pBtcContext, u8 getTyp= e, void *pOutBuf) struct rt_link_detect_t *plinkinfo; plinkinfo =3D &padapter->mlmepriv.LinkDetectInfo; =20 - if (plinkinfo->NumTxOkInPeriod > plinkinfo->NumRxOkInPeriod) + if (plinkinfo->tx_ok_in_period > plinkinfo->NumRxOkInPeriod) *pU4Tmp =3D BTC_WIFI_TRAFFIC_TX; else *pU4Tmp =3D BTC_WIFI_TRAFFIC_RX; diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme.h b/drivers/staging= /rtl8723bs/include/rtw_mlme.h index 2a128568c6df..b40b10a854a9 100644 --- a/drivers/staging/rtl8723bs/include/rtw_mlme.h +++ b/drivers/staging/rtl8723bs/include/rtw_mlme.h @@ -93,9 +93,9 @@ struct sitesurvey_ctrl { }; =20 struct rt_link_detect_t { - u32 NumTxOkInPeriod; - u32 NumRxOkInPeriod; - u32 NumRxUnicastOkInPeriod; + u32 tx_ok_in_period; + u32 NumRxOkInPeriod; + u32 NumRxUnicastOkInPeriod; bool bBusyTraffic; bool bTxBusyTraffic; bool bRxBusyTraffic; --=20 2.52.0