From nobody Sun Feb 8 03:27:19 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9610F358D0D for ; Thu, 15 Jan 2026 09:37:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768469846; cv=none; b=rjlTrxKlrztuPT5tfrTlwVACr5n8aRlYrwRGi3kjVcayZyPcD8nG5NzdqDIklplxE1xN19VHDh0E8CYHIvrvZeBa5PdeMbv99Rsw3X6XC8bwzEQ3YO0E23DafUjO4GdPOX5zsmXCloKKfzPX9Um4hd6vDienbKdJ3Hv6hiFx5DM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768469846; c=relaxed/simple; bh=qDuq0yGOKI22gOlKBf0PGwkkhhxaOIQfECBpMMLXSL8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=p6fYRra5HLlsJVencaG/+pOEYehlc1WKgtrj+jeL+XsehhL+xOo7EsZCaVyV0JT8hD49qy1Hfa/2AgW2LXCoz6Je6YMGlu0MjVHmWPxna2+KieSobnROu7DADQ7kaNMDnmg1LjJu/1atfRKslj7QNw7yaK2+MHFEeNFR8DW1mgw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UY4LYlyI; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UY4LYlyI" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2a07fac8aa1so5438775ad.1 for ; Thu, 15 Jan 2026 01:37:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768469844; x=1769074644; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eND/NhtLaC/z2AB8mlhX2K83B1CurXmM8VX2+usxEK0=; b=UY4LYlyI29geVYDJe6kUo4HCxranIXn6zkMmEwX+f2zy4mtBNRLpmNLIAlHCb7seY7 8H9TaARhl8lBbkI4GN0dLNnsMM1g+QIkVDXOxbxBgEf/YEB6OSkXVtmR7RzefjK8cAtT w2L0h2lkF6zpEQZAU5P6xwYkPOHZpD7MLxR5EvWNExMVGXOLYSI2vN/oNMhKjWKE/c7Y sMz+xdwoETyTjqEgUT1iqdBudM5L4gUwjFyAwv2JVFb1GMJ/A3bg8nxKoxb0InwOXYRo AldiTMa5OMkCe7L7i8WIhwkyD95LAnX0eNo9OQCZ6buzYZzdKk259HQiqJgMIsuAYiYH hQAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768469844; x=1769074644; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eND/NhtLaC/z2AB8mlhX2K83B1CurXmM8VX2+usxEK0=; b=CbiC7GhT5abn6VXBo6QnM72/9deH3xbnFYPvxFt24jSQ6J1rcZEhZq7RhDsIX5jjlx YaMfA4Qh5+jKZmvojd/H5Y/TzZbzN17od0nt2B40T74paSQtUiTgWqgKKQ1IknHH0nxk W9hxBTJVL3J8QPz7wAHqt1Myq8ncw6s2Q4dbpqmGTM87p7PA1Gd0Jx8s7nNQPn3nYKg2 H0ly7zL8pLiUWa68xjsYLbZ9oDCipXxrYR3Jlk78tpEItNUzuKAuILiwOvfbRnSzDZTr Cc6F9DtU0z35F924u+IbPGy9OhehyBpTqQEZ4fAyuKU+rjbISrUOcXrPQX2rBvlsya7V hz6Q== X-Forwarded-Encrypted: i=1; AJvYcCWd8o72unPX5K4q4G6YvQsDh0ztd1Zcogxz3DytkvQq7EKf4pyyRDv5LBBmYLpWwGC2H3TMP2LQEAZ5CaU=@vger.kernel.org X-Gm-Message-State: AOJu0YxTg5+QKTVMIsnloUsbyM1QmFt3MxtTpbpuNcgM3NpsSMpEMpx8 SyLBYwiI2lt00gWeCSyiDgZQRHXvZJQk5/ZlXHvd1Kjbq+/yMP+q8SwG X-Gm-Gg: AY/fxX6t2NniYILj9aIhFPArN8vJuCsz2E1SIWkT13SJV4DsrqJ88tAgcUiug39R83m fM4uoyJTrgXMkt/7KhE8oRqbVDQAtTaUp24/MXhtwp9IVCaosizCGAtsdJkN1DUToZR6aR41OGq NBhf8d6IT37eVcMPDynPqM2IYOXAIDOFbCgAnqFpOfIG5W8dds9+a9pkYcF4PN1TULjVCh40g3u MX7XV0FG0/dGX9BGNeOQF+Us4big86YIqduK+TULQpXEJLieCDYqXs8mm1Eh21/LpRFfNI0Awu/ B6qe6YnCnrwVdfShtTY347x1mzm0SezSwqX56XgPfdZ5s2OHiIJ8S3c8Rs8WGmBvznd3NKCPg1J 3aLFcLI6yiNeHHWh4D02D+3pVjNvJnyMMwKsvSpllk0i6LJDmtb1YT92CpR49MyRWbH1cIM9Vf2 EEQC1QJfmerwJUXz3wXS/RLXTOAA== X-Received: by 2002:a17:903:2a8e:b0:2a1:360c:3659 with SMTP id d9443c01a7336-2a599eab2e0mr63829705ad.58.1768469843667; Thu, 15 Jan 2026 01:37:23 -0800 (PST) Received: from snowman ([223.196.193.117]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c48dc1sm244063595ad.40.2026.01.15.01.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 01:37:23 -0800 (PST) From: Khushal Chitturi To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, hansg@kernel.org, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 1/4] staging: rtl8723bs: fix operator and type cast spacing Date: Thu, 15 Jan 2026 15:04:36 +0530 Message-ID: <20260115093439.7588-2-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115093439.7588-1-khushalchitturi@gmail.com> References: <20260115093439.7588-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix spacing around operators and type casts in rtw_xmit.c to comply with the kernel coding style. Signed-off-by: Khushal Chitturi --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 89 +++++++++++++---------- 1 file changed, 50 insertions(+), 39 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 21690857fd62..bbc42db1c828 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -78,7 +78,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, stru= ct adapter *padapter) } pxmitpriv->pxmit_frame_buf =3D (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitpriv= ->pallocated_frame_buf), 4); =20 - pxframe =3D (struct xmit_frame *) pxmitpriv->pxmit_frame_buf; + pxframe =3D (struct xmit_frame *)pxmitpriv->pxmit_frame_buf; =20 for (i =3D 0; i < NR_XMITFRAME; i++) { INIT_LIST_HEAD(&pxframe->list); @@ -238,7 +238,9 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) pxmitbuf->padapter =3D padapter; pxmitbuf->buf_tag =3D XMITBUF_CMD; =20 - res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_CMDBUF_SZ+XM= ITBUF_ALIGN_SZ, true); + res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, + MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ, + true); if (res =3D=3D _FAIL) { res =3D _FAIL; goto exit; @@ -248,7 +250,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) pxmitbuf->pend =3D pxmitbuf->pbuf + MAX_CMDBUF_SZ; pxmitbuf->len =3D 0; pxmitbuf->pdata =3D pxmitbuf->ptail =3D pxmitbuf->phead; - pxmitbuf->alloc_sz =3D MAX_CMDBUF_SZ+XMITBUF_ALIGN_SZ; + pxmitbuf->alloc_sz =3D MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ; } } =20 @@ -274,7 +276,7 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv) { int i; struct adapter *padapter =3D pxmitpriv->adapter; - struct xmit_frame *pxmitframe =3D (struct xmit_frame *) pxmitpriv->pxmit_= frame_buf; + struct xmit_frame *pxmitframe =3D (struct xmit_frame *)pxmitpriv->pxmit_f= rame_buf; struct xmit_buf *pxmitbuf =3D (struct xmit_buf *)pxmitpriv->pxmitbuf; =20 rtw_hal_free_xmit_priv(padapter); @@ -321,7 +323,9 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv) for (i =3D 0; i < CMDBUF_MAX; i++) { pxmitbuf =3D &pxmitpriv->pcmd_xmitbuf[i]; if (pxmitbuf) - rtw_os_xmit_resource_free(padapter, pxmitbuf, MAX_CMDBUF_SZ+XMITBUF_ALI= GN_SZ, true); + rtw_os_xmit_resource_free(padapter, pxmitbuf, + MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ, + true); } =20 rtw_free_hwxmits(padapter); @@ -736,7 +740,7 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p pattrib->subtype =3D WIFI_DATA_TYPE; pattrib->priority =3D 0; =20 - if (check_fwstate(pmlmepriv, WIFI_AP_STATE|WIFI_ADHOC_STATE|WIFI_ADHOC_MA= STER_STATE)) { + if (check_fwstate(pmlmepriv, WIFI_AP_STATE | WIFI_ADHOC_STATE | WIFI_ADHO= C_MASTER_STATE)) { if (pattrib->qos_en) set_qos(&pktfile, pattrib); } else { @@ -787,15 +791,15 @@ static s32 xmitframe_addmic(struct adapter *padapter,= struct xmit_frame *pxmitfr rtw_secmicsetkey(&micdata, &pattrib->dot11tkiptxmickey.skey[0]); } =20 - if (pframe[1]&1) { /* ToDS =3D=3D 1 */ + if (pframe[1] & 1) { /* ToDS =3D=3D 1 */ rtw_secmicappend(&micdata, &pframe[16], 6); /* DA */ - if (pframe[1]&2) /* From Ds =3D=3D 1 */ + if (pframe[1] & 2) /* From Ds =3D=3D 1 */ rtw_secmicappend(&micdata, &pframe[24], 6); else rtw_secmicappend(&micdata, &pframe[10], 6); } else { /* ToDS =3D=3D 0 */ rtw_secmicappend(&micdata, &pframe[4], 6); /* DA */ - if (pframe[1]&2) /* From Ds =3D=3D 1 */ + if (pframe[1] & 2) /* From Ds =3D=3D 1 */ rtw_secmicappend(&micdata, &pframe[16], 6); else rtw_secmicappend(&micdata, &pframe[10], 6); @@ -810,16 +814,20 @@ static s32 xmitframe_addmic(struct adapter *padapter,= struct xmit_frame *pxmitfr =20 for (curfragnum =3D 0; curfragnum < pattrib->nr_frags; curfragnum++) { payload =3D (u8 *)round_up((SIZE_PTR)(payload), 4); - payload =3D payload+pattrib->hdrlen+pattrib->iv_len; + payload =3D payload + pattrib->hdrlen + pattrib->iv_len; =20 - if ((curfragnum+1) =3D=3D pattrib->nr_frags) { - length =3D pattrib->last_txcmdsz-pattrib->hdrlen-pattrib->iv_len-((pa= ttrib->bswenc) ? pattrib->icv_len : 0); + if ((curfragnum + 1) =3D=3D pattrib->nr_frags) { + length =3D pattrib->last_txcmdsz - pattrib->hdrlen - + pattrib->iv_len - + ((pattrib->bswenc) ? pattrib->icv_len : 0); rtw_secmicappend(&micdata, payload, length); - payload =3D payload+length; + payload =3D payload + length; } else { - length =3D pxmitpriv->frag_len-pattrib->hdrlen-pattrib->iv_len-((patt= rib->bswenc) ? pattrib->icv_len : 0); + length =3D pxmitpriv->frag_len - pattrib->hdrlen - + pattrib->iv_len - + ((pattrib->bswenc) ? pattrib->icv_len : 0); rtw_secmicappend(&micdata, payload, length); - payload =3D payload+length+pattrib->icv_len; + payload =3D payload + length + pattrib->icv_len; } } rtw_secgetmic(&micdata, &mic[0]); @@ -1108,8 +1116,10 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter,= struct sk_buff *pkt, struct if (bmcst || (rtw_endofpktfile(&pktfile) =3D=3D true)) { pattrib->nr_frags =3D frg_inx; =20 - pattrib->last_txcmdsz =3D pattrib->hdrlen + pattrib->iv_len + ((pattrib= ->nr_frags =3D=3D 1) ? llc_sz:0) + - ((pattrib->bswenc) ? pattrib->icv_len : 0) + mem_sz; + pattrib->last_txcmdsz =3D pattrib->hdrlen + pattrib->iv_len + + ((pattrib->nr_frags =3D=3D 1) ? llc_sz : 0) + + ((pattrib->bswenc) ? pattrib->icv_len : 0) + + mem_sz; =20 ClearMFrag(mem_start); =20 @@ -1158,7 +1168,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padap= ter, struct sk_buff *pkt, s mem_start =3D pframe =3D (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET; pwlanhdr =3D (struct ieee80211_hdr *)pframe; =20 - ori_len =3D BIP_AAD_SIZE+pattrib->pktlen; + ori_len =3D BIP_AAD_SIZE + pattrib->pktlen; tmp_buf =3D BIP_AAD =3D rtw_zmalloc(ori_len); subtype =3D GetFrameSubType(pframe); /* bit(7)~bit(2) */ =20 @@ -1211,14 +1221,14 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *pad= apter, struct sk_buff *pkt, s /* conscruct AAD, copy address 1 to address 3 */ memcpy(BIP_AAD + 2, &pwlanhdr->addrs, sizeof(pwlanhdr->addrs)); /* copy management fram body */ - memcpy(BIP_AAD+BIP_AAD_SIZE, MGMT_body, frame_body_len); + memcpy(BIP_AAD + BIP_AAD_SIZE, MGMT_body, frame_body_len); /* calculate mic */ if (omac1_aes_128(padapter->securitypriv.dot11wBIPKey[padapter->security= priv.dot11wBIPKeyid].skey - , BIP_AAD, BIP_AAD_SIZE+frame_body_len, mic)) + , BIP_AAD, BIP_AAD_SIZE + frame_body_len, mic)) goto xmitframe_coalesce_fail; =20 /* copy right BIP mic value, total is 128bits, we use the 0~63 bits */ - memcpy(pframe-8, mic, 8); + memcpy(pframe - 8, mic, 8); } else { /* unicast mgmt frame TX */ /* start to encrypt mgmt frame */ if (subtype =3D=3D WIFI_DEAUTH || subtype =3D=3D WIFI_DISASSOC || @@ -1267,9 +1277,10 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *pada= pter, struct sk_buff *pkt, s memcpy(pframe, pattrib->iv, pattrib->iv_len); pframe +=3D pattrib->iv_len; /* copy mgmt data portion after CCMP header */ - memcpy(pframe, tmp_buf+pattrib->hdrlen, pattrib->pktlen-pattrib->hdrlen= ); + memcpy(pframe, tmp_buf + pattrib->hdrlen, + pattrib->pktlen - pattrib->hdrlen); /* move pframe to end of mgmt pkt */ - pframe +=3D pattrib->pktlen-pattrib->hdrlen; + pframe +=3D pattrib->pktlen - pattrib->hdrlen; /* add 8 bytes CCMP IV header to length */ pattrib->pktlen +=3D pattrib->iv_len; if ((pattrib->icv_len > 0) && (pattrib->bswenc)) { @@ -1375,7 +1386,7 @@ void rtw_count_tx_stats(struct adapter *padapter, str= uct xmit_frame *pxmitframe, struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; u8 pkt_num =3D 1; =20 - if ((pxmitframe->frame_tag&0x0f) =3D=3D DATA_FRAMETAG) { + if ((pxmitframe->frame_tag & 0x0f) =3D=3D DATA_FRAMETAG) { pkt_num =3D pxmitframe->agg_num; =20 pmlmepriv->LinkDetectInfo.NumTxOkInPeriod +=3D pkt_num; @@ -2070,7 +2081,7 @@ signed int xmitframe_enqueue_for_sleeping_sta(struct = adapter *padapter, struct x =20 spin_lock_bh(&psta->sleep_q.lock); =20 - if (psta->state&WIFI_SLEEP_STATE) { + if (psta->state & WIFI_SLEEP_STATE) { u8 wmmps_ac =3D 0; =20 if (pstapriv->sta_dz_bitmap & BIT(psta->aid)) { @@ -2083,20 +2094,20 @@ signed int xmitframe_enqueue_for_sleeping_sta(struc= t adapter *padapter, struct x switch (pattrib->priority) { case 1: case 2: - wmmps_ac =3D psta->uapsd_bk&BIT(0); + wmmps_ac =3D psta->uapsd_bk & BIT(0); break; case 4: case 5: - wmmps_ac =3D psta->uapsd_vi&BIT(0); + wmmps_ac =3D psta->uapsd_vi & BIT(0); break; case 6: case 7: - wmmps_ac =3D psta->uapsd_vo&BIT(0); + wmmps_ac =3D psta->uapsd_vo & BIT(0); break; case 0: case 3: default: - wmmps_ac =3D psta->uapsd_be&BIT(0); + wmmps_ac =3D psta->uapsd_be & BIT(0); break; } =20 @@ -2214,20 +2225,20 @@ void wakeup_sta_to_xmit(struct adapter *padapter, s= truct sta_info *psta) switch (pxmitframe->attrib.priority) { case 1: case 2: - wmmps_ac =3D psta->uapsd_bk&BIT(1); + wmmps_ac =3D psta->uapsd_bk & BIT(1); break; case 4: case 5: - wmmps_ac =3D psta->uapsd_vi&BIT(1); + wmmps_ac =3D psta->uapsd_vi & BIT(1); break; case 6: case 7: - wmmps_ac =3D psta->uapsd_vo&BIT(1); + wmmps_ac =3D psta->uapsd_vo & BIT(1); break; case 0: case 3: default: - wmmps_ac =3D psta->uapsd_be&BIT(1); + wmmps_ac =3D psta->uapsd_be & BIT(1); break; } =20 @@ -2259,7 +2270,7 @@ void wakeup_sta_to_xmit(struct adapter *padapter, str= uct sta_info *psta) =20 pstapriv->tim_bitmap &=3D ~BIT(psta->aid); =20 - if (psta->state&WIFI_SLEEP_STATE) + if (psta->state & WIFI_SLEEP_STATE) psta->state ^=3D WIFI_SLEEP_STATE; =20 if (psta->state & WIFI_STA_ALIVE_CHK_STATE) { @@ -2274,7 +2285,7 @@ void wakeup_sta_to_xmit(struct adapter *padapter, str= uct sta_info *psta) if (!psta_bmc) goto _exit; =20 - if ((pstapriv->sta_dz_bitmap&0xfffe) =3D=3D 0x0) { /* no any sta in ps mo= de */ + if ((pstapriv->sta_dz_bitmap & 0xfffe) =3D=3D 0x0) { /* no any sta in ps = mode */ xmitframe_phead =3D get_list_head(&psta_bmc->sleep_q); list_for_each_safe(xmitframe_plist, tmp, xmitframe_phead) { pxmitframe =3D list_entry(xmitframe_plist, @@ -2327,20 +2338,20 @@ void xmit_delivery_enabled_frames(struct adapter *p= adapter, struct sta_info *pst switch (pxmitframe->attrib.priority) { case 1: case 2: - wmmps_ac =3D psta->uapsd_bk&BIT(1); + wmmps_ac =3D psta->uapsd_bk & BIT(1); break; case 4: case 5: - wmmps_ac =3D psta->uapsd_vi&BIT(1); + wmmps_ac =3D psta->uapsd_vi & BIT(1); break; case 6: case 7: - wmmps_ac =3D psta->uapsd_vo&BIT(1); + wmmps_ac =3D psta->uapsd_vo & BIT(1); break; case 0: case 3: default: - wmmps_ac =3D psta->uapsd_be&BIT(1); + wmmps_ac =3D psta->uapsd_be & BIT(1); break; } =20 --=20 2.52.0 From nobody Sun Feb 8 03:27:19 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5B8B35BDD7 for ; Thu, 15 Jan 2026 09:37:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768469852; cv=none; b=ADAuk0gclxHZJb2Mv779oNJJYk908n/8t2eQF1hMQmhKGgq1oN5cTJUKu6oMVupPGrJL794pYehSdTezRUcC/0Z1054F/SbGe+n9MmeH6j/C0kECELTyuL5m2n1Sk/7ev7HvlfyGyVKzPEsQY5VYWcgbN6WsxYWdu9JTvuYF2wY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768469852; c=relaxed/simple; bh=3QdS/denaq16/3sivzZA0Q6Ucn9w5M5cvWYwrrN/Rcs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ned6T1wj5thgJdW+yYuy1Qsbcwe9y50dYAEBgFTuxi7LU3s4tVLXbj3BRYC6qAhwN8tlyXEKi5uwV0KBlzXrAfZLFShSgPgV6885xoGdrK4HAqmih6Zs9SfThJOvmVYL3eHJpDqRq2aN750oIE6Ml45qlJEih0gTSltM41jh0r8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WVfs6I3u; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WVfs6I3u" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2a0833b5aeeso7015485ad.1 for ; Thu, 15 Jan 2026 01:37:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768469850; x=1769074650; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/KWROqewGtb9x4YqcV1XLj0HExKDP9GByF0lRk9d/q0=; b=WVfs6I3ugTbZA1aLm27kcTzq6UgofMsorLu8Y1NzjaZx+d9axer0LMNHg3BY2/Tt/J 8rTUb4FhZnwI9KolJzSKXJuyL9qF3CuLCMq970yaCVv+rH/9OcoNmLHk1Ravw0snb7Qf HOKkA2IO3sDy1TSj2c+3Ltv9LIWu266hp1+IprjMvzE71R1uyB9gF85p4Lu6tD8GHCKf YA2+ZDPneJ+n6XFXky6dchVvoanuQAVQgMbqHDDo+Ubpv6M1KTILOpus7knILmSZF7bC HNNNZoH7tQ+C/sg2ajXrB8U242lwFb1kMBEHlK+EelrWWjSapykUr6p2aurPnSzNtpNc 2YkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768469850; x=1769074650; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/KWROqewGtb9x4YqcV1XLj0HExKDP9GByF0lRk9d/q0=; b=pJLc0OLFbh97+fKFcVQw5CnE6t6caQ15sxebgsU4z+MkA14GTFxoyVV4vLRIjpnIoJ b954/m+LM4x/rPa/ezip/1GqL+XOdBu8m1maprF3kryyTswigDbFVc82U+VMH6mBIhgC 9Upj2CPHUwhdmu9SsmAKU3HBg7tVfNx7QZ0xbyLo5k+Nc6asZBCvp2w04yE1NUzYKSDV LX/usbqZa9FA1ipxm/tNPaC1eeQZEmbyQV8bI2OVBlpj1hMFzkPVaEmS+RumsJwM1enW nVrgKlsDm+2zZU1z3xR5FGmNLR0CPuE+8AFmalBPOcXMP8+XO/klx8xKsm582xu0rklH rgHA== X-Forwarded-Encrypted: i=1; AJvYcCWnFIjBqU7DJwoz++45IInFmYQj+tbGyq1omhgu1/BZUttx+QTYIMSb4phsZhJ1rZosy67DGr4y1YaXIEo=@vger.kernel.org X-Gm-Message-State: AOJu0Yxk+IKW3/8HxvHRKJHxcGzbF9XUazQCnAgqdIXAADW8AVZa0Df0 vywI5blM7ZKjyuPkzjPTy0tIXXqtL3lRbLiswCwy4WUc6Bl0SJRwiyN4 X-Gm-Gg: AY/fxX64PS7PZE//jdHgaowoYcRGo1KfOFj6eB+qb0A0KJktKmVNGgk3Bv7nk+LQ2JH bQfGhoeXgNc/1DXsflBbC+i8H3Y7i42Z0kOIXyEAjQgjWPOaY0rSg7zVUNR980ZmwBfvWCVYhGN qDr7B6L17EhuvJmtef2ovqr0gqG0iZ6mK8Tr3PLdO+0jqYfFAYX46YX/NYDeJ842w2L0jKgPpSI sc8zwVrgvR/qPd7kkq18fPkRmT+zZW9QEzW+rfKNDevFSzuXWQa+inEZ10vstWC5eNXBBagSivw qS5WWJeM8qhXPwaIRI6BPzpv77Sf33XDCvruZbLwXsY+UhvQfd4tjautM5t2TfobcjvROr8MhZN +gZp0tcLocYMb357gNeEMv/fd8qKzaAnKH1G6iQqxs8NGd6FHtoVjWihBaEm6akh+3dKz8Mj3Qu 7ra05apQn/++8v0gA= X-Received: by 2002:a17:903:46cb:b0:2a0:b06d:1585 with SMTP id d9443c01a7336-2a599e12199mr61486395ad.34.1768469850051; Thu, 15 Jan 2026 01:37:30 -0800 (PST) Received: from snowman ([223.196.193.117]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c48dc1sm244063595ad.40.2026.01.15.01.37.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 01:37:29 -0800 (PST) From: Khushal Chitturi To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, hansg@kernel.org, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 2/4] staging: rtl8723bs: simplify boolean expressions Date: Thu, 15 Jan 2026 15:04:37 +0530 Message-ID: <20260115093439.7588-3-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115093439.7588-1-khushalchitturi@gmail.com> References: <20260115093439.7588-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplify boolean expressions in rtw_xmit.c to comply with the kernel coding style Signed-off-by: Khushal Chitturi hi to be squashed --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 38 ++++++++++++----------- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index bbc42db1c828..97e38ef62ac4 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -384,7 +384,8 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * } else { while (true) { /* IOT action */ - if ((pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_ATHEROS) && (pattrib= ->ampdu_en =3D=3D true) && + if ((pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_ATHEROS) && + (pattrib->ampdu_en) && (padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _AES_)) { pattrib->vcs_mode =3D CTS_TO_SELF; break; @@ -420,7 +421,7 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * /* to do list: check MIMO power save condition. */ =20 /* check AMPDU aggregation for TXOP */ - if (pattrib->ampdu_en =3D=3D true) { + if (pattrib->ampdu_en) { pattrib->vcs_mode =3D RTS_CTS; break; } @@ -482,10 +483,10 @@ static s32 update_attrib_sec_info(struct adapter *pad= apter, struct pkt_attrib *p memset(pattrib->dot11tkiptxmickey.skey, 0, 16); pattrib->mac_id =3D psta->mac_id; =20 - if (psta->ieee8021x_blocked =3D=3D true) { + if (psta->ieee8021x_blocked) { pattrib->encrypt =3D 0; =20 - if ((pattrib->ether_type !=3D 0x888e) && (check_fwstate(pmlmepriv, WIFI_= MP_STATE) =3D=3D false)) { + if ((pattrib->ether_type !=3D 0x888e) && (!check_fwstate(pmlmepriv, WIFI= _MP_STATE))) { res =3D _FAIL; goto exit; } @@ -639,8 +640,8 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p memcpy(pattrib->dst, ðerhdr.h_dest, ETH_ALEN); memcpy(pattrib->src, ðerhdr.h_source, ETH_ALEN); =20 - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { + if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) || + (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) { memcpy(pattrib->ra, pattrib->dst, ETH_ALEN); memcpy(pattrib->ta, pattrib->src, ETH_ALEN); } else if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { @@ -704,7 +705,8 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p if (!psta) { /* if we cannot get psta =3D> drop the pkt */ res =3D _FAIL; goto exit; - } else if ((check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) && (!(p= sta->state & _FW_LINKED))) { + } else if ((check_fwstate(pmlmepriv, WIFI_AP_STATE)) && + (!(psta->state & _FW_LINKED))) { res =3D _FAIL; goto exit; } @@ -880,7 +882,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr SetFrameSubType(fctrl, pattrib->subtype); =20 if (pattrib->subtype & WIFI_DATA_TYPE) { - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { /* to_ds =3D 1, fr_ds =3D 0; */ =20 { @@ -894,7 +896,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr =20 if (pqospriv->qos_option) qos_option =3D true; - } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) { + } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) { /* to_ds =3D 0, fr_ds =3D 1; */ SetFrDs(fctrl); memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN); @@ -903,8 +905,8 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr =20 if (pattrib->qos_en) qos_option =3D true; - } else if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { + } else if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) || + (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) { memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN); memcpy(pwlanhdr->addr2, pattrib->src, ETH_ALEN); memcpy(pwlanhdr->addr3, get_bssid(pmlmepriv), ETH_ALEN); @@ -962,7 +964,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr pattrib->ampdu_en =3D true; =20 /* re-check if enable ampdu by BA_starting_seqctrl */ - if (pattrib->ampdu_en =3D=3D true) { + if (pattrib->ampdu_en) { u16 tx_seq; =20 tx_seq =3D psta->BA_starting_seqctrl[pattrib->priority & 0x0f]; @@ -1113,7 +1115,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct =20 frg_inx++; =20 - if (bmcst || (rtw_endofpktfile(&pktfile) =3D=3D true)) { + if (bmcst || (rtw_endofpktfile(&pktfile))) { pattrib->nr_frags =3D frg_inx; =20 pattrib->last_txcmdsz =3D pattrib->hdrlen + pattrib->iv_len + @@ -1139,7 +1141,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct =20 xmitframe_swencrypt(padapter, pxmitframe); =20 - if (bmcst =3D=3D false) + if (!bmcst) update_attrib_vcs_info(padapter, pxmitframe); else pattrib->vcs_mode =3D NONE_VCS; @@ -1978,14 +1980,14 @@ s32 rtw_xmit(struct adapter *padapter, struct sk_bu= ff **ppkt) do_queue_select(padapter, &pxmitframe->attrib); =20 spin_lock_bh(&pxmitpriv->lock); - if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe) =3D=3D true)= { + if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe)) { spin_unlock_bh(&pxmitpriv->lock); return 1; } spin_unlock_bh(&pxmitpriv->lock); =20 /* pre_xmitframe */ - if (rtw_hal_xmit(padapter, pxmitframe) =3D=3D false) + if (!rtw_hal_xmit(padapter, pxmitframe)) return 1; =20 return 0; @@ -2029,7 +2031,7 @@ signed int xmitframe_enqueue_for_sleeping_sta(struct = adapter *padapter, struct x signed int bmcst =3D is_multicast_ether_addr(pattrib->ra); bool update_tim =3D false; =20 - if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D false) + if (!check_fwstate(pmlmepriv, WIFI_AP_STATE)) return ret; psta =3D rtw_get_stainfo(&padapter->stapriv, pattrib->ra); if (pattrib->psta !=3D psta) @@ -2154,7 +2156,7 @@ static void dequeue_xmitframes_to_sleeping_queue(stru= ct adapter *padapter, struc =20 ret =3D xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe); =20 - if (true =3D=3D ret) { + if (ret) { ptxservq =3D rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8= *)(&ac_index)); =20 ptxservq->qcnt--; --=20 2.52.0 From nobody Sun Feb 8 03:27:19 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A41535EDA1 for ; Thu, 15 Jan 2026 09:37:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768469859; cv=none; b=TKniVDZmoWe/lbBMoGaBELfRW+L81GB69nbRFwc/PI2rMz2r9Oex3g/8W8y0yzXWUMGhyl2k7HKPhy1NKdugNTUs6KN0cGmX1UQvRvbj29aAPuMABdT0EPk2drDr2M1XxMox9iNJGapF6dBPI7opE0FGwjxldHFB2ymW2ww0ewk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768469859; c=relaxed/simple; bh=fnFV8PBNQlippHm1HirX/EXSWFlF7ZQmPRG49u4zF0k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VJIY9mHDduclFSBtIThR0U0xNJ+/ZysPC+UFFqYQ87LxdqsTP1UOC/Qn9tgL51QGxXurYx/gquqU8My1Ff3Ouqbm2gCsnrZGMPg+a1rLv4SCAOfAbOODtsHakbxg7BDwq4TW/5Rtrjd6udizm6+aGAzt15E2NCexyv5S0lHeLZs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ceL96QWM; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ceL96QWM" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2a3e76d0f64so9064255ad.1 for ; Thu, 15 Jan 2026 01:37:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768469856; x=1769074656; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tlvyCIH2YNVvl+Z7egcO8FGfVtyV86Fgh9Yw7qPMcmQ=; b=ceL96QWMPmv5q1KiF5H29tWcNOy/+2YNlyfqXCMV500SNnHE0pt9umPTnB3eASthbl vKRJX3XOITzm/ArqnG1StqDdLq56ioNR6Xphp+fzxudo5fNg8gXBsbJGM5UB2YweIDLj xMmjfoZpU0+ck3V4tjkqW8IOlzC1bR84LAWG9A2LIJ5F9XBCiBqUMKsqM8vECd8pL/sK 20b/5dJaXGwI3lnCgQuGKXpUzEQ6zhvlvetal1zeQ+wVMYYXP2oW7iNzdF2nnuiumu45 +15OHlA8yXLUneMVkEjP5yi9cOUr1dgPV5PHNK48tcMYt5klWhquJwa1p9qEP9hYjLwl jmDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768469856; x=1769074656; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tlvyCIH2YNVvl+Z7egcO8FGfVtyV86Fgh9Yw7qPMcmQ=; b=ukOb42zGtPzzYTOFabQW6FuxJ9VoQmVC5IWj4iD21mO9hVG3vlX2wWVLknGEhYCSGZ B8nFzpttqe3Oamsye11M+/s8N2fmBid5cQ8jTwKBWfsw6EXaemzGh5Y3BlZbOWZc8lD1 x6LG3cnxDiyS8lNjGnCCBiT1zHxBYoB3NYl576e8qKKir80MOeKguk21yo1fOjJREEga o8GPqs35es4Sxw1X5kNtK2T/mYov6HVbuMl7HRxcsoms995o4UH7Td3QKAT7/zyQieYZ oFRDekCx9AsPPx7A/SLynbKMsZSa/RavIxGI7DIRJXEZjVtR2JA9LOQUOoKy2x9eDOxP DvUw== X-Forwarded-Encrypted: i=1; AJvYcCXMudNwIftJQQmvZ7dTl3LHl/B3XqWNpSL7CpdSvpJ9ZEo6JrNYsnDeVP9/4rPDo6yiW6l7WQj6dQskJZ8=@vger.kernel.org X-Gm-Message-State: AOJu0YwUG49s4Cqtk9HBfc9B+CNkvbNoTx5dIt8P4SCZ+g8O0jrFSOEV kTrmnWDtXpJT0hpYIwwDPo/yy+hlGhrkceeTubMfY2xM+sBlobEkHsLi X-Gm-Gg: AY/fxX6AIv+zb80oE0BZbgA3BvfXLyh2zxZIxLRKn2pK8QPV80GV2djkOgLxEN30/+7 +9mZ4ZHiCd2C06nq8wIHRMB20+OLzWBsavSvbcVdaOQ6FaFEuworvTk4gbE9QqjNx3/9hd0/+tW 58wTCM3JbYWeD/sKvDKv/rMrSsqQDIpR9nyOZdDHBw2PWubyZZL1zysmzMtijrgf6g8X7bhzT45 XMQvozklhZ88RqSyOSpc2jY7NTl5D7YhM3oG9DPgw0MntrcS5g26OS4SQyRK8ZlIACEpkNYSNvV Q6oiQqi4ZyLEoWPyWM9+Jj+o6Tls/SiqeGq6mXczNz2oE+VOiTT97J7oqnb3abohXwkVnqvjXvx nThX5/YjKjhPtVfsnhPD1hEyfp8Q9OIM4ZDEbnzda0b5wdsHQNorZ1yxZ+5qbKJ1dlhxqKvlT75 bvs3+eZVRXbxcGdiY= X-Received: by 2002:a17:902:ecc5:b0:2a1:3769:1d02 with SMTP id d9443c01a7336-2a7009be24emr27023875ad.12.1768469856248; Thu, 15 Jan 2026 01:37:36 -0800 (PST) Received: from snowman ([223.196.193.117]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c48dc1sm244063595ad.40.2026.01.15.01.37.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 01:37:35 -0800 (PST) From: Khushal Chitturi To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, hansg@kernel.org, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 3/4] staging: rtl8723bs: rename CamelCase identifiers to snake_case Date: Thu, 15 Jan 2026 15:04:38 +0530 Message-ID: <20260115093439.7588-4-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115093439.7588-1-khushalchitturi@gmail.com> References: <20260115093439.7588-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename several CamelCase identifiers across the driver to follow kernel naming conventions. The following identifiers were renamed: 1) UserPriority to user_priority 2) NumTxOkInPeriod to tx_ok_in_period 3) HTOpMode to ht_op_mode Signed-off-by: Khushal Chitturi nits tbswpo tbswpo --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 17 ++++++++++------- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- drivers/staging/rtl8723bs/core/rtw_xmit.c | 17 +++++++++-------- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +- drivers/staging/rtl8723bs/include/rtw_mlme.h | 6 +++--- 5 files changed, 24 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl= 8723bs/core/rtw_cmd.c index ef2d92b5588a..005e6737e1af 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -1148,10 +1148,11 @@ u8 traffic_status_watchdog(struct adapter *padapter= , u8 from_timer) BusyThreshold =3D BusyThresholdLow; =20 if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > BusyThreshold || - pmlmepriv->LinkDetectInfo.NumTxOkInPeriod > BusyThreshold) { + pmlmepriv->LinkDetectInfo.tx_ok_in_period > BusyThreshold) { bBusyTraffic =3D true; =20 - if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > pmlmepriv->LinkDetectIn= fo.NumTxOkInPeriod) + if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > + pmlmepriv->LinkDetectInfo.tx_ok_in_period) bRxBusyTraffic =3D true; else bTxBusyTraffic =3D true; @@ -1159,18 +1160,20 @@ u8 traffic_status_watchdog(struct adapter *padapter= , u8 from_timer) =20 /* Higher Tx/Rx data. */ if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > 4000 || - pmlmepriv->LinkDetectInfo.NumTxOkInPeriod > 4000) { + pmlmepriv->LinkDetectInfo.tx_ok_in_period > 4000) { bHigherBusyTraffic =3D true; =20 - if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > pmlmepriv->LinkDetectIn= fo.NumTxOkInPeriod) + if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > + pmlmepriv->LinkDetectInfo.tx_ok_in_period) bHigherBusyRxTraffic =3D true; else bHigherBusyTxTraffic =3D true; } =20 /* check traffic for powersaving. */ - if (((pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod + pmlmepriv->Link= DetectInfo.NumTxOkInPeriod) > 8) || - (pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod > 2)) { + if (((pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod + + pmlmepriv->LinkDetectInfo.tx_ok_in_period) > 8) || + (pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod > 2)) { bEnterPS =3D false; =20 if (bBusyTraffic) { @@ -1214,7 +1217,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, = u8 from_timer) } =20 pmlmepriv->LinkDetectInfo.NumRxOkInPeriod =3D 0; - pmlmepriv->LinkDetectInfo.NumTxOkInPeriod =3D 0; + pmlmepriv->LinkDetectInfo.tx_ok_in_period =3D 0; pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod =3D 0; pmlmepriv->LinkDetectInfo.bBusyTraffic =3D bBusyTraffic; pmlmepriv->LinkDetectInfo.bTxBusyTraffic =3D bTxBusyTraffic; diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 98704179ad35..6b8923109c47 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2518,7 +2518,7 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter,= struct xmit_frame *pxmitfr s32 bmcst =3D is_multicast_ether_addr(pattrib->ra); =20 /* if (bmcst || (padapter->mlmepriv.LinkDetectInfo.bTxBusyTraffic =3D=3D = false)) */ - if (bmcst || (padapter->mlmepriv.LinkDetectInfo.NumTxOkInPeriod < 100)) + if (bmcst || (padapter->mlmepriv.LinkDetectInfo.tx_ok_in_period < 100)) return; =20 priority =3D pattrib->priority; diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 97e38ef62ac4..39477b7c443d 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -403,10 +403,11 @@ static void update_attrib_vcs_info(struct adapter *pa= dapter, struct xmit_frame * =20 /* check HT op mode */ if (pattrib->ht_en) { - u8 HTOpMode =3D pmlmeinfo->HT_protection; + u8 ht_op_mode =3D pmlmeinfo->HT_protection; =20 - if ((pmlmeext->cur_bwmode && (HTOpMode =3D=3D 2 || HTOpMode =3D=3D 3))= || - (!pmlmeext->cur_bwmode && HTOpMode =3D=3D 3)) { + if ((pmlmeext->cur_bwmode && + (ht_op_mode =3D=3D 2 || ht_op_mode =3D=3D 3)) || + (!pmlmeext->cur_bwmode && ht_op_mode =3D=3D 3)) { pattrib->vcs_mode =3D RTS_CTS; break; } @@ -605,17 +606,17 @@ static void set_qos(struct pkt_file *ppktfile, struct= pkt_attrib *pattrib) { struct ethhdr etherhdr; struct iphdr ip_hdr; - s32 UserPriority =3D 0; + s32 user_priority =3D 0; =20 _rtw_open_pktfile(ppktfile->pkt, ppktfile); _rtw_pktfile_read(ppktfile, (unsigned char *)ðerhdr, ETH_HLEN); =20 - /* get UserPriority from IP hdr */ + /* get user_priority from IP hdr */ if (pattrib->ether_type =3D=3D 0x0800) { _rtw_pktfile_read(ppktfile, (u8 *)&ip_hdr, sizeof(ip_hdr)); - UserPriority =3D ip_hdr.tos >> 5; + user_priority =3D ip_hdr.tos >> 5; } - pattrib->priority =3D UserPriority; + pattrib->priority =3D user_priority; pattrib->hdrlen =3D WLAN_HDR_A3_QOS_LEN; pattrib->subtype =3D WIFI_QOS_DATA_TYPE; } @@ -1391,7 +1392,7 @@ void rtw_count_tx_stats(struct adapter *padapter, str= uct xmit_frame *pxmitframe, if ((pxmitframe->frame_tag & 0x0f) =3D=3D DATA_FRAMETAG) { pkt_num =3D pxmitframe->agg_num; =20 - pmlmepriv->LinkDetectInfo.NumTxOkInPeriod +=3D pkt_num; + pmlmepriv->LinkDetectInfo.tx_ok_in_period +=3D pkt_num; =20 pxmitpriv->tx_pkts +=3D pkt_num; =20 diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/r= tl8723bs/hal/hal_btcoex.c index 9105594d2dde..ad2b79cb6f0a 100644 --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c @@ -366,7 +366,7 @@ static u8 halbtcoutsrc_Get(void *pBtcContext, u8 getTyp= e, void *pOutBuf) struct rt_link_detect_t *plinkinfo; plinkinfo =3D &padapter->mlmepriv.LinkDetectInfo; =20 - if (plinkinfo->NumTxOkInPeriod > plinkinfo->NumRxOkInPeriod) + if (plinkinfo->tx_ok_in_period > plinkinfo->NumRxOkInPeriod) *pU4Tmp =3D BTC_WIFI_TRAFFIC_TX; else *pU4Tmp =3D BTC_WIFI_TRAFFIC_RX; diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme.h b/drivers/staging= /rtl8723bs/include/rtw_mlme.h index 2a128568c6df..b40b10a854a9 100644 --- a/drivers/staging/rtl8723bs/include/rtw_mlme.h +++ b/drivers/staging/rtl8723bs/include/rtw_mlme.h @@ -93,9 +93,9 @@ struct sitesurvey_ctrl { }; =20 struct rt_link_detect_t { - u32 NumTxOkInPeriod; - u32 NumRxOkInPeriod; - u32 NumRxUnicastOkInPeriod; + u32 tx_ok_in_period; + u32 NumRxOkInPeriod; + u32 NumRxUnicastOkInPeriod; bool bBusyTraffic; bool bTxBusyTraffic; bool bRxBusyTraffic; --=20 2.52.0 From nobody Sun Feb 8 03:27:19 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA55235EDC3 for ; Thu, 15 Jan 2026 09:37:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768469865; cv=none; b=ASwnSauZ/ZBLQ2LttzCZ8LPlzfsAeAMyWAF7sSkNee/QnAyaXO/XfeMJW6rkGedJHvM2tzHkD4nCn7ytUUmFb8iY/4PEpAOkwDC0+6E/R6aiWZgMSp5oe/7UDbx6eKpNgtGMe4i/75qC1w4SmseO0s9sDx0pq4jMqV7GQ2ulxy0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768469865; c=relaxed/simple; bh=en1K2qY0OfCkmIAVuqViWryjD4SE6e10f53/nwuSOsg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N1RbV2QNzL8UWhEOMJKB6vWw9A4fK0FmV92HAk4UbQ8Q43pgLeieN5F7+fDdQQWeLCT77r6CPEGoRfHEHH4m6jbDWA66x5QLc+4vZjanKXnFaSt/6XYC/chQHUE5mSuMrggqtmJ4rKr1I5AYAWhSndw2/qXj08dvMVTBKadFlcg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GeL8kv1d; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GeL8kv1d" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2a1022dda33so4248815ad.2 for ; Thu, 15 Jan 2026 01:37:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768469863; x=1769074663; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u81+X0PCCkWJbRTw0ieif5+Qw0Ru+KM/itZu0huPlnA=; b=GeL8kv1d0lF2PERbLoNs8UVrRHWxDTRxgXIEzM4yXzkFuu4AtXsGgk/ILPyAeAOAM1 9wI+i/cpOwlQqQ2eMPNx7wibTdTjmGmstkb2tByx/h6boZr7psrbWTN1OVoF3nqXCJeS OPKds1ucLlNC5YPYZ7BSdjN35s+tubBmcBqLPtgsIeXPRSxmq8DuPSE6/oFDcqz6EpOV dIH/Uxl8yAfHJ8AfzUVjF34n8fXppK2HrtFHwROL9t1VHulP1LNlUUttwBqbcvP03xkC xb+iYSXMOY08iCmvsb/glGODfaGUxJL5/1ZA9caYNlU8iN3gEtwxBp+ob4M8JPX+yjw6 lw8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768469863; x=1769074663; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=u81+X0PCCkWJbRTw0ieif5+Qw0Ru+KM/itZu0huPlnA=; b=W3Hp3Dv2FnJPAAyS+bTIjGHKAnt7+vSM/JpFaJ37KgwxNgEoYxy2uK43XOB/vbAl6/ 8YGCznKGXZhSVLWqaeQYhvD9PBJqSJ5RWzr7uLoi+kxL5Yf6TroasNYtxXzCDM4XWXje //aDAktJ8ScVhbg/XOepNk6VdwPWB/NnKQR/wauH3JGWroTB9ZljhXQBh5lkspueqGmO gMjvklFoBqXHW860IGHW1W9b2d1nZknX2w3nuVHP5L3ya1NY+H2ZS5K2pFtgTga9VFI6 k4jbDf6a4dbyj5AW6Wf+62cr6i9st6rC0FAdhJoRE12h32JaWLTUqd0pCQmPEVZT8Jdr a2jQ== X-Forwarded-Encrypted: i=1; AJvYcCXgCXtbNyGXci++jUCnxTmKWPbNCz3xQ8xCJI17ZruWV3ObIoCsFeMJTU7qG0YiBJllYO1h+71Fmf/57lU=@vger.kernel.org X-Gm-Message-State: AOJu0YxyLGpxd/iNooCQhp1/qkhZl0hpT1P7bGUF+0ycK311h/pWg9EL 4lxrZdtuPzC0sM2UT8G4k+PkR6Vq++TTYHFHkbKIkQETcQ2LC4AS9f9w X-Gm-Gg: AY/fxX7/GEKQu1o1akcNXmUdKVy8FILCyxGXCrLtV0njP9abajkMKu+zhlMS697tzym x0TKsw4H05eoR7v68dToN+DBQN6BWvFA9hYTYUS4ui5e5eJUCjjLchixKnU8JBVphRZGkTHKs5O II3mUflEC3El0Yu4eje24Y0wMqBZo7xPArpqvIIh6jxIfkuKV75P4RkqyTI4LJIvoQmS/BmPdTy a7lAkieXdtluUa6JxldWG65jCYX2PkvYx3kr6hZBlacv7tydQz8b7s/CqMl5Q7vnvXnJ13lWmrt fHTIa0n5bPT8Nm1bQkMD/kNAjBBVkMWqeBAX1zAp6ZZihiR03JtxyzIr7g1tcKORlC2S/+Ycz5m c5EHFejMliX1zcnMRyoyatcyDeUrbFoD1zqO6wEdnNBwiuIqZk5jW81ROMMixenuQWEeXMDTA1t 0BGYoyp69bHfDO1dA= X-Received: by 2002:a17:902:f54e:b0:295:570d:116e with SMTP id d9443c01a7336-2a599e22084mr56689885ad.41.1768469863256; Thu, 15 Jan 2026 01:37:43 -0800 (PST) Received: from snowman ([223.196.193.117]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c48dc1sm244063595ad.40.2026.01.15.01.37.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 01:37:42 -0800 (PST) From: Khushal Chitturi To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, hansg@kernel.org, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 4/4] staging: rtl8723bs: fix line length and alignment issues Date: Thu, 15 Jan 2026 15:04:39 +0530 Message-ID: <20260115093439.7588-5-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115093439.7588-1-khushalchitturi@gmail.com> References: <20260115093439.7588-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix multiple coding style issues in rtw_xmit.c to comply with the kernel coding style by splitting expressions and adjusting alignment. This patch resolves checkpatch.pl warnings caused by line length exceeding 100 columns and alignment matching the open parenthesis. Signed-off-by: Khushal Chitturi --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 94 +++++++++++++++-------- 1 file changed, 60 insertions(+), 34 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 39477b7c443d..4cc41d1f4836 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -126,10 +126,14 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, = struct adapter *padapter) pxmitbuf->buf_tag =3D XMITBUF_DATA; =20 /* Tx buf allocation may fail sometimes, so sleep and retry. */ - res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ += XMITBUF_ALIGN_SZ), true); + res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, + (MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ), + true); if (res =3D=3D _FAIL) { msleep(10); - res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ = + XMITBUF_ALIGN_SZ), true); + res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, + (MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ), + true); if (res =3D=3D _FAIL) goto exit; } @@ -208,7 +212,9 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) pxmitbuf->padapter =3D padapter; pxmitbuf->buf_tag =3D XMITBUF_MGNT; =20 - res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_XMIT_EXTBUF_S= Z + XMITBUF_ALIGN_SZ, true); + res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, + MAX_XMIT_EXTBUF_SZ + XMITBUF_ALIGN_SZ, + true); if (res =3D=3D _FAIL) { res =3D _FAIL; goto exit; @@ -291,7 +297,9 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv) } =20 for (i =3D 0; i < NR_XMITBUFF; i++) { - rtw_os_xmit_resource_free(padapter, pxmitbuf, (MAX_XMITBUF_SZ + XMITBUF_= ALIGN_SZ), true); + rtw_os_xmit_resource_free(padapter, pxmitbuf, + (MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ), + true); =20 pxmitbuf++; } @@ -313,7 +321,9 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv) /* free xmit extension buff */ pxmitbuf =3D (struct xmit_buf *)pxmitpriv->pxmit_extbuf; for (i =3D 0; i < NR_XMIT_EXTBUFF; i++) { - rtw_os_xmit_resource_free(padapter, pxmitbuf, (MAX_XMIT_EXTBUF_SZ + XMIT= BUF_ALIGN_SZ), true); + rtw_os_xmit_resource_free(padapter, pxmitbuf, + (MAX_XMIT_EXTBUF_SZ + XMITBUF_ALIGN_SZ), + true); =20 pxmitbuf++; } @@ -367,7 +377,9 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * sz =3D pattrib->last_txcmdsz; =20 /* (1) RTS_Threshold is compared to the MPDU, not MSDU. */ - /* (2) If there are more than one frag in this MSDU, only the first fra= g uses protection frame. */ + /* (2) If there are more than one frag in this MSDU, + * only the first frag uses protection frame. + */ /* Other fragments are protected by previous fragment. */ /* So we only need to check the length of first fragment. */ if (pmlmeext->cur_wireless_mode < WIRELESS_11_24N || padapter->registryp= riv.wifi_spec) { @@ -437,7 +449,8 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * pattrib->vcs_mode =3D padapter->driver_vcs_type; } =20 -static void update_attrib_phy_info(struct adapter *padapter, struct pkt_at= trib *pattrib, struct sta_info *psta) +static void update_attrib_phy_info(struct adapter *padapter, struct pkt_at= trib *pattrib, + struct sta_info *psta) { struct mlme_ext_priv *mlmeext =3D &padapter->mlmeextpriv; =20 @@ -465,7 +478,8 @@ static void update_attrib_phy_info(struct adapter *pada= pter, struct pkt_attrib * pattrib->ch_offset =3D psta->htpriv.ch_offset; pattrib->ampdu_en =3D false; =20 - if (padapter->driver_ampdu_spacing !=3D 0xFF) /* driver control AMPDU Den= sity for peer sta's rx */ + /* driver control AMPDU Density for peer sta's rx */ + if (padapter->driver_ampdu_spacing !=3D 0xFF) pattrib->ampdu_spacing =3D padapter->driver_ampdu_spacing; else pattrib->ampdu_spacing =3D psta->htpriv.rx_ampdu_min_spacing; @@ -473,7 +487,8 @@ static void update_attrib_phy_info(struct adapter *pada= pter, struct pkt_attrib * pattrib->retry_ctrl =3D false; } =20 -static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_att= rib *pattrib, struct sta_info *psta) +static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_att= rib *pattrib, + struct sta_info *psta) { signed int res =3D _SUCCESS; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; @@ -512,7 +527,8 @@ static s32 update_attrib_sec_info(struct adapter *padap= ter, struct pkt_attrib *p } =20 /* For WPS 1.0 WEP, driver should not encrypt EAPOL Packet for WPS hands= hake. */ - if (((pattrib->encrypt =3D=3D _WEP40_) || (pattrib->encrypt =3D=3D _WEP1= 04_)) && (pattrib->ether_type =3D=3D 0x888e)) + if (((pattrib->encrypt =3D=3D _WEP40_) || (pattrib->encrypt =3D=3D _WEP1= 04_)) && + (pattrib->ether_type =3D=3D 0x888e)) pattrib->encrypt =3D _NO_PRIVACY_; } =20 @@ -564,7 +580,7 @@ static s32 update_attrib_sec_info(struct adapter *padap= ter, struct pkt_attrib *p memcpy(pattrib->dot118021x_UncstKey.skey, psta->dot118021x_UncstKey.skey= , 16); =20 if (pattrib->encrypt && - ((padapter->securitypriv.sw_encrypt) || (!psecuritypriv->hw_decrypted))) + ((padapter->securitypriv.sw_encrypt) || (!psecuritypriv->hw_decrypted= ))) pattrib->bswenc =3D true; else pattrib->bswenc =3D false; @@ -656,7 +672,9 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p pattrib->pktlen =3D pktfile.pkt_len; =20 if (pattrib->ether_type =3D=3D ETH_P_IP) { - /* The following is for DHCP and ARP packet, we use cck1M to tx these p= ackets and let LPS awake some time */ + /* The following is for DHCP and ARP packet, + * we use cck1M to tx these packets and let LPS awake some time + */ /* to prevent DHCP protocol fail */ =20 u8 tmp[24]; @@ -667,7 +685,7 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p if (pktfile.pkt_len > 282) {/* MINIMUM_DHCP_PACKET_SIZE) { */ if (pattrib->ether_type =3D=3D ETH_P_IP) {/* IP header */ if (((tmp[21] =3D=3D 68) && (tmp[23] =3D=3D 67)) || - ((tmp[21] =3D=3D 67) && (tmp[23] =3D=3D 68))) { + ((tmp[21] =3D=3D 67) && (tmp[23] =3D=3D 68))) { /* 68 : UDP BOOTP client */ /* 67 : UDP BOOTP server */ pattrib->dhcp_pkt =3D 1; @@ -778,7 +796,8 @@ static s32 xmitframe_addmic(struct adapter *padapter, s= truct xmit_frame *pxmitfr if (pattrib->encrypt =3D=3D _TKIP_) { /* encode mic code */ { - u8 null_key[16] =3D {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, = 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}; + u8 null_key[16] =3D {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, + 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}; =20 pframe =3D pxmitframe->buf_addr + hw_hdr_offset; =20 @@ -999,9 +1018,9 @@ s32 rtw_txframes_pending(struct adapter *padapter) struct xmit_priv *pxmitpriv =3D &padapter->xmitpriv; =20 return ((!list_empty(&pxmitpriv->be_pending.queue)) || - (!list_empty(&pxmitpriv->bk_pending.queue)) || - (!list_empty(&pxmitpriv->vi_pending.queue)) || - (!list_empty(&pxmitpriv->vo_pending.queue))); + (!list_empty(&pxmitpriv->bk_pending.queue)) || + (!list_empty(&pxmitpriv->vi_pending.queue)) || + (!list_empty(&pxmitpriv->vo_pending.queue))); } =20 /* @@ -1031,7 +1050,8 @@ u32 rtw_calculate_wlan_pkt_size_by_attribue(struct pk= t_attrib *pattrib) * 5. move frag chunk from pframe to pxmitframe->mem * 6. apply sw-encrypt, if necessary. */ -s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, = struct xmit_frame *pxmitframe) +s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, + struct xmit_frame *pxmitframe) { struct pkt_file pktfile; =20 @@ -1152,7 +1172,8 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct } =20 /* broadcast or multicast management pkt use BIP, unicast management pkt u= se CCMP encryption */ -s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *= pkt, struct xmit_frame *pxmitframe) +s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *= pkt, + struct xmit_frame *pxmitframe) { u8 *pframe, *mem_start =3D NULL, *tmp_buf =3D NULL; u8 subtype; @@ -1235,7 +1256,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padap= ter, struct sk_buff *pkt, s } else { /* unicast mgmt frame TX */ /* start to encrypt mgmt frame */ if (subtype =3D=3D WIFI_DEAUTH || subtype =3D=3D WIFI_DISASSOC || - subtype =3D=3D WIFI_REASSOCREQ || subtype =3D=3D WIFI_ACTION) { + subtype =3D=3D WIFI_REASSOCREQ || subtype =3D=3D WIFI_ACTION) { if (pattrib->psta) psta =3D pattrib->psta; else @@ -1249,11 +1270,11 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *pad= apter, struct sk_buff *pkt, s =20 /* according 802.11-2012 standard, these five types are not robust type= s */ if (subtype =3D=3D WIFI_ACTION && - (pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_PUBLIC || - pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_HT || - pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_UNPROTECTED_WNM || - pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_SELF_PROTECTED || - pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_P2P)) + (pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_PUBLIC || + pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_HT || + pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_UNPROTECTED_WNM || + pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_SELF_PROTECTED || + pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_P2P)) goto xmitframe_coalesce_fail; /* before encrypt dump the management packet content */ if (pattrib->encrypt > 0) @@ -1410,7 +1431,7 @@ void rtw_count_tx_stats(struct adapter *padapter, str= uct xmit_frame *pxmitframe, } =20 static struct xmit_buf *__rtw_alloc_cmd_xmitbuf(struct xmit_priv *pxmitpri= v, - enum cmdbuf_type buf_type) + enum cmdbuf_type buf_type) { struct xmit_buf *pxmitbuf =3D NULL; =20 @@ -1431,7 +1452,7 @@ static struct xmit_buf *__rtw_alloc_cmd_xmitbuf(struc= t xmit_priv *pxmitpriv, } =20 struct xmit_frame *__rtw_alloc_cmdxmitframe(struct xmit_priv *pxmitpriv, - enum cmdbuf_type buf_type) + enum cmdbuf_type buf_type) { struct xmit_frame *pcmdframe; struct xmit_buf *pxmitbuf; @@ -1768,7 +1789,8 @@ s32 rtw_xmitframe_enqueue(struct adapter *padapter, s= truct xmit_frame *pxmitfram return _SUCCESS; } =20 -struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, struct sta_= info *psta, signed int up, u8 *ac) +struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, struct sta_= info *psta, + signed int up, u8 *ac) { struct tx_servq *ptxservq =3D NULL; =20 @@ -2022,7 +2044,8 @@ inline bool xmitframe_hiq_filter(struct xmit_frame *x= mitframe) return allow; } =20 -signed int xmitframe_enqueue_for_sleeping_sta(struct adapter *padapter, st= ruct xmit_frame *pxmitframe) +signed int xmitframe_enqueue_for_sleeping_sta(struct adapter *padapter, + struct xmit_frame *pxmitframe) { signed int ret =3D false; struct sta_info *psta =3D NULL; @@ -2117,7 +2140,8 @@ signed int xmitframe_enqueue_for_sleeping_sta(struct = adapter *padapter, struct x if (wmmps_ac) psta->sleepq_ac_len++; =20 - if (((psta->has_legacy_ac) && (!wmmps_ac)) || ((!psta->has_legacy_ac) &= & (wmmps_ac))) { + if (((psta->has_legacy_ac) && (!wmmps_ac)) || + ((!psta->has_legacy_ac) && (wmmps_ac))) { if (!(pstapriv->tim_bitmap & BIT(psta->aid))) update_tim =3D true; =20 @@ -2137,7 +2161,8 @@ signed int xmitframe_enqueue_for_sleeping_sta(struct = adapter *padapter, struct x return ret; } =20 -static void dequeue_xmitframes_to_sleeping_queue(struct adapter *padapter,= struct sta_info *psta, struct __queue *pframequeue) +static void dequeue_xmitframes_to_sleeping_queue(struct adapter *padapter,= struct sta_info *psta, + struct __queue *pframequeue) { signed int ret; struct list_head *plist, *phead, *tmp; @@ -2158,7 +2183,8 @@ static void dequeue_xmitframes_to_sleeping_queue(stru= ct adapter *padapter, struc ret =3D xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe); =20 if (ret) { - ptxservq =3D rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8= *)(&ac_index)); + ptxservq =3D rtw_get_sta_pending(padapter, psta, pattrib->priority, + (u8 *)(&ac_index)); =20 ptxservq->qcnt--; phwxmits[ac_index].accnt--; @@ -2464,8 +2490,8 @@ struct xmit_buf *dequeue_pending_xmitbuf_under_survey= (struct xmit_priv *pxmitpri type =3D GetFrameSubType(pxmitbuf->pbuf + TXDESC_OFFSET); =20 if ((type =3D=3D WIFI_PROBEREQ) || - (type =3D=3D WIFI_DATA_NULL) || - (type =3D=3D WIFI_QOS_DATA_NULL)) { + (type =3D=3D WIFI_DATA_NULL) || + (type =3D=3D WIFI_QOS_DATA_NULL)) { list_del_init(&pxmitbuf->list); break; } --=20 2.52.0