From nobody Sun Feb 8 02:41:55 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 932C020DD48 for ; Thu, 15 Jan 2026 05:40:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768455650; cv=none; b=nU2PC3LClOE64NDiBFZQEBUK8BV90H2uYktFvhKweJ+3iSCeKzJXvAPkR5LQ06qOnrmrSoa2/Db7Mwm9BEfXVECT/w827yawJOaFuufrFDbVP6QuVpnT7fsFZmU1QSc+dwGQeWB1CCgcElHJ3DEqm+OS/+6FbWo7PqWN64b03Jc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768455650; c=relaxed/simple; bh=Wl7xCZoWBvN0SYe3lKX1wJCCqVhc26kn4JqRvUIG6/A=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bOmbf8NogKpPivAqSqMdw+r+xzF6w1UtVNhzGKPgN/j2r6P/KCEBx2r96wYsvD82xBmMte0NMs4PmuKWRnigpw8OVgwxM6Yyr2iHHtfGV3RfU3Sun0snXOJSag3FfKW/4Hd6IdBNW0ucykEkKYSGXRX5AFGOXUyvbj65yZk72HE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ARdt78c3; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ARdt78c3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768455648; x=1799991648; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Wl7xCZoWBvN0SYe3lKX1wJCCqVhc26kn4JqRvUIG6/A=; b=ARdt78c3mRPzYfEhdpnt42dZbqFYV7pUtYmMuSi8F95G43Kzsi0Jbv+H KBMfoFItyWSHXzusLPb0py8bq7M6yhWrTiw99TyDhyAZIlFI5rFDHtGzt LjKckLFo5HP91JB2mTlEsY1ieptAKADHREvNNrXXCR6XbaNiFZlSdW97d nisjtQZTSHZHMYiahoh0tMPUysc3BVyE4ada9uam+TBvQ5TKWyM5JsXit r+PhURNM5MY1In3mh3sJSWbNcjnPwSB2pWb5ByaNaDngMWUQRGzr2jscN 6CSxvJ5b1wyRm0510takWRF1FD7o7yZH545xUwTCC2HcaitMaKtHkOO2v w==; X-CSE-ConnectionGUID: GTx30D9iQPmqpN2A/ZaU5A== X-CSE-MsgGUID: ejMx8AWrQ2aOn9eqXka4Lw== X-IronPort-AV: E=McAfee;i="6800,10657,11671"; a="80479299" X-IronPort-AV: E=Sophos;i="6.21,226,1763452800"; d="scan'208";a="80479299" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2026 21:40:48 -0800 X-CSE-ConnectionGUID: Wp8RXAohSL6q/3n46iaI2g== X-CSE-MsgGUID: sFumAQ2dTv6/vJzbdn6a8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,226,1763452800"; d="scan'208";a="235587833" Received: from sannilnx-dsk.jer.intel.com ([10.12.231.107]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2026 21:40:43 -0800 From: Alexander Usyskin To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Reuven Abliyev , Alexander Usyskin , "Gustavo A . R . Silva" , Raag Jadav , Jani Partanen , Lucas De Marchi Subject: [PATCH] mtd: intel-dg: Fix accessing regions before setting nregions Date: Thu, 15 Jan 2026 07:22:37 +0200 Message-ID: <20260115052237.1149027-1-alexander.usyskin@intel.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The regions array is counted by nregions, but it's set only after accessing it: [] UBSAN: array-index-out-of-bounds in drivers/mtd/devices/mtd_intel_dg.c:7= 50:15 [] index 0 is out of range for type ' [*]' Fix it by also fixing an undesired behavior: the loop silently ignores ENOMEM and continues setting the other entries. CC: Gustavo A. R. Silva CC: Raag Jadav Reported-by: Jani Partanen Closes: https://lore.kernel.org/all/caca6c67-4f1d-49f1-948f-e63b6b937b29@so= tapeli.fi Fixes: ceb5ab3cb646 ("mtd: add driver for intel graphics non-volatile memor= y device") Signed-off-by: Lucas De Marchi Signed-off-by: Alexander Usyskin Reviewed-by: Raag Jadav --- drivers/mtd/devices/mtd_intel_dg.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/devices/mtd_intel_dg.c b/drivers/mtd/devices/mtd_i= ntel_dg.c index 2bab30dcd35f..7f751c48a76d 100644 --- a/drivers/mtd/devices/mtd_intel_dg.c +++ b/drivers/mtd/devices/mtd_intel_dg.c @@ -770,6 +770,7 @@ static int intel_dg_mtd_probe(struct auxiliary_device *= aux_dev, =20 kref_init(&nvm->refcnt); mutex_init(&nvm->lock); + nvm->nregions =3D nregions; =20 for (n =3D 0, i =3D 0; i < INTEL_DG_NVM_REGIONS; i++) { if (!invm->regions[i].name) @@ -777,13 +778,15 @@ static int intel_dg_mtd_probe(struct auxiliary_device= *aux_dev, =20 char *name =3D kasprintf(GFP_KERNEL, "%s.%s", dev_name(&aux_dev->dev), invm->regions[i].name); - if (!name) - continue; + if (!name) { + ret =3D -ENOMEM; + goto err; + } + nvm->regions[n].name =3D name; nvm->regions[n].id =3D i; n++; } - nvm->nregions =3D n; /* in case where kasprintf fail */ =20 ret =3D devm_pm_runtime_enable(device); if (ret < 0) { --=20 2.43.0