From nobody Mon Feb 9 02:12:52 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 588CF3A0EB7 for ; Thu, 15 Jan 2026 13:59:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768485575; cv=pass; b=aeD+Z0cbuh5HIdgKAkuhAlZuCfB/L0sJRfwbgPBQD7jDQZfrAQAKPBYoy/nDpZdcil4FWlK9+VsN2Col7sWhokPEcB1NIb9PYKzM3JFOKTnl/JRvdoYLJBWm11iUuLfga5wWd4W+jevE/aqm3BEVhuGAfy5Hqgoq7ksYuJuNQsw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768485575; c=relaxed/simple; bh=doImEWGaHxRQM5xh/0r8UUsIPMyBXhZHwCH+YMIZ6MI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CHUNdQIfkfT/K603ETctr1GWs71fYWpMTdmp78UUvjLRRso1EW+CXG3i0BEmuydqvmn+cKOkZExnmYST30AXzsMFNDUIuufskDzsVAfE/aLRsnrncNHT11wcKYOXo870VUZVtJmk0f7NMHbU/23jcX8GJZoiXPIdGpgdT5zQjaw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=Jim4UA1m; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="Jim4UA1m" ARC-Seal: i=1; a=rsa-sha256; t=1768485558; cv=none; d=zohomail.com; s=zohoarc; b=EBZgXEsW/5N+xS/Dcgfatg1VMes5tNcQebDFKrb/qso5E6J80K8thjFO5Lxacou3S+aLzCNlhq6gkMa9Aan65hhDVEpC6Jozhg+2QxmxikZMP5EbpzkJondBGBjqL73z2BvVZ3au6csV73prkiefkUtQ+EjYyn4iY96a4GeqFYU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768485558; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=gX3dCtVk++wU9ee5yZE4qk+1ES55FzJ5Q1jYoGhBbV0=; b=nFrhZsIFgABWzmbR13EUGgP8yJEOAxpgzXsQ59IKGkD0Sexw5fUzyUj14b5k9+1AOPXYPcBiJr5GrdE5lhgovn5yb5vklr8L5KTfyqiWwBu4iRME38xFtiwxX33YE8Mc6+tHwU3hSK8b5/UVI2DEdI+7AkyADDdsL4IXzoIsGgg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768485558; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=gX3dCtVk++wU9ee5yZE4qk+1ES55FzJ5Q1jYoGhBbV0=; b=Jim4UA1m0I5CZj/e5kSmjLyV1WkjeXA2kxggRL1nmY6ZEQ2uEfS+xTnedlMUbVbb 2460f1clRhEHLwvyst4LNXXiSKVQN6PPWZu/1friD774pSp0ZJ5Na8wRvsLSkPXWCz7 DUiCEovzcUTtFgKrHhKO29w+0cRRDOKPcRlt2vsE= Received: by mx.zohomail.com with SMTPS id 1768485556990928.4577118495597; Thu, 15 Jan 2026 05:59:16 -0800 (PST) From: Nicolas Frattaroli Date: Thu, 15 Jan 2026 14:58:59 +0100 Subject: [PATCH v9 1/4] drm/panthor: Rework panthor_irq::suspended into panthor_irq::state Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260115-panthor-tracepoints-v9-1-e13e4f7d01dc@collabora.com> References: <20260115-panthor-tracepoints-v9-0-e13e4f7d01dc@collabora.com> In-Reply-To: <20260115-panthor-tracepoints-v9-0-e13e4f7d01dc@collabora.com> To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chia-I Wu , Karunika Choo Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 To deal with the threaded interrupt handler and a suspend action overlapping, the boolean panthor_irq::suspended is not sufficient. Rework it into taking several different values depending on the current state, and check it and set it within the IRQ helper functions. Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/panthor/panthor_device.h | 32 ++++++++++++++++++++++++++--= ---- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_device.h b/drivers/gpu/drm/pan= thor/panthor_device.h index f35e52b9546a..2bf9a8434dc5 100644 --- a/drivers/gpu/drm/panthor/panthor_device.h +++ b/drivers/gpu/drm/panthor/panthor_device.h @@ -61,6 +61,17 @@ enum panthor_device_pm_state { PANTHOR_DEVICE_PM_STATE_SUSPENDING, }; =20 +enum panthor_irq_state { + /** @PANTHOR_IRQ_STATE_ACTIVE: IRQ is active and ready to process events.= */ + PANTHOR_IRQ_STATE_ACTIVE =3D 0, + /** @PANTHOR_IRQ_STATE_PROCESSING: IRQ is currently processing events. */ + PANTHOR_IRQ_STATE_PROCESSING, + /** @PANTHOR_IRQ_STATE_SUSPENDED: IRQ is suspended. */ + PANTHOR_IRQ_STATE_SUSPENDED, + /** @PANTHOR_IRQ_STATE_SUSPENDING: IRQ is being suspended. */ + PANTHOR_IRQ_STATE_SUSPENDING, +}; + /** * struct panthor_irq - IRQ data * @@ -76,8 +87,8 @@ struct panthor_irq { /** @mask: Current mask being applied to xxx_INT_MASK. */ u32 mask; =20 - /** @suspended: Set to true when the IRQ is suspended. */ - atomic_t suspended; + /** @state: one of &enum panthor_irq_state reflecting the current state. = */ + atomic_t state; }; =20 /** @@ -409,8 +420,10 @@ static irqreturn_t panthor_ ## __name ## _irq_raw_hand= ler(int irq, void *data) { \ struct panthor_irq *pirq =3D data; \ struct panthor_device *ptdev =3D pirq->ptdev; \ + enum panthor_irq_state state; \ \ - if (atomic_read(&pirq->suspended)) \ + state =3D atomic_read(&pirq->state); \ + if (state =3D=3D PANTHOR_IRQ_STATE_SUSPENDED || state =3D=3D PANTHOR_IRQ_= STATE_SUSPENDING) \ return IRQ_NONE; \ if (!gpu_read(ptdev, __reg_prefix ## _INT_STAT)) \ return IRQ_NONE; \ @@ -423,8 +436,11 @@ static irqreturn_t panthor_ ## __name ## _irq_threaded= _handler(int irq, void *da { \ struct panthor_irq *pirq =3D data; \ struct panthor_device *ptdev =3D pirq->ptdev; \ + enum panthor_irq_state state; \ irqreturn_t ret =3D IRQ_NONE; \ \ + atomic_cmpxchg(&pirq->state, PANTHOR_IRQ_STATE_ACTIVE, PANTHOR_IRQ_STATE_= PROCESSING); \ + \ while (true) { \ u32 status =3D gpu_read(ptdev, __reg_prefix ## _INT_RAWSTAT) & pirq->mas= k; \ \ @@ -435,8 +451,11 @@ static irqreturn_t panthor_ ## __name ## _irq_threaded= _handler(int irq, void *da ret =3D IRQ_HANDLED; \ } \ \ - if (!atomic_read(&pirq->suspended)) \ + state =3D atomic_read(&pirq->state); \ + if (state !=3D PANTHOR_IRQ_STATE_SUSPENDED && state !=3D PANTHOR_IRQ_STAT= E_SUSPENDING) { \ gpu_write(ptdev, __reg_prefix ## _INT_MASK, pirq->mask); \ + atomic_set(&pirq->state, PANTHOR_IRQ_STATE_ACTIVE); \ + } \ \ return ret; \ } \ @@ -445,14 +464,15 @@ static inline void panthor_ ## __name ## _irq_suspend= (struct panthor_irq *pirq) { \ pirq->mask =3D 0; \ gpu_write(pirq->ptdev, __reg_prefix ## _INT_MASK, 0); \ + atomic_set(&pirq->state, PANTHOR_IRQ_STATE_SUSPENDING); \ synchronize_irq(pirq->irq); \ - atomic_set(&pirq->suspended, true); \ + atomic_set(&pirq->state, PANTHOR_IRQ_STATE_SUSPENDED); \ } \ \ static inline void panthor_ ## __name ## _irq_resume(struct panthor_irq *p= irq, u32 mask) \ { \ - atomic_set(&pirq->suspended, false); \ pirq->mask =3D mask; \ + atomic_set(&pirq->state, PANTHOR_IRQ_STATE_ACTIVE); \ gpu_write(pirq->ptdev, __reg_prefix ## _INT_CLEAR, mask); \ gpu_write(pirq->ptdev, __reg_prefix ## _INT_MASK, mask); \ } \ --=20 2.52.0