From nobody Mon Feb 9 13:00:20 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C764433A6E9 for ; Thu, 15 Jan 2026 07:29:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768462168; cv=none; b=hJPGp4IgYJ4RYGDkazFf+si45jfc78uSk/r3hyfxEHpPs3N+bayhxshklwYHt6CQmCGWpA/TF0y1Ba4idTlCsg2Ky/joFzQLCT8bWIIwaGUBhsmD8z5KV9EPjS0O70JvvABwph7Rk3akekThEi8wk+17LL+cGYnvTOByh9qy584= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768462168; c=relaxed/simple; bh=ZtwLsg6p0b8AfSzbDB138yGAcIa8HoM5WjV12Fcz6EQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=R7sjoMI54tw6wA0mO4laxTpJqoe0sS6Dvu9n82FL5CP7ZZm8aYzTh5O5ny4QnPfUirgJ6md6wr96fpFMTBBuajmFShugHQiK7QWk3fBqlCvL1/7Z6Lv99WDO1Hb0a7hQ2aEZOu5ZGI6mQBh+KX8vWz88hncbFHjVXSASlCephi8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N7zNLmwI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HpdLcyTC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N7zNLmwI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HpdLcyTC" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60F6g9UJ1056304 for ; Thu, 15 Jan 2026 07:29:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XLSj/TWpVJxmGvdBCFFcBev9pg9q/iSGm2XdYaBUr2g=; b=N7zNLmwI7Cx41IjL n4cg7c19upZ6A9n0FvqXM7ZeALZiZIbAMs70a6vmu0z+pmfzkzi9kkdINaoXdB3z Qrd56b812WU0dk/00fOC//E7K+v6Cx+04Sz3PNuW17OGbTvkf/dCxIW+tAr6kpnB 1K8LLUNdzYML5uaaAJXKG9OLd+PzOaUcZ0qNAqSLXA88FVv59hTvPsBRMPTf9eJg ld8c138fb8vKAyMFNggMXTTJZLJNVfaULE6cO9Yf94CDidcpuy7D3KbrOB5WZ8G6 h1XiZwTU16GeALjej/z+qy3FvovXaC8OU6YvA6GEUyXi+Tx7OTWP9SFjGdE2tgkz yV+AiQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bp8d33rfs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 15 Jan 2026 07:29:25 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8b9fa6f808cso183498885a.1 for ; Wed, 14 Jan 2026 23:29:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768462165; x=1769066965; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XLSj/TWpVJxmGvdBCFFcBev9pg9q/iSGm2XdYaBUr2g=; b=HpdLcyTCWAxrcBVL+fGM3U9Gy/sE0WtwfqYTqJ//9F5ZSxHYSxPGYf+pB5WCbIb8Mm hv6RuzYVCvYaRLBgfVZdIOrU3IdYpr5OHAhJzubhI0Hp5G9M8igOownWT6z2+l31zQZK tcQnv+VokXOMVwR/QcRIgpXiEC2rK5eWRgSZIyf6gR8w0bPlwjQR/UuxM2jSG/VSUlB4 HpieywqChNoZMkrUfDEGCeYRcqCS+sQGiEIjE86Vc2mFV9RSXgtncjlHsIUIjmke/R6c Fc8O/ma0rtjX/DjgAOlB2YwpPAtJHrT2FYpK+oxWg1zd3e/pwlbBbuHtJRo1HNn/Spx5 CLnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768462165; x=1769066965; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=XLSj/TWpVJxmGvdBCFFcBev9pg9q/iSGm2XdYaBUr2g=; b=Ubfcb8LewJWrRqaERMR6hzrdPNKQg8oUuX9pRWdXEa3TtsapASuvJA2M529/vMygqg kZZ6J1Jw95BMrwk+0yEGwrwFSy7H1cnC5hpXEawn5q+ltd4FO0odMEjzV4IXs6tp9pJi MAPbNmLkQ6nDjkk/Af2zyZTi429PS68PRTAu0iAvBAuBb90dO5k8tayfXglVxfdwwp9E t8v3ARKIZgtMmzsJP2zZOg9eZOxdZ/NAijt+1Bs6O+llpcV8CWtXMJVCYLG+05YjPe5t 5fcV+xfEGzgcI0Vk9jxKcW4ZhtesVfUOVhKoBmr+tyXR9y24IJ5vSOhCOLwLR7NFj8e2 HrDw== X-Forwarded-Encrypted: i=1; AJvYcCXqxHrChN/FM3iXulBXfa4rFVpRqu1s9pF9c89GYMOfCu86ShEhYnb0ad2STYz2WbL3hGXULcN5a8imyxk=@vger.kernel.org X-Gm-Message-State: AOJu0YzSYzvzYkbhncLzbybbSHLOhKhVSI0jsI8+MTaDWEnqsPq0UCYN i3S2/6ltmPFN8zqI9C/cI1UUJnDMrkHep5o7BDUJl09xhLVgeNo2J+LHoUqm1YtDlWMwb1OCgNd qVivpw1rjjX84kncDo/BS7ZtH26tUygSsVfFAQR8/RgoKmfk18lJhdDa6qUraaqe8snA= X-Gm-Gg: AY/fxX7k3LNVmP3CbepZKm/3J2md+834BnAEme99OFNX2D7I96fEYs6DA/o1SXW+dN3 FXBm+4h/FrPkY9MKmB96A4FeEmS1+lXoANcYon2IrWsrgIJxNs9npgd7PfrXJI8sgCVAvUgtWqP 44O3pGt8vYw2jS90TlJ+aA/XIybOU2CUVYidaLGFSojEhlWckT/pz6boIGu9N7qMl2YgN3Dhi6q YIniDzPnJ5aWYp5iVpfAM26jgwC2+XrunFj8mKBvadSbUyyfG0kyeziRq2l+x1mFQP5Hlm/aiSI 4fB3VO7mfNwOEy5d8IUnBuPjDRk64Dw3pvwIN2vl+b+JOrIp/SUn1SOZyk9oylWxrehGSoAdoEM F5h6ufFuYDzWzliHhj4Lk4Qu7iH7PQy+gBPJsrhb4jlojBnBoMK5REBSQzhzdw6HTyBCa2EY4rl kdWtPZcCI0CPhCu2Ohucmi6rE= X-Received: by 2002:a05:620a:8a84:b0:8c5:33bf:524f with SMTP id af79cd13be357-8c533bf5487mr387329885a.59.1768462164997; Wed, 14 Jan 2026 23:29:24 -0800 (PST) X-Received: by 2002:a05:620a:8a84:b0:8c5:33bf:524f with SMTP id af79cd13be357-8c533bf5487mr387328685a.59.1768462164573; Wed, 14 Jan 2026 23:29:24 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-382eb7b1a4dsm58078801fa.17.2026.01.14.23.29.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 23:29:23 -0800 (PST) From: Dmitry Baryshkov Date: Thu, 15 Jan 2026 09:29:11 +0200 Subject: [PATCH v3 6/8] drm/msm/dp: drop event data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260115-hpd-refactor-v3-6-08e2f3bcd2e0@oss.qualcomm.com> References: <20260115-hpd-refactor-v3-0-08e2f3bcd2e0@oss.qualcomm.com> In-Reply-To: <20260115-hpd-refactor-v3-0-08e2f3bcd2e0@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5908; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=ZtwLsg6p0b8AfSzbDB138yGAcIa8HoM5WjV12Fcz6EQ=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpaJdDlEGZrfhfWSXwbEfq2QgFK1z+KIppQqfx1 RD1Hou6Sf2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaWiXQwAKCRCLPIo+Aiko 1SU8B/97FtUsLseqjWjW6wU6ORL+a7MT0QOnljI3PsP3jprvkuXxu5bRHWzDrPS5h/I/gu/YSQO hLKjbJkE9tdfuQJ23itEvzdVDiKUZNv5lJm5JeF9CHmCPv2TKTOKO1sZPli8FdL/GfP00aBK1kJ wx2u9qmnDE078vg9HUBdGNxBqYEszXLMaeDqDQgk+wKgzOTjCdRNZ+908SiwZmj5SmFcqoBgzgn V2XTzKI9xqxq7zigBeyaJSeWqiyGe6URL/1CknXDKw6IAVPpkZsX9cLJpcUD6WH18qdV37ifO9N zAkPtRR3rngLh5Yy8GLBbHnAS96JvyxHEiQVb0QryuPskR1+ X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: bYf7A8_jtbR6OWhY1XIq-yi4DHo0oG4z X-Authority-Analysis: v=2.4 cv=fbWgCkQF c=1 sm=1 tr=0 ts=69689755 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=zd47t_UtYfsHpvN5YEcA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: bYf7A8_jtbR6OWhY1XIq-yi4DHo0oG4z X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE1MDA0OSBTYWx0ZWRfX+GPZrktE4fQO NCeArENupl3/rZeAEYhr0gYaLUKsbcGXPXvi67OLTaGlLwq3TyAXkyYGRaLRO+76BoS1WMI5lz+ sFiFAP+Yol+RJtHbQe87AYqYIMeKEVoOw/t65qXYqPaPDe+uwDpgwc2jd3mDN5NM8K5mezkfohj pq6As1+R9d/fjAe7J3V30f2+K320+prMlCKvCUDmKUgCeis7CVmsWtoIKIL0WRe/btFe7OSPd59 fMzfY61ZZ7/0PVy0AqdjEV0UfA80Q/py0EOT3fB5ml88Fz7SqVTfcpgVupUGS1z5Uw6byo5Ai1o /phYY4fq1SrUoBZab5kt4oiaTNilQ03xGqYDIXrLrYUQUbWYFpBO682Mt3hl6ORLxAMfD0ilQkL T0rRkKg6mwkcuHkjUtSRyfUTNyF2zCtb4Avm8cWvUvtjFWcWOYyOPlt+JypMQAuCUrfaAPTixDH n42AyYIZVavaXi19Mkg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-15_02,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 impostorscore=0 phishscore=0 priorityscore=1501 adultscore=0 clxscore=1015 malwarescore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601150049 With EV_USER_NOTIFICATION gone event's data is no longer useful. Drop it, removing also the argument from event handlers. Signed-off-by: Dmitry Baryshkov Reviewed-by: Bjorn Andersson Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/dp/dp_display.c | 39 +++++++++++++++++----------------= ---- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index e0b424ac861a..e93de362dd39 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -69,7 +69,6 @@ enum { =20 struct msm_dp_event { u32 event_id; - u32 data; u32 delay; }; =20 @@ -218,7 +217,7 @@ static struct msm_dp_display_private *dev_get_dp_displa= y_private(struct device * } =20 static int msm_dp_add_event(struct msm_dp_display_private *msm_dp_priv, u3= 2 event, - u32 data, u32 delay) + u32 delay) { unsigned long flag; struct msm_dp_event *todo; @@ -236,7 +235,6 @@ static int msm_dp_add_event(struct msm_dp_display_priva= te *msm_dp_priv, u32 even todo =3D &msm_dp_priv->event_list[msm_dp_priv->event_pndx++]; msm_dp_priv->event_pndx %=3D DP_EVENT_Q_MAX; todo->event_id =3D event; - todo->data =3D data; todo->delay =3D delay; wake_up(&msm_dp_priv->event_q); spin_unlock_irqrestore(&msm_dp_priv->event_lock, flag); @@ -576,7 +574,7 @@ static int msm_dp_display_usbpd_attention_cb(struct dev= ice *dev) return rc; } =20 -static int msm_dp_hpd_plug_handle(struct msm_dp_display_private *dp, u32 d= ata) +static int msm_dp_hpd_plug_handle(struct msm_dp_display_private *dp) { u32 state; int ret; @@ -602,7 +600,7 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display= _private *dp, u32 data) =20 if (state =3D=3D ST_DISCONNECT_PENDING) { /* wait until ST_DISCONNECTED */ - msm_dp_add_event(dp, EV_HPD_PLUG_INT, 0, 1); /* delay =3D 1 */ + msm_dp_add_event(dp, EV_HPD_PLUG_INT, 1); mutex_unlock(&dp->event_mutex); return 0; } @@ -644,7 +642,7 @@ static void msm_dp_display_handle_plugged_change(struct= msm_dp *msm_dp_display, plugged); } =20 -static int msm_dp_hpd_unplug_handle(struct msm_dp_display_private *dp, u32= data) +static int msm_dp_hpd_unplug_handle(struct msm_dp_display_private *dp) { u32 state; struct platform_device *pdev =3D dp->msm_dp_display.pdev; @@ -706,7 +704,7 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_displ= ay_private *dp, u32 data) return 0; } =20 -static int msm_dp_irq_hpd_handle(struct msm_dp_display_private *dp, u32 da= ta) +static int msm_dp_irq_hpd_handle(struct msm_dp_display_private *dp) { u32 state; =20 @@ -724,7 +722,7 @@ static int msm_dp_irq_hpd_handle(struct msm_dp_display_= private *dp, u32 data) =20 if (state =3D=3D ST_MAINLINK_READY || state =3D=3D ST_DISCONNECT_PENDING)= { /* wait until ST_CONNECTED */ - msm_dp_add_event(dp, EV_IRQ_HPD_INT, 0, 1); /* delay =3D 1 */ + msm_dp_add_event(dp, EV_IRQ_HPD_INT, 1); mutex_unlock(&dp->event_mutex); return 0; } @@ -1079,7 +1077,6 @@ static int hpd_event_thread(void *data) todo_next =3D &msm_dp_priv->event_list[msm_dp_priv->event_pndx++]; msm_dp_priv->event_pndx %=3D DP_EVENT_Q_MAX; todo_next->event_id =3D todo->event_id; - todo_next->data =3D todo->data; todo_next->delay =3D todo->delay - 1; =20 /* clean up older event */ @@ -1105,13 +1102,13 @@ static int hpd_event_thread(void *data) =20 switch (todo->event_id) { case EV_HPD_PLUG_INT: - msm_dp_hpd_plug_handle(msm_dp_priv, todo->data); + msm_dp_hpd_plug_handle(msm_dp_priv); break; case EV_HPD_UNPLUG_INT: - msm_dp_hpd_unplug_handle(msm_dp_priv, todo->data); + msm_dp_hpd_unplug_handle(msm_dp_priv); break; case EV_IRQ_HPD_INT: - msm_dp_irq_hpd_handle(msm_dp_priv, todo->data); + msm_dp_irq_hpd_handle(msm_dp_priv); break; default: break; @@ -1212,19 +1209,19 @@ static irqreturn_t msm_dp_display_irq_handler(int i= rq, void *dev_id) dp->msm_dp_display.connector_type, hpd_isr_status); /* hpd related interrupts */ if (hpd_isr_status & DP_DP_HPD_PLUG_INT_MASK) - msm_dp_add_event(dp, EV_HPD_PLUG_INT, 0, 0); + msm_dp_add_event(dp, EV_HPD_PLUG_INT, 0); =20 if (hpd_isr_status & DP_DP_IRQ_HPD_INT_MASK) { - msm_dp_add_event(dp, EV_IRQ_HPD_INT, 0, 0); + msm_dp_add_event(dp, EV_IRQ_HPD_INT, 0); } =20 if (hpd_isr_status & DP_DP_HPD_REPLUG_INT_MASK) { - msm_dp_add_event(dp, EV_HPD_UNPLUG_INT, 0, 0); - msm_dp_add_event(dp, EV_HPD_PLUG_INT, 0, 3); + msm_dp_add_event(dp, EV_HPD_UNPLUG_INT, 0); + msm_dp_add_event(dp, EV_HPD_PLUG_INT, 3); } =20 if (hpd_isr_status & DP_DP_HPD_UNPLUG_INT_MASK) - msm_dp_add_event(dp, EV_HPD_UNPLUG_INT, 0, 0); + msm_dp_add_event(dp, EV_HPD_UNPLUG_INT, 0); =20 ret =3D IRQ_HANDLED; } @@ -1649,7 +1646,7 @@ void msm_dp_bridge_atomic_enable(struct drm_bridge *d= rm_bridge, } =20 if (dp->is_edp) - msm_dp_hpd_plug_handle(msm_dp_display, 0); + msm_dp_hpd_plug_handle(msm_dp_display); =20 mutex_lock(&msm_dp_display->event_mutex); if (pm_runtime_resume_and_get(&dp->pdev->dev)) { @@ -1722,7 +1719,7 @@ void msm_dp_bridge_atomic_post_disable(struct drm_bri= dge *drm_bridge, msm_dp_display =3D container_of(dp, struct msm_dp_display_private, msm_dp= _display); =20 if (dp->is_edp) - msm_dp_hpd_unplug_handle(msm_dp_display, 0); + msm_dp_hpd_unplug_handle(msm_dp_display); =20 mutex_lock(&msm_dp_display->event_mutex); =20 @@ -1844,7 +1841,7 @@ void msm_dp_bridge_hpd_notify(struct drm_bridge *brid= ge, return; =20 if (!msm_dp_display->link_ready && status =3D=3D connector_status_connect= ed) - msm_dp_add_event(dp, EV_HPD_PLUG_INT, 0, 0); + msm_dp_add_event(dp, EV_HPD_PLUG_INT, 0); else if (msm_dp_display->link_ready && status =3D=3D connector_status_dis= connected) - msm_dp_add_event(dp, EV_HPD_UNPLUG_INT, 0, 0); + msm_dp_add_event(dp, EV_HPD_UNPLUG_INT, 0); } --=20 2.47.3