From nobody Tue Feb 10 04:03:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B94C3310762 for ; Thu, 15 Jan 2026 20:05:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768507550; cv=none; b=ZyU8w5IMGU9AjORjvmrphl0rmNshVl/PxSbotbJbUE1wHLXcLXVSF/MuFfqdFko6cXxAWB/YAs0GxXtLlMhqG42DBNRhtEERrlemp5002dlwtPcYNodwqNdiw67BCUXGUlK8z8h8l8kGAZDk8pd42o5Fd3fuVVCfmeT/oPETw4g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768507550; c=relaxed/simple; bh=xCYpyxz2Y++3bSOvFHpWng3+Lz48nC4C6QeLJXM/NFw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=H9AhgilkUFeAvo4Fm7w8FCPCJ9yWPtlni+8POuXLDWRy9yWFkm1nLmv09v4QktAp4JAP0jIldN/wbE6HlruPkpQfob4VPCzL3+T2mZ7xNz6N72e0YDhOs4SfIWvgochfc6N72oq00xzcVLw2QNpXruTpBDvKSjFDx1R9ur0yndg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mthU4qzs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QLabAuMS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mthU4qzs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QLabAuMS" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60FFYGG62866215 for ; Thu, 15 Jan 2026 20:05:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= f/enLxHnBBykrdCL+IaxgmW7qNcWXutcZNBdtd7FtnY=; b=mthU4qzsZz5I+ucW iwOjZiK+6bpkiJYpr3K1jN9WMMhX0GecJZafQhvWcnZ4y6ISfXbi9LvyhwdwQzz3 Zvceu9KKl+LjCe9Rc3jcikWQKWqjHZyEMe7wFmo+s2W+oOGfXF+9MPDMZI/ldXEa S96Q5CuUPAgJXooNYrSJB9cREwe8eDxYEArZb+UarrATR6qLpfXI9r3F4T2XRr2q 5Hri9h5F6MQ2/U51rIj220xByDC603EDvNbUkYkOIHkOwOCQMLZZ9tLZ9H+hncxy APDmLubeRqOQaNVtUdE1IoReNmbLkrg4APq1jC4TC313JMgKt/mqEdNoc4hjBWv1 hq987w== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bptu2japh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 15 Jan 2026 20:05:45 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8b9fa6f808cso422738585a.1 for ; Thu, 15 Jan 2026 12:05:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768507545; x=1769112345; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=f/enLxHnBBykrdCL+IaxgmW7qNcWXutcZNBdtd7FtnY=; b=QLabAuMSSStXGvOUvEsJZZ5HMutmJVUALh3tRKcFOxqS3uLOtimXjtKcln3obzsz8o UtUs1p84aBCdPNIfD7deCRDo/QVESj6m9TBZOBfx2S9qifG9KG3qOP1G0EZ0GiQNmlOF A5jTKLVyVceTdO7w8ps9uzK7wfrFeacffClLvvmGnMB7Sb0beqfuSBLHnVa3MKkhmqOz qsMews/UUEtxm2MHgkgzuxTU4XDdQ6e4ETRvuRwUK76qSY/fcig3fiFmozrXem8yT2sX n9bT24BcDJpjr0R4OGYGZIsUBoM5IP2mbnXdAg3egO4ojgvUtkTCoaQjGcqhGlvIbM+h qVfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768507545; x=1769112345; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=f/enLxHnBBykrdCL+IaxgmW7qNcWXutcZNBdtd7FtnY=; b=sU9GShq5U+TvDIoQFrteu0FiCYEoO0LLEpY0pVFwHGxsxSRrtZ0Y+BfQJCXSXdeKAZ 4qeLSQt8OUYZSDum2AFDjJ7wUAi9Bay63nx9DCZRAdX/hdugg3LJDLaab4BEY/MIDqEs maqgGCrbndn2kNJyevf7Gp+mhXmy6Uiom8e70247klgeUyicAFOAOKmvh17jaLiXa1N7 bc/2BZbgk3VgRltkKFGAt4q13jXgIwd01m7lv6oe82mxNmZxssiO8uD6Id0bm8qvej7z wAE36dwf3u5D4LrpklJ4A3tMR/D94qlgPv3TNgO+2EHes/yNrUIDaj6UBulV2F1ak+bG DRtg== X-Forwarded-Encrypted: i=1; AJvYcCXFLQjqv7zsYdj1Z480sHXsTHzdLQcwsLaaLr6JDy5O8QMmJqdHW+Q4yA/vGpiZ+6GdLGnazsAvYKxWkRM=@vger.kernel.org X-Gm-Message-State: AOJu0YwkIXtuXWkzOCekz/xCf3vvP7VppUyaty9bXfgRremrh1rR9HF6 Jv95HemEpfQSS6pbfuwePDWh1df0sRtdPC17QCn4Nt7yKHm3Ej7+XpHmkfzyGsI2qToLYzITFsX KPqr+Wo6dUKwBaRxuEN0Ab2Fo2YpzqQkVWS+/CLxL5LfhJrSzbkzmc+c1Tg9oqWP7M8s= X-Gm-Gg: AY/fxX7+ol6SdZJ0qeZonUfv6s8005EzZgMU+r/mORwxCJIaGJqkIZQI5sX05k6ga84 nozXCWHdJLvcIamrfGFO0ZhHyQGOskqSKUx1SdVzXNrxe0LDb1s0taNN7wpiadH2i93jEfjhVjB GaYx4mYSEUZ/FSdbH4kPQJJ1luIc5ixjKpod/0Q6sRsjTn5qv8q9w8yLn05Ku7MJ7MID88CMmLB GSPkCfiR5CfnFrivZfTybf9TGohMqbkzOg9XTqUcYHnWwRPmKPpQEWzu0FLcoVZl/puXha/9VvR LeoEjTiVJ/AUeuQfEk626A4d+6njPgvI7/ZGq9BABA5X/Bx8uqOJ2WUvG9Gr6oOd+0bEbtUgkV0 VOeXOMr2o3d1h2On56qd/PPb1807Urb83/ONaBDKCpDUS1zZNgPJPjXpKx6TBTAjJZ/MA25UvuU B4tHyyFqjhiDtLQmMzPohpU0M= X-Received: by 2002:a05:620a:3910:b0:8c5:2dbc:6244 with SMTP id af79cd13be357-8c6a678e8c1mr113035885a.47.1768507544928; Thu, 15 Jan 2026 12:05:44 -0800 (PST) X-Received: by 2002:a05:620a:3910:b0:8c5:2dbc:6244 with SMTP id af79cd13be357-8c6a678e8c1mr113028585a.47.1768507544295; Thu, 15 Jan 2026 12:05:44 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38384e790casm1381901fa.29.2026.01.15.12.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 12:05:42 -0800 (PST) From: Dmitry Baryshkov Date: Thu, 15 Jan 2026 22:05:38 +0200 Subject: [PATCH 1/2] drm/msm/dpu: correct error messages in RM Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260115-dpu-fix-dspp-v1-1-b73152c147b3@oss.qualcomm.com> References: <20260115-dpu-fix-dspp-v1-0-b73152c147b3@oss.qualcomm.com> In-Reply-To: <20260115-dpu-fix-dspp-v1-0-b73152c147b3@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3115; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=xCYpyxz2Y++3bSOvFHpWng3+Lz48nC4C6QeLJXM/NFw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpaUiSa+LQBrNcwNslYVUlAqVNZ9NlLmdtfWaaX ubVvRo2GlWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaWlIkgAKCRCLPIo+Aiko 1YLOB/93x1oEBQn3+4s4f1V4tQPtT/OFmIEoQR9Ac8P7YDJB+7Bom8kDcNhCOQ4BpxRcqnLccuS P/vLOepyMeMebSCIr7TINb/ZkxAToBK4uhUIH1z/A/8AdAPh+hribG5/jifPfqM6kNGVGNI5jAh /zL4kS2z33raiR74Mdmkzy8K+XTpIu8tHIH8VhptRoyizb9ojl0iomwRbHTzx3Cy+x2w6HfSB/y TntlP5sesrUtoTOTLjlNrwLP83+TeJKmNc8Pxqc0BarIA2Mo0aMiR1QvJ84Jyu1zUVu1C939I7y y8UoHyMT1Jf0PBlphk6nxG3X3xpAopNPQ04vPFJ6pJNnE8+q X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE1MDE1NyBTYWx0ZWRfXyAk3Tizf9PlY x6Jp75UDF74vlRCgjUrOpsYHk+UmSfWnr8F7UJO5mndiLKZXU1rTbyf4sOxjUc/CpdRCMxGvWKJ Vjimu+hYZB7K81Ngg7M33ofIB796VdIkraYlDTKzBpmNZImrO9mcpFJGvzgMSP+4gVw8aVpMgFF Sl0jiZazr9T32uHn7Gio51+tK0fobfFF/jojYqtOOgRpuq6z8dcH+wMVYHLD/+4jW2r/8FUSn8A OYrkTCpf0bLITsMNIPTy0H3fSU3NkUaqsADBIzKQKRtyjOeIoM0+kpXGtwiIBboNs2sSZj+ST1l Glj005f43XEqqpKB/B70dj31zpV2S5dESu432lwYsEqwfVMbVPFYOlH6Ls7A46gpeZxf0L3AHvN wF8ByjJobRuePg6WA7jVObj1rsWdedK6ava240zXqgXtXx78TUWMNSTPWwRqgFntDf3cQcTD41R DlqfCSLQb8kXzEj4eKQ== X-Proofpoint-ORIG-GUID: spPXLeLNN8UN5pSFieD_DcooOgapORXL X-Authority-Analysis: v=2.4 cv=W6Y1lBWk c=1 sm=1 tr=0 ts=69694899 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=LiGtz_15ZcBlpgV9qhMA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: spPXLeLNN8UN5pSFieD_DcooOgapORXL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-15_06,2026-01-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 phishscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 malwarescore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601150157 Some of error messages in RM reference block index, while other print the enum value (which is shifted by 1), not to mention that some of the messages are misleading. Reformat the messages, making them more clear and also always printing the hardware block name. Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/d= isp/dpu1/dpu_rm.c index f6568ed8375f..7e77d88f8959 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c @@ -315,20 +315,19 @@ static bool _dpu_rm_check_lm_and_get_connected_blks(s= truct dpu_rm *rm, =20 /* Already reserved? */ if (reserved_by_other(global_state->mixer_to_crtc_id, lm_idx, crtc_id)) { - DPU_DEBUG("lm %d already reserved\n", lm_idx + LM_0); + DPU_DEBUG("LM_%d already reserved\n", lm_idx); return false; } =20 lm_cfg =3D to_dpu_hw_mixer(rm->mixer_blks[lm_idx])->cap; idx =3D lm_cfg->pingpong - PINGPONG_0; - if (idx < 0 || idx >=3D ARRAY_SIZE(rm->pingpong_blks)) { - DPU_ERROR("failed to get pp on lm %d\n", lm_cfg->pingpong); + if (idx < 0 || idx >=3D ARRAY_SIZE(rm->pingpong_blks) || !rm->pingpong_bl= ks[idx]) { + DPU_ERROR("LM_%d, invalid PP_%d\n", lm_idx, idx); return false; } =20 if (reserved_by_other(global_state->pingpong_to_crtc_id, idx, crtc_id)) { - DPU_DEBUG("lm %d pp %d already reserved\n", lm_cfg->id, - lm_cfg->pingpong); + DPU_DEBUG("LM_%d PP_%d already reserved\n", lm_idx, idx); return false; } *pp_idx =3D idx; @@ -337,14 +336,13 @@ static bool _dpu_rm_check_lm_and_get_connected_blks(s= truct dpu_rm *rm, return true; =20 idx =3D lm_cfg->dspp - DSPP_0; - if (idx < 0 || idx >=3D ARRAY_SIZE(rm->dspp_blks)) { - DPU_ERROR("failed to get dspp on lm %d\n", lm_cfg->dspp); + if (idx < 0 || idx >=3D ARRAY_SIZE(rm->dspp_blks) || !rm->dspp_blks[idx])= { + DPU_ERROR("LM_%d, invalid DSPP_%d\n", lm_idx, idx); return false; } =20 if (reserved_by_other(global_state->dspp_to_crtc_id, idx, crtc_id)) { - DPU_DEBUG("lm %d dspp %d already reserved\n", lm_cfg->id, - lm_cfg->dspp); + DPU_DEBUG("LM_%d DSPP_%d already reserved\n", lm_idx, idx); return false; } *dspp_idx =3D idx; @@ -364,7 +362,7 @@ static int _dpu_rm_reserve_lms(struct dpu_rm *rm, int i, lm_count =3D 0; =20 if (!topology->num_lm) { - DPU_ERROR("invalid number of lm: %d\n", topology->num_lm); + DPU_ERROR("zero LMs in topology\n"); return -EINVAL; } =20 @@ -468,13 +466,13 @@ static int _dpu_rm_reserve_ctls( features =3D ctl->caps->features; has_split_display =3D BIT(DPU_CTL_SPLIT_DISPLAY) & features; =20 - DPU_DEBUG("ctl %d caps 0x%lX\n", j + CTL_0, features); + DPU_DEBUG("CTL_%d caps 0x%lX\n", j, features); =20 if (needs_split_display !=3D has_split_display) continue; =20 ctl_idx[i] =3D j; - DPU_DEBUG("ctl %d match\n", j + CTL_0); + DPU_DEBUG("CTL_%d match\n", j); =20 if (++i =3D=3D num_ctls) break; --=20 2.47.3