From nobody Sun Feb 8 06:22:19 2026 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E7CF2FDC22 for ; Wed, 14 Jan 2026 18:07:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768414065; cv=none; b=Ako66Tjl6x87WSObsh7FINymkxT+7MeKtXhauj2xsrV2a42BuLqz3RK5UIXE7Gh4opj4DWjaUNOBnS48CZD0AJJxkp6XjlfWM1h5C71wfeuYqPYeCnG5bjOLBYmF0TUb8tvxAu/26aUbz+bCnfZ6eLb8aniCtHCbysAK5ADiZAU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768414065; c=relaxed/simple; bh=U58OgqkF0FnLNMsluxHv6GR+9+T+DzItDJduGe9JjeE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LHjAiNC/E1+w4+y7ZW+8LobnfPN2zgzKNlVmFAnOoUJCvs9579TYbyAG+LAR8r/d+7SROTR14msFssgVHbB1SkZx0r5YlIyDrpEhj8IAD/N72UAUnHWrPFalrXPoReXXz6/Qis9OkB7i/G05bkuyHgFzNKBVHkEc0V6iMY1YSBQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G4ep5WVK; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G4ep5WVK" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-c2dc870e194so58282a12.2 for ; Wed, 14 Jan 2026 10:07:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768414063; x=1769018863; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mQjaCQcS7+ndCFM47qBrIon6U6oW4IRpWFUDwNmONx4=; b=G4ep5WVKmOuSpwCJfo1KesdeqMDFnfb2SZRgtFSi7sEprZM7PW3x5CEtm2pQkCXTdY PWzeO4dNYvuYzWs7hN/IzP91jQOZrP+bLrLRBCpcxbY92uFy9Z4Z/7Y4VQscq6NM8VAz d/22iNQXciKJAt5lYf6CeG0AQzK6qGcRd1bSVI1wEaa0djL2az0vy2n3LLQ3I6ARLhsm gv/lHDijjfYy6ubnPQgAyxO7tasKaMIXgD9De7vL4aseSxsOxqqjWK54Lhwi7bHu+RHo 4VqVHQdXkLka+serSZykB3XG4qK0Qh/6MdmseflCJ8zO55khxo97LZ2C1t9A6C/WlyEv 96tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768414063; x=1769018863; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mQjaCQcS7+ndCFM47qBrIon6U6oW4IRpWFUDwNmONx4=; b=jD7ann4xex4uDmr5+z544zETjb3hN1s+FapiqzjKRB74SO6BZHk78Z86RAuUwfsuzu XZibxKJsIj6meiKzOzFNqt7eJIQXrY4HxOPuxbMGkuQOXvNrU3+v0gMG45FGIEOOsbs3 +vG9Zydna+R2pKFtDhj3wtnoPcYO9O3+D54jCDfGs7JMCizMgw/M0GWH8VpW7O2UjBQB ZZHkF4Yyo0wSlauD8xjwSS7HrgLLT1XWzY0k8M6YLhpsd82BvUCWfjXkXIsYcfX7L4d0 cR21t/OBV955Lna4Tt6iEHDeewF1BJ5Q0FPukqXY2ZmtNcb7kv+qJYHk6dpCkVMZvJbY lIzg== X-Forwarded-Encrypted: i=1; AJvYcCWvMrVefQgcu/p3vzqaEuYZBXy61z4G/GzssJVi7E6G/U0D9DMLoTZ7Od/LWqA4a07oOaG2uqNL8NoVcu0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6BFLG7mLZL/4dfCr6CTbOjb9YEzKCgtDUpG4lHyeT0Def33e2 ZOFz0rDVltAAkWmrTP423YYuzr5SZUY8cSHIlU12Da7C7ErAAXBDBWQr X-Gm-Gg: AY/fxX7l81vYXSFtyKJ4EmIXplPKhPqNDhyXeVt9vvVxWitmt5+fqYvOwwm6kCZbkyo fXRFQWRJ+Z927/djwuEPV2eXY4sRHDKImt1Q5d3A9trbA+lk5ibx/vk3uVxrLpRhzGn1ipikGyF HmFTy2WGX3xa00APrr7lwxOmR4j87TVtVdaZe09gnXvn0XhtZayFUlEDXrxwzQXI4YVRCorQA/H WGljIsgV3cbeFhqKZzy2Moklsdxvh2ZvslHcALxvaQTEetYamIJ7B+lEmgfpfJpqWj+7yZ92tN+ Iqkk2gqDlaeVgL41U/tNbXWSg4uyl09V1G4FJaRDrA9lyNiv/YCrw/2WNnCtQ9Lk+7qMI52tQ8Y 0YqrY4e/N9tyzm/XdJaQW4TAtODbmcwWEToG2Opu4//LecxserdIfaWyys4oDec+wXjGhBcujZl N5rlsQZKAcN8eQNQN2acflrI/kPKYwx/Yf0w== X-Received: by 2002:a17:90b:2e87:b0:340:7b2e:64cc with SMTP id 98e67ed59e1d1-351090b0ef3mr3627828a91.15.1768414062538; Wed, 14 Jan 2026 10:07:42 -0800 (PST) Received: from karthik.bbrouter ([103.215.237.249]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35107b75c70sm1424570a91.5.2026.01.14.10.07.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 10:07:42 -0800 (PST) From: Karthikey Kadati To: andy@kernel.org, hansg@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org Cc: sakari.ailus@linux.intel.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, Karthikey D Kadati Subject: [PATCH v2] media: atomisp: replace ia_css_region with v4l2_rect Date: Wed, 14 Jan 2026 23:37:30 +0530 Message-ID: <20260114180730.39744-1-karthikey3608@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Karthikey D Kadati The struct ia_css_region definition is redundant as struct v4l2_rect provides the same functionality (left, top, width, height) and is the standard V4L2 type. Replace usage of ia_css_region with v4l2_rect in ia_css_dz_config and remove the definition of ia_css_region from ia_css_types.h. Also remove historical comments referencing the addition of zoom_region and include to support the v4l2_rect type. Signed-off-by: Karthikey D Kadati --- Changes in v2: - Replaced ia_css_region with v4l2_rect in ia_css_types.h. - Removed definition of ia_css_region. - Removed historical comments about zoom_region. - Verified atomisp_cmd.c logic is safe with the type change. - Updated commit message for clarity and conciseness. drivers/staging/media/atomisp/pci/ia_css_types.h | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/ia_css_types.h b/drivers/sta= ging/media/atomisp/pci/ia_css_types.h index 5c21a5415..f7b77901e 100644 --- a/drivers/staging/media/atomisp/pci/ia_css_types.h +++ b/drivers/staging/media/atomisp/pci/ia_css_types.h @@ -15,6 +15,7 @@ * directly but still need to forward parameters for it. */ =20 +#include #include =20 #include "ia_css_frac.h" @@ -427,16 +428,6 @@ struct ia_css_point { s32 y; /** y coordinate */ }; =20 -/** - * This specifies the region - */ -struct ia_css_region { - s32 left; /** Starting point coordinates for the region */ - s32 top; - s32 width; /** Region resolution */ - s32 height; -}; - /** * Digital zoom: * This feature is currently available only for video, but will become @@ -444,7 +435,7 @@ struct ia_css_region { * Set the digital zoom factor, this is a logarithmic scale. The actual zo= om * factor will be 64/x. * Setting dx or dy to 0 disables digital zoom for that direction. - * New API change for Digital zoom:(added struct ia_css_region zoom_region) + * * zoom_region specifies the origin of the zoom region and width and * height of that region. * origin : This is the coordinate (x,y) within the effective input resolu= tion @@ -457,7 +448,7 @@ struct ia_css_region { struct ia_css_dz_config { u32 dx; /** Horizontal zoom factor */ u32 dy; /** Vertical zoom factor */ - struct ia_css_region zoom_region; /** region for zoom */ + struct v4l2_rect zoom_region; /** region for zoom */ }; =20 /* The still capture mode, this can be RAW (simply copy sensor input to DD= R), --=20 2.43.0