From nobody Sun Feb 8 13:32:52 2026 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD75F23C51D for ; Wed, 14 Jan 2026 17:07:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768410427; cv=none; b=r7X0yOB5cVryr+wPkloRFmVCYoKQ9Fz9SsHCvc6rDTokxyU55zg9gl6yyC1YzgDTrRaOgmjOmIhXbaU6GCuM/i8Na+TUej4LprT5weK9HUD0ZT5BlhiiwVcdk5rogU2L+FeM+ystk1ZcN6f0OUw12CUung9DgwgafJg3iQEOJzo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768410427; c=relaxed/simple; bh=TbzI/bD6DFrQZQgun/mAh3uK12x79cRdzpvs4SaNoVo=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=nVbzO77vjecSUIvQDYAZxaJRM/w44+Z30PUWMs7TOtvGbnMOUaFe4DPNgBm5KNCfX6OCQ66TqliOJj+NbcMR+0PZ7nwsz+FKPyPZk0CqVIGYEGwoVSJ0BoH4tQ4CxlSn7eP7k4Y7KDko3i5QzD8lJ3+928seL9ZJSJPAgyv4aE8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OrAUTmzU; arc=none smtp.client-ip=209.85.160.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OrAUTmzU" Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-3f5aaa0c8d7so6819973fac.3 for ; Wed, 14 Jan 2026 09:07:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768410425; x=1769015225; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QNhEaxSZLtZ583ZqqjEh4HtDQY1qITTRwZIloM+cVRI=; b=OrAUTmzUZShXdIL/Y/TPzXvsO5JqddwvJlR7o8tfhkl9jL7vRtusLUiiUYs/QxMIb9 M7JOsmn1ho6uFNrueDZZIdw0R9+IS0R9oxq/FJ2coJZpJaYkkyAIIbUqbKG+IEBaLNV9 M/WbrnS0Ce81EbWB0w9agHn80dtO6BFOrNrhZh7M7XRDHFdN1p3rqOuI+38GLo6b05GW jvNx0Uasq8EJq4NhLAfmPvSlh7nfob1Fes7gRklA6jP3nSg5Odh0gfcFC5POOt/mdRvG 3AQsefV5dvDXacl9OVlsQ0GwVEurpIJ3Lx/PE1gXqY6Nvrdzty3ZPDDjbkr2mwVdx+DN HbSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768410425; x=1769015225; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QNhEaxSZLtZ583ZqqjEh4HtDQY1qITTRwZIloM+cVRI=; b=at7e/Gz0XYl9zn58azTNkmwlUKT7YgMxhd4cgARJac+1aiyfqQTyiPHQibyBkhyhVD b3+ByGDv/swWWacRfInC1oJVPj0rbDd/UmUe8rwJFPxXtGLVE9YxXxPk6OYUZPIfJj/N HkGOD8tHjPIqgKwZfKYjm+EkK3tvT1pWr9Z2Ma1omlaPoLjzJYIQrj9K+H/NByKBFzum w4DjsYDS9NftSjtuP6RWmoAGOFfdzXVYYFMdlNGFZBh7IItzm7aAImwtp3KEz8FMcqaw D+hh1na+hsGNLm1vEltd1MwhKat/O2n1yZGKT8rNyJ1KwE6NVBY39slh2HOPsLzceeZ3 +Gsw== X-Forwarded-Encrypted: i=1; AJvYcCUasUPCvqweU7LSwwdwmhwNTPvap9wHx/c9nqUvuwqJxuwDuCnPEeUuXYgNDIY9XnrsGR2RzBRMu/RCJCU=@vger.kernel.org X-Gm-Message-State: AOJu0YyTztD0ohPp20JYFxBfKxR8KLwSmPtuYnTGChGL6Y9pDdYfsDgq gqptq7y/9zrr9HOhQ4+BcUfhgYKfqL5xQPvl2x2n33WpLCc4vOcZxmmb X-Gm-Gg: AY/fxX4yj420ISFQNK368A1+9+GDw8xC5DNirvFzkzMCB+9mxgC8JbK8gQ87O8lhlFr zfsb53H2AojLQ25dsfsuEP6uoMd29u1oc0jWCqeur8tVTCey3AjkA+GpPUGdpXI98Ax6quMakFQ IimIT5udK0EWl8GqmHk76IqUVtoG3YBcVjIQhhM5m4jYqEme5XupdfJiNw4VvWxWcafBZzf+czk zfLCXKL6feP7xyFtmkdy5cYUgszLWp+8ZxXQpbWTI7n3MRGbZ5+M7+oQvLAB9LRYmuvDjBVQq5F +wGmfkH/T7QSJvegw5onWZXRYmy4YP7MVzpHF0i+c28XAc7FmbgZgRuflbxNxlDiX6zBIe5iRLa B3CHSDsZuZI6F0nEb2JP6PdgNJYC2P/VjlD/VCfWXhH5p0z+Mw1QTiv59mLzO8oHGufudm+qc0y wunTjnxXo6+LK+uP0TzfEz/ByY3aevDWiq X-Received: by 2002:a05:6808:1a07:b0:44d:a429:e816 with SMTP id 5614622812f47-45c71531796mr1770671b6e.53.1768410424692; Wed, 14 Jan 2026 09:07:04 -0800 (PST) Received: from newman.cs.purdue.edu ([128.10.127.250]) by smtp.gmail.com with ESMTPSA id 5614622812f47-45a5e288d5fsm11880164b6e.14.2026.01.14.09.07.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 09:07:04 -0800 (PST) From: Jiasheng Jiang To: Chris Mason , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jiasheng Jiang Subject: [PATCH] btrfs: fail priority tickets in maybe_fail_all_tickets Date: Wed, 14 Jan 2026 17:07:01 +0000 Message-Id: <20260114170701.6018-1-jiashengjiangcool@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Differential analysis reveals that while btrfs_try_granting_tickets correctly iterates over both space_info->priority_tickets and space_info->tickets, the maybe_fail_all_tickets function only processes space_info->tickets. In scenarios where the filesystem is aborted (BTRFS_FS_ERROR), we rely on maybe_fail_all_tickets() to wake up all tasks waiting on reservations and notify them of the error. Because priority tickets are currently ignored, tasks waiting on them (typically high-priority flush workers) will not be woken up, leading to permanent tasks hangs. Fix this inconsistency by updating maybe_fail_all_tickets() to iterate over both priority_tickets and tickets lists, ensuring all waiting tasks are properly errored out during a filesystem abort. Signed-off-by: Jiasheng Jiang --- fs/btrfs/space-info.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/fs/btrfs/space-info.c b/fs/btrfs/space-info.c index 6babbe333741..09c76df8dbc8 100644 --- a/fs/btrfs/space-info.c +++ b/fs/btrfs/space-info.c @@ -1120,6 +1120,7 @@ static bool maybe_fail_all_tickets(struct btrfs_space= _info *space_info) struct reserve_ticket *ticket; u64 tickets_id =3D space_info->tickets_id; const int abort_error =3D BTRFS_FS_ERROR(fs_info); + struct list_head *head =3D &space_info->priority_tickets; =20 trace_btrfs_fail_all_tickets(fs_info, space_info); =20 @@ -1128,10 +1129,9 @@ static bool maybe_fail_all_tickets(struct btrfs_spac= e_info *space_info) __btrfs_dump_space_info(space_info); } =20 - while (!list_empty(&space_info->tickets) && - tickets_id =3D=3D space_info->tickets_id) { - ticket =3D list_first_entry(&space_info->tickets, - struct reserve_ticket, list); +again: + while (!list_empty(head) && tickets_id =3D=3D space_info->tickets_id) { + ticket =3D list_first_entry(head, struct reserve_ticket, list); if (unlikely(abort_error)) { remove_ticket(space_info, ticket, abort_error); } else { @@ -1153,6 +1153,12 @@ static bool maybe_fail_all_tickets(struct btrfs_spac= e_info *space_info) btrfs_try_granting_tickets(space_info); } } + + if (head =3D=3D &space_info->priority_tickets) { + head =3D &space_info->tickets; + goto again; + } + return (tickets_id !=3D space_info->tickets_id); } =20 --=20 2.25.1