From nobody Sun Feb 8 13:39:02 2026 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AB1A23504B for ; Wed, 14 Jan 2026 14:44:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768401895; cv=none; b=We7Snx36Qql/M/Wc5X8uUdkozy3tVh44lGAaXRrgj1DlagXtfH8W60AXdoqbwoAqEOEweTLD/7Yyb5fY6OFSnT3b5fxv1gxw5h9u5LSbdfh6Zsc192P2fqSgMz4NJ3ZGT6E3KYmalDDos75l7EMpEQaW83rCtPvRpVkO+V0kM1Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768401895; c=relaxed/simple; bh=ZdGn+g3+1OS0nkrvB4E8l23YybK09xBeJh00yNHe9bo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Nqf5IJa1c7+rtj8bNpeWbQ5K8QzpaI2GNGAMhGzrsJt50xnh3VPPlp37uxvxKgYV2IU+276ylkeCC9Ki0zvvFytSN/BbBVN26gSxfT8c7YAc6z7b+/NCB3qs/j5jK0jDsq4zOM0qHGk7Ff61O9pRH7te39zePpfIsBjezIZ1c3Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bqQffqvC; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bqQffqvC" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-459a516592eso5753129b6e.1 for ; Wed, 14 Jan 2026 06:44:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768401893; x=1769006693; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Tk41miGTpx94qcsuSJtMLlzWI+q+8a0dYgXV36tfo7U=; b=bqQffqvCbWUc7S9qF00nOcg/fNrrUnBauefE97r7GTbzLVqxBKCv20d3puFTioe1ih jtC2CEJHW6BwakAGYG4U0k04cWhlspk+aU0iAjyz4X8K598j6MV9wM7F7MX4/D2F+s1Q hmi/oViOV9S2Mgle5oAXqdhFntcABjbQAhzJhQ2NJdrnbLuvwtaJ97IUeFp3vPtG46X7 cx6dNZOv2Bfq6Joa8YXkKkvvJRTcs9VohHKsv4n9CIJCC6NDjKNGTp9y5DEqA50Nayfw KvbvIACqBG1RHQlRLE46ubkrkm/6hKBtcqk/u2d/LkKj1DvHD3MvJBEbx+Qp5zr/JE9F FizA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768401893; x=1769006693; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Tk41miGTpx94qcsuSJtMLlzWI+q+8a0dYgXV36tfo7U=; b=GJMyMvQaypyzvakFUZKtvrUf6ijseXXyvYNbzcAKz24VCwqB5mDqJwLL7Ld/WbaBhp +jKt3xRkwPFTkNNbplFiOf+8/+BZ3OD8S5a129jyoyE9pKLQS+xVerGNArxli+MSle27 ZmqN1cAYrbobzdHSuT7ES3ghREFqxapgHxk+frl64i8dxHjAo1MDSTQNMo/Ayn6nCZgY 434ulzxSDefcdtDswUdkK7wsbhz+JT0uFl5ehXU0gWgoh5dtAbDGqydokBy7RsGdT+Qw iL4QZIPAByQXlaTT3gr/feb4mFRMDUs3cNnvkgJyvmiCecn9eKjM8PxwfTrPDV+xgqZg otGQ== X-Forwarded-Encrypted: i=1; AJvYcCXL0UMe0SGMGXF+pqzi4C5Sidnb/NtajxqQoDVkR6r8VMasKSij4bLFhSSj8B4HFPW4P3ag4eciqCL2yXA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyd5qgiWLeTyWanZA0Ev0hH6DYJjXX92iROpAgrwfvLHCDamqps VLg8367W5K7HBMNHeHRKOp93iLog8dofyKUKSHyjtODDrpP9RHMbKXQl X-Gm-Gg: AY/fxX5ybefKidcNUsDoaz2qSRuNiFGQw7N62WgC8wT4oXWHnR1GTzr7muFFc2A+2Wt 9nz++1XAR9NmgVFswQksBfvMpTaUqQUOdoGt+bCuqMRzF14d5kqn48peSJuxC6tgYiQ4ptkgiW/ XNCV8gE6LunqvaRmZjMaASIdX3NtUYlCeARBsnnATrEnzfUiFGjK7pKdsJyzbezLC2i6BmD7L0T f9EO6FtrgL7MmJ+fwUxt839QD1bbr2xZSZ7G2edWJL/E2CAgY1mPkneSbfn+VvugJeoq1vrHMDA z/MH4TERYaMirqY3jOtrrwTruQIB8UkIyI8o182I0/MqOgaacPcqBS8Vju2Z2iR+tXsr0tTjrdx 49LxGzQ+t7Z95hyPyi3/AUsY7Hny111wfL3xTWvRekowIHZX2p4a5XQ1SB7NaTPm9JMma8KtbO1 aJj4uzqXcQ4yywulIGZfBgTu1/bK3Jd0vbF2tg7xVuod0= X-Received: by 2002:a05:6808:d4d:b0:453:77d6:1784 with SMTP id 5614622812f47-45c7153d1aamr1775376b6e.33.1768401893309; Wed, 14 Jan 2026 06:44:53 -0800 (PST) Received: from newman.cs.purdue.edu ([128.10.127.250]) by smtp.gmail.com with ESMTPSA id 5614622812f47-45a5e1b1285sm11015763b6e.8.2026.01.14.06.44.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 06:44:52 -0800 (PST) From: Jiasheng Jiang To: naohiro.aota@wdc.com Cc: boris@bur.io, clm@fb.com, dsterba@suse.com, jiashengjiangcool@gmail.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3] btrfs: zoned: remove redundant space_info lock and variable in do_allocation_zoned Date: Wed, 14 Jan 2026 14:44:50 +0000 Message-Id: <20260114144450.48776-1-jiashengjiangcool@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In do_allocation_zoned(), the code acquires space_info->lock before block_group->lock. However, the critical section does not access or modify any members of the space_info structure. Thus, the lock is redundant as it provides no necessary synchronization here. This change simplifies the locking logic and aligns the function with other zoned paths, such as __btrfs_add_free_space_zoned(), which only rely on block_group->lock. Since the 'space_info' local variable is no longer used after removing the lock calls, it is also removed. Removing this unnecessary lock reduces contention on the global space_info lock, improving concurrency in the zoned allocation path. Signed-off-by: Jiasheng Jiang --- Changelog: v2 -> v3: 1. Removed the description about the 'space_info->lock' in the comment bloc= k above do_allocation_zoned(). v1 -> v2: 1. Removed the description about avoiding deadlocks. --- fs/btrfs/extent-tree.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index e4cae34620d1..36b06ee47c1a 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -3824,9 +3824,8 @@ static int do_allocation_clustered(struct btrfs_block= _group *block_group, * Lock nesting * =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D * - * space_info::lock - * block_group::lock - * fs_info::treelog_bg_lock + * block_group::lock + * fs_info::treelog_bg_lock */ =20 /* @@ -3839,7 +3838,6 @@ static int do_allocation_zoned(struct btrfs_block_gro= up *block_group, struct btrfs_block_group **bg_ret) { struct btrfs_fs_info *fs_info =3D block_group->fs_info; - struct btrfs_space_info *space_info =3D block_group->space_info; struct btrfs_free_space_ctl *ctl =3D block_group->free_space_ctl; u64 start =3D block_group->start; u64 num_bytes =3D ffe_ctl->num_bytes; @@ -3900,7 +3898,6 @@ static int do_allocation_zoned(struct btrfs_block_gro= up *block_group, */ } =20 - spin_lock(&space_info->lock); spin_lock(&block_group->lock); spin_lock(&fs_info->treelog_bg_lock); spin_lock(&fs_info->relocation_bg_lock); @@ -4002,7 +3999,6 @@ static int do_allocation_zoned(struct btrfs_block_gro= up *block_group, spin_unlock(&fs_info->relocation_bg_lock); spin_unlock(&fs_info->treelog_bg_lock); spin_unlock(&block_group->lock); - spin_unlock(&space_info->lock); return ret; } =20 --=20 2.25.1