From nobody Sun Feb 8 18:39:25 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27F721A08AF for ; Wed, 14 Jan 2026 13:25:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768397138; cv=none; b=fJSgmpJ/HxqC7JpBuHdTcJiqvtUPtK/DGyOp9mlspPOeq2CnVwkWUhorVMHdSGhExJgCb87QetTrrQ2IWgF0V2DI7Ou2TevZKrBASVL/eIBql7pfDNwRfXVGjnzAzri3SnEKB0izG+vo20SK6dxWJ3dEF+jKcYLCeyp5eu/qRt8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768397138; c=relaxed/simple; bh=IJ1YuoJNnINORZcq29gXzb5yWN7982dGGnwo2QAKeIg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QzjZqIwoYgnx69I69AvChqxHLeq1kdXztBDP9tnypD4/NUN8xo2FsJjFhfjDDpSQ1srICr6xKIl1YO05Pl+f+Xqw+fXSM4NX6Kf6TGJ0yoObvL5mASRhI5WY85GzWL+n9hg0askdqS01H1PlhP75xIs3UwAJCq0SfEFnu+Og1so= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LXODbjNp; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LXODbjNp" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-81f3c14027cso458144b3a.1 for ; Wed, 14 Jan 2026 05:25:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768397136; x=1769001936; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8LnhTFj1tma4eUY9c5fXV/iFL0e6WBel/tWLHDbN1mw=; b=LXODbjNpDnIZwIcP+trnGPvAqyoOtcbUjuT7lHcbyjF8zN/YnsX5Ghpy15k0lyulKQ nOwLcC/BjXO3me+HCyVtI8XJQy8Y/mw++9jxDeClRdxYPTASAwpbPJHBpp9wEEWXlsPz qk0I38UAaOUu1KAJHYn65g373VpEqkaeD0fDMlkDvR6Ouxj5x1kRiQs1EKHX2/LaAXOE QIT1WHQ6J5VgUd6lyO/GpfcDGlwayzZ9rqQHaGI3SqtAPHxU88JFWGGrqpUbCvB0nkPR WvDKGNJL/a7I8TCXhk37YBk3t1UUdfOKwRBWgtZd/3CbIrbnsw84z51MRNzU+86a42xF NEeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768397136; x=1769001936; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8LnhTFj1tma4eUY9c5fXV/iFL0e6WBel/tWLHDbN1mw=; b=SdixIdp4mpwte29fU+daJiT36ZzB4R65bm8XhiLP7n0jVrjMd9LVszL4rvr+3HXW42 zdwYY4veS9Rkb7kqZZDBNB3oAR3V6qq6QHCGjTpCsyCTXLVFUkEqKGyOmrLE2XSn5FQs Z12+z4C+dqfUhxa+s2BmjMndpo9LOKNY0mV6mRpNsQ+iqjnMrsuRW9DFKlWBeIOxFUun kTGtlBzABBRlJ0t/XLZ8DiZESaMGRcjz50A89bJejIbauq3hwxRHTw2fO9PGd6yJ+44/ sLBcCadrPbxoXMHKanmCMLCnkDARj1ww9wDp2tUDVVthdxKlobatdyib16RrOxGFr090 1LIA== X-Forwarded-Encrypted: i=1; AJvYcCXE9JX86BmEI+OUfUWygxsC4Iw+r9AwdbdGR5l9uoTFjI4NLiPBrPtB+zIWXXnfkoKEgJAkVuWR8MBBzVo=@vger.kernel.org X-Gm-Message-State: AOJu0YwxCz8GNIlHaKo0e8WAU2CS1WiEfwM1jodGzHmhiPAs4yftFEv/ d2HHZOHuJlXhbPhOsw3SWLKxWpaIwkBOtIFbANg3M2igEbbN+Sx3FLHA X-Gm-Gg: AY/fxX7FgqLZFxoDUfxPb2gHTu6LqNjnrXTouDWYmrQpbm8yuUdaHwbIc4n2LK5+RHn ow013OJEOLfeolRSM/oVoxB58lJnkNqdbG93EQu4BB7TO4+DYxWhnMGsbXb19O29uijzPUvThwb OyFl2sQ8VGe8eKjUX6dV1agU6aP9PoElze/8Ml2yWJ6UeZDCDklVx2JvZ4jzzaHirauNeE9UY5j jgKHtZ8EqSJZ66UStuGazoS0Jj2IJHuJ+/B2ZgucuT9bbHTOdMQ5TS6/oE+5KNf3D67yOfYKAcg 14djTKweORdsqzipJxs1k7lySM4nGYvg2fAwUcfZHpmRDS5ZLT8xQuid4gxPTtNSxZEcjA1FD2K Rb+SHqLnXWr6BDAhxnwa2mozGx5lTHnycgg/k5lkZRnVFbU0bd2IIZzjSm4/dPD5lVBT67BHVyE 9+sxRYwpzRhNL1W+7YmhCFMkXHfQ53PV7c6w4= X-Received: by 2002:a05:6a00:22c6:b0:7f0:61d:d092 with SMTP id d2e1a72fcca58-81f6f7dc7c0mr6720265b3a.21.1768397136338; Wed, 14 Jan 2026 05:25:36 -0800 (PST) Received: from DESKTOP-MOQC9AF.mioffice.cn ([43.224.245.239]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819c52f90c0sm23282961b3a.41.2026.01.14.05.25.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 05:25:35 -0800 (PST) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: Peter Zijlstra Cc: Ingo Molnar , linux-sched@vger.kernel.org, linux-kernel@vger.kernel.org, Zhan Xusheng Subject: [PATCH] sched/fair: clarify init_entity_runnable_average comment Date: Wed, 14 Jan 2026 21:25:31 +0800 Message-ID: <20260114132531.19599-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The comment in init_entity_runnable_average() uses vague terms such as "full load" and "heavy tasks", and does not clearly describe how group entities are initialized. Clarify that task entities are initialized with their scaled weight so they are initially considered heavy until PELT converges to the actual load, while group entities remain zero-initialized until tasks are attached. This makes the comment more precise and consistent with the code. Signed-off-by: Zhan Xusheng --- kernel/sched/fair.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index e71302282671..99c22863f3b8 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -1060,10 +1060,14 @@ void init_entity_runnable_average(struct sched_enti= ty *se) memset(sa, 0, sizeof(*sa)); =20 /* - * Tasks are initialized with full load to be seen as heavy tasks until - * they get a chance to stabilize to their real load level. - * Group entities are initialized with zero load to reflect the fact that - * nothing has been attached to the task group yet. + * Initialize runnable average for a new sched_entity. + * + * - Ordinary tasks (entity_is_task) are initialized with their + * scaled load weight so that they are initially considered "heavy" + * by the scheduler, until PELT smoothing adjusts them to the actual lo= ad. + * + * - Group entities (task groups) remain at zero load since no tasks + * have been attached yet; their load will grow as tasks are added. */ if (entity_is_task(se)) sa->load_avg =3D scale_load_down(se->load.weight); --=20 2.43.0