From nobody Sun Feb 8 20:59:56 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA147396D36 for ; Wed, 14 Jan 2026 11:49:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768391389; cv=none; b=jnLTFus8hBbUXD0n1uVp77JK6yU+jN1jfJLk8aTBtPgb9sFXKpvvqECz7N8L7jiuETiOANikmBGF2PtoiZmK/6uwe6hoWA/jlovKrSDHkOTRVzGjUf5jD1uBqy6zdpvOnJSzi/APycEk/TqvEsXxLQtvS0JnwFXTZ9OfjdLYBE4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768391389; c=relaxed/simple; bh=mHd5/FDiQ86yScP8/xKWBTcg+ow54G9KDtNwccSg1Uk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nML01sHrRdLP4X6LdXjNYP4RWz9pMCTVnli5FWfkddkebhVDB08fzmco6/M0Ac4+wcwqHBeWqVSrNv/Xz0/rummBc9HUbk0Lx1sJauTZJPYEEVlRXF625ze3j4UqgOpoRXGDqSlM/xDcmwMbc508DbX+qit7VoxyF0k5qgu/d/g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UPbIsKw9; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UPbIsKw9" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-bc274b8b15bso5524392a12.1 for ; Wed, 14 Jan 2026 03:49:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768391386; x=1768996186; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qykhmziqocBs83eOMsCXS+riegj3dQCRKqwsythsgqI=; b=UPbIsKw9rTGrJ0YchZMoe5YB2dExA6jg3yz2G6T3KOPpdUTSX2E9sGfj/qJWoPfdkB /14NyQ0ejiJfMQZm/pvMaxKeoeu6O+9C0codz1OJF9iCsx1cD4b4+7FstdYC16t+pQon vpasjHat4RoGVmqHeNwG/VuP1yrvwJbdamnP03I1E14RP4XpNuImMUv2ri17pJLwbm9X 1vr0uobR0ORSTQwIMwGWbsl6Px6OZV2uimQLHKb6RWexwAFqjNq+MaP81yzNKw9YcwXr kNa1+t/tdEDB4hszdxaZqwP1j6k3FJO8NCmlnHrpLl3edwx2bdZ4MiG0g9q736ho8T7W 8LdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768391386; x=1768996186; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qykhmziqocBs83eOMsCXS+riegj3dQCRKqwsythsgqI=; b=IPzDyp4fUFa/zz0i/dQS8PJKA1fdte1wigZG3ithlHBtygWHGdzrHO9N6yE9eIsb6Y v1HGeWpgoBqL4TgPUOq3kKQbfhgTGhNoQPnBTsGricjmh3k5RiBiZ2pqA1nkPgWrAkhv Nxf1CpJtqrqr/EEQ9LiAhjH/GD5BJvWPs+ITnl4icnR+anxHmuCD9xGUwaevMosjzbul ysu4ujz0VtUI2SUraMNuFnSnnfGH35RPWCLCztr5RlgkejaVFMpVgsiPhjpPpTlynZ9t V6uV27VUUfSh9DE3V+0TqWkf6jtLPtGvTfIZAOonre4SW3uWdZ9SFnrkP601szGGGFuJ MuSQ== X-Forwarded-Encrypted: i=1; AJvYcCVsJXmqt1lJq/cyG7f7ygjtfQaGpI5yzZ839duDNAR6bPgfPZuwJdiWkYmk2rz7Qcsq6/3shkomRGHmiQ4=@vger.kernel.org X-Gm-Message-State: AOJu0YxWohbdVH15dtdkt6KtnAXxrYt641+OQUienFSOf3n8csdP6VxI qZH8kiiJUtSZ3LdAiOtbIt61dTiUs0HE2r2EgeEUyqN2qp20XV59iZQc X-Gm-Gg: AY/fxX7jXHOcxGgu3HGLBj2SQhAp+g1kxYFxECBM+MXzFaS7H5VV0H+l1cAH0hr0Lbx 2PlNJe8fVeAXYgyrPw2IVL/5fccUUVXsoBj8IU030ThxxgI83wzeXmmCcWWcJTZY501wQUCuYTQ rQtKkfTkuzBhjGIremeRTOkl1CFU/c0SRJvANeYWzK8gfBX84kHw56ycfJhof9QARQJhIH7+Lif lheRmEjQfScxJd4/c5aoFYDWNfLkjJjnv7uNtBi5TlY6oqVeqGOzQxmSP8gV/KyPvJekZ1958G1 mwKv7pJgfN7Dsaz4vonzjNoTb80/O+yAgohzovy3uw31cNMomGox+NpdbFyfrogmpwbY/Ap0QHq mcMWsDM6IEs2jlzzyK0UzgE+jDrBuSS7aVPhzpQCd8eqP27lSOvSkt64J6Oo6Ft7KHOf0FMt/YI y07ICZrfci3wKh8+Tb+CywkKaunO6KaXq59wNbTB1GgG9vemU/NE1g+g== X-Received: by 2002:a05:6a20:3d0e:b0:35f:84c7:4031 with SMTP id adf61e73a8af0-38bed1f3939mr2523103637.55.1768391386021; Wed, 14 Jan 2026 03:49:46 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c4cbf28f678sm22632123a12.3.2026.01.14.03.49.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 03:49:45 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, Dan Carpenter , David Laight Subject: [PATCH net-next v5 1/2] net: dsa: yt921x: Fix MIB overflow wraparound routine Date: Wed, 14 Jan 2026 19:47:41 +0800 Message-ID: <20260114114745.213252-2-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260114114745.213252-1-mmyangfl@gmail.com> References: <20260114114745.213252-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Reported by the following Smatch static checker warning: drivers/net/dsa/yt921x.c:702 yt921x_read_mib() warn: was expecting a 64 bit value instead of '(~0)' Fixes: 186623f4aa72 ("net: dsa: yt921x: Add support for Motorcomm YT921x") Reported-by: Dan Carpenter Closes: https://lore.kernel.org/netdev/aPsjYKQMzpY0nSXm@stanley.mountain/ Suggested-by: David Laight Signed-off-by: David Yang --- drivers/net/dsa/yt921x.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c index 0b3df732c0d1..5e4e8093ba16 100644 --- a/drivers/net/dsa/yt921x.c +++ b/drivers/net/dsa/yt921x.c @@ -682,21 +682,22 @@ static int yt921x_read_mib(struct yt921x_priv *priv, = int port) const struct yt921x_mib_desc *desc =3D &yt921x_mib_descs[i]; u32 reg =3D YT921X_MIBn_DATA0(port) + desc->offset; u64 *valp =3D &((u64 *)mib)[i]; - u64 val =3D *valp; u32 val0; - u32 val1; + u64 val; =20 res =3D yt921x_reg_read(priv, reg, &val0); if (res) break; =20 if (desc->size <=3D 1) { - if (val < (u32)val) - /* overflow */ - val +=3D (u64)U32_MAX + 1; - val &=3D ~U32_MAX; - val |=3D val0; + u64 old_val =3D *valp; + + val =3D (old_val & ~(u64)U32_MAX) | val0; + if (val < old_val) + val +=3D 1ull << 32; } else { + u32 val1; + res =3D yt921x_reg_read(priv, reg + 4, &val1); if (res) break; --=20 2.51.0