From nobody Sun Feb 8 18:49:36 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA6E138F93F for ; Wed, 14 Jan 2026 10:07:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768385281; cv=none; b=rHRXbuMQc4aCjuJORIRsqQHggfbfNe1Ikg6M7cvFm9Zhm++mdP/BVULY7Sw0vCfKvtc7OFik2JVPg066OdZo433sj2nf0PJTy4UL0EHgQsPsgYFG1cz11JkaeUUkiELmJZzvme/PH4kEu+zZsMmYp52n0rDNs/irIoGnb4ADnSg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768385281; c=relaxed/simple; bh=phMaZEdW+xwnGZ/4yeh8Mowv3dTqrpN1TGsy4KysEu8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=NyszISQG3lpK6BiTiyZpRtrkbZHl9kvNlunqGtq4KNRIKRrxOZ6HAcRIGNIDV7aPnuzSkHhbcMNQT8rDoga8EZe8GTiVa/tzGaUaBxjLOHlDm/gaSchg4L/922QYV5LfMQytGXWd+wtQvZU0ql8UAR5VlkYaM3pinx82MDa73es= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GCnxFrLm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Xyia5pM8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GCnxFrLm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Xyia5pM8" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60E7jPDU2057182 for ; Wed, 14 Jan 2026 10:07:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=cdPa96MAj6K cEAgrDqHeO2LCi+XsOMkFPiPYTvWqu9g=; b=GCnxFrLmQh/9UfLZODrAy8FyEM/ 22hGQehbourkAA9ZPt0SDl4oHpGQTg4G7v2C+dcaGAdbXtdPMVuR5H0IuPd8Tpcg A9ZdL62gjVnf/CTlqP1hDU6lEbL50kq1OuFQ/8RW/F/8jqIi1O5SjpvnSUb6LL33 5nwqY9nU6nmDMObw1+WLIt7uJjsyyb5w2znL3hn5nku7vpz754AmWpU99YVJjFRw H2DUVx4sMTmCKu+XSm1BVuveRpLmXWAh4un4vxY1V8JpEE8iOq0gdOQDZlMiqOY7 Bi3xQAk/tI4rd2i8nR//hmdq6WiPnd0uwFosx5xE6GMBpagN9SMLzGri+FA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bnr3ebph2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 10:07:59 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a58c1c74a3so16256735ad.2 for ; Wed, 14 Jan 2026 02:07:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768385278; x=1768990078; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cdPa96MAj6KcEAgrDqHeO2LCi+XsOMkFPiPYTvWqu9g=; b=Xyia5pM8W2TusvWG7OBQnsPXtHMbc8ygnKnIW81O+7TCsgTPgaMW3XqILDZQ/bOyti /RzLWL55AUECSigIJ52rcIcWgKKcnf+Yh2E9IBI8KI/9XEJ0HPe0jU4FnSiA/DbPQ2MZ W3tRK2V/nmTGkiihSdi8erPJDh08VVjTP2OqIhE0G+rfWO7yPawbaPhVWRIKT7A/QrS4 IgFI0VxZeGC0Py0fznAvXqjFYgaWSt9s1ezBsF+PTnZ7STbALc5WQPmKD1laxeGj7GCp uo+eWs4exdbhhUFi2qoRhV5y8GiOWn5q9GPTZb1SGPuNSCpE73EirKFhKDV9F6fppPG0 i5tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768385278; x=1768990078; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cdPa96MAj6KcEAgrDqHeO2LCi+XsOMkFPiPYTvWqu9g=; b=SGQnAE4DH+YS5p+kHZ5FhEqx4IwRXpHuSaNqbLOL8yERxJGuVl1uRrbk/J/0Tehjn5 WNPqf3/Cft4H/ma9LuPjfrmnPAGS9DJWitt6X1fe2nSrOpGvHalwgTS+RkJYNuXj1Db+ 9a6djypcW+cBDemFXl6TRm9KQPWDGxx8L6FCfj4Pb6AzfS6G+83istHfRz2bAP9julnv Qe0eG66sAjR+cLvHR8hItXn5GlnQoZG64yjwczunbpZSwoL/4CHEI5Pm84LVRFQexl0i wH5LQ2FbGRjyGAjBUlZn4FwgtjGcm53bONqbhmQVqPVScz6sC6xuLBtUxmaP9/TJoWkW LZNQ== X-Forwarded-Encrypted: i=1; AJvYcCX2A8Qp4MGO7zCsEdJBEiKgV8Nfos8dq0aAC67Jw2IruDjmm9xLolUEqmKiJH4KiQfz6ZcBwJWkLFQ9y4A=@vger.kernel.org X-Gm-Message-State: AOJu0Yz23LenAYSJfzObFgSdDdD+EkYgiNEibWaw4RFyQQs852fuqlym LGHPRW6VV7/NM5zIvJxQghV/zlKnMUA1VMZ3dC1TU6O7Ewsqvjwz7ukGgJbnTP7mJsAA7TwLpiw iSWabhSaKzj9beZeyhd2lb8lt3oqQ7h/0jr7L/4HGNCkPuncSPkbbSLQ3nTdlZKmO/WBCcR+e2n I= X-Gm-Gg: AY/fxX6zIIId7tDaJQmLwhWxVEbW7sBVd/L+oFQFItT3HNFuvJdEhWLWypWAhXYRKCx mCISr+hG0AkNrhOLZaQHw3gk25jcMUhnusRG91PH8U4rtzU3nEtD9DlhhwwxKl5SVU1Xx2LcBkJ 4Un0/gqH7s9pVuxWzY0ImCpuCO8vdPGfAdN4/j+GerFf1etgI0diCS54zB475Pp+nLH+o8YWt15 XorM7AY1vWDey3QFRyRDcQE8UBh4T86oyKsovqPhmUPafjHjNubxBorv0BPe2H0f2DlUzVdQ+4e tR+dC/qhEdDOLsZBEL3FjAwBVND8EOFr2HiWx+Q7Wx1DU9LQ7JXJsY5r5wc9hopezfiEUMvrxYk zCW9Lq6bBIJvUfC41hGuTHs+ihmA/0w2EymqI6A== X-Received: by 2002:a17:902:d4cd:b0:2a1:1f28:d7ee with SMTP id d9443c01a7336-2a599e5b9fcmr19238925ad.57.1768385277703; Wed, 14 Jan 2026 02:07:57 -0800 (PST) X-Received: by 2002:a17:902:d4cd:b0:2a1:1f28:d7ee with SMTP id d9443c01a7336-2a599e5b9fcmr19238675ad.57.1768385277253; Wed, 14 Jan 2026 02:07:57 -0800 (PST) Received: from hu-prashk-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cd3632sm226379975ad.95.2026.01.14.02.07.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 02:07:56 -0800 (PST) From: Prashanth K To: Thinh Nguyen , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Prashanth K Subject: [PATCH v4 1/3] usb: dwc3: Remove of dep->regs Date: Wed, 14 Jan 2026 15:37:46 +0530 Message-Id: <20260114100748.2950103-2-prashanth.k@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260114100748.2950103-1-prashanth.k@oss.qualcomm.com> References: <20260114100748.2950103-1-prashanth.k@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=TPFIilla c=1 sm=1 tr=0 ts=69676aff cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=jIQo8A4GAAAA:8 a=M8qNcNEInNZZPuFPK7cA:9 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDA4MiBTYWx0ZWRfX4BhJ9AS50rn/ qhNPbD7C324kXXVTVEPQWECTk6ngNgJEfX8pweBa8wUTZbJdoMLpk97P5I/E4Jx+TvqBNl3AtRM /eKICEvpzu2Eo0h0k3cvv1WHqMr24dULkQ7Z8bBndrEn7gx6u18m+3pOr/yJJ4wXIOoWGqe43Ek /GAYU0CQ0zNoDex1/D/uS2Oq3H78xN+/dEpXSKGhbV+K+TmPXVvCu0Kax8o6kolKRBeDfLwdLcC McOdkhvll02+vSLM2HWez7iaEK+uTlgC5bX4sXwgMSVxuYkh2QIcj3hhAIoSlbJVQ6xSRzbsh1L wE6esH0hlxFeU86MsMdNkCr48dJ/5Es3/of+p95KpEVD7tCxW5/uxnbrqzGStpobWycMXg5icZJ FB8gNAi8iCXELfJQe8BAHsH4Ihl30yK0u+LpPmi8KEKqALemN8TbAtvO0gIHFpmbdClTyW4KL7T a/RS0pv/BkU50SfeHdg== X-Proofpoint-GUID: 3_KP0ZfQiT8vcFy9WvF_O1Z_CyaK39qc X-Proofpoint-ORIG-GUID: 3_KP0ZfQiT8vcFy9WvF_O1Z_CyaK39qc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_03,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140082 Content-Type: text/plain; charset="utf-8" Remove dep->regs from struct dwc3_ep and reuse dwc->regs instead. Thus eliminating redundant iomem addresses and making register access more consistent across the driver. Signed-off-by: Prashanth K Acked-by: Thinh Nguyen --- drivers/usb/dwc3/core.h | 10 ++++------ drivers/usb/dwc3/debugfs.c | 12 ++++-------- drivers/usb/dwc3/gadget.c | 12 ++++++------ drivers/usb/dwc3/gadget.h | 2 +- 4 files changed, 15 insertions(+), 21 deletions(-) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index a5fc92c4ffa3..23188b910528 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -165,10 +165,10 @@ #define DWC3_DCFG1 0xc740 /* DWC_usb32 only */ =20 #define DWC3_DEP_BASE(n) (0xc800 + ((n) * 0x10)) -#define DWC3_DEPCMDPAR2 0x00 -#define DWC3_DEPCMDPAR1 0x04 -#define DWC3_DEPCMDPAR0 0x08 -#define DWC3_DEPCMD 0x0c +#define DWC3_DEPCMDPAR2(n) (DWC3_DEP_BASE(n) + 0x00) +#define DWC3_DEPCMDPAR1(n) (DWC3_DEP_BASE(n) + 0x04) +#define DWC3_DEPCMDPAR0(n) (DWC3_DEP_BASE(n) + 0x08) +#define DWC3_DEPCMD(n) (DWC3_DEP_BASE(n) + 0x0c) =20 #define DWC3_DEV_IMOD(n) (0xca00 + ((n) * 0x4)) =20 @@ -749,8 +749,6 @@ struct dwc3_ep { struct list_head pending_list; struct list_head started_list; =20 - void __iomem *regs; - struct dwc3_trb *trb_pool; dma_addr_t trb_pool_dma; struct dwc3 *dwc; diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c index d18bf5e32cc8..0b45ff16f575 100644 --- a/drivers/usb/dwc3/debugfs.c +++ b/drivers/usb/dwc3/debugfs.c @@ -36,23 +36,19 @@ #define dump_ep_register_set(n) \ { \ .name =3D "DEPCMDPAR2("__stringify(n)")", \ - .offset =3D DWC3_DEP_BASE(n) + \ - DWC3_DEPCMDPAR2, \ + .offset =3D DWC3_DEPCMDPAR2(n), \ }, \ { \ .name =3D "DEPCMDPAR1("__stringify(n)")", \ - .offset =3D DWC3_DEP_BASE(n) + \ - DWC3_DEPCMDPAR1, \ + .offset =3D DWC3_DEPCMDPAR1(n), \ }, \ { \ .name =3D "DEPCMDPAR0("__stringify(n)")", \ - .offset =3D DWC3_DEP_BASE(n) + \ - DWC3_DEPCMDPAR0, \ + .offset =3D DWC3_DEPCMDPAR0(n), \ }, \ { \ .name =3D "DEPCMD("__stringify(n)")", \ - .offset =3D DWC3_DEP_BASE(n) + \ - DWC3_DEPCMD, \ + .offset =3D DWC3_DEPCMD(n), \ } =20 =20 diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 8a35a6901db7..ce087cbc4a53 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -320,6 +320,7 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsign= ed int cmd, =20 int cmd_status =3D 0; int ret =3D -EINVAL; + u8 epnum =3D dep->number; =20 /* * When operating in USB 2.0 speeds (HS/FS), if GUSB2PHYCFG.ENBLSLPM or @@ -355,9 +356,9 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsign= ed int cmd, * improve performance. */ if (DWC3_DEPCMD_CMD(cmd) !=3D DWC3_DEPCMD_UPDATETRANSFER) { - dwc3_writel(dep->regs, DWC3_DEPCMDPAR0, params->param0); - dwc3_writel(dep->regs, DWC3_DEPCMDPAR1, params->param1); - dwc3_writel(dep->regs, DWC3_DEPCMDPAR2, params->param2); + dwc3_writel(dwc->regs, DWC3_DEPCMDPAR0(epnum), params->param0); + dwc3_writel(dwc->regs, DWC3_DEPCMDPAR1(epnum), params->param1); + dwc3_writel(dwc->regs, DWC3_DEPCMDPAR2(epnum), params->param2); } =20 /* @@ -381,7 +382,7 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsign= ed int cmd, else cmd |=3D DWC3_DEPCMD_CMDACT; =20 - dwc3_writel(dep->regs, DWC3_DEPCMD, cmd); + dwc3_writel(dwc->regs, DWC3_DEPCMD(epnum), cmd); =20 if (!(cmd & DWC3_DEPCMD_CMDACT) || (DWC3_DEPCMD_CMD(cmd) =3D=3D DWC3_DEPCMD_ENDTRANSFER && @@ -391,7 +392,7 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsign= ed int cmd, } =20 do { - reg =3D dwc3_readl(dep->regs, DWC3_DEPCMD); + reg =3D dwc3_readl(dwc->regs, DWC3_DEPCMD(epnum)); if (!(reg & DWC3_DEPCMD_CMDACT)) { cmd_status =3D DWC3_DEPCMD_STATUS(reg); =20 @@ -3381,7 +3382,6 @@ static int dwc3_gadget_init_endpoint(struct dwc3 *dwc= , u8 epnum) dep->dwc =3D dwc; dep->number =3D epnum; dep->direction =3D direction; - dep->regs =3D dwc->regs + DWC3_DEP_BASE(epnum); dwc->eps[epnum] =3D dep; dep->combo_num =3D 0; dep->start_cmd_status =3D 0; diff --git a/drivers/usb/dwc3/gadget.h b/drivers/usb/dwc3/gadget.h index d73e735e4081..c3aa9638b7a5 100644 --- a/drivers/usb/dwc3/gadget.h +++ b/drivers/usb/dwc3/gadget.h @@ -132,7 +132,7 @@ static inline void dwc3_gadget_ep_get_transfer_index(st= ruct dwc3_ep *dep) { u32 res_id; =20 - res_id =3D dwc3_readl(dep->regs, DWC3_DEPCMD); + res_id =3D dwc3_readl(dep->dwc->regs, DWC3_DEPCMD(dep->number)); dep->resource_index =3D DWC3_DEPCMD_GET_RSC_IDX(res_id); } =20 --=20 2.34.1