From nobody Tue Feb 10 00:24:42 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 391B73876D5; Wed, 14 Jan 2026 09:27:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768382878; cv=none; b=ZtykYNxPn4JGduPwIfjc0THV7vn43RsQ9dxVGFCKr6Ia1OzwPGQAOhDy2IWiq+yNtT00Ysw5jG++iSx54jgjcESYJWeQZRmZzZqo51XcttMnPqxOdCGvzWc9GOmqrNLB2NyGq90UseQiE3Wm5dYz2NZ0g/+oA2dX/0YyenhkYag= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768382878; c=relaxed/simple; bh=DF4IVE+H3i5y6MYd4G1/bcW9AIbcqBrlEypFUFFzNxY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kAdTuTmVKKNGY218ZTaLSzLwcQCFXB7XnU5l5E1ntia00UkZ4ANQyxTTCs+Jfdpkusve6PubGSbbVaWuAY0cvBwjFCU1nLDGFO/AflZcPrq0qhb91QADmu+Rpzd7upzRGcLarQlgC33AzrDvIKv6mlAKiJURGtMxALYRcke24Iw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=a9HtEzo6; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="a9HtEzo6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1768382871; bh=DF4IVE+H3i5y6MYd4G1/bcW9AIbcqBrlEypFUFFzNxY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a9HtEzo6KnmMsTPCcYyqHsJvzIif7/Cb5oZ9K3UU706bRFvTXUOPUvzqqKAWqNUeg NOUvZm2zBXoLQja1z3x5xVyEFm2oi7UzB6TedPwzdHV2J7c1Kgd1to6huqr2JTVAlt JUQlsIA/54CwNcRobzsVGUlqBI3r1VWuGplieWgnGZXSZSbliOZ6ShLxl0IxShys63 cIss5U1HOLEYbbYgw4i22QZKgnei6uiC1GmQhP1Dmkf2filn0Zb0G6a+vILu6nCsf8 +/z30h7IeBqwYYBvYbjD0Yjw6Y1t/aYK49bpEv3zyaWChxeStRdUnK/gWxq/st04Hg /pLIKINMd3+og== Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 7783917E1523; Wed, 14 Jan 2026 10:27:50 +0100 (CET) From: AngeloGioacchino Del Regno To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, srini@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, sre@kernel.org, sboyd@kernel.org, angelogioacchino.delregno@collabora.com, krzk@kernel.org, dmitry.baryshkov@oss.qualcomm.com, quic_wcheng@quicinc.com, melody.olvera@oss.qualcomm.com, quic_nsekar@quicinc.com, ivo.ivanov.ivanov1@gmail.com, abelvesa@kernel.org, luca.weiss@fairphone.com, konrad.dybcio@oss.qualcomm.com, mitltlatltl@gmail.com, krishna.kurapati@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org, kernel@collabora.com Subject: [PATCH v8 03/10] spmi: Remove unneeded goto in spmi_device_add() error path Date: Wed, 14 Jan 2026 10:27:35 +0100 Message-ID: <20260114092742.13231-4-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260114092742.13231-1-angelogioacchino.delregno@collabora.com> References: <20260114092742.13231-1-angelogioacchino.delregno@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If any error happens during device_add() just return inside of the conditional, as the goto path doesn't do anything else if not just returning. While at it, to improve readability, also change this function to explicitly return 0 (for success) at the end. Signed-off-by: AngeloGioacchino Del Regno Acked-by: Stephen Boyd --- drivers/spmi/spmi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c index c21789c6b59f..29567c0620ae 100644 --- a/drivers/spmi/spmi.c +++ b/drivers/spmi/spmi.c @@ -69,13 +69,11 @@ int spmi_device_add(struct spmi_device *sdev) err =3D device_add(&sdev->dev); if (err < 0) { dev_err(&sdev->dev, "Can't add device, status %pe\n", ERR_PTR(err)); - goto err_device_add; + return err; } =20 dev_dbg(&sdev->dev, "device registered\n"); - -err_device_add: - return err; + return 0; } EXPORT_SYMBOL_GPL(spmi_device_add); =20 --=20 2.52.0