From nobody Mon Feb 9 13:57:32 2026 Received: from mail-oa1-f66.google.com (mail-oa1-f66.google.com [209.85.160.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C19912F12D9 for ; Wed, 14 Jan 2026 01:59:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768355956; cv=none; b=ZEUp6RmsMAVHhHjWK2ALRRIBYaaMRZ2VALVJyxrTvQC8Tn4Bc68wtEylBzsm3EiFsUKa/geOSBS3YYmN4IhLBxByRdoDf6g7bUgS0cPKA7311PVwVOQz9vLcJ95Bg+GydU5p9kNgKrXiLp1LJa7o4o+ww1P8ZqXPevsRnRLVMXs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768355956; c=relaxed/simple; bh=sDWD1uGFDDRlfxhy01ddUztM6UdtdQV0shZVeb+54EY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EZ+WCExxTrBNAnZBGXKRHk3NFG/MvpMcuVNzHPXVrcxIjimQxUWymD0Sb4rtWeY78quTqT4G0gs0KHDvbGEX7HfMeRdyhyuT6JA5Qd49aKkUclhpuArQuOTmSogWlBRMSMc2b5tPQnIPW78720TxorBNXW7VDLCxmxXUoDnRwvU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TbZVy1qB; arc=none smtp.client-ip=209.85.160.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TbZVy1qB" Received: by mail-oa1-f66.google.com with SMTP id 586e51a60fabf-3ec6c10a295so3646290fac.0 for ; Tue, 13 Jan 2026 17:59:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768355952; x=1768960752; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pKljsU8Xmw+/foisR3SYsx7mqK9N8s1wNDUiE0Eb/VY=; b=TbZVy1qBrLW2UvMad4FXwFwloPilP+ad6+gRn9Fk+SVRNS6Rd371xt65drwSoNcVQ+ OjMrYdBoYik/f7JeloiaYn1H5J9ivzdzdY0QXPILO6YOYDLePF4C8p9JTWsDDuDj1wE4 KEbMgFQ79ZChIDgU56+WA8hKzlbuxi3UZlIHOEnepjq68FVCqQRkArUj0NjFAFaPDm09 PnIB+TrnnpVwdLMdierNp9Z8aWUy4hbcKD0NUsyxsKBU2ejJWFtKG/uQ5I6w+pLiriIo sxZYVLOer22wb3pmE5eobqpGaPKZufyhFQX/yDHH0FuAaovASCJC/xsN4jsKryFaryU0 blfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768355952; x=1768960752; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pKljsU8Xmw+/foisR3SYsx7mqK9N8s1wNDUiE0Eb/VY=; b=vZIDM13HnglpXYsFKvouIog2ZoKo1Tz1pgXZPi8bTwvejeau8Pdk36d5c8JW6kU1bf 7DXUvu3sYMnfoYwSqTFI7gZwSHl56e4jkhUdVL+itXaTto+0fLrzZOasxebBtIqPm3Y+ Uy7dIqDVgzFFo2mieFUyb3DDHn+OTqJN86dPkxYzyqxPgrEoYCVXFJAD3lVHGciRGteI 5Z91prIGAVEBhPrzTjAU3eQAvlN8Vg5IdK3Kws5XwHP5K7NP9MSgS6/c3MuztTnKLd17 lmh5X+rlWOn+xSApGQZ0sOINTslI/RqTVLwgb85XSpzDTzbVOkxRIy1s9cZAbq00XyuC 4zyQ== X-Forwarded-Encrypted: i=1; AJvYcCVin4ZeMqZfE7NF1axuuroGYnqwwqdYxiOvQgJw/SiDdt9KPSveqEq0dHPZ/97Kev8xDvsFuxwM0/rfo3s=@vger.kernel.org X-Gm-Message-State: AOJu0YyA0tBmnh0jsoD/TqcGHHpIOq56viZ2P1nbxrSXkPkhoKoe/4zt 4p5ax9x7HxnFKuq2HOGd+m3vCdlgb4lvVMcA0q9LRH3jeI3t5GzXkFer X-Gm-Gg: AY/fxX7TdJcyqzfagKHh78Jewm+sGHbIQOmAN3Qnxiin6ZQcDfyII8BjLJosbeMdciu iMG+NsR3ECcE/Fi399l67QfOz8Z4DeBX58MKk7FBV9S4Y/fx8jYtFNUOZrg9z5Rppng5DZoOt0m 08KpbcHoZ9OAKjeiI4lU+oZEoFNA2fODJnhhdGJCPolTgW2Xaw28TwTYWdCLHN9G4zN6M1R96cw M8E0fM9+dceC91IU0EikdW2O5H2yuGmJOnyQvZWwlfKdedo7xlCXHRlL7wefd3XONzR/QFLTGrP 2WTrLEUkQWePI2Q287JbKYkhRAXIScKEZ7c7seJVsjF940D+/jVYvV2AjI8gPCwR6EsAyHFtNzh gJ1TsTpocgGiInmT4jPnaarclk++Jqyb1Jkp5cxvJOPt2+cXFsvV8P/ITNUHioIPNlofDOiMZQs x4RWoCAAQVbqZBtUmcTgGneZWiNTKJVT2S9HCs X-Received: by 2002:a05:6820:168e:b0:65b:3c3b:699d with SMTP id 006d021491bc7-66102df2cb6mr449232eaf.64.1768355951696; Tue, 13 Jan 2026 17:59:11 -0800 (PST) Received: from frodo (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 006d021491bc7-65f48bbb3f1sm9740809eaf.4.2026.01.13.17.59.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 17:59:11 -0800 (PST) From: Jim Cromie To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Cc: Jim Cromie , Jason Baron , =?UTF-8?q?=C5=81ukasz=20Bartosik?= , Louis Chauvet , Bagas Sanjaya , Dave Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org, Petr Mladek , Shuah Khan , linux-doc@vger.kernel.org, Steven Rostedt , "Liam R. Howlett" Subject: [PATCH v8 07/31] dyndbg: make ddebug_class_param union members same size Date: Tue, 13 Jan 2026 18:57:23 -0700 Message-ID: <20260114015815.1565725-8-jim.cromie@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260114015815.1565725-1-jim.cromie@gmail.com> References: <20260114015815.1565725-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" struct ddebug_class_param keeps a ref to the state-storage of the param; make both class-types use the same unsigned long storage type. ISTM this is simpler and safer; it avoids an irrelevant difference, and if 2 users somehow get class-type mixed up (or refer to the wrong union member), at least they will both see the same value. Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 2 +- lib/dynamic_debug.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index 98a36e2f94b6..4b7c3b997657 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -103,7 +103,7 @@ struct _ddebug_info { struct ddebug_class_param { union { unsigned long *bits; - unsigned int *lvl; + unsigned long *lvl; }; char flags[8]; const struct ddebug_class_map *map; diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index cb171088850c..d2ff203d0873 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -810,7 +810,7 @@ int param_get_dyndbg_classes(char *buffer, const struct= kernel_param *kp) =20 case DD_CLASS_TYPE_LEVEL_NAMES: case DD_CLASS_TYPE_LEVEL_NUM: - return scnprintf(buffer, PAGE_SIZE, "%d\n", *dcp->lvl); + return scnprintf(buffer, PAGE_SIZE, "%ld\n", *dcp->lvl); default: return -1; } --=20 2.52.0