From nobody Mon Feb 9 10:27:41 2026 Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07AB830EF6F for ; Wed, 14 Jan 2026 02:00:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768356034; cv=none; b=dE6UtUdycN/SRt4oijOJtqWgEHBGBdtVSIRQ+xD8TrSGuw10+b25igi1g2MJmxvJU1Oy1Li7QJTHD1N6pa/v6aJnsTV1gobC0uZas/Is19L04XAOGlc4Gj6BoPywwguRADopTYT+vvWxEKg+K0+WnZwVCMzZYXZQgOfqkIrkpWI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768356034; c=relaxed/simple; bh=NiDfgm9IIZPO7vTOaAaoNFPcWN2xiAR0IE0jA7B36/8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bvXUYiOOWa6WUKPQHdEjpK5ZmWeLi4boMuo1TkOy7ReuQbSo7tw3NlQ4/JfuVSLele8OP5qbSx7QePQ9B5CI3Zx7PSNdL94pdAKYnm32frQIN4fOrAAenUli+y3qjVIJ2IYElS+DFLHEmIpQbiNPneqapUI0Hi2I5aQuAPiZu9k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KD9aZrc6; arc=none smtp.client-ip=209.85.161.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KD9aZrc6" Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-657044fea68so235162eaf.0 for ; Tue, 13 Jan 2026 18:00:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768356032; x=1768960832; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ii1VafhOMs6l+h1e+D2giL8132vNQ2TDoma8/MEoG3Y=; b=KD9aZrc6LziXFGGc2giGdpGlzQJewqWKn9hpf61nKw0cM+byzX5OLnWsva/aCrVo0q ngk8gw6ppxE449l6SGQ9fSOXjw4IaUb2WMSB69RgO1mBL3k062kfY6U5yfhvNzBU4wK/ c+l4NkVk6XEsL7gXl16IWTegAxMKdPQD3PKekb+iNpnlk+bp6jKPNWgphDlz/tx5ve17 rLj8PYV1IvIgcdBv+iG9Hip9TYhAW72N2hIy/M+hU/6UaaLUgbdqN+maNGbEUbzq3FsB mjBvH4tHLCmNiwl38o70p5IcHWLIDfqtgTuBU/GlPoAiVUOTSvCTl97HSQ5rXvRoFX93 jY9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768356032; x=1768960832; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ii1VafhOMs6l+h1e+D2giL8132vNQ2TDoma8/MEoG3Y=; b=nDF/KLDabRI4DSOvXzWQ7MQ7KuWZpVtN9vUrPEad+4rKa4/URh8nGBYz+aN9tCE9Zo 18+6aP9rL6wTr855gc4tVH8k1oT2azcc+a1QlNzymoRrml3gTqhktJJwjvKa+39otac8 wOf3hSnwxPN0DkmSRgSTtDpf4t/WBtNHEDQP0m94mf3gITkyM6RlTnfM8nbEBxnYW/Rq nyfFQy2hGe43qq05QytuyYVP8y4w1okJcBwpzKpDf8FZEIPoRx3tpxDS7INfy7mepJeU 1tGuMJivhb9UApdwbS06y1jONfO8fAq1NplKjPpWQCfgiX9L/+9HNaSf3IxRQrG+Mw4O bUhw== X-Forwarded-Encrypted: i=1; AJvYcCVL3NTY/tfJM6yFs0VgaTXIx9Wgk3IfGYti8D/rDoJNmNq7E6ajq9V54gHR7guIHz2QMfVprlhy3Hy5V7Y=@vger.kernel.org X-Gm-Message-State: AOJu0YymE+YlpR58QlUvOD+7aXPToNTntATCZeNerbNGoG5Ao4vybzc3 FyWgABzplm05AZJk4PQx7O8D+WBdN+jReqi1wqulDxmtIbKLH4wz5hbadqrBNGhLEIg= X-Gm-Gg: AY/fxX4mLhKUl22T/etWhVDpNEavd7LbFaexfghGRQ8Jr7NRVbPWOM1Us6FZaTqvM92 n0G1IkBZ8P+YJ4ofh7zIjzjOhKUBnKr5+KmmPMALbZFMkqgqdgsWAhM4ROvcY8G2ID9FViSwKDg IzF07VuTf8FWDl8Cp+hv+nZkPAoAdSuSwaCkv0ef8zK6mTx9fMg8NLsPDlq7SMni5fM0Hs0N2Ro M9qefxcRLGaI1P14buP/D0Fkg17vFiHPNda4WxqbcaaeuDG1CLhi8Teq3CikrTzq4dumI97KybX T+bTh4hkRfEiFH+zgTvHDjJv/i4WpT8eByYfL3cbugPVhOL2IbxqE8CFXoaz2vqxA8vXPIshreH l3jSeX4D/lC1IdgpKA+IxSLBf3Sv9Cxf6YrRnUFwT2G2eeyahcGkou9Xd0/U673Ne+E1W7nLtiv 33GO69ic9eH9zKc+H6yZF2xdxPTBO6jCAL0uTp X-Received: by 2002:a05:6820:c00e:b0:661:45:9b7f with SMTP id 006d021491bc7-661010be2a1mr505522eaf.39.1768356031942; Tue, 13 Jan 2026 18:00:31 -0800 (PST) Received: from frodo (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 006d021491bc7-65f48cb03d4sm9629865eaf.12.2026.01.13.18.00.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 18:00:31 -0800 (PST) From: Jim Cromie To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Cc: Jim Cromie , Jason Baron , =?UTF-8?q?=C5=81ukasz=20Bartosik?= , Louis Chauvet , Bagas Sanjaya , Dave Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org, Petr Mladek , Shuah Khan , linux-doc@vger.kernel.org, Steven Rostedt , "Liam R. Howlett" Subject: [PATCH v8 27/31] dyndbg: split multi-query strings with % Date: Tue, 13 Jan 2026 18:57:43 -0700 Message-ID: <20260114015815.1565725-28-jim.cromie@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260114015815.1565725-1-jim.cromie@gmail.com> References: <20260114015815.1565725-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since commit 85f7f6c0edb8 ("dynamic_debug: process multiple debug-queries on a line") Multi-query commands have been allowed: modprobe drm dyndbg=3D"class DRM_UT_CORE +p; class DRM_UT_KMS +p" modprobe drm dyndbg=3D< [ 203.902703] dyndbg: query parse failed [ 203.902871] dyndbg: processed 2 queries, with 0 matches, 2 errs bash: echo: write error: Invalid argument The '%' splits the input into 2 queries, and both fail. Given the limited utility of matching against the working parts of a format string "foo: %d bar %s", nothing is actually lost here. selftests-dyndbg: test_percent_splitting This does basic testing of classmaps using '%' separated multi-queries. It modprobes test_dynamic_debug with several classes enabled, and counts to verify that the expected sites show the enablement in the control file. Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- .../admin-guide/dynamic-debug-howto.rst | 8 ++++--- lib/dynamic_debug.c | 2 +- .../dynamic_debug/dyndbg_selftest.sh | 24 +++++++++++++++++++ 3 files changed, 30 insertions(+), 4 deletions(-) diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentat= ion/admin-guide/dynamic-debug-howto.rst index 350d93834e19..89ee15d7ae58 100644 --- a/Documentation/admin-guide/dynamic-debug-howto.rst +++ b/Documentation/admin-guide/dynamic-debug-howto.rst @@ -85,10 +85,12 @@ by spaces, tabs, or commas. So these are all equivalen= t:: :#> ddcmd ' file svcsock.c line 1603 +p ' :#> ddcmd file,svcsock.c,line,1603,+p =20 -Command submissions are bounded by a write() system call. -Multiple commands can be written together, separated by ``;`` or ``\n``:: +Command submissions are bounded by a write() system call. Multiple +commands can be written together, separated by ``%``, ``;`` or ``\n``:: =20 - :#> ddcmd "func pnpacpi_get_resources +p; func pnp_assign_mem +p" + :#> ddcmd func foo +p % func bar +p + :#> ddcmd func foo +p \; func bar +p + :#> ddcmd "func foo +p ; func bar +p" :#> ddcmd <<"EOC" func pnpacpi_get_resources +p func pnp_assign_mem +p diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 5ac7248d51bb..c50836c262b4 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -626,7 +626,7 @@ static int ddebug_exec_queries(char *query, const char = *modname) int i, errs =3D 0, exitcode =3D 0, rc, nfound =3D 0; =20 for (i =3D 0; query; query =3D split) { - split =3D strpbrk(query, ";\n"); + split =3D strpbrk(query, "%;\n"); if (split) *split++ =3D '\0'; =20 diff --git a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh b/too= ls/testing/selftests/dynamic_debug/dyndbg_selftest.sh index c7bf521f36ee..513f6cb1db1d 100755 --- a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh +++ b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh @@ -256,9 +256,33 @@ function comma_terminator_tests { ddcmd =3D_ } =20 +function test_percent_splitting { + echo -e "${GREEN}# TEST_PERCENT_SPLITTING - multi-command splitting on= % ${NC}" + if [ $LACK_TMOD -eq 1 ]; then + echo "SKIP - test requires test-dynamic-debug.ko" + return + fi + ifrmmod test_dynamic_debug_submod + ifrmmod test_dynamic_debug + ddcmd =3D_ + modprobe test_dynamic_debug dyndbg=3Dclass,D2_CORE,+pf%class,D2_KMS,+p= t%class,D2_ATOMIC,+pm + check_match_ct =3Dpf 1 + check_match_ct =3Dpt 1 + check_match_ct =3Dpm 1 + check_match_ct test_dynamic_debug 23 -r + # add flags to those callsites + ddcmd class,D2_CORE,+mf%class,D2_KMS,+lt%class,D2_ATOMIC,+ml + check_match_ct =3Dpmf 1 + check_match_ct =3Dplt 1 + check_match_ct =3Dpml 1 + check_match_ct test_dynamic_debug 23 -r + ifrmmod test_dynamic_debug +} + tests_list=3D( basic_tests comma_terminator_tests + test_percent_splitting ) =20 # Run tests --=20 2.52.0